juzser
Repos
16
Followers
14
Following
16

Shopify Polaris design system for Vue JS. Shopify’s design system to help us build the great apps for all of our merchants.

22
6

For the one who is finding a customizable chatbot UI.

28
11

The communications platform that puts data protection first.

33490
7380

The Rocket.Chat Apps engine and definitions.

86
78

A pure PHP library for reading and writing word processing documents

6393
2427

Ownego - Interactive Agency

8
2

Events

create tag
juzser create tag v1.1.6
Created at 9 hours ago

Update: default value for auto-complete in TextField component

Merge pull request #170 from ownego/feature/text-field-default-value-auto-complete

Update: default value for auto-complete in TextField component

Chore: 1.1.6

Merge remote-tracking branch 'origin/master' into dev

Merge pull request #172 from ownego/dev

Update PrimaryLink for IndexTable

Created at 9 hours ago
pull request closed
Update PrimaryLink for IndexTable
Created at 9 hours ago

Merge pull request #169 from ownego/dev

Migrate 10.4.1

Fix: Link trigger click twice

Fix: IndexTable supports dataPrimaryLink

Merge pull request #171 from ownego/fix/index-table-primary-link

Fix: Index Table supports dataPrimaryLink

Chore: 1.1.6

Merge remote-tracking branch 'origin/master' into dev

Created at 9 hours ago
pull request opened
Update PrimaryLink for IndexTable
Created at 9 hours ago

Fix: Link trigger click twice

Fix: IndexTable supports dataPrimaryLink

Merge pull request #171 from ownego/fix/index-table-primary-link

Fix: Index Table supports dataPrimaryLink

Created at 9 hours ago
pull request closed
Fix: Index Table supports dataPrimaryLink
Created at 9 hours ago
pull request closed
Update: default value for auto-complete in TextField component
Created at 9 hours ago

Update: default value for auto-complete in TextField component

Merge pull request #170 from ownego/feature/text-field-default-value-auto-complete

Update: default value for auto-complete in TextField component

Created at 9 hours ago
create tag
juzser create tag v1.1.5
Created at 1 day ago

Migrate: 10.4.1

Chore: 1.1.5

Merge pull request #169 from ownego/dev

Migrate 10.4.1

Created at 1 day ago
pull request closed
Migrate 10.4.1
Created at 1 day ago
pull request opened
Migrate 10.4.1
Created at 1 day ago

Merge remote-tracking branch 'origin/dev'

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.5

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.6

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.7

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.8

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.9

Merge remote-tracking branch 'origin/dev'

Chore: v0.5.10

Merge remote-tracking branch 'origin/dev'

Merge remote-tracking branch 'origin/dev'

Change package version

Merge remote-tracking branch 'origin/dev'

Chore 0.7.1

Merge remote-tracking branch 'origin/dev'

Chore 0.7.2

Created at 1 day ago

Fix: losing reactive context

Merge pull request #168 from ownego/fix/index-table-losing-reactive

Fix: IndexTable lost its reactive context properties

Created at 1 day ago
pull request closed
Fix: IndexTable lost its reactive context properties
Created at 1 day ago

[polaris.shopify.com] Improve props table (#6757)

This PR adds a powerful new props table for every component.

🚀 Closes #6371 🚀 Closes #6529 🚀 Closes #6599 🚀 Closes #6779 🚀

ezgif-3-18af949102

Implementation details

What's in the PR?

  • A script that parses polaris-react and outputs props.json
  • Tests for that script
  • New front end logic for displaying the props

Jest mess

The AST parser is complex and needs pretty thorough tests, so I added Jest. This introduces a bit of a...situation:

  • Jest supports Typescript, if you add a babel.config.json file.
  • Next.js version 12 (latest) introduces a new Rust-based compiler (SWC). If users want to opt out, they do this by...adding a babel.config.json file.

So, these two things collide. I want to customize Jest, but Next.js thinks I want to disable the Rust compiler. Sigh. To get around this, I placed the Jest tests and config in the /scripts dir. They live in their own little island that the website (and Next.js) doesn't know about.

Later on, when the Rust compiler can't be opted out of, we should move this to the website root.

Checklist

  • [x] Output default values
  • [x] Highlight deprecated types (DataTableProps.hasFixedFirstColumn)
  • [x] Highlight optional types
  • [x] Dump type definition "as is" when it can't be understood
  • [x] Handle types
  • [x] Handle interfaces
  • [x] Handle enums
  • [x] Handle properties
  • [x] Handle methods
  • [x] Handle index signatures like[key: string]: boolean;
  • [x] Inline simple references like Alignment (= 'top' | 'center' | 'bottom')
  • [x] Expandable definitions for referenced types
    • [x] One reference
    • [x] Unions of interfaces (InterfaceA | Interface B)
    • [x] Intersections of interfaces (InterfaceA & Interface B)
    • [x] Methods with interfaces ((a: string, b: InterfaceA) => void)
    • [x] Arrays of references (Interface[])
  • [x] Use semantic HTML elements
  • [x] Add syntax highlighting for types
  • [x] Add accessible syntax highlighting theme and use for prism code blocks as well
  • [x] Align syntax highlighting colors with decorative colors in tokens
  • [x] Gracefully handle components that define props in a way that we can't parse (Badge)
  • [x] Is responsive

Potential follow-ups:

  • [ ] Link to MDN for native types (Range)
  • [ ] Handle components that accept no props
  • [ ] Show links to Github
  • [ ] Add copyable typescript code for types
  • [ ] Support types that were imported from other polaris packages (ColorScheme from polaris-tokens)

Add whats new section for typography page (#7089)

No top level navigation but can be viewed and shared at /whats-new/version-10-typography

localhost_3000_whats-new_version-10-typography
(1)

[polaris.shopify.com] Remove welcome banner from website (#7202)

The new props table addresses the final big feedback that we've been getting regarding the new site.

With this change, the legacy website is ready to be taken down and we can remove the welcome banner.

[IndexTable] Fix overflowing sticky column (#7130)

WHY are these changes introduced?

Fixes #4012

When a table column is sticky and bigger than the container (aka, causes an overflow) the table width is not calculated properly and the non-sticky columns overlap the sticky one. Check this pure html reproduction for a better understanding of the root issue.

Disclaimer: This PR does not fit the condensed mode of the table, which has it's own issues when overflowing

WHAT is this pull request doing?

The bug does not happen on small screens because the only sticky column in that size is the one with checkboxes, which is small enough to not cause an issue, but when a sticky column has long texts the problem can happen on bigger screens.

To solve it I calculate dynamically the size of the sticky column(s) and apply the sticky styles only when the full width of the table can fit them without an overflow. If the table is narrower than the sticky columns, the small screen styles are applied (only the checkbox remains sticky)

If users do not want this behaviour, they can still apply a max-width and white-space: wrap to the wider cells or columns, which is the non-official solution to this bug right now (web is doing it, in case you want to check that the fix does not affect that setup)

🎩 checklist

Spin instance

Only preversion packages before official release (#7220)

WHY are these changes introduced?

Running preversion on the polaris-react package when performing /snapit was causing an error when there wasn't a new version of polaris-react to be released.

See this GitHub Action error.

WHAT is this pull request doing?

This PR filters the preversion pacakges to only those being released. This avoids running into the issue where the polaris-react preversion script was failing on snapit.

Replace Sass spacing but leave comment if needs manual check (#7217)

WHY are these changes introduced?

It will be easier to migrate spacing if we do the spacing conversion but leave a comment to manually check the migration when there is an operator.

WHAT is this pull request doing?

Performs the spacing replacement even if there is an operator.

Version Packages (#7221)

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@shopify/plugin-polaris@0.0.2

Patch Changes

  • Updated dependencies [77d7b5ae3]:
    • @shopify/polaris-migrator@0.1.1

@shopify/polaris-migrator@0.1.1

Patch Changes

  • #7217 77d7b5ae3 Thanks @samrose3! - Update the Sass spacing migration to perform spacing replacement even when there is an operator.

@shopify/polaris@10.3.1

Patch Changes

polaris.shopify.com@0.18.0

Minor Changes

Patch Changes

polaris-for-figma@0.0.16

Patch Changes

  • Updated dependencies [c09994418]:
    • @shopify/polaris@10.3.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Replace quoted function argument values (ex: spacing('tight')) (#7223)

WHY are these changes introduced?

Fixes issue where spacing('tight') was being replaced by a CSS custom property within single quotes var('--p-space-2')

WHAT is this pull request doing?

This PR fixes the CSS custom property value being contained within single quotes and also optimizes some of the typing inferences (less type casting).

[Icons] Add metafields type icons (#7184)

WHY are these changes introduced?

We are currently using these icons in the Metafields Settings, admin, and OSE to for the following types:

  • Color
  • JSON
  • Measurement (Dimension, Volume, Weight)
  • Money

And in the code they are currently these are all custom.

This issue will relate to #229 #7152

WHAT is this pull request doing?

Adding the following Metafield type icons (in Minor only):

  • Color
  • JSON
  • Measurement
  • Money

Screen Shot 2022-09-12 at 3 25 23
PM

Co-authored-by: Kyle Durand kyledurand@users.noreply.github.com

Output operator lines as comments to preserve working Sass (#7229)

WHY are these changes introduced?

Fixes cases where spacing function is nested within parentheses (ex: margin: (-1 * spacing()) 0 0)

WHAT is this pull request doing?

Mark operators if present in the parsed declaration value. Then, add the migrated value as a comment if the declaration contains an operator.

[polaris.shopify.com] Remove text alignment guidance (#7235)

The text alignment guidance is more nuanced than what we provide right now. We need to spend some more time with this. For now we're going to remove the section to avoid conflicting guidance.

This PR removes "Right align tabular numbers section"

Add plop migration generator (#7218)

Fix IndexTable rendering issue in Safari (#7243)

Version Packages (#7225)

Enable namespace option for Sass spacing migration (#7241)

WHY are these changes introduced?

This change prepares the Sass spacing migration to handle updating the spacing function with a namespace prefix. This is in preparation for the switch from node-sass to sass-embedded.

Usage

Default (no namespace)

npx @shopify/polaris-migrator replace-sass-spacing "./**/*.scss"

With namespace

npx @shopify/polaris-migrator replace-sass-spacing "./**/*.scss" --namespace="legacy-polaris-v8"

Add range media query for larger tap target on small screen (#7226)

WHY are these changes introduced?

Contributes to #14004 in online-store-web

We believe increasing the tap target to the range slider in mobile will provide easier accessibility on smaller screens.

WHAT is this pull request doing?

Adds a media query that increases the height of the SingleThumb slider to 44px for easier accessibility on a small screen.

Before:

After:

🎩 Instructions

Spin link: https://shop1.shopify.rangesliderchanges.rana-jurjus.us.spin.dev/admin/themes/1/editor

  1. Make sure you are in mobile web view (dev tools)
  2. In the sections footer, select a section that has rangesliders (collage for example)
  3. Ensure the rangeslider is a height of 44px and nothing looks out of the ordinary.
  4. For more dense rangeslider examples, click the ... in the header in mobile and select theme settings
  5. Select Layout and make sure the height is 44px and everything looks ok

🎩 checklist

Correct typo in Naming section (#7253)

Add documentation on breakpoint token usage in media queries (#7230)

WHY are these changes introduced?

We've noticed some incorrect implementations of the new breakpoint tokens and want to add more clarifying documentation to the tokens page.

The breakpoint tokens are a bit special in that a transform takes the values and generates Sass variables for each breakpoint in up, down, and only directions. These Sass variables are the values that should be used in media queries not the tokens themselves.

WHAT is this pull request doing?

This PR adds descriptions to each of breakpoint tokens as well as a section below the tokens to go into further detail about how to use them in media queries. It's not the most elegant section but it contains really important information we need tied to the breakpoint tokens. Happy to jam on tweaking the styling for this section further if needed.

localhost_3000_tokens_breakpoints

Update the Release process to help reduce the review bottleneck (#7251)

WHY are these changes introduced?

We have been experience a process bottleneck issue in how we release packages. This process change should help ensure we aren't shipping a broken package, yet not blocking new changes being merged into Polaris.

WHAT is this pull request doing?

This moves the Shopify/web tophatting step from the snapshot phase to the official release update phase. This way, we aren't having to wait on reviewer approval prior to release. We can release new versions (Version Packages PR) as soon as we can confirm the snapshot release builds and passes CI tests in web. Then, tophatting can be performed by contributors after the official release has been performed.

Choicelist update (#7252)

WHY are these changes introduced?

Contributes to #14004 in online-store-web and is related to #7226 changes.

We believe lengthening the tap target on the checkbox and radio buttons (ultimately changes made at the ChoiceList level) in mobile will provide easier accessibility on smaller screens.

WHAT is this pull request doing?

Adds a media query that increases the width of ChoiceList items (checkbox and radio buttons) to 100% width for easier accessibility on a small screen.

Before width 100%:

https://user-images.githubusercontent.com/69861203/191824923-0b70160b-f1dc-47bf-933c-aab163e10dec.mov

After width 100%:

https://user-images.githubusercontent.com/69861203/191824957-55149a73-5bbe-4143-837b-51ac5d8bb70d.mov

How to 🎩

🖥 Local development instructions 🗒 General tophatting guidelines 📄 Changelog guidelines

Spin link: https://admin.web.choicelistfinal.rana-jurjus.us.spin.dev/store/shop1/themes/1/editor

  1. Ensure you are in mobile web view (use dev tools) on a smaller screened device (iPhone SE for example)
  2. Open the section list bottom sheet and select a section that has choicelist items (ex: Featured Collection, Header for checkboxes. Cannot find radio button options to tophat at this time). Ensure everything looks okay, that the cell has 100% width, and that you can click anywhere within that cell to toggle the selection.

🎩 checklist

Created at 1 day ago
started
Created at 2 days ago
started
Created at 2 days ago

Update: avatar icon url

Created at 3 days ago

Update: add some rules for ref and reactive in vuejs

Merge pull request #1 from ownego/guidelines/vue-v3

Update: add some rules for ref and reactive in vuejs

Created at 6 days ago
pull request closed
Update: add some rules for ref and reactive in vuejs
Created at 6 days ago
create tag
juzser create tag v1.1.4
Created at 2 weeks ago