justinbmeyer
Repos
25
Followers
324
Following
28

jQuery JavaScript Library

57153
20141

Build CRUD apps in fewer lines of code.

1898
417

Your app. Done.

1354
149

Gets JavaScript

1360
518

A functional test suite based on jQuery

568
383

The sophisticated documentation engine

596
383

Events

justinbmeyer delete branch design-system
Created at 5 hours ago

dynamic quarters and months

Merge pull request #5 from bitovi/design-system

dynamic quarters and months

Created at 5 hours ago
pull request closed
dynamic quarters and months
Created at 5 hours ago
pull request opened
dynamic quarters and months
Created at 5 hours ago

dynamic quarters and months

Created at 5 hours ago

a key

extended timeline view looks nicer

turning cashing off

Merge pull request #4 from bitovi/design-system

Design system and new timeline view

Created at 5 hours ago
pull request closed
Design system and new timeline view
Created at 5 hours ago
pull request opened
Design system
Created at 5 hours ago

turning cashing off

Created at 5 hours ago

extended timeline view looks nicer

Created at 5 hours ago
Created at 1 day ago

adding a design system

a bit nicer looking

adding more rules about how status is reported

better status

Merge pull request #3 from bitovi/design-system

Design system and instructions

Created at 2 days ago
pull request closed
Design system and instructions

image

Created at 2 days ago
pull request opened
Design system
Created at 2 days ago

adding more rules about how status is reported

better status

Created at 2 days ago
justinbmeyer create branch design-system
Created at 5 days ago
Toggling a radio button to false leaves a checked attribute in the DOM

Thanks for reporting, we will look into it.

On Mon, Jan 23, 2023 at 9:37 AM rjgotten @.***> wrote:

Having a Stache binding such as , when the checked view model property toggles from false to true and then back to false it leaves a rogue valueless checked (Chrome) or empty string valued checked="" (Firefox) DOM attribute on the node.

The culprit is in the special handling for checked properties:

https://github.com/canjs/can-attribute-observable/blob/a9f5b8a9ef1058a1878bea3d23d84ff9e5c82092/behaviors.js#L191-L212

Specifically lines 202-204. As one can see, these only ever flip defaultChecked (which is wired to the presence of the DOM attribute) to true but never flip it back to false.

Should the relevant lines not simply be:

if ( this.type === "radio" ) { this.defaultChecked = notFalse;}

or is there a specific reason, such as workaround for a browser bug, for the current unidirectional behavior?

— Reply to this email directly, view it on GitHub https://github.com/canjs/can-attribute-observable/issues/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATGCSC6RNGGP6JNEIIQ5TWT2QSBANCNFSM6AAAAAAUD7T4MI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Created at 1 week ago
issue comment
Unclear diff / instructions on cleaning up removed actions

I think there's a way to tell academy to show the removed stuff. If not, it's probably pretty easy to add.

Created at 1 month ago

can seemingly resolve paths

Created at 1 month ago

able to serve prod and dev spas

Created at 1 month ago

able to progressively load

Created at 1 month ago

adding the css

Created at 1 month ago

adding css to build

Created at 1 month ago

prod build with just js works

Created at 1 month ago

more progress, using normal canjs now

Created at 1 month ago

rough pass

Created at 1 month ago