25
324
28
Events
dynamic quarters and months
Merge pull request #5 from bitovi/design-system
dynamic quarters and months
dynamic quarters and months
a key
extended timeline view looks nicer
turning cashing off
Merge pull request #4 from bitovi/design-system
Design system and new timeline view
Design system and new timeline view
extended timeline view looks nicer
adding a design system
a bit nicer looking
adding more rules about how status is reported
better status
Merge pull request #3 from bitovi/design-system
Design system and instructions
Design system and instructions
adding more rules about how status is reported
better status
Toggling a radio button to false leaves a checked attribute in the DOM
Thanks for reporting, we will look into it.
On Mon, Jan 23, 2023 at 9:37 AM rjgotten @.***> wrote:
Having a Stache binding such as , when the checked view model property toggles from false to true and then back to false it leaves a rogue valueless checked (Chrome) or empty string valued checked="" (Firefox) DOM attribute on the node.
The culprit is in the special handling for checked properties:
https://github.com/canjs/can-attribute-observable/blob/a9f5b8a9ef1058a1878bea3d23d84ff9e5c82092/behaviors.js#L191-L212
Specifically lines 202-204. As one can see, these only ever flip defaultChecked (which is wired to the presence of the DOM attribute) to true but never flip it back to false.
Should the relevant lines not simply be:
if ( this.type === "radio" ) { this.defaultChecked = notFalse;}
or is there a specific reason, such as workaround for a browser bug, for the current unidirectional behavior?
— Reply to this email directly, view it on GitHub https://github.com/canjs/can-attribute-observable/issues/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATGCSC6RNGGP6JNEIIQ5TWT2QSBANCNFSM6AAAAAAUD7T4MI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Unclear diff / instructions on cleaning up removed actions
I think there's a way to tell academy to show the removed stuff. If not, it's probably pretty easy to add.
can seemingly resolve paths
able to serve prod and dev spas
able to progressively load
prod build with just js works
more progress, using normal canjs now
