Constraint ResponseHeaderSame now shows the actual header value

Hi @javiereguiluz,

I guess most people check for header existence before they assert the header value, but I think it makes sense to add the null case, yes.

Constraint ResponseHeaderSame now shows the actual header value

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | maybe, more like a small adjustment | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

I am using the BrowserKitAssertionsTrait::assertResponseHeaderSame(...) quite a lot in my functional tests and it would be nice to see the actual header value in case the expected one doesn't match. So instead of just seeing:

Failed asserting that the Response has header "Cache-Control" with value "public".

it would be helpful to see:

Failed asserting that the Response has header "Cache-Control" with value "public", value of header "Cache-Control" is "no-cache, private".

Constraint ResponseHeaderSame now shows the actual header value

Fix choice filter error when loading mix of grouped and non-grouped choices

bug #46610 [Messenger] use the outermost wrapping DBAL connection (xabbuh)

This PR was merged into the 5.4 branch.

Discussion

[Messenger] use the outermost wrapping DBAL connection

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46436 | License | MIT | Doc PR |

Commits

4178244247 use the outermost wrapping DBAL connection

bug #46594 [FrameworkBundle] Fix XML cache config (HeahDude)

This PR was merged into the 4.4 branch.

Discussion

[FrameworkBundle] Fix XML cache config

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix https://github.com/symfony-tools/symfony-application/pull/3#discussion_r618261687 | License | MIT | Doc PR | ~

The docs currently bypass XML checks because of this, so I propose to consider it a bug fix to remain consistent (ref https://github.com/symfony-tools/symfony-application/pull/3#discussion_r618261687), as the other way would imply updating all the docs.

Commits

d976b24b17 [FrameworkBundle] Fix XML cache config

fix merge

Merge branch '4.4' into 5.4

• 4.4: [Console] Escape % in command name & description from getDefault*() [FrameworkBundle] Fix XML cache config

Merge branch '5.4' into 6.0

• 5.4: use the outermost wrapping DBAL connection [Console] Fix deprecation when description is null [Console] Escape % in command name & description from getDefault*() [FrameworkBundle] Fix XML cache config

bug #46576 Fix choice filter error when loading mix of grouped and non-grouped choices (BreyndotEchse)

This PR was merged into the 5.4 branch.

Discussion

Fix choice filter error when loading mix of grouped and non-grouped choices

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT

How to reproduce this bug:

$choiceType = $builder->create('test', ChoiceType::class, [
    'choice_loader' => new CallbackChoiceLoader(fn() => [
        'Foo',
        'Optgroup' => [
            'Bar',
            'Baz',
        ],
    ]),
    'choice_filter' => fn() => true,
]);
$choiceType->getForm()->createView();

TypeError:

Argument 1 passed to Symfony\Component\Form\ChoiceList\ArrayChoiceList::getChoicesForValues() must be of the type array, string given, called in ~/symfony/form/ChoiceList/Loader/FilterChoiceLoaderDecorator.php on line 39

Commits

24c65bf8a8 Fix choice filter error when loading mix of grouped and non-grouped choices

[Messenger] Remove redundant interface in DoctrineReceiver

minor #46626 [Messenger] Remove redundant interface in DoctrineReceiver (HeahDude)

This PR was merged into the 4.4 branch.

Discussion

[Messenger] Remove redundant interface in DoctrineReceiver

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~

ListableReceiverInterface extends ReceiverInterface

Commits

2dc8e6d7e6 [Messenger] Remove redundant interface in DoctrineReceiver

bug #46548 [Mime] Allow url as a path in the DataPart::fromPath (wkania)

This PR was merged into the 4.4 branch.

Discussion

[Mime] Allow url as a path in the DataPart::fromPath

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A

While switching from the Swift Mailer to the Symfony Mailer I encounter a bug Symfony\Component\Mime\Exception\InvalidArgumentException. Steps to reproduce:

1. I have created an email with an attachment that is a remote file and saw An exception has been thrown during the rendering of a template.
2. Also when I have visited tab E-mails in the Symfony Profiler, saw the same Symfony Exception page

DataPart can't be created from url, even if fopen can open url. Apparently, before Symfony 4.4.11 this worked with URLs. At least in the context of email with attachments. PHP doesn't support rewind on non-local streams, so calling multiple times method getBody from TextPart would return an empty string. So in another context, it worked partially.

Additional notes:

1. Network example based on this
2. Base64Encoder chunk split base64 encoded string so I only check the first line

Commits

12bf8cb092 [Mime] Allow url as a path in the DataPart::fromPath

Merge branch '4.4' into 5.4

• 4.4: [Messenger] Remove redundant interface in DoctrineReceiver [Mime] Allow url as a path in the DataPart::fromPath

bug #46545 Fix getting class constraints on debug command (loic425)

This PR was merged into the 5.4 branch.

Discussion

Fix getting class constraints on debug command

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Partially #46544 | License | MIT | Doc PR |

Currently, Symfony debug:validator command does not show constraints that are configured on the class. It only shows constraints of class properties.

So with this fix, we add class constraints on the output tables. - symbol is used on the Propertycolumn to show that the constraint is not linked to a property.

Before

After

Commits

633007649b Fix getting class constraints on debug command

Merge branch '5.4' into 6.0

• 5.4: [Messenger] Remove redundant interface in DoctrineReceiver Fix choice filter error when loading mix of grouped and non-grouped choices [Mime] Allow url as a path in the DataPart::fromPath Fix getting class constraints on debug command

Fix tests related to Doctrine method renaming

[Mailer] Fix Error Handling for OhMySMTP Bridge

minor #46629 Fix tests related to Doctrine method renaming (jderusse)

This PR was merged into the 5.4 branch.

Discussion

Fix tests related to Doctrine method renaming

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | /

Method used to create table has been renamed in https://github.com/doctrine/dbal/pull/5416

Commits

05be7b2102 Fix tests related to Doctrine method renaming

Merge branch '5.4' into 6.0

• 5.4: Fix tests related to Doctrine method renaming

bug #46603 [Mailer] Fix Error Handling for OhMySMTP Bridge (paul-oms)

This PR was merged into the 5.4 branch.

Discussion

[Mailer] Fix Error Handling for OhMySMTP Bridge

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix N/A | License | MIT | Doc PR | symfony/symfony-docs#...

The OhMySMTP Bridge does not handle errors correctly, and throws up an Undefined array key "Message" error when an API error is encountered (e.g. an invalid API key or Internal Server Error). This PR fixes this by showing the full error response.

Commits

3bebc645bc [Mailer] Fix Error Handling for OhMySMTP Bridge

bug #46368 [Mailer] Fix for missing sender name in case with usage of the EnvelopeListener (bobahvas)

This PR was merged into the 4.4 branch.

Discussion

[Mailer] Fix for missing sender name in case with usage of the EnvelopeListener

| Q | A | ------------- | --- | Branch? | 4.4, 5.4 or 6.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT

$eventDispatcher = new \Symfony\Component\EventDispatcher\EventDispatcher();
$eventDispatcher->addSubscriber(
    new \Symfony\Component\Mailer\EventListener\EnvelopeListener(
        new \Symfony\Component\Mime\Address('noreply@test.com', 'TestName')
    )
);

Commits

c12039b1c3 Fix for missing sender name in case with usage of the EnvelopeListener

[Messenger] move resetting services at worker stopped into ResetServicesListener

Update README.md

Update README.md

Update README.md

Update README.md

Update README.md

Update README.md

Correct license year (#101)