johnstevenson
Repos
43
Followers
62

Events

NOT AN ISSUE

Many thanks for this comment. The CLI version worked, although somewhat hacky, but the arrival of Windows 11 with the disabling of the Prolific recommended replacement drivers (PL2303 TA/TB) forced me to do it a bit better.

I'm chuffed that it is being used and that you find it useful.

Created at 1 day ago
issue comment
The Composer installer script did not run correctly [exit code 259] and no output was returned.

We are more than willing to help here, but we can't do anything without a log file. Please create a new issue https://github.com/composer/windows-setup/issues/new/ and follow the instructions.

Created at 3 weeks ago
issue comment
Match default choice to actual default

None at all. The user can always change their mind with the default Cancel action of the UAC dialog.

Created at 1 month ago
opened issue
Old Buckenam ATZ

Old Buckenam (EGSV) is listed as OLD BUCKINGHAM.

Created at 1 month ago
Created at 1 month ago
issue comment
Improve simple-phpunit.php

True. I've procrastinated reviewing this PR because changing for the sake of it is usually based on personal opinions and leads to time-consuming reviews...

Yup, I'm sure I'm guilty of this too. However I've tried to keep the changes minimal in order to make the code more consistent and readable for the future.

Entirely up to you.

Created at 1 month ago

minor #45942 [ExpressionLanguage] Add missing changelog entry (nicolas-grekas)

This PR was merged into the 6.1 branch.

Discussion

[ExpressionLanguage] Add missing changelog entry

| Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Related to #45912

Commits

f84a106d3b [ExpressionLanguage] Add missing changelog entry

[DependencyInjection] Add TaggedIteratorArgument unit tests

[RateLimiter] Adding default empty value

Because Security::LAST_USERNAME not always exist, it can trigger a "preg_match(): Argument #2 ($subject) must be of type string" if $username is null

Add tests to messenger connection get for OraclePlatform

[Intl] Update the ICU data to 71.1 - 4.4

[Intl] Update the ICU data to 71.1 - 5.4

[Notifier] Improve some type annotations

minor #45966 Add tests to messenger connection get for OraclePlatform (rjd22)

This PR was merged into the 4.4 branch.

Discussion

Add tests to messenger connection get for OraclePlatform

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT

Add tests for Oracle for code added in #45714

Commits

6d5887c4c8 Add tests to messenger connection get for OraclePlatform

bug #45948 [RateLimiter] Adding default empty string value on Security::LAST_USERNAME (David-Crty)

This PR was merged into the 5.4 branch.

Discussion

[RateLimiter] Adding default empty string value on Security::LAST_USERNAME

Because Security::LAST_USERNAME not always exist, it can trigger a preg_match(): Argument #2 ($subject) must be of type string if $username is null

The error is critical when having declare(strict_types=1), to avoid issue when people create their own LoginRateLimiter from the DefaultLoginRateLimiter we can juste set a default empty string.

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT

Commits

0fdfcae499 [RateLimiter] Adding default empty value

[FrameworkBundle] [Command] Fix debug:router --no-interaction error …

bug #45947 [FrameworkBundle] [Command] Fix debug:router --no-interaction error … (WilliamBoulle)

This PR was squashed before being merged into the 4.4 branch.

Discussion

[FrameworkBundle] [Command] Fix debug:router --no-interaction error …

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #45777 | License | MIT

When command debug:router is used in non-interactive mode with a name that matches more than one route, render the list of matching routes debug_router_profiler_nointeraction

Commits

e92e26183d [FrameworkBundle] [Command] Fix debug:router --no-interaction error …

Fix use_cookies framework session configuration

bug #45964 Fix use_cookies framework session configuration (alexander-schranz)

This PR was squashed before being merged into the 5.4 branch.

Discussion

Fix use_cookies framework session configuration

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #45105 | License | MIT | Doc PR | symfony/symfony-docs#...

Keep use_cookies false flag in mind.

Todo:

  • [x] test case

Commits

2f59c5a79c Fix use_cookies framework session configuration

minor #45970 [Notifier] Improve some type annotations (b1rdex)

This PR was merged into the 6.1 branch.

Discussion

[Notifier] Improve some type annotations

| Q | A | ------------- | --- | Branch? | 6.1 (not sure) | Bug fix? | to some extent | New feature? | no | Deprecations? | no | License | MIT

In this PR, I tried to improve (add) some type annotations:

  • the first one is a public API channels list type on Notification
  • and the second one is an internal one in Notifier that eases understanding the code and what's expected to be returned

I'm not sure about the target branch. IMO it should target 5.4, but I'm open for your advices and set it to 6.1 for now.

Commits

8b7b0820b1 [Notifier] Improve some type annotations

[Notifier] [OvhCloud] Add no_stop_clause to DSN

feature #45951 [Notifier] [OvhCloud] Add no_stop_clause to DSN (alamirault)

This PR was squashed before being merged into the 6.1 branch.

Discussion

[Notifier] [OvhCloud] Add no_stop_clause to DSN

| Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #45932 | License | MIT

This PR allow to configure no_stop_clause (default false) for OvhCloud. Was always false before.

Commits

0999ac0dd3 [Notifier] [OvhCloud] Add no_stop_clause to DSN

bug #45968 [Intl] Update the ICU data to 71.1 - 4.4 (jderusse)

This PR was merged into the 4.4 branch.

Discussion

[Intl] Update the ICU data to 71.1 - 4.4

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | /

Commits

5ad56d818e [Intl] Update the ICU data to 71.1 - 4.4

Merge branch '4.4' into 5.4

  • 4.4: [FrameworkBundle] [Command] Fix debug:router --no-interaction error … [Intl] Update the ICU data to 71.1 - 4.4 Add tests to messenger connection get for OraclePlatform [Process] Fix Process::getEnv() when setEnv() hasn't been called before [ExpressionLanguage] Fix matching null against a regular expression

bug #45969 [Intl] Update the ICU data to 71.1 - 5.4 (jderusse)

This PR was merged into the 5.4 branch.

Discussion

[Intl] Update the ICU data to 71.1 - 5.4

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | /

Commits

e15957d6cd [Intl] Update the ICU data to 71.1 - 5.4

[Messenger] Consume a PSR-14 dispatcher for dispatching events

Created at 1 month ago
closed issue
The Composer installer script did not run correctly [exit code 259] and no output was returned.

The Composer installer script did not run correctly [exit code 259] and no output was returned.

Created at 1 month ago
issue comment
The Composer installer script did not run correctly [exit code 259] and no output was returned.

Unless you supply the required information (the log file) there is not much we can so.

Created at 1 month ago
closed issue
composer
Created at 1 month ago
issue comment
Composer trying to install older version despite incompatibility and newer one being available

All I know is that I think this is Powershell thing. The %* expansion just fowards the command line as is and can be tested by changing the bat file to:

@echo OFF
:: in case DelayedExpansion is on and a path contains ! 
setlocal DISABLEDELAYEDEXPANSION
php "%~dp0testargs.php" %*

where testargs.php in the same folder is:


<?php

print_r($argv);

Using cmd the caret is preserved:

$ composer require "twig/twig:^3.0"
Array
(
    [0] => C:\ProgramData\ComposerSetup\bin\testargs.php
    [1] => require
    [2] => twig/twig:^3.0
)

But with Powershell it is eaten:

$ composer require "twig/twig:^3.0"
Array
(
    [0] => C:\ProgramData\ComposerSetup\bin\testargs.php
    [1] => require
    [2] => twig/twig:3.0
)

The only way to get Powershell to preserve the caret is to use 4 of them, either quoted or not: twig/twig:^^^^3.0

Created at 2 months ago
issue comment
Composer trying to install older version despite incompatibility and newer one being available

I specifically tested the xdebug-handler restart before I posted (just in case I had screwed something up there), and it quoted everything fine, with the caret being preserved in the restarted command line args.

@Meryl Try running echo twig/twig:^3.0 and echo "twig/twig:^3.0" in Powershell (echo is a built-in alias for Write-Host). In both cases for me it produces twig/twig:^3.0.

Created at 2 months ago
issue comment
Composer trying to install older version despite incompatibility and newer one being available

As you can see in "requires twig/twig 3.0" it seems your shell ate the ^ away

I'm not so sure about this because the caret in composer require "twig/twig:^3.0" is not treated as a special character when it is enclosed in double-quotes:

// quoted - caret has no special meaning inside double-quotes
$ echo "twig/twig:^3.0"
"twig/twig:^3.0"

// unquoted - caret means next character is treated as literal and the caret is removed
$ echo twig/twig:^3.0
twig/twig:3.0
Created at 2 months ago
issue comment
i can install composer but occur issue The Composer installer script was not successful [exit code 1]. and The Composer installer script did not run correctly [exit code 259] and no output was returned.

Please supply a log file. Thanks.

Created at 2 months ago