johejo
Repos
172
Followers
16
Following
1

Simple Go coverage report viewer

2
3

golang-migrate extra drivers for io/fs

13
2

Package promredis exports pool stats of go-redis/redis as prometheus metrics collector.

8
1

Package prommongo exports pool stats of Mongo Driver as prometheus metrics collector.

2
1

Package ghfs wraps the github v3 rest api with io/fs.

7
0

Package cachehandler provides net/http middleware that caches HTTP responses.

0
0

Events

pull request opened
reuse http.Client

Description

Reuse http.Client without initializing each time.

Related Issue

Motivation and Context

https://pkg.go.dev/net/http#Client

The Client's Transport typically has internal state (cached TCP connections), so Clients should be reused instead of created as needed. Clients are safe for concurrent use by multiple goroutines.

How Has This Been Tested?

Add a unit test.

Screenshots (if appropriate):

Created at 2 weeks ago

reuse http.Client

Created at 2 weeks ago
create branch
johejo create branch reuse_http_client
Created at 2 weeks ago
Created at 2 weeks ago
issue comment
Add timeformat to govet analysers

It is disabled by default in go vet but seems to be enabled by default in gopls.

Created at 3 weeks ago
pull request opened
Add timeformat to govet analysers

https://github.com/golang/go/issues/48801

Like go vet it is not enabled by default.

Created at 3 weeks ago
create branch
johejo create branch add_timeformat
Created at 3 weeks ago

update

Created at 1 month ago

update

Created at 1 month ago
issue comment
panic: flag redefined

For example, it confuses many users to panic just by importing github.com/golang/glog.

https://go.dev/play/p/WAxoXS_BHib

Created at 1 month ago

Update README.md

Created at 1 month ago
Created at 1 month ago

update

Created at 1 month ago
pull request closed
zip: Fallback to in-memory buffer stream

This might be preprocessing that the user of this package had better to do.

I have written this fallback several times when extracting remote zip files.

Created at 1 month ago
issue comment
zip: Fallback to in-memory buffer stream

Rather than adding options, I think it would be better to add documentation and control the users who read it. Determining a default buffer size that satisfies many use cases is difficult.

Some users might prefer a limited buffer instead of io.ReadAll. It may be better to divert golang/go's internal/safeio. https://github.com/golang/go/blob/master/src/internal/saferio/io.go

https://github.com/golang/go/issues/47653

Created at 1 month ago
pull request opened
zip: Fallback to in-memory buffer stream

This might be preprocessing that the user of this package had better to do.

I have written this fallback several times when extracting remote zip files.

Created at 1 month ago

zip: Fallback to in-memory buffer stream

Created at 1 month ago
create branch
johejo create branch fallback_zip_reader
Created at 1 month ago
Created at 1 month ago
pull request opened
Use environment files instead of set-output

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Created at 1 month ago
create branch
johejo create branch deprecated_set-output
Created at 1 month ago
Created at 1 month ago

add chain to recover from panic

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Created at 2 months ago

add chain to recover from panic

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Created at 2 months ago

Revert "fix parser option to keep old non-standard behavior"

This reverts commit f3d75b68f43851ecbb0a0ac2ebf8c0159a4d41ac.

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Revert "fix parser option to keep old non-standard behavior"

This reverts commit 49ec9ef7ec976e4225afcd268dd250347575ad26.

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

add chain to recover from panic

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Created at 2 months ago

fix: snyk report bugs (#10544)

Signed-off-by: CI michael@crenshaw.dev

Signed-off-by: CI michael@crenshaw.dev

chore: update gitops-engine (3951079) (#10616)

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

added ./ for broken url link (#10623)

  • added ./ for broken url link

Signed-off-by: RutviShukla rutvi.shukla@ufl.edu

  • added command for setting default namespace

Signed-off-by: RutviShukla rutvi.shukla@ufl.edu

  • added command for setting default namespace

Signed-off-by: RutviShukla rutvi.shukla@ufl.edu

  • relocated incommand related to setting default namespace

Signed-off-by: RutviShukla rutvi.shukla@ufl.edu

Signed-off-by: RutviShukla rutvi.shukla@ufl.edu

feat: dark mode (#4722) (#9703)

  • feat: enable dark theme in ui

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • add more theme styles

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • remove package lock

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • improvements

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • improvements

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • cleanup

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • fix review comments

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • update argo-ui sha

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • update moment yarn.lock

Signed-off-by: saumeya saumeyakatyal@gmail.com

update moment yarn.lock

Signed-off-by: saumeya saumeyakatyal@gmail.com

update moment yarn.lock

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • fix review comments

Signed-off-by: saumeya saumeyakatyal@gmail.com

Signed-off-by: saumeya saumeyakatyal@gmail.com

fix: Application details page crashes with JS error (#10640)

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Adding Elastic as an ArgoCD User (#10649)

Adding Elastic in the user list

Signed-off-by: Christopher Cutajar 60098546+christophercutajar@users.noreply.github.com

Signed-off-by: Christopher Cutajar 60098546+christophercutajar@users.noreply.github.com

Add Kandji to users list (#10650)

Signed-off-by: Stephen Wolfe stephen@swolfe.io

Signed-off-by: Stephen Wolfe stephen@swolfe.io Co-authored-by: Alexander Matyushentsev AMatyushentsev@gmail.com

test: Add logic to handle for fileHandle.Close() (#10632)

Signed-off-by: xin.li xin.li@daocloud.io

Signed-off-by: xin.li xin.li@daocloud.io

chore: update Helm and Kustomize versions (#10273) (#10599)

  • chore: update Helm and Kustomize versions

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

  • remove v from kustomize version

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

  • DRY

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

  • Helm 3.10.0

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

  • update tool-versions.sh

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

docs: Add enigmo to list of users (#10603)

Signed-off-by: Masatoshi Natsume 27754135+natten426@users.noreply.github.com

Signed-off-by: Masatoshi Natsume 27754135+natten426@users.noreply.github.com Signed-off-by: Michael Crenshaw michael@crenshaw.dev Co-authored-by: Michael Crenshaw michael@crenshaw.dev

fix: Provide better error message when application source is missing some settings (#10694)

Signed-off-by: cleverhu shouping.hu@daocloud.io

Signed-off-by: cleverhu shouping.hu@daocloud.io

chore: update install-codegen-tools.sh and upgrade docs (#10692)

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

chore: upgrade k8s.io/kube-openapi to avoid CVE-2022-1996 (#10691)

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

fix: Fix a nil pointer crash for repo server (#10696)

Fixes: https://github.com/argoproj/argo-cd/issues/10614 Signed-off-by: cleverhu shouping.hu@daocloud.io

Signed-off-by: cleverhu shouping.hu@daocloud.io Co-authored-by: jannfis jann@mistrust.net

fix: button consistency in logs panel #9945 (#10016)

Signed-off-by: Mayursinh Sarvaiya marvinduff97@gmail.com

tests: cmd unit test version (#10689)

  • tests: add unit test version command

Signed-off-by: emirot emirot.nolan@gmail.com

  • tests: add unit test version command

Signed-off-by: emirot emirot.nolan@gmail.com

  • tests: add unit test version command

Signed-off-by: emirot emirot.nolan@gmail.com

  • tests: add unit test version command

Signed-off-by: emirot emirot.nolan@gmail.com

  • tests: add unit test version command

Signed-off-by: emirot emirot.nolan@gmail.com

  • tests: client version

Signed-off-by: emirot emirot.nolan@gmail.com

Signed-off-by: emirot emirot.nolan@gmail.com

docs: Default value for server.rootpath is incorrect (#10665)

Signed-off-by: Petr Drastil petr.drastil@gmail.com

Signed-off-by: Petr Drastil petr.drastil@gmail.com

fix: add tooltip for long title in list view ui (#9792)

  • fix: add tooltip for long title in list view ui

Signed-off-by: saumeya saumeyakatyal@gmail.com

  • review comments

Signed-off-by: saumeya saumeyakatyal@gmail.com

Signed-off-by: saumeya saumeyakatyal@gmail.com

fix: ui add tooltips on repository url links and names (#9868) (#10108)

  • fix: ui add tooltips on repository url links and names (#9868)

Signed-off-by: XieYanke xieyanke007@gmail.com

  • fix: yarn lint failure

Signed-off-by: XieYanke xieyanke007@gmail.com

Signed-off-by: XieYanke xieyanke007@gmail.com

Add Splunk as ArgoCD user (#10718)

Signed-off-by: emagana 112656855+emagana@users.noreply.github.com

Signed-off-by: emagana 112656855+emagana@users.noreply.github.com

Created at 2 months ago
Unexpected versions are published

https://pkg.go.dev/github.com/envoyproxy/protoc-gen-validate?tab=versions

v0.6.9, v0.6.10 and v0.6.11 don't exist on github, but seem to be indexed on proxy.golang.org. It may be better to retract them. https://go.dev/ref/mod#go-mod-file-retract

$ curl https://proxy.golang.org/github.com/envoyproxy/protoc-gen-validate/@v/list -fsSL | sort -r -V | head -n 10
v0.6.11
v0.6.10
v0.6.9-rc.2
v0.6.9-rc.1
v0.6.9-rc.0-java
v0.6.9-rc.0
v0.6.9
v0.6.8
v0.6.7-java
v0.6.7
Created at 2 months ago
opened issue
Duplicate dot after enum's namespace in typescript file when using dot in package name

related #1271

#1278 breaks the package name includes dot.

$ tree
.
├── child
│   └── enum.proto
└── test.proto

1 directory, 2 files

test.proto

syntax = "proto3";

import "child/enum.proto";

package test;

message HelloRequest {
    child.DocEnum doc = 1;
}

child/enum.proto

syntax = "proto3";

package test.child;

enum DocEnum {
    DOC_ENUM_PDF = 0;
    DOC_ENUM_HTML = 1;
}
$ protoc-gen-grpc-web --version
protoc-gen-grpc-web 1.4.0
protoc -I=. *.proto --plugin=/path/to/protoc-gen-js --plugin=/path/to/protoc-gen-grpc-web --js_out=import_style=commonjs:. --grpc-web_out=import_style=commonjs+dts,mode=grpcwebtext:.
import * as jspb from 'google-protobuf'

import * as child_enum_pb from './child/enum_pb';


export class HelloRequest extends jspb.Message {
  getDoc(): child_enum_pb..DocEnum;
  setDoc(value: child_enum_pb..DocEnum): HelloRequest;

  serializeBinary(): Uint8Array;
  toObject(includeInstance?: boolean): HelloRequest.AsObject;
  static toObject(includeInstance: boolean, msg: HelloRequest): HelloRequest.AsObject;
  static serializeBinaryToWriter(message: HelloRequest, writer: jspb.BinaryWriter): void;
  static deserializeBinary(bytes: Uint8Array): HelloRequest;
  static deserializeBinaryFromReader(message: HelloRequest, reader: jspb.BinaryReader): HelloRequest;
}

export namespace HelloRequest {
  export type AsObject = {
    doc: child_enum_pb..DocEnum,
  }
}
Created at 2 months ago

docs: Include Pandosearch in USERS.md (#10596)

Signed-off-by: Edward Smit github@edwardsmit.com

Signed-off-by: Edward Smit github@edwardsmit.com

docs: Fix Broken Link in Getting Started Docs (#10585)

  • Fix Broken Link

Signed-off-by: Greg Knoblauch knoblauch.greg@gmail.com

  • Update docs/getting_started.md

Co-authored-by: asingh 11219262+ashutosh16@users.noreply.github.com Signed-off-by: Greg Knoblauch knoblauch.greg@gmail.com

Signed-off-by: Greg Knoblauch knoblauch.greg@gmail.com Co-authored-by: asingh 11219262+ashutosh16@users.noreply.github.com

chore: remove incompatible miniredis dependency (#10566)

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

docs: update description of policy.csv example in rbac.md (#10565)

Signed-off-by: Minchao minchao.220@gmail.com

Signed-off-by: Minchao minchao.220@gmail.com

docs: decision about logs RBAC enforcement in release notes (#10563)

Signed-off-by: CI michael@crenshaw.dev

Signed-off-by: CI michael@crenshaw.dev

fix: add skip-test-tls flag to optionally skip testing for tls (#9679) (#10484)

  • feat: add skip-test-tls flag to optionally skip testing for tls, fixes #9679

Signed-off-by: msvechla m.svechla@gmail.com

  • docs: update cli documentation

Signed-off-by: msvechla m.svechla@gmail.com

Signed-off-by: msvechla m.svechla@gmail.com

docs: decision about logs RBAC enforcement in release notes for 2.4 (#10564)

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

Signed-off-by: Michael Crenshaw michael@crenshaw.dev

Merge remote-tracking branch 'origin/master' into robfig_cron_v3

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Created at 2 months ago