jnoordsij
Repos
27
Followers
3

Events

Fix parameter types (#43403)

Update Task.php (#43400)

Break out quotes method (#43397)

[9.x] Improve Test For Replaces method in Collection (#43396)

add some case for index and associative array and item will be add when there is no match in collection

feat: add support for multiple hash algorithms (#43407)

[9.x] Improves serve Artisan command (#43375)

  • Improves serve Artisan command

  • Handles better edge cases

  • Removes assets requests, and displays unexpected output as "warn"

  • Simplifies command and handles assets

  • Better captures

  • formatting

Co-authored-by: Taylor Otwell taylor@laravel.com

[9.x] Improve test For Split method In Collection (#43408)

typo correction (#43431)

To calm the PHPStorm IDE ("Function has a parameter whose default value is incompatible with its declared type")

[9.x] Improve test for values method in Collection (#43423)

The values method returns the keys reset to consecutive integers

[9.x] Fix overriding global locale (#43426)

  • Fix overriding global locale

  • wip

  • formatting

  • Update Request.php

Co-authored-by: Taylor Otwell taylor@laravel.com

version

version

formatting

[9.x] Add unique locking to broadcast events (#43416)

  • Add unique locking to broadcast events

  • Don't require uniqueId, set default

  • Locking irrelevant when broadcasting now

  • formatting

Co-authored-by: Taylor Otwell taylor@laravel.com

Apply fixes from StyleCI

Fixes serve command on Windows (#43437)

version

[9.x] Added changelog

[9.x] Added changelog

[9.x] Added changelog

Created at 2 days ago
jnoordsij delete branch 8.x
Created at 2 days ago

[8.x] Added changelog

Merge remote-tracking branch 'upstream/8.x' into 8.x

[8.x] Added changelog

[8.x] Added changelog

gracefully fail when unable to locate expected binary on the system (#43521)

Revert "Update RouteRegistrar.php (#43509)" (#43523)

This reverts commit d004416a28936cb43fc66f5091df01a73da6aa58.

add union type for expected listener (#43522)

Co-authored-by: charlesbilbo c.bilbo@rxmg.com

[9.x] Fix unique locking on broadcast events (#43516)

  • Fix broadcasting locks

  • Update BroadcastManager.php

  • Respect event uniqueVia

  • Remove UniqueBroadcastEvent, use event instead

  • clean up logic

  • formatting

  • formatting

Co-authored-by: Taylor Otwell taylor@laravel.com

[9.x] Add restoreQuietly functionality (#43550)

  • [9.x]: add restoreQuietly functionality

  • [9.x]: add restoreQuietly functionality - return type fix

[9.x] Improve output for some Artisan commands (#43547)

  • Improve output for some Artisan commands

  • Improve output for migrate:fresh command

  • Fix tests

Co-authored-by: Alvin Lau alvinlau@fimmick.com

[9.x] Alternative database name in Postgres DSN, allow pgbouncer aliased databases to continue working on 9.x (#43542)

  • feat: allow creating a Postgres DSN string with a different database name than is used for information_schema queries

See https://github.com/laravel/framework/discussions/43536

  • formatting

Co-authored-by: Taylor Otwell taylor@laravel.com

add test for delete quietly (#43538)

[9.x] Allow @class() for component tags (#43140)

  • Allow class directive inside tag components

  • formatting

Co-authored-by: Taylor Otwell taylor@laravel.com

Apply fixes from StyleCI

Fixes the issue of running docs command on windows (#43566)

  • Fixes the issue of running docs command on windows

  • Update DocsCommand.php

Co-authored-by: Taylor Otwell taylor@laravel.com

Apply fixes from StyleCI

[9.x]: Add mergeUnless to resource ConditionallyLoadsAttributes trait (#43567)

  • [9.x]: Add mergeUnless to resource ConditionallyLoadsAttributesTrait

  • Update Queueable.php

  • Update ConditionallyLoadsAttributes.php

Co-authored-by: Taylor Otwell taylor@laravel.com

Update NotificationFake with notifications getter (#43558)

When testing notifications this is super handy for testing whether the correct notifications have been sent. Similar method is available in the QueueFake with Queue::getJobs()

[9.x] Attribute Cast Performance Improvements (#43554)

  • Remove repeated calls to getCasts() in same method

  • Switch strncmp to starts_with_str

Marginally faster, better readability, and matches similar functions

  • Add castTypeCache

getCastType is called a lot when processing models with defined casts and contributes to a significant number of overall calls. Caching the results of the key conversion can result in significant performance improvement when processing large numbers of models.

Remove redundant @group annotation (#43580)

Created at 2 days ago
pull request opened
Update Traefik to v2.8.7

What does this PR do?

Update to latest Traefik patch version. See https://github.com/traefik/traefik/releases/tag/v2.8.7.

More

Created at 2 days ago
jnoordsij create branch traefik-2.8.7
Created at 2 days ago
jnoordsij delete branch traefik-2.8.5
Created at 2 days ago

Update Traefik version to v2.8.5

Created at 2 days ago
delete branch
jnoordsij delete branch patch-1
Created at 1 week ago
opened issue
Add end-user function to generate CSP report-uri

Problem Statement

It is possible to use Sentry as endpoint for collecting CSP violations, see https://docs.sentry.io/product/security-policy-reporting/. In order to do so, it requires passing a specific report-uri value to the CSP header in the response of your application. It would be great if the SDK would be able to generate such an URI.

Solution Brainstorm

The Raven: Sentry Integration module for Drupal has an implentation of this, see https://git.drupalcode.org/project/raven/-/blob/4.x/src/Plugin/CspReportingHandler/Raven.php. It would be great to have a public function for this URI in any application using Sentry PHP SDK.

Created at 1 week ago
issue comment
Mark arguments as nullable in AddCspHeaders

You change allows null to be passed, but we don't want to encourage that.

Actually in the PHP 8.0 and above, using null as default makes the type implicitly nullable (see https://www.php.net/manual/en/functions.arguments.php above Example #10), so this really is simply a cosmetic/style change and does not change any functionality for users.

Though I do agree not adding it to the typehint is somewhat of an encouragement not to pass null.

Created at 1 week ago
pull request opened
Mark arguments as nullable in AddCspHeaders

Credits to my codestyle checker that noticed this while I was looking through the source code.

Created at 1 week ago

Mark arguments as nullable in AddCspHeaders

Created at 1 week ago
Created at 1 week ago
issue comment
[Bug] PHP 8.2 deprecation in AddonServiceProvider in BackPack/PRO

Thanks for looking into this! Can't guarantee this will be the only deprecation, but it's the only thing I've run into so far on my quick first round of tests, so let's hope there will be no further major changes required. Though of course my application probably doesn't use all parts of this package.

If I'll spot any more things I'll be sure to let you know.

Created at 1 week ago
issue comment
Fix PHP 8.2 deprecation

Any update on this?
PHP 8.2 now has a first RC and is scheduled for release on November 24, 2022.

Created at 2 weeks ago
opened issue
[Bug] PHP 8.2 deprecation in AddonServiceProvider in BackPack/PRO

Bug report

What I did

Run my application using BackPack on the RC-version of PHP 8.2.

What I expected to happen

Everything to work smoothly ;)

What happened

Everything worked smoothly, but a deprecation error was raised.

What I've already tried to fix it

Submitted a PR to fix this in the addon-skeleton repository that seems to be used as a base for the pro repository, see https://github.com/Laravel-Backpack/addon-skeleton/pull/13. I think this might have gone unnoticed. Note that the same fix should be done in the pro repository, but I cannot access that.

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there?
Yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:
5.3.10 and pro 1.2.7
PHP 8.2rc1

Created at 2 weeks ago
pull request opened
Update Traefik version to v2.8.5

What does this PR do?

Update to latest Traefik patch version. See https://github.com/traefik/traefik/releases/tag/v2.8.5.

More

Created at 2 weeks ago

Update Traefik version to v2.8.5

Created at 2 weeks ago
jnoordsij create branch traefik-2.8.5
Created at 2 weeks ago

Update Traefik version to v2.8.4

Created at 2 weeks ago
jnoordsij delete branch traefik-2.8.4
Created at 3 weeks ago

Update Traefik version to v2.8.4

Created at 3 weeks ago
pull request opened
Update Traefik version to v2.8.4

What does this PR do?

Update to latest Traefik patch version. See https://github.com/traefik/traefik/releases/tag/v2.8.4.

More

Created at 3 weeks ago
jnoordsij create branch traefik-2.8.4
Created at 3 weeks ago

Update PodDisruptionBudget apiVersion to policy/v1

Created at 3 weeks ago
delete branch
jnoordsij delete branch improve-query-init
Created at 3 weeks ago
pull request closed
Use newQuery method on model for creating model query

WHY

This feels to me as a little more elegant and readable way to create a new model query.

HOW

Is it a breaking change?

No, the resulting Builder class should be exactly the same as before.

Created at 3 weeks ago
issue comment
Use newQuery method on model for creating model query

Ahh my bad, I thought this was some sort of Laravel default, but that probably is only applied after executing the query, not when creating it. Then it makes sense to keep it the way it is, I'll close this. Thanks for checking!

Created at 3 weeks ago
pull request opened
Use newQuery method on model for creating model query

WHY

This feels to me as a little more elegant and readable way to create a new model query.

HOW

Is it a breaking change?

No, the resulting Builder class should be exactly the same as before.

Created at 3 weeks ago
pull request opened
Fix typehint for query property in CrudPanel/Traits/Query.php

WHY

BEFORE - What was wrong? What was happening before this PR?

The query property of the CrudPanel was listed as instance of Illuminate\Database\Query\Builder. It is correctly typehinted in all method return types.

AFTER - What is happening after this PR?

The query property of the CrudPanel is correctly listed as instance of Illuminate\Database\Eloquent\Builder.

Any model-based query in Laravel is based on the Eloquent-namespace version, which has some additional available methods on the query builder, like e.g. whereHas and other relation-based methods. Currently, when referencing crud->query in my codebase, the static analyzer produces errors like Call to an undefined method Illuminate\Database\Query\Builder::whereHas().

HOW

Is it a breaking change?

No, just a static typehint improvement.

Created at 3 weeks ago