jeffbyrnes
Repos
81
Followers
58
Following
21

Events

Update to pdk v2.5.0

Automatically updated via pdk update using PDK v2.5.0

Bring back module-specific gems

Unclear if the puppet-lint-* gems are needed, but these are:

  • coveralls
  • fakefs
  • rspec-json_expectations (this esp.)

Add beaker gems back for acceptance testing

Apply autofixes from rubocop -a && puppet-lint -f

Automate PDK validate & test unit

Add .ruby-version for those using rbenv, etc.

PDK + rbenv is a bit tricky; this helps

Use H2 headers for PR template

More sensible w/ the idea that the PR title == H1

Switch fixtures to use Forge modules

Seems safer to use published modules instead of bleeding edge

Set Types & use Puppet Strings for class params

Typecasting & documentation is nice

Update dependencies for Puppet v7.x

Also:

  • Use consistent name style
  • Switch to puppet/systemd

Ignore tests w/ case statements that appear empty

Seems to be a shortcoming of rubocop-rspec

Update supported OS distros + versions

  • Reduce supported versions to the last 2 major OS distro versions
  • Drop Amazon Linux support
  • Drop Scientific Linux support
  • Drop Fedora Linux support

Update & clean up README syntax & formatting

Update beaker-rspec configs for newer OS versions

Doesn’t quite work though, so something’s missing

Clean up README some more

Update module name & author, reset version

Forking & running away on our own

Use Puppet Strings to generate DOCS.md

Needs to be automated, but better than trying to keep the doc strings and the README up-to-date.

Drop using Beaker

Use named Rspec subjects

pdk (CONVENTION): rubocop: Name your test subject if you need to reference it explicitly. (spec/classes/vault_spec.rb:97:20)

Clean up vault::params variables

  • Get closer to the same order as Class[Vault]
  • Add missing $vault::params::service_options
    • Undefined b/c it is optional
Created at 38 minutes ago
issue comment
Open Weather 401 Unauthorized

@obatola unfortunately, that’s not the issue, as I show in #16. Here’s an example of calling the 2.5 endpoint, just like the workflow does:

♠ https "api.openweathermap.org/data/2.5/onecall?lat=42.394722&lon=-71.109103&appid=$API_KEY"
HTTP/1.1 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: GET, POST
Access-Control-Allow-Origin: *
Connection: keep-alive
Content-Length: 20137
Content-Type: application/json; charset=utf-8
Date: Mon, 03 Oct 2022 12:43:28 GMT
Server: openresty
X-Cache-Key: /data/2.5/onecall?lat=42.39&lon=-71.11

{
    "current": {
        "clouds": 75,
        "dew_point": 277.35,
        "dt": 1664801007,
        "feels_like": 278.17,
        "humidity": 72,
        "pressure": 1024,
        "sunrise": 1664793812,
        "sunset": 1664835790,
        "temp": 282.12,
        "uvi": 0.88,
        "visibility": 10000,
        "weather": [
            {
                "description": "broken clouds",
                "icon": "04d",
                "id": 803,
                "main": "Clouds"
            }
        ],
        "wind_deg": 60,
        "wind_gust": 12.86,
        "wind_speed": 9.26
    },
# snip
Created at 1 day ago
issue comment
Cut a new release and publish to forge

Would love to see a new release as well! Happy to help.

Created at 4 days ago

Add VS Code shell integration

Created at 1 week ago
issue comment
403 error with Climacell

Relates to #24

Created at 1 week ago
issue comment
Open Weather 401 Unauthorized

This is a duplicate of #16 (which has a typo in its title)

Created at 1 week ago
issue comment
404 Unauthorized

Not sure what to tell you, @miregal23.

Some “dumb” questions to be sure you’ve got things configured properly:

  • Have you tried reinstalling a freshly downloaded copy of the workflow?
  • Have you set your API key via the options by typing wto into Alfred?

Mine is working well with OpenWeather at this point:

[10:19:39.368] Weather[Script Filter] {"items":[{"title":"Refreshed!","subtitle":"Data will be reloaded on the next forecast","arg":"{}","valid":false}]}
[10:19:45.847] Weather[Script Filter] Queuing argument ''
[10:19:46.450] Weather[Script Filter] Script with argv '' finished
[10:19:46.459] STDERR: Weather[Script Filter] [alfred] 2022/09/19 10:19:45 Alfred version: 5.0.2
[weather] 2022/09/19 10:19:45 Using config file /Users/jeffbyrnes/Library/Application Support/Alfred/Workflow Data/com.jason0x43.alfred-weather/config.json
[weather] 2022/09/19 10:19:45 Using cache file /Users/jeffbyrnes/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.jason0x43.alfred-weather/cache.json
[weather] 2022/09/19 10:19:45 loaded config
[weather] 2022/09/19 10:19:45 loaded cache
[alfred] 2022/09/19 10:19:45 set keyword to 'daily'
[alfred] 2022/09/19 10:19:45 tell: data=alfred.workflowData{Keyword:"daily", Mode:"tell", Mod:"", Data:""}, arg=''
[alfred] 2022/09/19 10:19:45 Adding items for 'daily'
[weather] 2022/09/19 10:19:45 Running DailyCommand
[weather] 2022/09/19 10:19:45 using configured location
[weather] 2022/09/19 10:19:45 getting forecast for main.Location{Latitude:42.39031035304344, Longitude:-71.08542360028589, ShortName:"Somerville, Middlesex County, Massachusetts, 02145, United States", Name:"Somerville, Middlesex County, Massachusetts, 02145, United States"}
[weather] 2022/09/19 10:19:45 getting URL https://api.openweathermap.org/data/2.5/onecall?appid=${API_KEY}&lat=42.390310&lon=-71.085424&units=metric
[alfred] 2022/09/19 10:19:46 Saving JSON to /Users/jeffbyrnes/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.jason0x43.alfred-weather/cache.json
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[weather] 2022/09/19 10:19:46 precip: -1
[alfred] 2022/09/19 10:19:46 loaded cache
[10:19:46.460] Weather[Script Filter] {"items":[{"title":"Weather for Somerville, Middlesex County, Massachusetts, 02145, United States","subtitle":"–––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––","arg":"{}","valid":false,"mods":{"cmd":{"arg":"{\"keyword\":\"daily\",\"mode\":\"do\",\"mod\":\"cmd\",\"data\":\"{\\\"ToOpen\\\":\\\"https://api.openweathermap.org/data/2.5/onecall?lat=42.390310\\\\u0026lon=-71.085424\\\\u0026units=metric\\\"}\"}","valid":true,"subtitle":"Open this forecast in a browser"}}},{"title":"Currently: overcast clouds","subtitle":"61°F (61°F)","arg":"{\"keyword\":\"hourly\",\"mode\":\"tell\",\"data\":\"{\\\"Start\\\":\\\"0001-01-01T00:00:00Z\\\"}\"}","icon":{"path":"icons/grzanka/mostlycloudy.png"},"valid":true},{"title":"Today: heavy intensity rain","subtitle":"↓ 61°F    ↑ 70°F    ☼ 06:28    ☾ 18:47","arg":"{\"keyword\":\"hourly\",\"mode\":\"tell\",\"data\":\"{\\\"Start\\\":\\\"2022-09-19T06:28:29-04:00\\\"}\"}","icon":{"path":"icons/grzanka/rain.png"},"valid":true},{"title":"Tuesday: light rain","subtitle":"↓ 57°F    ↑ 62°F    ☼ 06:29    ☾ 18:46","arg":"{\"keyword\":\"hourly\",\"mode\":\"tell\",\"data\":\"{\\\"Start\\\":\\\"2022-09-20T06:29:32-04:00\\\"}\"}","icon":{"path":"icons/grzanka/rain.png"},"valid":true},{"title":"Wednesday: overcast clouds","subtitle":"↓ 55°F    ↑ 71°F    ☼ 06:30    ☾ 18:44","arg":"{\"keyword\":\"hourly\",\"mode\":\"tell\",\"data\":\"{\\\"Start\\\":\\\"2022-09-21T06:30:35-04:00\\\"}\"}","icon":{"path":"icons/grzanka/mostlycloudy.png"},"valid":true},{"title":"Thursday: light rain","subtitle":"↓ 51°F    ↑ 69°F    ☼ 06:31    ☾ 18:42","arg":"{}","icon":{"path":"icons/grzanka/rain.png"},"valid":false},{"title":"Friday: broken clouds","subtitle":"↓ 48°F    ↑ 58°F    ☼ 06:32    ☾ 18:40","arg":"{}","icon":{"path":"icons/grzanka/mostlycloudy.png"},"valid":false},{"title":"Saturday: broken clouds","subtitle":"↓ 45°F    ↑ 64°F    ☼ 06:33    ☾ 18:38","arg":"{}","icon":{"path":"icons/grzanka/mostlycloudy.png"},"valid":false},{"title":"Sunday: broken clouds","subtitle":"↓ 49°F    ↑ 73°F    ☼ 06:34    ☾ 18:37","arg":"{}","icon":{"path":"icons/grzanka/mostlycloudy.png"},"valid":false},{"title":"Monday: moderate rain","subtitle":"↓ 60°F    ↑ 68°F    ☼ 06:35    ☾ 18:35","arg":"{}","icon":{"path":"icons/grzanka/rain.png"},"valid":false}]}
Created at 2 weeks ago
pull request closed
Change from ClimaCell v3 to Tomorrow.io v4 API

This likely needs more than a change in the URL, but it’s a start

Fixes #24

Created at 2 weeks ago
issue comment
Change from ClimaCell v3 to Tomorrow.io v4 API

Closing this in favor of #27

Created at 2 weeks ago
issue comment
404 Unauthorized

So I created a new API key, and while at first, it did not work, I came back a little later, and it works fine with the existing code.

Right now, the workflow makes calls like so:

♠ https "api.openweathermap.org/data/2.5/onecall?lat=42.394722&lon=-71.109103&appid=${API_KEY}"
HTTP/1.1 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: GET, POST
Access-Control-Allow-Origin: *
Connection: keep-alive
Content-Length: 20489
Content-Type: application/json; charset=utf-8
Date: Sun, 18 Sep 2022 17:22:35 GMT
Server: openresty
X-Cache-Key: /data/2.5/onecall?lat=42.39&lon=-71.11
[snip]

I’ve set up the workflow using this new API key of mine, and toggling it to use OpenWeather for its API, and the workflow works well.

So I can’t reproduce this, unfortunately.

Created at 2 weeks ago
issue comment
404 Unauthorized

It seems that the current code uses the “One Call By Call” endpoint, which is only available when you provide billing information, but offers 1,000 free calls, as the OpenWeather Pricing page describes.

I’ll poke a little & see if I can make this work with the default free plan instead.

Created at 2 weeks ago

Update TESTING.md per code review

One more for the translation improvements!

Co-authored-by: Jorie Helwig joriephoto@gmail.com

Created at 2 weeks ago

Apply grammar suggestions from code review

As described, these will improve translations & understanding

Co-authored-by: Jorie Helwig joriephoto@gmail.com

Created at 2 weeks ago

FIXUP: correct use of class params downstream

One cannot access class params via the $facts variable

Created at 2 weeks ago
Create athena fork

As an FYI, I opened puppetlabs/litmusimage#48 to see about having an OL8 Docker image for use with Litmus for acceptance testing.

Created at 3 weeks ago
pull request opened
Add newer oraclelinux images

Add oraclelinux:8 and oraclelinux:9 for use with Litmus.

Created at 3 weeks ago
create branch
jeffbyrnes create branch add-newer-oraclelinux-images
Created at 3 weeks ago
Created at 3 weeks ago
issue comment
Update to current Chef community conventions

And I tracked down that single unit test failure: turns out, libraries/recipe_helpers was being tested by two sets of unit tests.

I deleted the older one in 12b321a, and now we’ve got all our units & integration tests passing here.

I can bring in the cookstyle changes to get the linter passing as well, but seems like this PR is already plenty big enough.

@axl89, @albertvaka, @jtappa, this really, finally, is in a place to be merged in.

Happy to discuss further.

Created at 3 weeks ago

Move datadog::security-agent spec to common place

All of the other recipe specs are in this directory, seems to make sense to move this one there.

Use Ruby 1.9 style hash in ServerSpec spec_helper

Ensure datadog::system-probe uses Windows Env Var

Hard-coding values is dangerous. Best to be consistent & use the env var like in other instances.

Remove duplicate unit tests for recipe_helpers

This library ended up with two copies of its spec, and the one in the spec/recipes directory had fallen behind & has had at least 1 broken test for some time now.

Created at 3 weeks ago
Update process_config setting per Agent v7 deprecation notice

Per the current (as of this writing) v7 version of Datadog Agent:

process_config.enabled is deprecated, use process_config.container_collection.enabled and process_config.process_collection.enabled instead, see https://docs.datadoghq.com/infrastructure/process#installation for more information
Created at 3 weeks ago
jeffbyrnes create tag v1.0.2
Created at 3 weeks ago
jeffbyrnes create tag v1.0.1
Created at 3 weeks ago

Add further documentation around configuration

Set example docker-compose.yml to use latest image

Provides a better example for operators

Created at 3 weeks ago
jeffbyrnes delete tag v1.0.1
Created at 3 weeks ago
jeffbyrnes delete tag v1.0.2
Created at 3 weeks ago