jdrieghe
Repos
30
Followers
14
Following
1

Events

Install Laravel Pint

Run Laravel Pint & fix coding standards issues

Configure GitHub Actions

Merge branch 'main' into pint

GitHub Actions test

Fix coding standards issues

Add concat_space rule

Fix concat_space issues

Merge pull request #350 from nbayramberdiyev/pint

Add Coding Standards Fixer via Laravel Pint

Created at 4 weeks ago
pull request closed
Add Coding Standards Fixer via Laravel Pint

This PR adds coding standards fixer to the project via Laravel Pint that is built on top of PHP-CS-Fixer. By default, Pint uses the laravel preset which is the opinionated coding style of Laravel (see rules).

I don’t know exactly what rules you prefer but the laravel preset may be a good starting point to keep coding style consistent IMO. Let me know if you want me enable/disable any rules in the preset.

Also, I added a GitHub workflow that fixes code style issues and commits changes automatically. If you prefer --dry-run without actually modifying the files in GitHub workflow, I'm happy to change it like so.

Created at 4 weeks ago
issue comment
Add Coding Standards Fixer via Laravel Pint

We use this configuration in our php-cs-fixer-config library: https://github.com/madewithlove/php-cs-fixer-config/blob/master/src/Config.php#L39

Created at 4 weeks ago
issue comment
Add Coding Standards Fixer via Laravel Pint

I'm not a big fan of the concatenation without spaces from Pint. Can we enforce a single space around string concatenations?

Created at 4 weeks ago

Add readonly modifier to properties

Remove empty space

Use conditional class

Merge pull request #339 from nbayramberdiyev/readonly-properties

Created at 1 month ago
pull request closed
Readonly properties

This PR;

  • uses readonly properties instead of getters,
  • uses conditional class blade directive.
Created at 1 month ago

Remove unused import

Fix unit test namespace

Fix package comparison (not nullable)

Correct closing directives

Merge pull request #338 from nbayramberdiyev/minor-fixes

Minor fixes

Created at 1 month ago
pull request closed
Minor fixes

This PR;

  • removes unused imports,
  • fixes unit test namespace,
  • fixes the variable $package comparison in blade template (since it's not nullable),
  • corrects closing blade directives.
Created at 1 month ago
issue comment
Test method names

I think @WouterSioen created them deliberately like that because the non-breaking spaces are normally not visible, and it makes it very easy to read the test method name as if they were words. Not sure how attached you are to that approach, Wouter?

Created at 1 month ago

Update package name

Update package description

Update package keywords

Reorder composer.json according to the latest version of Laravel

Remove server.php file from style CI

Update .gitattributes according to the latest version of Laravel

Update .gitignore according to the latest version of Laravel

Update the lock file hash

Move lang directory to the root project directory

Update validation language lines according to the latest version of Laravel

Bump actions/checkout to v3

Bump actions/cache to v3

Remove .styleci.yml

Merge pull request #333 from nbayramberdiyev/minor-improvements

Minor improvements

Created at 1 month ago
pull request closed
Minor improvements

This PR;

  • updates the fields name, description, and keywords in composer.json file,
  • reorders composer.json content for compatibility with the latest version of Laravel boilerplate,
  • removes server.php file from Style CI since it was removed from the Laravel boilerplate,
  • updates .gitattributes and .gitignore files for compatibility with the latest version of Laravel boilerplate,
  • moves lang directory to the root project directory (see this),
  • updates validation language lines for compatibility with the latest version of Laravel boilerplate,
  • upgrades actions/checkout and actions/cache to the latest versions.
Created at 1 month ago
issue comment
Minor improvements

Great work @nbayramberdiyev, thank you so much. I think we can simply remove the .styleci.yml file because we aren't using it.

Created at 1 month ago
Redirect With Folder Not Working?

Describe the bug Testing ".htaccess" file "Redirect 301 /foo/bar.php /index.html" with query "http://example.com/foo/bar.php" shows it not being hit. Whereas testing "Redirect 301 /bar.php /index.html" with query "http://example.com/bar.php" shows it being hit.

Expected behavior I don't really know what I'm doing, so I might have made some mistake, but in real life, both seem to be hit, so this should do the same.

Reproduce link https://htaccess.madewithlove.com?share=9db717eb-2fda-489c-80bc-bbf170ec0a88

Created at 1 month ago

Remove config directory

Remove database/factories directory

Specify value type and remove app/Http/Kernel.php from excluded

Specify value type and remove app/Console/Kernel.php from excluded

Specify value type and remove app/Exceptions/Handler.php from excluded

Merge branch 'madewithlove:main' into static-analysis

Merge pull request #332 from nbayramberdiyev/static-analysis

Static analysis improvements

Created at 1 month ago
pull request closed
Static analysis improvements

This PR;

  • removes config directory from paths and excludePaths in PHPStan configuration file since it doesn't make sense to provide the same path to both paths and excludePaths,
  • removes database/factories directory from excludePaths in PHPStan configuration file since it doesn't exist,
  • removes app/Console/Kernel.php, app/Http/Kernel.php, and app/Exceptions/Handler.php files from excludePaths in PHPStan configuration file and specifies value type in iterable type array.
Created at 1 month ago
issue comment
Static analysis improvements

Thanks for your contribution!

Created at 1 month ago
issue comment
Static analysis improvements

Thanks @nbayramberdiyev . Could you please merge (or rebase to) the last commit from main (https://github.com/madewithlove/semver/commit/78c69f1bf7f4c5d2fb2368e20e83f08b85034c93) in your fork so that we can run the CI pipeline? It looks like we forgot to configure the pull_request_target trigger.

Created at 1 month ago

Also run CI workflows on pull_request_target

Created at 1 month ago
,htaccess issue in my website

Dear sir , i am facing some .htaccess file error please support me and resovle the issues , i checked with gitthub.com tool i find error please guide me sir my domain name is https://www.learn4earnmoney.com recently i am facing multiple canonical issues in my SEO critical issues report sir thanks and doing needful

Created at 1 month ago