chore: use prettier cache for faster linting

Prettier v2.7 introduced a new --cache CLI-option, which can dramatically improve CLI performance:

https://prettier.io/blog/2022/06/14/2.7.0.html

https://atlasicons.vectopus.com/

Add "Atlas Icons"

https://atlasicons.vectopus.com/

(create-svelte) speed up formatting and linting

Prettier v2.7 introduced a new --cache CLI-option, which can dramatically improve CLI performance:

https://prettier.io/blog/2022/06/14/2.7.0.html

chore: use prettier cache for faster linting

Prettier v2.7 introduced a new --cache CLI-option, which can dramatically improve CLI performance:

https://prettier.io/blog/2022/06/14/2.7.0.html

Problem

Prettier formatting and linting can get pretty slow, especially when a SvelteKit project gets bigger and there is transpilation/compilation (eg TypeScript) involved.

Solution

Prettier v2.7 introduced a --cache CLI-option, which can "dramatically improve CLI performance":

• https://prettier.io/blog/2022/06/14/2.7.0.html
• https://prettier.io/docs/en/cli.html#--cache

Since prettier was updated to v2.8 in https://github.com/sveltejs/kit/commit/581c43e1884d7d79e4ae6d41ed8f77a1e0b1732f, this change should just work.

I also added the --cache-flag to "internal" CI checks as a separate commit.

Discussion

• Caching might not be desired when running prettier in a CI environment, since caches are generally not persisted in CI
• It is possible to set a different --cache-strategy, which may makes sense for some usecases (https://prettier.io/docs/en/cli.html#--cache-strategy)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• [x] This message body should clearly illustrate what problems it solves.
• [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

• [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

(create-svelte) speed up formatting and linting

Prettier v2.7 introduced a new --cache CLI-option, which can dramatically improve CLI performance:

https://prettier.io/blog/2022/06/14/2.7.0.html

chore: use prettier cache for faster linting

Prettier v2.7 introduced a new --cache CLI-option, which can dramatically improve CLI performance:

https://prettier.io/blog/2022/06/14/2.7.0.html

Before filing issues, please check the following points first:

• [ ] Please don't open issues for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
• [ ] Have a look at https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md
• [ ] Read the FAQ at https://github.com/handlebars-lang/handlebars.js/blob/master/FAQ.md
• [ ] Use the jsfiddle-template at https://jsfiddle.net/4nbwjaqz/4/ to reproduce problems or bugs

This will probably help you to get a solution faster. For bugs, it would be great to have a PR with a failing test-case.

I think this would be hard to implement, since the parser is generated from this spec: https://github.com/handlebars-lang/handlebars-parser/blob/163b2756c0c342605536be4033d4d1bb36b544bc/src/handlebars.l#L47

The spec is compiled to JS and shipped via npm. I think in order to allow different mustache-syntax, the generated parser would have to be able to set different syntax dynamically, and I think https://github.com/zaach/jison can't do this.

The Chromium team specifically notes that nosniff should be provided as a header on all private/sensitive content, including HTML responses, and has indicated that Site Isolation / CORB protections depend on it

I'm curious if that is still the case.

Google does not send the X-CTO header on its own HTML document (google.com) but it does send the header on CSS/JS:

Trying 172.217.16.164:443...

< HTTP/2 200 
< date: Sun, 05 Mar 2023 20:57:12 GMT
< expires: -1
< cache-control: private, max-age=0
< content-type: text/html; charset=ISO-8859-1
< p3p: CP="This is not a P3P policy! See g.co/p3phelp for more info."
< server: gws
< x-xss-protection: 0
< x-frame-options: SAMEORIGIN
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
< accept-ranges: none
< vary: Accept-Encoding

Trying 172.217.16.164:443...

< HTTP/2 200 
< accept-ranges: bytes
< content-security-policy-report-only: require-trusted-types-for 'script'; report-uri https://csp.withgoogle.com/csp/gws-team
< cross-origin-resource-policy: cross-origin
< cross-origin-opener-policy: same-origin; report-to="gws-team"
< report-to: {"group":"gws-team","max_age":2592000,"endpoints":[{"url":"https://csp.withgoogle.com/csp/report-to/gws-team"}]}
< content-length: 863764
< x-content-type-options: nosniff
< server: sffe
< x-xss-protection: 0
< date: Sat, 04 Mar 2023 08:33:55 GMT
< expires: Sun, 03 Mar 2024 08:33:55 GMT
< cache-control: public, max-age=31536000
< last-modified: Fri, 03 Mar 2023 22:27:20 GMT
< content-type: text/javascript; charset=UTF-8
< vary: Accept-Encoding, Origin
< age: 131301
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

Document things not working properly

Just to clarify... This was working without error in 4.5.3. But as of 4.6.0 it does not. The release notes indicate that there were not any breaking changes between these versions (hence only a minor version roll). However, this appears to be a breaking change to me. Am I missing something, or should this still behave the same?

There was a breaking change (for security reasons):

• https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md#v460---january-8th-2020
• https://github.com/handlebars-lang/handlebars.js/pull/1633

This is an error from the handlebars-helpers library:

https://github.com/helpers/handlebars-helpers/blob/5d3405f178a9ec4c90df3c7dc07b4faf9a09dfd7/lib/math.js#L86

I guess this error is thrown because of something else.

The reason for the error is that pageCount is undefined inside your for-helper. You have to make variables available in your helper like this:

https://handlebarsjs.com/playground.html#format=1&currentExample=%7B%22template%22%3A%22%7B%7B%23for%200%20pageCount%201%7D%7D%5Cn%20%20pageCount%3A%20%7B%7Bcount%7D%7D%5Cn%20%20%7B%7B%23unless%20(eq%20this%20(subtract%20count%201))%7D%7D%2C%7B%7B%2Funless%7D%7D%5Cn%7B%7B%2Ffor%7D%7D%22%2C%22partials%22%3A%5B%5D%2C%22input%22%3A%22%7B%20pageCount%3A%201%20%7D%22%2C%22output%22%3A%22%20%20pageCount%3A%201%5Cn%20%20%2C%5Cn%22%2C%22preparationScript%22%3A%22Handlebars.registerHelper('for'%2C%20(from%2C%20to%2C%20incr%2C%20block)%20%3D%3E%20%7B%5Cn%20%20%20%20let%20accum%20%3D%20''%3B%5Cn%20%20%20%20for%20(let%20i%20%3D%20from%3B%20i%20%3C%20to%3B%20i%20%2B%3D%20incr)%20%7B%5Cn%20%20%20%20%20%20%20%20accum%20%2B%3D%20block.fn(%7Bcount%3A%20to%7D)%3B%5Cn%20%20%20%20%7D%5Cn%20%20%20%20return%20accum%3B%5Cn%7D)%3B%5Cn%5CnHandlebars.registerHelper('subtract'%2C%20(a%2C%20b)%20%3D%3E%20%7B%5Cn%20%20return%20a%20-%20b%3B%5Cn%7D)%3B%5Cn%5CnHandlebars.registerHelper('eq'%2C%20(a%2C%20b%2C%20options)%20%3D%3E%20%7B%5Cn%20%20return%20a%20%3D%3D%20b%3B%5Cn%7D)%3B%22%2C%22handlebarsVersion%22%3A%224.7.7%22%7D

Update

Use new URL format for streams

Also switched to new CORS url.

https://unicornicons.com/

Add "Unicorn" icons

https://unicornicons.com/