hughmcmaster
Repos
32

Events

issue comment
Using pkg-config to find libxml2

Sorry for my delayed reply. Those changes in the new branch look good, @vlvassilev. I really prefer the simplification. Just a few points below.

For testing, I rebuilt every directory with a configure.ac file, including the main source tree.

In the example-modules: ietf-alarms failed to build due to a missing #include <stdio.h>. Basically, FILE needs to be defined via the header. interfaces-alarms - same issue as above. yuma-arp - same issue with stdio.h and also agt_yuma_arp.h I couldn't find a package with this file on Debian.

In netconf/test/netconf: multiple_edit_callbacks fails to build, as <libxml/xmlstring.h> is missing. If the header is required, you'll need to re-add the pkg-config code and fix Makefile.am.

In netconf/python: This failed to build as the path to Python.h wasn't known at build-time. The path (at least on Debian) is a subdirectory of the standard search paths. I had to add: PKG_CHECK_MODULES([PYTHON3],[python3]) to configure.ac and add $(PYTHON3_CFLAGS) to Makefile.am.

Two files had a very minor whitespace issue, with <space># indenting before an #include directive: example-modules/chat/chat.c (procdefs.h) netconf/src/ncx/val.c (xml_util.h)

Created at 4 days ago
issue comment
Modernise configure.ac and allow cadaver to regenerate its build system from source

Great! Thanks so much!

Created at 1 week ago
issue comment
Using pkg-config to find libxml2

Fixed by #130, #131 and #132. Closing.

Created at 1 week ago
closed issue
Using pkg-config to find libxml2

Debian is taking steps to remove xml2-config in favour of pkg-config. This means yuma123 will fail to build from source.

Making the switch to pkg-config is simple, although there are some design decisions to be made.

  1. Replacing AM_PATH_XML2 with PKG_CHECK_MODULES([XML], [libxml-2.0]). This would need to done across all configure.ac files in your source, including those in the module examples. You could also retain support for XML2_CONFIG if desired.
  2. As PKG_CHECK_MODULES will automatically define (in this case) the variables XML_CFLAGS and XML_LIBS, it would be nice to use them directly. Your package uses XML_CPPFLAGS and XML_LIBS. While we can easily add AC_SUBST([XML_CPPFLAGS], [$XML_CFLAGS]) to each configure.ac file, I think it'd be simpler and more logical to update the various Makefile.am files to reference $XML_CFLAGS instead.

I'm happy to take care of these changes. Please let me know your preferences on the above points. Otherwise, let me know how you want to proceed.

Created at 1 week ago
pull request closed
yuma123: Use pkg-config to find libxml2

Fixes #129

Created at 1 week ago
issue comment
yuma123: Use pkg-config to find libxml2

Thanks for merging!

Created at 1 week ago
pull request closed
example-modules: Use pkg-config to find libxml2

As discussed in #129. Feel free to squash the commits.

Created at 1 week ago
issue comment
example-modules: Use pkg-config to find libxml2

Thanks for merging!

Created at 1 week ago
pull request closed
netconf: Use pkg-config to find libxml2

As discussed in #129.

Created at 1 week ago
issue comment
netconf: Use pkg-config to find libxml2

Thanks for merging!

Created at 1 week ago
issue comment
How to build with bundled neon?

If you're building from the latest git source, cadaver no longer supports building against the bundled neon code.

You'll need to build neon yourself, then use the relevant configure flags to pass the location of your debug-enabled neon library to configure. Run ./configure --help to find the correct options.

If you're using the latest git version, the build system is broken at the moment due to other issues.

Created at 1 week ago
issue comment
Modernise configure.ac and allow cadaver to regenerate its build system from source

@notroj, building cadaver from source is broken at the moment, as AM_GNU_GETTEXT_VERSION and various header and function checks are needed.

Would prefer me to revise this MR to include only essential patches?

Created at 1 week ago
delete branch
hughmcmaster delete branch spelling
Created at 1 week ago

intl: Fix spelling of "version" in help strings

Merge pull request #6 from hughmcmaster/spelling

intl: Fix spelling of "version" in help strings

Created at 1 week ago
pull request opened
netconf: Use pkg-config to find libxml2

As discussed in #129.

Created at 1 week ago
pull request opened
example-modules: Use pkg-config to find libxml2

As discussed in #129

Created at 1 week ago
pull request opened
yuma123: Use pkg-config to find libxml2

Fixes #129

Created at 1 week ago

yuma123: Use pkg-config to find libxml2

Signed-off-by: Hugh McMaster hugh.mcmaster@outlook.com

Created at 1 week ago

netconf/python: Use pkg-config to find libxml2

netconf/src/yangrpc: Use pkg-config to find libxml2 (libapache2-mod-yangrpc-example)

netconf/test: Use pkg-config to find libxml2 (netconfd)

netconf/test: Use pkg-config to find libxml2 (yangdump)

netconf/test: Use pkg-config to find libxml2 (yangrpc)

netconf/test: Use pkg-config to find libxml2 (yangcli)

Created at 1 week ago

configure.ac: Use pkg-config to find libxml2

Signed-off-by: Hugh McMaster hugh.mcmaster@outlook.com

Created at 1 week ago
create branch
hughmcmaster create branch example-modules
Created at 1 week ago
delete branch
hughmcmaster delete branch example-modules
Created at 1 week ago
create branch
hughmcmaster create branch netconf
Created at 1 week ago
create branch
hughmcmaster create branch example-modules
Created at 1 week ago
create branch
hughmcmaster create branch pkgconfig
Created at 1 week ago
issue comment
Using pkg-config to find libxml2

That will definitely work, although you can simplify the changes quite a bit.

By making the variable prefix XML, no changes are required for your existing $(LIB_XML) variable references. And AC_SUBST is called automatically by PKG_CHECK_MODULES.

You also don't need XML_CFLAGS, since it's not used in the source at all.

Of course, if you want to use LIBXML2 as the variable prefix, you can just drop the XML_CFLAGS lines. But I'd recommend quoting with square brackets to avoid any issues.

 diff --git a/configure.ac b/configure.ac
 index 36e75185..4485e494 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -12,6 +12,8 @@ AC_SEARCH_LIBS([dlopen], [dl dld], [], [
    AC_MSG_ERROR([unable to find the dlopen() function])
  ])
  
 +PKG_PROG_PKG_CONFIG
 +
  netconfmoduledir="$libdir/yuma"
  AC_SUBST(netconfmoduledir)
  
 @@ -84,7 +86,9 @@ AC_ARG_WITH(tecla,
  AM_CONDITIONAL([WITH_TECLA], [test "x$TECLA" = x1])
  AM_CONDITIONAL([STANDALONE], [test x$standalone = xtrue])
  
 -AM_PATH_XML2
 +PKG_CHECK_MODULES([XML], [libxml-2.0 >= 2.3.9])
 +XML_CPPFLAGS="$XML_CFLAGS"
 +AC_SUBST([XML_CPPFLAGS])
Created at 2 weeks ago
opened issue
Using pkg-config to find libxml2

Debian is taking steps to remove xml2-config in favour of pkg-config. This means yuma123 will fail to build from source.

Making the switch to pkg-config is simple, although there are some design decisions to be made.

  1. Replacing AM_PATH_XML2 with PKG_CHECK_MODULES([XML], [libxml-2.0]). This would need to done across all configure.ac files in your source, including those in the module examples. You could also retain support for XML2_CONFIG if desired.
  2. As PKG_CHECK_MODULES will automatically define (in this case) the variables XML_CFLAGS and XML_LIBS, it would be nice to use them directly. Your package uses XML_CPPFLAGS and XML_LIBS. While we can easily add AC_SUBST([XML_CPPFLAGS], [$XML_CFLAGS]) to each configure.ac file, I think it'd be simpler and more logical to update the various Makefile.am files to reference $XML_CFLAGS instead.

I'm happy to take care of these changes. Please let me know your preferences on the above points. Otherwise, let me know how you want to proceed.

Created at 2 weeks ago
Created at 2 weeks ago
issue comment
Excessive thickness (wide stroke) on shape outlines

Sadly, @Herschel's (merged) fix in #7042 had no effect in this case, but it is definitely a big step in the right direction.

Created at 3 weeks ago
opened issue
Updating `loudgain`: How can we help?

Given you don't have time to update and maintain loudgain, how can we help?

I’d be happy if someone really knowledgeable could help, ideally someone who could explain: a) how to set up a co-maintainership here b) would take care of some issues & PR’s

I'm sure there are many knowledgable and capable people who would be happy to co-maintain loudgain (me included). Permissions for write access are set through: Settings >> Collaborators >> Add people >> [Add username] Quick link: https://github.com/Moonbase59/loudgain/settings/access

c) make this an official Debian/Ubuntu/Mint package.

loudgain is already available in Debian 11 (Bullseye) and Ubuntu 22.04 (Jammy Jellyfish). Linux Mint users can install the package from the Ubuntu repository.

Created at 3 weeks ago