herndlm
Repos
59
Followers
12
Following
10

Events

Support list type

Add FQCN support to implementsInterface

Created at 5 hours ago
issue comment
Remove IssetCheck/MutatingScope::issetCheck deviations and remove too early exits

Fyi I have a rough planning about re-usage of this code already that I'll be working on in the evening :)

Created at 6 hours ago
Support list type

Second thought was doing it in the Sam test class but a dedicated bleedingEdge type file. I'll see what works best

Created at 6 hours ago
Support list type

I can split bleedingEdge tests into a dedicated test class if you prefer that

Created at 6 hours ago
pull request closed
Extract IssetHelper from MutatingScope

This would be the precondition to cleanup IssetCheck and to another PR I'm currently working on :)

Not sure about class and method names, any suggestions appreciated

Created at 18 hours ago
issue comment
Extract IssetHelper from MutatingScope

I guess the goal could be to use either MutatingScope::issetCheck or the IssetCheck class. No need for another way of doing this :) I'll try to figure it out

Created at 18 hours ago

Remove IssetCheck/MutatingScope::issetCheck deviations and remove too early exits

Created at 18 hours ago
pull request opened
Remove IssetCheck/MutatingScope::issetCheck deviations and remove too early exits

While trying to check the deviations I noticed the following things that I re-did in MutatingScope::issetCheck

  • the maybe block was removed in IssetCheck
  • Scope::isSpecified was added additionally to the yes block

Additionally, while trying to use MutatingScope::issetCheck in my https://github.com/phpstan/phpstan-src/pull/1781 I noticed that it returned true for an ArrayDimFetch ala $foo['x'][['y']['z'] that should count as being unset because it exited too early in the yes block while checking from right to left. I was not successful creating a test for it yet, but it started breaking an existing IssetRuleTest.

I hope this helps in removing duplications and I wanted to see if CI is also green..

Created at 18 hours ago
create branch
herndlm create branch reduce-isset-check-deviations-and-remove-too-early-exits
Created at 18 hours ago
issue comment
Extract IssetHelper from MutatingScope

also: I just realised now that IssetCheck is not a rule but already a helper class for a rule.. 😅

Created at 19 hours ago

Extract IssetHelper from MutatingScope

Created at 19 hours ago

Extract IssetHelper from MutatingScope

Created at 20 hours ago

Extract IssetHelper from MutatingScope

Created at 20 hours ago

Extract IssetHelper from MutatingScope

Created at 20 hours ago
pull request opened
Support list type

This is for after PHPStan 1.9.0 was released :)

Created at 20 hours ago
herndlm create branch support-list-type
Created at 20 hours ago
issue comment
Extract IssetHelper from MutatingScope

weird, I don't understand what's going on with the incompatible ScopeFactory::create error, I can't explain how the changes here would lead to that. Is this related to downgrading the code?

Created at 21 hours ago
Created at 21 hours ago

Revert "Extract IssetHelper from MutatingScope"

This reverts commit 8cb28619d2ba9dfe9c1c7548b28c82a6a2e94be3.

Created at 21 hours ago

Extract IssetHelper from MutatingScope

Created at 21 hours ago
herndlm delete branch support-key-not-exists
Created at 21 hours ago

Extract IssetHelper from MutatingScope

Created at 21 hours ago
pull request opened
Extract IssetHelper from MutatingScope

This would be the precondition to cleanup IssetCheck and to another PR I'm currently working on :)

Not sure about class and method names, any suggestions appreciated

Created at 21 hours ago
create branch
herndlm create branch extract-isset-helper
Created at 21 hours ago
herndlm delete branch support-is-instance-of-any
Created at 21 hours ago
herndlm delete branch support-is-a-of
Created at 21 hours ago
herndlm delete branch support-greater-less-and-range-assertions
Created at 21 hours ago
herndlm create branch empty
Created at 21 hours ago
issue comment
Implement array list type

Nice! I'll see what I can do to infer lists via the webmozart/assert extension soon :)

Created at 1 day ago