hakimel:Making Slides.com • kodemo.com • reveal.js • Creator of questionable value at https://hakim.se

@media print {
  html:not(.print-pdf) body {
      font-size: 20pt!important;
  }

  html:not(.print-pdf) h1 { 
    font-size: 28pt !important;
   }
}

So a normal page without reveal js like this:

Becomes like this just because reveal style is imported:

(I embed a reveal.js in page:)

My confusion is why is that file needed as users are already asked to print with ?print-pdf?

Also does anyone have the same confusion with me why reveal.js tries and why it should use high priority selectors and !important to force overriding default tag style?

Created at 6 days ago

issue comment

hakimel/reveal.js

[Bug] Importing reveal js called print style breaking

Thanks for pointing this out. Definitely not desirable that the print styles bleed into the rest of the page.

I've revised this now so that all print styles are scoped to .reveal. The only styles that are still set on the html level are required to ensure overflow is visible otherwise printing won't work.

Created at 6 days ago

push

hakimel/reveal.js

hakimel push hakimel/reveal.js

scope print styles to .reveal #3348

commit sha：447fefd31cbadf390c92d4fd9337202700d29d33

Created at 6 days ago

issue comment

hakimel/reveal.js

Missing lang attribute

Thanks!

Created at 1 week ago

push

hakimel/reveal.js

hakimel push hakimel/reveal.js

Missing lang attribute

The lang attribute does not default to English. It defaults to an unknown, which is an accessibility issue.

commit sha：b5fb6da46e7d9e9c627589bdd42d0a4da8c4081a

Merge pull request #3257 from sojinsamuel/patch-1

Missing lang attribute

commit sha：6510916b9f55a8f3110030bcdd1aee1b7fb77b6f

Created at 1 week ago

pull request closed

hakimel/reveal.js

Missing lang attribute

The lang attribute does not default to English. It defaults to an unknown, which is an accessibility issue.

Created at 1 week ago

issue comment

hakimel/reveal.js

GitHub Workflows security hardening

Makes sense. Thanks for the making reveal.js more secure!

Created at 1 week ago

push

hakimel/reveal.js

hakimel push hakimel/reveal.js

Update js.yml

Signed-off-by: sashashura 93376818+sashashura@users.noreply.github.com

commit sha：a09249998177ef1d468f4728358684e930fcaba1

Merge pull request #3268 from sashashura/patch-1

GitHub Workflows security hardening

commit sha：9c95411dfa1a9f939c7f22bb48d4c337068816d2

Created at 1 week ago

pull request closed

hakimel/reveal.js

GitHub Workflows security hardening

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Created at 1 week ago

closed issue

hakimel/reveal.js

Resolving gulp dependabot security errors

If you, like me, love reveal.js but are annoyed by dependabot security alerts and like to fix them, I have good-ish news on the vulns it is flagging in glob-parent as pulled in transitively through gulp's dependencies. First off, Gulpjs is not going to address this directly: https://github.com/gulpjs/gulp/issues/2640, but per this stackoverflow: https://stackoverflow.com/questions/68333071/how-to-solve-this-npm-glob-parent-problem , you can hardwire the resolution of glob to an updated version, which does not appear to have any problems (testing on serving static reveal presentations, no testing on reveal.js server functionality, so ymmv).

(not a bug, but I suppose with additional testing this could be baked in to reveal's package.json directly?)

Created at 1 week ago

issue comment

hakimel/reveal.js