hakimel
Repos
27
Followers
11833
Following
28

The HTML Presentation Framework

63004
15427

The official reveal.js website and documentation

67
54

Buttons with built-in loading indicators.

7885
862

A three dimensional and space effecient menu

2350
464

Assorted CSS and UI experiments.

4267
962

CSS3 list scroll effects

4349
730

Events

Fixes typos

Merge pull request #3356 from deining/fix/typos

Fixes typos

Created at 4 days ago
pull request closed
Fixes typos

This PR fixes a few typos I spotted.

Created at 4 days ago
issue comment
Fixes typos

oh my, funny how many typos sneak in over time 😅

Created at 4 days ago

Update README.md

Created at 4 days ago

Update README.md

Created at 4 days ago

instructions for adding new subjects

Created at 4 days ago

add AbstractSubject as example of how to create a subject

Created at 4 days ago

make it easier to add subjects

Created at 4 days ago

test code highlights

Created at 4 days ago

code/file tests

Created at 4 days ago

refactor subject exports

Created at 4 days ago

story style fix

Created at 5 days ago

Update README.md

Created at 5 days ago

Update README.md

Created at 5 days ago

0.3.2

Created at 6 days ago

0.3.2

Created at 6 days ago
closed issue
[Bug] Importing reveal js called print style breaking

This is caused by https://github.com/hakimel/reveal.js/blob/master/css/print/paper.scss

Even if I embed reveal.js in a page, it will override ALL THE BASIC ELEMENTS with !important, e.g.:

https://github.com/hakimel/reveal.js/blob/4fe3946cb43de57f79aaa7b646aee7e78f4bcc75/css/print/paper.scss#L8-L9

https://github.com/hakimel/reveal.js/blob/4fe3946cb43de57f79aaa7b646aee7e78f4bcc75/css/print/paper.scss#L39-L58

This means that output will have

@media print {
  html:not(.print-pdf) body {
      font-size: 20pt!important;
  }

  html:not(.print-pdf) h1 { 
    font-size: 28pt !important;
   }
}

So a normal page without reveal js like this:

Becomes like this just because reveal style is imported:

(I embed a reveal.js in page:)


My confusion is why is that file needed as users are already asked to print with ?print-pdf?

Also does anyone have the same confusion with me why reveal.js tries and why it should use high priority selectors and !important to force overriding default tag style?

Created at 6 days ago
issue comment
[Bug] Importing reveal js called print style breaking

Thanks for pointing this out. Definitely not desirable that the print styles bleed into the rest of the page.

I've revised this now so that all print styles are scoped to .reveal. The only styles that are still set on the html level are required to ensure overflow is visible otherwise printing won't work.

Created at 6 days ago

scope print styles to .reveal #3348

Created at 6 days ago
issue comment
Missing lang attribute

Thanks!

Created at 1 week ago

Missing lang attribute

The lang attribute does not default to English. It defaults to an unknown, which is an accessibility issue.

Merge pull request #3257 from sojinsamuel/patch-1

Missing lang attribute

Created at 1 week ago
pull request closed
Missing lang attribute

The lang attribute does not default to English. It defaults to an unknown, which is an accessibility issue.

Created at 1 week ago
issue comment
GitHub Workflows security hardening

Makes sense. Thanks for the making reveal.js more secure!

Created at 1 week ago

Update js.yml

Signed-off-by: sashashura 93376818+sashashura@users.noreply.github.com

Merge pull request #3268 from sashashura/patch-1

GitHub Workflows security hardening

Created at 1 week ago
pull request closed
GitHub Workflows security hardening

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Created at 1 week ago
closed issue
Resolving gulp dependabot security errors

If you, like me, love reveal.js but are annoyed by dependabot security alerts and like to fix them, I have good-ish news on the vulns it is flagging in glob-parent as pulled in transitively through gulp's dependencies. First off, Gulpjs is not going to address this directly: https://github.com/gulpjs/gulp/issues/2640, but per this stackoverflow: https://stackoverflow.com/questions/68333071/how-to-solve-this-npm-glob-parent-problem , you can hardwire the resolution of glob to an updated version, which does not appear to have any problems (testing on serving static reveal presentations, no testing on reveal.js server functionality, so ymmv).

(not a bug, but I suppose with additional testing this could be baked in to reveal's package.json directly?)

Created at 1 week ago
issue comment
Resolving gulp dependabot security errors

Thanks for the info @joncamfield—I've added an override for glob-parent that fixes the security alerts

Created at 1 week ago

fix security alerts by upgrading glob-parent #3343

Created at 1 week ago

jump to slide tweak

Created at 1 week ago

fix conflict between prism/hljs

Created at 1 week ago