guillaume-ro-fr
Repos
21
Followers
13
Following
12

Events

Created at 1 week ago
started
Created at 3 weeks ago
started
Created at 3 weeks ago
Created at 3 weeks ago
guillaume-ro-fr create tag v14.0.1
Created at 3 weeks ago
pull request closed
Update dependency to angular 14

Description

Updating dependency to support Angular 14 and bumped a minor version.

Your checklist for this pull request

  • [x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • [x] Make sure you are making a pull request against the canary branch (left side). Also you should start your branch off our canary.
  • [x] Check the commit's or even all commits' message styles matches our requested structure.
  • [x] Check your code additions will fail neither code linting checks nor unit test.
Created at 3 weeks ago
Update dependency to angular 14

Thanks for the PR @felipeclopes! v14.0.1 published

Created at 3 weeks ago
Angular v14 support

Sorry for the late! v14.0.1 published

Created at 3 weeks ago
Angular v14 support

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

OS and Version?

Generator Version

Tools Version

Targeted Angular version

v14.0.1

Repro steps.

Create a simple Angular 14.0.1 repo and try to install the ngx segment analytics library

The log given by the failure.

$ npm install --save ngx-segment-analytics 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: xxxxxxx@0.0.0
npm ERR! Found: @angular/common@14.0.1
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"14.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@">=12.0.0 <14.0.0" from ngx-segment-analytics@2.0.0
npm ERR! node_modules/ngx-segment-analytics
npm ERR!   ngx-segment-analytics@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Desired functionality.

Full Support of Angular 14

Mention any other details that might be useful.

Created at 3 weeks ago

Upgrade to Angular 14 and latest analytics-next

Fixes #147

Update documentation

Remove Greenkeeper badge

Update dependencies

Update documentation

Bump version

Created at 3 weeks ago
pull request closed
chore(deps): bump minimist from 1.2.5 to 1.2.6

Bumps minimist from 1.2.5 to 1.2.6.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Created at 3 weeks ago
Created at 1 month ago
Created at 1 month ago
(x|y)Adjust scriptable context not working properly (cached and overrided)

Hello 👋

I'm using the yAdjust property on label annotation for a box. The box is larger than the complete chart, which adjusts to the Y axis. Until the previous version of this plugin, I used yAdjust to correct the centering of the title (which when the "center" option is used, is centered with respect to the whole box and not the chart).

For that, I used this code:

yAdjust: (ctx: PartialEventContext) => (ctx.chart.chartArea.height - ctx.element.y) / 2,

With the double execution, I can just return 0 (or any value) when ctx.element.y is not ready, and return the correct value on the second execution:

if (typeof ctx.element.label?.y === 'undefined') {
    return 0; // Any value
}
return (ctx.chart.chartArea.height - ctx.element.label.y) / 2;

But now, this code doesn't work anymore, (I think) because of the merge request #725: yAdjust is evaluated twice but cached by the Proxy object:

  • updateElements -> resolveElementProperties -> resolveLabelElementProperties -> calculateY
  • updateElements -> updateSubElements -> resolveAnnotationOptions -> resolveObj

The problem is at line 64: resolver.label object contains the cached value of yAdjust (first call) and resolveAnnotationOptions method override element.elements[0].options.yAdjust (correct value with second call) with resolver.label.yAdjust value.

https://github.com/chartjs/chartjs-plugin-annotation/blob/5d9042ce25cae24f5e095b4996d1ca4c0259fd77/src/elements.js#L45-L64

Here is an example of my code (the red zone is the one with title uncentered):

https://codepen.io/guillaume-ro-fr/full/jOzXpMz

Don't hesitate to tell me if you need more information (I tried to return a Proxy instead of a raw number, but I failed...). Maybe related to #726

Created at 1 month ago
(x|y)Adjust scriptable context not working properly (cached and overrided)

When you are mentioning double execution, are you meaning after a chart update?

In the same update event. I don't know if it is relevant to send you the backtrace (with Webstorm, and I don't know if it is possible 🤷‍♂️).

But THANK YOU very much for your solution, it works perfectly!!! 🎉 It's been 3 hours that I try to find a solution through different means...

Created at 1 month ago
Created at 1 month ago
(x|y)Adjust scriptable context not working properly (cached and overrided)

Hello 👋

I'm using the yAdjust property on label annotation for a box. The box is larger than the complete chart, which adjusts to the Y axis. Until the previous version of this plugin, I used yAdjust to correct the centering of the title (which when the "center" option is used, is centered with respect to the whole box and not the chart).

For that, I used this code:

yAdjust: (ctx: PartialEventContext) => (ctx.chart.chartArea.height - ctx.element.y) / 2,

With the double execution, I can just return 0 (or any value) when ctx.element.y is not ready, and return the correct value on the second execution:

if (typeof ctx.element.label?.y === 'undefined') {
    return 0; // Any value
}
return (ctx.chart.chartArea.height - ctx.element.label.y) / 2;

But now, this code doesn't work anymore, (I think) because of the merge request #725: yAdjust is evaluated twice but cached by the Proxy object:

  • updateElements -> resolveElementProperties -> resolveLabelElementProperties -> calculateY
  • updateElements -> updateSubElements -> resolveAnnotationOptions -> resolveObj

The problem is at line 64: resolver.label object contains the cached value of yAdjust (first call) and resolveAnnotationOptions method override element.elements[0].options.yAdjust (correct value with second call) with resolver.label.yAdjust value.

https://github.com/chartjs/chartjs-plugin-annotation/blob/5d9042ce25cae24f5e095b4996d1ca4c0259fd77/src/elements.js#L45-L64

Here is an example of my code (the red zone is the one with title uncentered):

https://codepen.io/guillaume-ro-fr/full/jOzXpMz

Don't hesitate to tell me if you need more information (I tried to return a Proxy instead of a raw number, but I failed...).

Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
started
Created at 2 months ago
guillaume-ro-fr delete branch 1.0
Created at 2 months ago
started
Created at 2 months ago
started
Created at 2 months ago
pull request opened
Fix AuthRegistryInterface return type

Like #15, but for 1.0 branch.

The Nbgrp\OneloginSamlBundle\Onelogin\AuthRegistryInterface::addService method returns AuthRegistry instead of AuthRegistryInterface: we cannot implement AuthRegistryInterface without Auth class.

Created at 2 months ago
pull request closed
Fix AuthRegistryInterface return type

The Nbgrp\OneloginSamlBundle\Onelogin\AuthRegistryInterface::addService method returns AuthRegistry instead of AuthRegistryInterface: we cannot implement AuthRegistryInterface without Auth class.

Created at 2 months ago

Fix AuthRegistryInterface return type

Created at 2 months ago
Created at 2 months ago