grobie
Repos
65
Followers
254
Following
50

The Prometheus monitoring system and time series database.

45634
7376

Analyzes resource usage and performance characteristics of running containers.

14155
2021

A terminal client for https://soundcloud.com

1384
75

Simple server that scrapes HAProxy stats and exports them via HTTP for Prometheus consumption

581
202

Prometheus instrumentation library for Ruby applications

449
132

Production-Grade Container Scheduling and Management

94047
32965

Events

opened issue
Release new version

Thanks for providing this gem, your support for open source software, and for merging #15! :heart:

Please release a new gem version so that we can use the official gem again. Thank you!

Created at 3 weeks ago
issue comment
Output rspec seed if used

Thanks @StefSchenkelaars, I made the requested change. It would be very helpful if you could release a new version afterwards, so that we can remove the git dependency to install from my branch. Cheers!

Created at 3 weeks ago

Output rspec seed if used

Rspec supports running the specs in a random order. This helps in surfacing any accidental dependencies and side effects in the test suite. When debugging test failures caused by such side effects, it's often necessary to reproduce the issue by running the specs in the same order again. For that the seed value needs to be known and logged by the formatter.

Created at 3 weeks ago

Output rspec seed if used

Rspec supports running the specs in a random order. This helps in surfacing any accidental dependencies and side effects in the test suite. When debugging test failures caused by such side effects, it's often necessary to reproduce the issue by running the specs in the same order again. For that the seed value needs to be known and logged by the formatter.

Created at 3 weeks ago
issue comment
Output rspec seed if used

@StefSchenkelaars Apologies for the late response. How important is it to you to split this out?

The seed in the output has helped us multiple times already to re-run flaky tests in the same order. I expect every rspec user who enables random spec runs to have the same need, so splitting this into multiple formatters seems unnecessarily complex.

My order of preference would be: 1) you merge this :smile: 2) I change it as requested 3) We leave the PR unmerged

Created at 3 weeks ago
Created at 1 month ago
issue comment
Data race in TestLoginStatusFailsWhenLinksEmpty

@etsai-stripe I guess I created some confusion by naming the package manager surfacing the bug first. The issue exists in the Stripe CLI source code itself. All the AUR package does is downloading the source code and running the test code with the native go toolchain.

Created at 1 month ago
issue comment
Include request method in response

Thanks @geemus! If it's more than adding the necessary method getter/setter/hash key in the response.rb file I think it makes sense if you tackle it yourself. Unfortunately I don't have time to dive deep into the code base myself. Especially the part about backwards compatibility sounds like it's not quite that trivial?

Created at 1 month ago
started
Created at 1 month ago
opened issue
Include request method in response

When using instrumenters to set up logging or tracing the excon.response notification is particular helpful as it includes the response status and request latency. The notification data already includes information about request host, port, and path among others, but notably the request method is missing.

Especially in RESTful API design it's common that different operations share the same request path. The absence of the method attribute makes it difficult to disambiguate response notifications.

Related discussion https://github.com/excon/excon/issues/757.

Created at 1 month ago
opened issue
Data race in TestLoginStatusFailsWhenLinksEmpty

Issue

Trying to install AUR package stripe-cli 1.12.3 (already reported the AUR package as out-of-date, but there doesn't seem to be any related commit in 1.12.4) fails due to a data race detected while running the test suite.

Expected Behavior

Running tests with race detector enabled succeeds without issues.

Steps to reproduce

go test -failfast -race -coverpkg=./... -covermode=atomic -coverprofile=coverage.txt ./... -run . -timeout=2m

Traceback

==================                                      
WARNING: DATA RACE                                                                                                     
Write at 0x00c000102950 by goroutine 240:
  github.com/spf13/viper.(*Viper).ReadInConfig()    
      /home/grobie/code/pkg/mod/github.com/spf13/viper@v1.12.0/viper.go:1544 +0x3f3
  github.com/spf13/viper.ReadInConfig()
      /home/grobie/code/pkg/mod/github.com/spf13/viper@v1.12.0/viper.go:1518 +0x9c
  github.com/stripe/stripe-cli/pkg/config.(*Profile).GetAccountID()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/config/profile.go:97 +0x72         
  github.com/stripe/stripe-cli/pkg/rpcservice.updateContextWithTelemetry()                    
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/rpcservice/middleware.go:62 +0xfb
  github.com/stripe/stripe-cli/pkg/rpcservice.newWrappedStream()                              
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/rpcservice/middleware.go:33 +0x6f  
  github.com/stripe/stripe-cli/pkg/rpcservice.serverStreamInterceptor()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/rpcservice/middleware.go:100 +0x224
  google.golang.org/grpc.(*Server).processStreamingRPC()                                                               
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:1565 +0x1bb5                 
  google.golang.org/grpc.(*Server).handleStream()                                                                      
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:1640 +0xfae                  
  google.golang.org/grpc.(*Server).serveStreams.func1.2()                                                              
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:932 +0xec
                                                           
Previous write at 0x00c000102950 by goroutine 241:
  github.com/spf13/viper.(*Viper).ReadInConfig()
      /home/grobie/code/pkg/mod/github.com/spf13/viper@v1.12.0/viper.go:1544 +0x3f3
  github.com/spf13/viper.ReadInConfig()
      /home/grobie/code/pkg/mod/github.com/spf13/viper@v1.12.0/viper.go:1518 +0x9c
  github.com/stripe/stripe-cli/pkg/config.(*Profile).GetAccountID()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/config/profile.go:97 +0x72
  github.com/stripe/stripe-cli/pkg/rpcservice.updateContextWithTelemetry()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/rpcservice/middleware.go:62 +0xfb
  github.com/stripe/stripe-cli/pkg/rpcservice.serverUnaryInterceptor()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/pkg/rpcservice/middleware.go:118 +0x272
  github.com/stripe/stripe-cli/rpc._StripeCLI_LoginStatus_Handler()
      /home/grobie/.cache/yay/stripe-cli/src/stripe-cli-1.12.3/rpc/commands_grpc.pb.go:421 +0x22d
  google.golang.org/grpc.(*Server).processUnaryRPC()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:1295 +0x11c9
  google.golang.org/grpc.(*Server).handleStream()                                                                      
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:1636 +0xff8                                                                                                                                                            google.golang.org/grpc.(*Server).serveStreams.func1.2()                                                                                                                                                                                           /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:932 +0xec                                     
                                                           
Goroutine 240 (running) created at:
  google.golang.org/grpc.(*Server).serveStreams.func1()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:930 +0x4dd
  google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/internal/transport/http2_server.go:603 +0x3329
  google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/internal/transport/http2_server.go:648 +0x378
  google.golang.org/grpc.(*Server).serveStreams()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:916 +0x275
  google.golang.org/grpc.(*Server).handleRawConn.func1()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:858 +0x64

Goroutine 241 (finished) created at:
  google.golang.org/grpc.(*Server).serveStreams.func1()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:930 +0x4dd
  google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/internal/transport/http2_server.go:603 +0x3329
  google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/internal/transport/http2_server.go:648 +0x378
  google.golang.org/grpc.(*Server).serveStreams()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:916 +0x275
  google.golang.org/grpc.(*Server).handleRawConn.func1()
      /home/grobie/code/pkg/mod/google.golang.org/grpc@v1.48.0/server.go:858 +0x64
==================
--- FAIL: TestLoginStatusFailsWhenLinksEmpty (0.02s)
    testing.go:1319: race detected during execution of test
FAIL
coverage: 24.5% of statements in ./...
FAIL    github.com/stripe/stripe-cli/pkg/rpcservice     0.534s

Environment

go version go1.19.2 linux/amd64

Created at 1 month ago
Support multi-target

Apologies for the radio silence @mateusduboli.

@SuperQ @roidelapluie So I see that the project's stance on multi-targets has changed? I found @SuperQ's comment from February suggesting exactly this change https://github.com/prometheus/memcached_exporter/issues/111#issuecomment-1026606633.

The change looks good to me in general. I believe users should explicitly opt-in into the new behavior though by setting a flag. It might be unexpected and even harmful for users upgrading to the newest version if the exporter can be suddenly used to make requests against arbitrary endpoints.

Created at 1 month ago
opened issue
Support GitHub annotation formatter

User story. As a developer, I can configure the formatter to use the GitHub annotation format, so that I can see warnings directly in my pull request when running spectral as Github action.

Is your feature request related to a problem? Developers are often missing new Spectral warnings as they rarely manually check the logs of the Github action run manually.

Describe the solution you'd like I'd expect to be able to use --format github-annotation or similar as CLI parameter.

Additional context Github annotations support both warnings and errors, as seen in this example: [annotation example]

Created at 2 months ago
issue comment
Rails 7.0.3 vs Rails 6.1.4.4 regression when using shards in production

Thanks for the detailed explanation @eileencodes!

We're also using different shards and want to avoid a default shard at all costs (to ensure any code querying the database selects the correct shard explicitly). This has worked fine so far, but doesn't work anymore when trying to define a custom type for an attribute, as that code will call Type.adapter_name_from which currently depends on the retrieving a connection pool based on the default_shard: https://github.com/rails/rails/blob/3872bc0e54d32e8bf3a6299b0bfe173d94b072fc/activerecord/lib/active_record/attributes.rb#L216

Though in most applications I expect all shards to use the same adapter, so we could just fallback here to static database configurations in order to retrieve the adapter name, removing the need to define a default shard:

diff --git a/activerecord/lib/active_record/type.rb b/activerecord/lib/active_record/type.rb
index dadc02095e..6da45368b8 100644
--- a/activerecord/lib/active_record/type.rb
+++ b/activerecord/lib/active_record/type.rb
@@ -48,6 +48,9 @@ def default_value # :nodoc:
 
       def adapter_name_from(model) # :nodoc:
         model.connection_db_config.adapter.to_sym
+      rescue ConnectionNotEstablished
+        adapters = model.configurations.configurations.map(&:adapter)
+        adapters.uniq.size == 1 ? adapters.first.to_sym : raise
       end
 
       private

Would you accept a pull request to add this fallback to Type.adapter_name_from in order to make it independent of the presence of the default_shard?

Created at 2 months ago
closed issue
Request to transfer the gigs username

Dear "Gigs",

I'm Tobias, the Head of Engineering at a company called Gigs. We'd love to contribute to the open-source community on GitHub and publish our repositories preferably under https://github.com/gigs. As your user account appears to be unused, we were wondering if you could release the gigs handle for us?

You can reach me at tobias@gigs.tel to discuss the details and how to compensate you :smiley:

Best, Tobias

Created at 2 months ago

Bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0 (#140)

Bumps github.com/prometheus/client_golang from 1.12.2 to 1.13.0.


updated-dependencies:

  • dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 2 months ago
grobie delete branch dependabot/go_modules/github.com/prometheus/client_golang-1.13.0
Created at 2 months ago
pull request closed
Bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0

Bumps github.com/prometheus/client_golang from 1.12.2 to 1.13.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 2 months ago