gribnoysup
Repos
54
Followers
79
Following
36

Events

chore(compass-aggregations): move root reducer handlers logic to relevant slices (#3552)

Created at 3 hours ago
delete branch
gribnoysup delete branch agg-builder-clean-up-root-reducers-part-1
Created at 3 hours ago
pull request closed
chore(compass-aggregations): move root reducer handlers logic to relevant slices

Another round of state clean-up for agg builder. This time I'm moving more of the root reducer logic to the relevant slices, this means that when we will need to make any changes further down the road we will have better visibility on which store slices depend on which actions instead of having reducer logic basically split between root store and slices.

As a drive-by I removed a few store slices that are not used anywhere in the app anymore

Created at 3 hours ago
pull request opened
chore(compass-aggregations): move root reducer handlers logic to relevant slices

Another round of state clean-up for agg builder. This time I'm moving more of the root reducer logic to the relevant slices, this means that when we will need to make any changes further down the road we will have better visibility on which store slices depend on which actions instead of having reducer logic basically split between root store and slices.

As a drive-by I removed a few store slices that are not used anywhere in the app anymore

Created at 18 hours ago

chore(compass-aggregations): move root reducer handlers logic to relevant slices

Created at 18 hours ago

chore(compass-aggregations): move root reducer handlers logic to relevant slices

Created at 18 hours ago
create branch
gribnoysup create branch agg-builder-clean-up-root-reducers-part-1
Created at 18 hours ago

chore(compass-aggregations): clean up create store for aggregation builder (#3549)

Created at 21 hours ago
delete branch
gribnoysup delete branch clean-up-agg-create-store
Created at 21 hours ago
pull request closed
chore(compass-aggregations): clean up create store for aggregation builder

This path change agg builder initial state setup flow from using multiple actions to set up initial state to just passing initial state directly to the root reducer on the store creation. I'm doing this change right now in the anticipation of the following changes we would need to do for the upcoming text editor project: we will be introducing a bunch of changes to the store, so simplifying the store (i.e. not using actions where they are not needed at all for state that can't change while the store exists) will help us to do some further refactoring we are planning

Created at 21 hours ago

tmp: replace current state slice with the one using builder

Created at 22 hours ago