Done, I think.

I have a config file with Psalm and PHPStan enabled globally: https://github.com/greg0ire/dotfiles/blob/main/.config/phpactor/phpactor.yml#L13-L14

When I open nvim, PHPActor suggests I enable both extensions. It should IMO do nothing if the extensions are already enabled globally.

Move validation logic to dtos

Extract array access implementation into a trait

As soon as the phar is available, the building and test do happen, but as a PHPUnit test, not as a separate github action: https://github.com/doctrine/migrations/blob/3.6.x/tests/Doctrine/Migrations/Tests/BoxPharCompileTest.php#L18-L70

No no, you're right, I think it's just we didn't think of that! @asuri0n , can you please edit the body of the pull request, as suggested?

Fix test file/class names (#9649)

Revert "Use charset/collation from column or table default when creating relations (#9636)"

This reverts commit 03f4468be22ab66ed0e4328a7a89549d6237bebf. The inferring process seems fragile and MySQL-specific. The ORM might not be the correct place to fix this issue (if it needs to be fixed at all).

Merge pull request #9654 from greg0ire/revert-9636

Revert "Use charset/collation from column or table default when creatng relations (#9636)"

Fix tests for enum ID hydration (#9658)

Indicate support for doctrine/persistence 3 (#9656)

Merge branch '2.12.x' into 3.0.x

• 2.12.x: Indicate support for doctrine/persistence 3 (#9656) Fix tests for enum ID hydration (#9658) Revert "Use charset/collation from column or table default when creating relations (#9636)" Fix test file/class names (#9649)

Fix enum hydration when fetching partial results (#9657)

ScalarColumnHydrator: prevent early-bail on falsy values (#9663)

• add failing test for issue #9230

• ScalarColumnHydrator: prevent early-bail on falsy values, fix #9230

Co-authored-by: Mickael GOETZ contact@mickael-goetz.com

Merge branch '2.11.x' into 2.12.x

• 2.11.x: ScalarColumnHydrator: prevent early-bail on falsy values (#9663)

Deprecate the doctrine binary (#9661)

Merge branch '2.12.x' into 3.0.x

• 2.12.x: Deprecate the doctrine binary (#9661) ScalarColumnHydrator: prevent early-bail on falsy values (#9663) Fix enum hydration when fetching partial results (#9657)

Conditionally extend the old AnnotationDriver class (#9671)

Drop support for persistence 2 (#9665)

• Drop support for persistence 2

• Switch to the common static analysis job

Merge branch '2.13.x' into 3.0.x

• 2.13.x: Conditionally extend the old AnnotationDriver class (#9671)

Remove the doctrine binary (#9662)

Fix type on ClassMetadata discriminatorMap (#9675)

Fix HydrationException::invalidDiscriminatorValue parameter type (#9676)

Document ORM drivers only really load ORM metadata

Merge pull request #9677 from greg0ire/assert-drivers-are-orm-specific

Document ORM drivers only really load ORM metadata

Validate XML mapping against XSD file

Co-Authored-By: Axel Venet avenet@wamiz.com Co-authored-by: Luís Cobucci lcobucci@gmail.com

I'd say that's because the ORM has a base ORMException class that needs to be extended by every exception in doctrine/orm

Reopening: there is still no bug caused by this, but it looks weird to people (see #10591)

This means that a class implementing a doctrine/persistence interface or extending a class from that package can throw a specialized exception that will still be caught by code in the parent package. Blocks #6728

The deprecation happened 7 years ago: https://github.com/doctrine/doctrine2/pull/249

Here is how I proceeded:

1. I moved all the code back from ClassMetadataInfo to ClassMetadata
2. I aliased ClassMetadataInfo to ClassMetadata.
3. I kept a ClassMetadataInfo class definition in an if (\false) statement to provide IDE autocompletion.

@asuri0n there are 9 commits now. Have you tried what I recommended above?

Then you might want to debug starting here: https://github.com/doctrine/orm/blob/da9b9de5906802cab1c71f59ffd9fba53ed4011d/lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php#L30-L42

When you use getDQL instead of getSQL() do you see that there is also an issue with the DQL? Trying to understand if this is an issue when parsing, or when transforming the DQL into SQL.

@theofidry if this looks OK to you, please, mark it as ready for review and I'll merge :)

@theofidry I pushed a new commit so that the relevant jobs are triggered :slightly_smiling_face:

Trigger the build on download script change

Cc @mpdude, regarding https://github.com/doctrine/doctrine-website/pull/473#discussion_r1129076152 :)

I will make a new merge request with clean commit message.

You don't need to, you can just force push once the history is good.

Thanks @e2palmes !

Added missing ';'

missing ';' on Obtaining the EntityManager section, bootstrap code line 32

Merge pull request #10589 from e2palmes/patch-1

missing ';' on Obtaining the EntityManager section, bootstrap code line 32