greg0ire
Repos
310
Followers
179
Following
40

Events

opened issue
templated types considered always different

I don't understand why Psalm thinks the type of $element cannot possibly be the same as the templated type in the wrapped collection in this code snippet. IMO it is a bug.

https://psalm.dev/r/9c680774e8

Created at 58 minutes ago

Try out collections 2

Created at 1 hour ago

Try out collections 2

Created at 10 hours ago

Try out collections 2

Created at 10 hours ago
create branch
greg0ire create branch evaluate-collections-2
Created at 10 hours ago
pull request opened
Try out collections 2
Created at 10 hours ago

Enable Psalm and Phpstan LSP extensions

Migrate to neovim

Migrate to a supported fork

Created at 11 hours ago
issue comment
Widen LazyCriteriaCollection::contains() param type

Will make sense with doctrine/collections 2

Created at 1 day ago
pull request closed
Widen LazyCriteriaCollection::contains() param type

That method is supposed to be able to deal with any mixed.

Created at 1 day ago

Widen LazyCriteriaCollection::contains() param type

That method is supposed to be able to deal with any mixed.

Created at 1 day ago
pull request opened
Widen LazyCriteriaCollection::contains() param type

That method is supposed to be able to deal with any mixed.

Created at 1 day ago
create branch
greg0ire create branch widen-contains-arg
Created at 1 day ago

Try out collections 2

Created at 1 day ago

Try out collections 2

Created at 1 day ago
delete branch
greg0ire delete branch revert-return-type-additions
Created at 1 day ago

Postpone return type additions

They prevent writing compatibility layers that would work with version 1 and 2 easily.

Merge pull request #331 from greg0ire/revert-return-type-additions

Postpone return type additions to 3.0

Created at 1 day ago
pull request closed
Postpone return type additions to 3.0

They prevent writing compatibility layers that would work with version 1 and 2 easily.

Prompted by https://github.com/doctrine/orm/pull/10070

It might be interesting to review the new diff with the stable branch: https://github.com/doctrine/collections/compare/1.7.x...greg0ire:collections:revert-return-type-additions

Created at 1 day ago
issue comment
Postpone return type additions to 3.0

If you feel some types should be made final or internal instead, please let me know.

Created at 1 day ago

Postpone return type additions

They prevent writing compatibility layers that would work with version 1 and 2 easily.

Created at 1 day ago

Postpone return type additions

They prevent writing compatibility layers that would work with version 1 and 2 easily.

Created at 1 day ago

Remove parameter type hint from before column

Add missing parameter type hints

It is unclear to me why this was not spotted by our coding standard.

Merge pull request #332 from greg0ire/add-missing-param-type-declarations

Add missing param type declarations

Postpone return type additions

They prevent writing compatibility layers that would work with version 1 and 2 easily.

Created at 1 day ago
delete branch
greg0ire delete branch add-missing-param-type-declarations
Created at 1 day ago

Remove parameter type hint from before column

Add missing parameter type hints

It is unclear to me why this was not spotted by our coding standard.

Merge pull request #332 from greg0ire/add-missing-param-type-declarations

Add missing param type declarations

Created at 1 day ago
pull request closed
Add missing param type declarations

It is unclear to me why this was not spotted by our coding standard.

Created at 1 day ago

Migrate QueryBuilder to PHP 8.1

Migrate ClassMetadataInfo to PHP 8.1

Merge pull request #10048 from greg0ire/php8-migration

Migrate QueryBuilder / ClassMetadataInfo

Created at 1 day ago
delete branch
greg0ire delete branch php8-migration
Created at 1 day ago
pull request closed
Migrate QueryBuilder / ClassMetadataInfo
Created at 1 day ago

Add missing parameter type hints

It is unclear to me why this was not spotted by our coding standard.

Created at 1 day ago