gotjosh
Repos
99
Followers
94
Following
177

My dotfiles

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.

52760
9848

The Prometheus monitoring system and time series database.

45722
7394

Prometheus Alertmanager

5343
1812

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

4920
682

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.

2651
209

Events

started
Created at 1 week ago
delete branch
gotjosh delete branch grafana-alertmanager-not-depend-on-grafana
Created at 1 week ago

Refactor GrafanaAlertmanager to not depend on Grafana (#19)

  • Refactor GrafanaAlertmanager to not depend on Grafana
Created at 1 week ago
pull request closed
Refactor GrafanaAlertmanager to not depend on Grafana

This is the first substantial PR at decoupling the Alertmanager logic from the Grafana-specific logic - you can reference that by the removal of the Grafana-based imports from the code and the scope of an interface for that specific logic.

There's a LOT more work TODO (hence the number of comments in the code), but these should be followed up immediately and are very obvious that things don't work. For the ones that we think would be more long term and I'm happy to create an issue to track them.

Created at 1 week ago
delete branch
gotjosh delete branch backport-58480-to-v9.2.x
Created at 2 weeks ago
pull request closed
[v9.2.x] Alerting: Implement the Webex notifier

Backport d748979048d16ff9cb4a3c116f9f3b2b61ca002e from #58480

Created at 2 weeks ago
issue comment
[v9.2.x] Alerting: Implement the Webex notifier

Closing, we don't need this in 9.2.x

Created at 2 weeks ago

Fix: Email and username trimming and invitation validation (#58442)

  • fix: email and username trimming and invitation validation

  • Trim leading and trailing whitespaces from email and username on signup

  • Check whether the provided email address is the same as where the invitation sent

  • Align tests

Co-authored-by: Mihaly Gyongyosi mgyongyosi@users.noreply.github.com

WIP: Remove Alertmanager depedency from Grafana

Remove local replace go.mod directive

more go.mod

more go.mod

Created at 2 weeks ago

more go.mod

Created at 2 weeks ago

more changes

Created at 2 weeks ago

more go.mod

Created at 2 weeks ago

Update emotion monorepo (#58066)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Accessibility: Enable rule jsx-a11y/no-noninteractive-element-interactions (#58077)

  • fixes for no-noninteractive-element-interactions

  • remaining fixes

  • add type="button"

  • fix unit tests

Update dependency @rollup/plugin-commonjs to v23 (#58075)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update typescript-eslint monorepo to v5.42.0 (#58073)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Tempo: Make usage of time range for TraceID query optional (#58057)

  • Added switch to toggle the TraceID query time shift

  • Fix and improve tests

Rendering: Add configuration options for renderKey lifetime (#57339)

  • Add configuration options for renderKey lifetime

  • Rename config key to render_key_lifetime

  • Update conf/defaults.ini

Co-authored-by: Joan López de la Franca Beltran 5459617+joanlopez@users.noreply.github.com

  • Add render_key_lifetime to sample.ini

Co-authored-by: Joan López de la Franca Beltran 5459617+joanlopez@users.noreply.github.com

Flame Graph: Add units and value to blocks (#57959)

  • Added unit to block label

  • Tests

  • Throw if value field is undefined

Update dependency @rollup/plugin-json to v5 (#58083)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency eslint-plugin-jsdoc to v39.6.2 (#58126)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency react-select to v5.6.0 (#58127)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency @rollup/plugin-node-resolve to v15 (#58130)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Alerting: Improving group modal with validation on evaluation interval (#57830)

  • Show rules list for the group with the For duration, and add validation for keeping all rules in the same group with a valid For

  • Sort rules by For duration

  • Add number evaluations column in alert list

  • Add Error badge in column #evaluations in case of invalid For

  • Add test for getNumberEvaluationsToStartAlerting method

  • Move re-usable new InfoIcon component into a separate file in unified components folder

  • Add edge case for getNumberEvaluationsToStartAlerting method, and change some namings

Graphite: Allow metric name to use true/false as name (#57996)

Chore: Add NewAnonymousSignedInUser to user service (#57537)

Public Dashboards: Renaming PubdashFooter (#58137)

Update dependency @types/ol-ext to v3 (#58140)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Nested Folders: Add tests for store methods (#57662)

  • Nested Folders: Add store tests

  • Fix parent order

  • Fix update

  • skip tests!

  • Export test helpers for now

reduce the number of requests in folder section (#55876)

TimeSeries: more thorough detection of negative values for stacking dir (#57863)

Update dependency eslint-plugin-jest to v27 (#58143)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Created at 2 weeks ago

Remove local replace go.mod directive

Created at 2 weeks ago

Change duplicated tags

Signed-off-by: gotjosh josue.abreu@gmail.com

Created at 2 weeks ago

Alerting: Implement the Webex notifier (#58480)

  • Alerting: Implement the Webex notifier

Closes https://github.com/grafana/grafana/issues/11750

Signed-off-by: gotjosh josue.abreu@gmail.com

Created at 2 weeks ago
delete branch
gotjosh delete branch webex-notifier
Created at 2 weeks ago
closed issue
Add notifier for Webex Teams

This issue is to track support of notifications for Cisco Webex Teams rooms (recently re-branded from Cisco Spark).

I sent a working PR for that in https://github.com/grafana/grafana/pull/11702, but Grafana currently does not accept new notifiers. This needs to be revisited once backend plugins are available.

Created at 2 weeks ago
pull request closed
Alerting: Implement the Webex notifier

Closes https://github.com/grafana/grafana/issues/11750

Sadly, I tried to go the unification route where I wanted to use the upstream notifier as part of the messaging, but the images in notification made this impossible to work around.

That said, I do have a clear idea now of what we need to modify upstream to make this reality - for now, I'd like to ship this as is and use this exact notifier as the first guinea pig for the unification.

Screenshot 2022-11-08 at 20 08 06

TODO

  • [x] Tests
  • [x] Documentation
  • [x] Alignment of settings with Prometheus Alertmanager
Created at 2 weeks ago

fix tests

Created at 2 weeks ago

Clean it up

Created at 2 weeks ago