goldbergyoni
Repos
25
Followers
3155
Following
11

Events

opened issue
Making the code generator based regex/comments

Context - We tried a code generator that is based on templating engine, but then the repo code is not executable (due to the mustache characters) and it becomes much harder to modify code, test it and sync with the repo

What type of functionality should the generator hold -

  1. Remove sections from files like "best practice" comments
  2. Avoid including specific file/folder like when user asks to avoid having github workflow file
  3. Switch between two different folders like when the user opts for Fastify over Express

Proposed solution - Our code generator should act on .ts files, apply its logic based on custom code and identify areas of change using regex/comments

Design-wise, we can a concept of 'modifiers', a simple function that do some modification to the output like remove a code part. These functions are registered on start, fs.walk calls them for everyfile and they return {fileContent, copyItem}

POC - We can have one like this to remove best practices section and to avoid copying github action file

@dormesica

Created at 1 day ago
closed issue
Make a library 'publishable'

🎯 Goal: - The code we generate contains multiple libraries, let's show how one can get published to npm so the main Microservice can install and use it. The rest will follow.

🤔 Things to consider:

  • Before publishing the code should transpile (build), version bump should happen (we can automate this later) and then publish to npm. Consider chaining all of these commands under one 'npm script' in the library package.json
  • Ensure .npmignore exists to avoid leaking secrets or none-relevant code
  • Test that the main Microservice can consume this library from the remote registry (currently it's linked locally)
Created at 1 week ago
closed issue
Don't let new commits decrease the coverage

🎯 Goal: - 100% coverage or not? Big question, at least we can disallow new commits to decrease the existing coverage

🤔 Things to consider:

  • codecov seems like a good tool for the mission. Feel free to consider other options
  • Should be a standard PR check - This way all the quality checks are centralized in one place
  • No absolute numbers rather per-commit measurement - It's hard to declare now which exact coverage number we aim for. Instead, we should define that the latest commit did not decrease comparing with the previous one (achievable with configuration only using codecov)
  • Other informative and 'cool' visuals that can be added to the PR are welcome
  • If the tool has other useful capabilities - bring it on!
Created at 1 week ago
closed issue
🔐 JWT validator library

🎯 Goal: - Protect routes by verifying the JWT token and stopping requests if the token is invalid. Later we will add JWKS later and authorization...

🤔 Things to consider:

  • Should be its own library with its own tests
  • Should be a middleware so every router/route pick it or not
  • Create also a public non-protected route to demonstrate how to bypass the test
  • Follow as much best practice that you can find while still keeping the code short. No worries if the 1st iteration is simplistic, all good
Created at 1 week ago
🎉 We (almost) have an example app - Meet practica.js

@rluvaton We will, just need to feel more confident that Practica is a little bit more ready

Created at 1 week ago
docs: add backend-joonyoung as a contributor for code

@rluvaton 💪

Created at 1 week ago
issue comment
Add .editorconfig to sync across editors

@mojcaostir We will be honored:)

Created at 2 weeks ago
I am kind of missing monorepo best practices

Welcome! Makes tons of sense, it should be clarified HOW to work with libraries. This is on our roadmap for 2022, a first fresh blog post already exists:)

What advice would you share on this regard?

Created at 2 weeks ago
pull request closed
fix (CONTRIBUTING): fix the link in CONTRIBUTING.md to contribution-short-guide.md

Fix the short-guide link in the CONTRIBUTING file.

Created at 2 weeks ago

fix (CONTRIBUTING): fix the link

Merge branch 'main' into fix-link-in-contributing-guide

Merge branch 'main' into fix-link-in-contributing-guide

Merge pull request #134 from yohai-zv/fix-link-in-contributing-guide

fix (CONTRIBUTING): fix the link in CONTRIBUTING.md to contribution-short-guide.md

Created at 2 weeks ago

Fixed a few typos and grammar in README.md

Fix typo in configuration-library.md

codecov integration

Fix paths

Remove python

Fix step

Fix file path

Add readme indication

codecov.yml

Merge branch 'main' into feat/issue-87

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Merge pull request #133 from YonatanKra/fix-typo-in-configuration-library.md

fix(decisions): typo in configuration-library.md

Merge pull request #138 from practicajs/all-contributors/add-YonatanKra

docs: add YonatanKra as a contributor for content

Merge pull request #132 from yoni-rapoport/main

Fixed a few typos and grammar in README.md

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Merge pull request #139 from practicajs/all-contributors/add-yoni-rapoport

docs: add yoni-rapoport as a contributor for content

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Created at 2 weeks ago
delete branch
goldbergyoni delete branch feat/issue-87
Created at 2 weeks ago

codecov integration

Fix paths

Remove python

Fix step

Fix file path

Add readme indication

codecov.yml

Merge branch 'main' into feat/issue-87

Merge branch 'main' into feat/issue-87

Merge pull request #135 from practicajs/feat/issue-87

codecov integration

Created at 2 weeks ago
pull request closed
codecov integration

Add integration with codecov in order to display code coverage and its delta between base and PR.

Created at 2 weeks ago

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Merge pull request #140 from practicajs/all-contributors/add-perilevy

docs: add perilevy as a contributor for code

Created at 2 weeks ago
delete branch
goldbergyoni delete branch all-contributors/add-perilevy
Created at 2 weeks ago
pull request closed
docs: add perilevy as a contributor for code

Add @perilevy as a contributor for code.

This was requested by goldbergyoni in this comment

Created at 2 weeks ago

Fixed a few typos and grammar in README.md

Fix typo in configuration-library.md

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Merge pull request #133 from YonatanKra/fix-typo-in-configuration-library.md

fix(decisions): typo in configuration-library.md

Merge pull request #138 from practicajs/all-contributors/add-YonatanKra

docs: add YonatanKra as a contributor for content

Merge pull request #132 from yoni-rapoport/main

Fixed a few typos and grammar in README.md

docs: update README.md [skip ci]

docs: update .all-contributorsrc [skip ci]

Merge pull request #139 from practicajs/all-contributors/add-yoni-rapoport

docs: add yoni-rapoport as a contributor for content

Merge branch 'main' into feat/issue-87

Created at 2 weeks ago