gmarler
Repos
109
Followers
6
Following
1

Events

closed issue
Provide a way to eliminate $MaxMessageSize from /etc/rsyslog.conf template

:ghost: Brief Description

Some versions of rsyslogd will consume all host memory if $MaxMessageSize is set to anything. Eliminating this directive eliminates the problem. The current cookbook attribute/template combination doesn't allow specifying that you don't want this directive at all in your configuration.

:pancakes: Cookbook version

8.x and 9.x

:woman_cook: Chef-Infra Version

version 14.x through 16.x

:tophat: Platform details

Solaris 11.3 with rsyslogd v8.4.2 provided by Oracle via IPS

Steps To Reproduce

Steps to reproduce the behavior:

  1. Install system/rsyslog IPS package on any Solaris 11.3 system
  2. Specify $MaxMessageSize with any value > 1024 or 1k in /etc/rsyslog.conf
  3. Load the standard imsolaris input module that comes with rsyslog
  4. Specify any facility/level rules to any targets
  5. Initiate the first log message to any facility/level via the logger command
  6. rsyslogd will begin to consume large amounts of CPU/Memory until all system memory is exhausted

:police_car: Expected behavior

Expected setting the attribute node['rsyslog']['max_message_size'] to nil or false would cause the template for /etc/rsyslog.conf to just not include this directive in the config file.

At present, specifying nil just generates this into /etc/rsyslog.conf

$MaxMessageSize

Specifying false generates this:

$MaxMessageSize false

:heavy_plus_sign: Additional context

Will be including PR shortly.

Created at 4 days ago
issue comment
Allow $MaxMessageSize to be omitted from configuration

Ok, added tests for when node['rsyslog']['max_message_size']:

  • Is explicitly set to nil
  • I explicitly set to '4k'

Let me know if the manner of testing is good for you, and if you want me to add another test for when the directive simply defaults (node['rsyslog']['max_message_size'] isn't set at all).

Created at 5 days ago

Add a test for when max_message_size is explicitly set

Created at 5 days ago

test for elimination of $MaxMessageSize

  • When node['rsyslog']['max_message_size'] is nil

Make cookstyle happy

Created at 5 days ago

update CHANGELOG

Created at 1 week ago
issue comment
Allow $MaxMessageSize to be omitted from configuraton

Oh, any particular place you'd like me to put a unit test for this?

Created at 1 week ago
issue comment
Allow $MaxMessageSize to be omitted from configuraton

Working it...

Created at 1 week ago
issue comment
Provide a way to eliminate $MaxMessageSize from /etc/rsyslog.conf template

PR https://github.com/sous-chefs/rsyslog/pull/197 has been submitted.

Created at 1 week ago
pull request opened
Allow $MaxMessageSize to be omitted from configuraton
  • Update template to not emit $MaxMessageSize if attr is nil/false
  • Update README.md for attr that nil/false are now valid

Description

Allows specifying nil/false for node['rsyslog']['max_message_size'], so that $MaxMessageSize is not emitted into /etc/rsyslog.conf

Issues Resolved

https://github.com/sous-chefs/rsyslog/issues/196

Check List

  • [ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented in the README if applicable.
Created at 1 week ago

Allow $MaxMessageSize to be omitted from configuraton

  • Update template to not emit $MaxMessageSize if attr is nil/false
  • Update README.md for attr that nil/false are now valid
Created at 1 week ago
opened issue
Provide a way to eliminate $MaxMessageSize from /etc/rsyslog.conf template

:ghost: Brief Description

Some versions of rsyslogd will consume all host memory if $MaxMessageSize is set to anything. Eliminating this directive eliminates the problem. The current cookbook attribute/template don't allow specifying that you don't want this directive at all in your configuration.

:pancakes: Cookbook version

8.x and 9.x

:woman_cook: Chef-Infra Version

version 14.x through 16.x

:tophat: Platform details

Solaris 11.3 with rsyslogd v8.4.2 provided by Oracle via IPS

Steps To Reproduce

Steps to reproduce the behavior:

  1. Install system/rsyslog IPS package on any Solaris 11.3 system
  2. Specify $MaxMessageSize to any value > 1024 or 1k in /etc/rsyslog.conf
  3. Load the standard imsolaris input module that comes with rsyslog
  4. Specify any facility/level rules to any files
  5. Initiate the first log message to any facility/level via the logger command
  6. rsyslogd will begin to consume large amounts of CPU/Memory until all system memory is exhausted

:police_car: Expected behavior

Expected setting the attribute node['rsyslog']['max_message_size'] to nil or false would cause the template for /etc/rsyslog.conf to just not include this directive into the config file.

:heavy_plus_sign: Additional context

Will be including PR shortly.

Created at 1 week ago
create branch
gmarler create branch max-messages-nil
Created at 1 week ago
Created at 1 week ago