What about section.title :

https://github.com/Taxel/PlexTraktSync/blob/f33ef68568c5ed5814065e4e381cdaad5c1293b5/plextraktsync/walker.py#L323-L332

Looks like I forgot to push: c4af50d5..94bac545 (or there was network error when I pushed before?)

ps: github still doesn't have threaded replies for reviews? doh.

Add kwargs to measure_time

Format section titles in media_from_sections

I'm looking for a way to create eslint bundle, i.e one file eslint.js with all necessary dependencies from node_modules bundled in to that file. because of dynamic imports, out of the box it does not work:

$ esbuild --platform=node --target=node14 --bundle --sourcemap --outfile=dist/eslint.js node_modules/.bin/eslint

  dist/eslint.js      3.3mb ⚠️
  dist/eslint.js.map  6.4mb

✨  Done in 0.32s.
$ node dist/eslint.js
There was a problem loading formatter: /Users/glen/work/dist/formatters/stylish
Error: Cannot find module '/Users/glen/work/dist/formatters/stylish'
Require stack:
- /Users/glen/work/dist/eslint.js

I setup your plugin into buld() pipeline, and it still gave me formatters/stylish import error.

Similarly for bundling pino, there's plugin that handles the dynamic imports for bundling:

• https://www.npmjs.com/package/esbuild-plugin-pino

but this project, given the same project name structure, and usage, does something different. what does it mean? because these two sentences definitely doesn't explain it. to me:

Lint your esbuild bundles with eslint. 🧐

Nicely integrates the most recent version of eslint into an esbuild plugin.

please describe the actual usage of this plugin in readme, perhaps with examples, asciicast?

For other items in WalkPlan:

• https://github.com/Taxel/PlexTraktSync/blob/f33ef68568c5ed5814065e4e381cdaad5c1293b5/plextraktsync/walker.py#L90-L92

need to refactor to use PlexLibraryItem there first.

See https://github.com/Taxel/PlexTraktSync/pull/1447#issuecomment-1487223403

Add Media.title_link to format title as rich link

Use rich links when printing titles

Merge pull request #1447 from glensc/md-titles

This fixes issues like:

1. titles with aposthrophes continue be colored
2. having title on screen it's difficult to find actual item

now it's clickable links, if terminal supports it.

this is not how this work. you create pr from your own fork, not push directly to upstream repo.

also, still unclear what are your other dependencies. create gist reproducer. last i checked you should be able to use proper psr package depending on your environment.

oh, lol. how I managed to jump two major versions and read only release notes for 6.x 🤣 . thanks!

Could add some custom log level:

• https://stackoverflow.com/questions/2183233/how-to-add-a-custom-loglevel-to-pythons-logging-facility/35804945#35804945

Not sure if that's worth it

Set some cache to responses that can generate 304 response

Cache for some time, this activates 304 responses, need some cache value to be able to compare and make conditional requests.

Add rule for plex discover watchlist without userstate

Add rule for Plex Discover Search

Add rule for trakt.tv/shows/*/seasons?extended=episodes

Add watched status, watchlist to cache, but keep them fresh

These all support 304 responses

Code comments

Reorder to have more specific match first

Use max-age header value for trakt.tv/shows/*/seasons?extended=episodes

Cache metadata.provider.plex.tv root url for 1d

Remove stale comment

Enable cache control for CachedSession

Enable rich tracebacks in rich logger

Catch all exceptions when running commands

Merge pull request #1443 from glensc/rich-exception

Bump platformdirs from 3.1.1 to 3.2.0 (#1445)

Bump rich from 13.3.2 to 13.3.3 (#1446)

Merge pull request #1360 from glensc/cache-policy

Add Media.title_link to format title as rich link

Use rich links when printing titles

Set some cache to responses that can generate 304 response

Cache for some time, this activates 304 responses, need some cache value to be able to compare and make conditional requests.

Add rule for plex discover watchlist without userstate

Add rule for Plex Discover Search

Add rule for trakt.tv/shows/*/seasons?extended=episodes

Add watched status, watchlist to cache, but keep them fresh

These all support 304 responses

Code comments

Reorder to have more specific match first

Use max-age header value for trakt.tv/shows/*/seasons?extended=episodes

Cache metadata.provider.plex.tv root url for 1d

Remove stale comment

Enable cache control for CachedSession

Merge pull request #1360 from glensc/cache-policy

Cache for some time, this activates 304 responses, need some cache value to be able to compare and make conditional requests.

Commands to expire existing cache (Not needed as previously these were not cached at all). Replace * with your trakt account.

plextraktsync cache --expire https://plex.tv/users/account
plextraktsync cache --expire https://api-v2launch.trakt.tv/sync/collection/shows
plextraktsync cache --expire https://api-v2launch.trakt.tv/sync/watched/shows
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/collection/movies
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/ratings/episodes
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/ratings/movies
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/ratings/shows
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/watched/movies
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/watchlist/movies
plextraktsync cache --expire https://api-v2launch.trakt.tv/users/*/watchlist/shows

This fixes issues like:

1. titles with aposthrophes continue be colored
2. having title on screen it's difficult to find actual item

now it's clickable links, if terminal supports it.

Add Media.title_link to format title as rich link

Use rich links when printing titles

what I found that sometimes plex responses were cached too eagerly, especially with inspect. but i don't have details, i just used --no-cache and moved on. then again, i have some overrides set to 1h for plex, 1d for trakt

@dependabot squash and merge

probably too much effort to fill 1.0.0 as it's a very huge changeset, and older than that nobody cares anymore :)

@dependabot squash and merge

so, it's program_name probably incorrect, the only thing you didn't check

4.6.0 to 6.0.1 has breaking change not listed in changelog:

an application (graphiql) served with this middleware installed resulting all requests end up with: net:: ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep 200" errors.

StackOverflow post

• https://stackoverflow.com/questions/70695881/neterr-blocked-by-response-notsameoriginafterdefaultedtosameoriginbycoep-200

to fix, had to add to option middleware:

  app.use(
    helmet({
      // @link https://github.com/helmetjs/helmet/wiki/Helmet-4-upgrade-guide#there-is-now-a-default-policy
      contentSecurityPolicy: false,
+      crossOriginEmbedderPolicy: false,
    }),
  );

I think this should be also noted as breaking change in the changelog

Is your feature request related to a problem? Please describe.

your renovatebot integration pins dependencies which is also affecting downstream packages. it's ok to pin your devDependencies, but pinning on dependencies has effect on downstream packages too, resulting duplicate instances in node_modules.

$ find node_modules -name value-or-promise
node_modules/value-or-promise
node_modules/@graphql-tools/mock/node_modules/value-or-promise
node_modules/@graphql-tools/schema/node_modules/value-or-promise

Describe the solution you'd like

Remove the version pinning and update your lock file only in your repo.

so currently:

• dependencies: value-or-promise "1.0.12"

future:

• value-or-promise "^1.0.0" (affects downstream packages)
• lockfile: value-or-promise "1.0.12" (does not affect downstream packages)

Describe alternatives you've considered

Additional context

please publish release notes for 1.0.1

there's no changelog in the project and nothing attached to 1.0.1 tag:

• https://github.com/IvanGoncharov/graphql-voyager/releases/tag/v1.0.1