I see! This should be an easy fix :slightly_smiling_face:

It'd be nice if the information in the "Edit Character" section and "tabs" conformed, that way information was visible and clearly arrayed in tidier ergonomic layout.

Yes, this would certainly be one way to do this. The current state results from various redesigns and I agree that we can do better. I'll think about this more.

The facility to see the text of Conditions in the "tab", which would likely apply to Psychology options too; psychologies might benefit from something akin to the layout off "Skills" "tab" or similar...

This would require import from Core Rulebook. Certainly possible, but quite a lot of work. The upside would be support for additional Conditions (Rattled)

The facility to see which skills are Basic and Advanced at a glance, and possibly a way to list native languages distinct from the other skills, there's some utility around this with how skills like Sail and the Linguistics Talent work too;

I'm totally for some visual distinction for Basic and Advanced Skills, this is really useful for Assistance. Do you have something in mind? Maybe a bold text or icon?

the ability to clearly distinguish between in-Career, Non-Career, and Species Advances.

For Species advances there is currently no way to know as app does not have a concept of Species Skills/Talents. For Career advances I currently plan separate screen intended for Career all advances (advancing Skills, Talents and Characteristics). Is there some mechanic that would benefit from tracking Species Advances separately?

A similar issue exists with Spells, as it's not at all possible for a player to see which Lore a spell belongs to, and the Lore features aren't accessible which would be handy. Perhaps grouping them by Lore as with "Skills, Talents, and Traits" in that "tab"?

Great idea, I can see how current state can be confusing from spellcasters with multiple lores + petty spells + arcane spells.

Added support for all handler options - bus, from_transport, handles, method and priority

Added tests for new handler and subscriber options - bus, from_transport, handles, method and priority

Union message handlers

• added tests for message handlers with union argument types
• fixed warning assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertMatchesRegularExpression() instead.

Updated the minimum required version of nette/di to 3.0.6

Merge pull request #17 from tg666/feature/handler-options

Added support for handler tag options and subscriber options

Added support for all handler options according to the Symfony documentation.

# ...
tags:
    messenger.messageHandler:
        # currently supported:
        bus: bus_name
        alias: alias_name
        
        # newly supported:
        priority: 10
        method: myHandleMethod
        handles: App\MyMessage
        from_transport: async

final class MyMessageSubscriber implements MessageSubscriberInterface
{
    public static function getHandledMessages(): iterable
    {
        yield MyMessage::class => [
            # currently supported:
            'method' => 'myHandleMethod',
            
            # newly supported:
            'priority' => 10,
            'bus' => 'bus_name',
            'from_transport' => 'memory1',
        ];
    }
 }

This was now released as part of 3.8.0

There are several reports from users unable to fill in Career when creating the Character.

The problem is that when there are no Careers in Compendium, the Career selectbox contains only one option - "None".

This is confusing and should probably use the same UI skills and other items use - Career picker with optional "Create non-compendium Career" or even something better.

Current solution

Currently you can check the "Custom Career" checkbox and fill in the Career details or preferably the GM should import Carrers from the Rulebook PDF as documented on Wiki (https://github.com/fmasa/wfrp-master/wiki/Creating-a-Party#importing-compendium). Careers in Compendium can then be selected in Career selectbox.

Replace "Custom Career" checkbox by better select box

Merge pull request #83 from fmasa/career-picker

Replace "Custom Career" checkbox by better select box

Closes https://github.com/fmasa/wfrp-master/issues/81

• single SelectBox that opens a picker similar to the one used for Skills etc.
• Selected Career is cleared by × button
• Custom career can be selected in a picker

Closes https://github.com/fmasa/wfrp-master/issues/81

Closes https://github.com/fmasa/wfrp-master/issues/38

Importing Pdfs of those rulebooks makes app crash. Afer relaunch of App there is no talents or skills from those books.

Increase max length of skill description

Add new PDFBox parsing for Core Rulebook, Up in Arms and Winds of Magic

Automatically close PDF stream

Overhaul PDF parsing to support more sources

This is a huge commit, sorry.

This change introduces new parsers for all compendium items for several books:

• Core Rulebook
• Winds of Magic
• Up in Arms

Remove old PDF parsing support

Merge pull request #82 from fmasa/pdf-import

Winds of Magic + Up in Arms PDF import

Overhaul PDF parsing to support more sources

This is a huge commit, sorry.

This change introduces new parsers for all compendium items for several books:

• Core Rulebook
• Winds of Magic
• Up in Arms

Remove old PDF parsing support

Closes https://github.com/fmasa/wfrp-master/issues/38

There are several reports from users unable to fill in Career when creating the Character.

The problem is that when there are no Careers in Compendium, the Career selectbox contains only one option - "None".

This is confusing and should probably use the same UI skills and other items use - Career picker with optional "Create non-compendium Career" or even something better.

Current solution

Currently you can check the "Custom Career" checkbox and fill in the Career details or preferably the GM should import Carrers from the Rulebook PDF as documented on Wiki (https://github.com/fmasa/wfrp-master/wiki/Creating-a-Party#importing-compendium).

Let users mark encounters as complete

Merge pull request #80 from fmasa/feat/encounter-complete

Completed Encounters

This builds upon something that has been dormant since the first implementation of Encounters.

GMs can now mark the Encounter as Completed, which will by default hide them from the Encounters list. This means that GM can now hide old Encounters without outright deleting them.

This builds upon something that has been dormant since the first implementation of Encounters.

GMs can now mark the Encounter as Completed, which will by default hide them from the Encounters list. This means that GM can now hide old Encounters without outright deleting them.

Fix screen model creation in career detail

Merge pull request #79 from fmasa/fix/career-detail

Fix crash in Career detail

Fix screen model creation in career detail