flowchartsman
Repos
130
Followers
88
Following
19

Events

Created at 4 hours ago
Created at 5 days ago

Update ch02 example to match others and also fit on the page better

Created at 6 days ago
flowchartsman create branch main
Created at 1 week ago
create repository
flowchartsman create repository
Created at 1 week ago
flowchartsman create branch main
Created at 1 week ago
create repository
flowchartsman create repository
Created at 1 week ago
issue comment
Hide empty packages in compact formats

Sounds good. Feel free to merge this in, and I'll start a separate PR

Created at 1 week ago
create branch
flowchartsman create branch fancyalice66
Created at 1 week ago
Created at 1 week ago

[improve][broker][PIP-149]make getBacklogQuotaMap method async in Namespaces (#16504)

[ci] bot commands may have leading whitespace (#16495)

Fix: Make DeadLetterPolicy deserializable (#16513)

Shared subscription: improvement with offloaded ledgers (#16417)

Bump prometheus client version from 0.5.0 to 0.15.0 (#13785)

Motivation

  • prometheus simpleclient has broken api, it makes pulsar-client-origin can not well used with other libraries
  • specify OpenMetrics

This PR contains metric name broken changes.

Modifications

Bump prometheus client version from 0.5.0 to 0.15.0

changes

  • bump the client version
  • rename the field prometheus client UNTYPED to UNKNOWN
  • OpenMetrics's counter name needs a _total suffix

metrics name broken changes

  • rename pulsar_expired_token_count to pulsar_expired_token_total
  • rename pulsar_authentication_success_count to pulsar_authentication_success_total
  • rename pulsar_authentication_failures_count to pulsar_authentication_failures_total
  • rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
  • rename pulsar_source_received_total_1min to pulsar_source_received_1min_total
  • rename pulsar_source_written_total_1min to pulsar_source_written_1min_total
  • rename pulsar_source_source_total_1min to pulsar_source_source_exceptions_1min_total
  • rename pulsar_source_system_exceptions_total_1min to pulsar_source_system_exceptions_1min_total
  • rename pulsar_function_received_total_1min to pulsar_function_received_1min_total
  • rename pulsar_function_user_exceptions_total_1min to pulsar_function_user_exceptions_1min_total
  • rename pulsar_function_system_exceptions_total_1min to pulsar_function_system_exceptions_1min_total
  • rename pulsar_function_processed_successfully_total_1min to pulsar_function_processed_successfully_1min_total
  • rename pulsar_function_received_total_1min to pulsar_function_received_1min_total
  • rename pulsar_function_user_exceptions_total_1min to pulsar_function_user_exceptions_1min_total
  • rename pulsar_function_system_exceptions_total_1min to pulsar_function_system_exceptions_1min_total
  • rename pulsar_function_processed_successfully_total_1min to pulsar_function_processed_successfully_1min_total
  • rename pulsar_sink_received_total_1min to pulsar_sink_received_1min_total
  • rename pulsar_sink_written_total_1min to pulsar_sink_written_1min_total
  • rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
  • rename pulsar_sink_system_exceptions_total_1min to pulsar_sink_system_exceptions_1min_total
  • rename pulsar_sink_received_total_1min to pulsar_sink_received_1min_total
  • rename pulsar_sink_written_total_1min to pulsar_sink_written_1min_total
  • rename pulsar_sink_sink_exceptions_total_1min to pulsar_sink_sink_exceptions_1min_total
  • rename pulsar_sink_system_exceptions_total_1min to pulsar_sink_system_exceptions_1min_total

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [x] doc-required As mentioned above, the metrics name has changed

[improve][doc] Clarify the usage of destination-topic-name for Debezium connector and fix incorrect REST API links (#16433)

[improve][connector] Add getSourceConfig method on SourceContext (#16305)

[fix][doc] Fix wording in Tiered Storage (#16579)

[fix][doc] fix client-libraries table style (#16522)

[fix][io-quickstart][docs] Corrected split sentence in tip (#16501)

[Doc] schema-manage example 1 fix

[improve][test] Improve the TransactionTest to reduce the execution time (#16580)

Motivation

The TransactionTest run over 3 minutes. To avoid start a pulsar cluster for each test method.

 [INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.322 s - in org.apache.pulsar.broker.transaction.TransactionTest

After this change, the execution time reduce to under 1 minute on my laptop

Offloaders: fix metrics (#16405)

[fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages (#16443)

  • [fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages

Motivation

The RawReader hasMessageAvailable will return true when all the messages have been consumed. And that will cause the readNextAsync blocked and the process never recovered. In the ConsumerImpl, we update the lastDequeuedMessageId in the messageProcess. The messageReceived method rewrites by the RawReader, we should update the lastDequeuedMessageId in the RawReader as well.

  • Fix the hasMessageAvaiable in batch messages

[fix][flaky-test] fix cumulative ack test after abort redeliver message by users (#16592)

Motivation

since https://github.com/apache/pulsar/pull/14371 merged, when the client abort txn with cumulative ack, We need to the redeliver message manually

Modifications

change test when transaction abort with cumulative ack, redeliver message manually

Verifying this change

Bump prometheus client version from 0.15.0 to 0.16.0 (#16591)

Motivation

prometheus client 0.16.0 contains some approvements that we can benefit from. Thanks for @dave2wave @michaeljmarshall the reminder and pointing out.

[ENHANCEMENT] Reduce the number of core threads in HTTPServer from 5 to 1. The HTTPServer will still start up to 5 threads on demand if there are parallel requests, but it will use only 1 thread as long as requests are sequential (https://github.com/prometheus/client_java/pull/786). [ENHANCEMENT] Optimize metric name sanitization: Replace the regular expression with a hard-coded optimized algorithm to improve performance (https://github.com/prometheus/client_java/pull/777). Thanks @fwbrasil

See https://github.com/prometheus/client_java/releases

Modifications

Bump prometheus client version from 0.15.0 to 0.16.0

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [x] doc-not-needed dependency updates, no need doc

[feature][cli] Pulsar Shell - pulsar-admin and pulsar-client - part 1 (#16251)

  • [feature][cli] Pulsar Shell

[feature][connector] JDBC sinks: support upsert and row deletion (#16448)

[improve][doc] Highlight important tips (#16575)

Fix TopicListWatcher creation (#16576)

Motivation

TopicListWatcher's can not work when the lookup url scheme is HTTP.

Changes

  • Not creating a TopicListWatcher when HTTP url is specified
  • Create test to avoid future regressions in this area
Created at 1 week ago
issue comment
Hide empty packages in compact formats

Sounds great. Can't wait to see this in the next release. Provided both flags can land, I'm comfortable closing my original PR

Created at 2 weeks ago
started
Created at 2 weeks ago
issue comment
Hide empty packages in compact formats

Actually, now that I think about it, a --junit-hide-empty-pkg option would probably be the right call, since that would allow people to skip either display or output, selectively.

Created at 3 weeks ago
issue comment
Hide empty packages in compact formats

This is great, but part of the reason I wrote the original code the way I did was so that I didn't end up with bloated junit.xml files. I have a relatively large project under a single module that has many directories that will never have tests, so it is useful to me not to clutter the junit.xml with a bunch of empty entries that will always be empty.

Not entirely sure what the right approach is; perhaps instead of the option to hide empty directories, there should be an option to only test those directories which are testable.

Created at 3 weeks ago
issue comment
suppress printing package names with no tests

I made a PR for this, adding a --skip-empty option that only works if you are testing ./..., since that's the situation where missing tests are going to show up most often. It was a bit tricky as I had to track missing stuff in two places to intercept it before it got to the formatters as well. There might be a better method. Wasn't sure where to add tests beyond arg checking, since AFAICT all of the testing harnesses that do golden file comparison on output are geared strictly to formatters, which my solution bypasses to avoid adding skipping behavior to all formatters.

Created at 3 weeks ago
issue comment
load from file if ConfigFile.Content is empty

Now that is one strict DCO rule. Should be good now?

Created at 3 weeks ago

load from file if ConfigFile.Content is empty

  • fixes #314

Signed-off-by: Andy Walker walkeraj@gmail.com

Created at 3 weeks ago
Created at 3 weeks ago

Fix argparse bug, add tests for package targets

Created at 3 weeks ago
issue comment
load from file if ConfigFile.Content is empty

Good to go (I think)

Created at 3 weeks ago

load from file if ConfigFile.Content is empty

  • fixes #314

Signed-off-by: Andy Walker andy@andy.dev

Created at 3 weeks ago

load from file if ConfigFile.Content is empty

  • fixes #314

Signed-off-by: Author Name authoremail@example.com

Created at 3 weeks ago

update help for test

Created at 3 weeks ago
pull request opened
Skip empty tests

First pass to fix #228

Created at 3 weeks ago
create branch
flowchartsman create branch skipmissing
Created at 3 weeks ago
Created at 3 weeks ago
issue comment
Parameter hints don't show up on autocompletion suggestion of methods.

Appears to be fixed in nightly, presumably thanks to @hyangah && https://go.dev/cl/446816

Created at 3 weeks ago
issue comment
Parameter hints don't show up on autocompletion suggestion of methods or functions.

@flowchartsman you said this is the case for methods or functions, but in my case I see this only for methods. Can you please confirm that you also see this misbehavior for functions?

Cannot confirm, your observation is correct, it does not happen with functions. It only appears to be methods.

Created at 3 weeks ago