federicobozzini
Repos
38
Followers
9

Inspired by Tatsuo Miyajima

Spark your research!

77
6

The website for the allspeak project

0
0

REST web service to expose the content of an active directory domain.

The backend for the allspeak project.

1
0

Events

issue comment
Upload command always visible on browser

I've pushed a squashed version, thanks.

Created at 2 weeks ago

terminal: Support VS Code Terminal Link Providers (#11552)

  • Implement the previously mocked support for Terminal Link Providers
  • Introduce Theia contribution point for adding link providers
  • Migrate existing link matchers to this new contribution point
  • Get rid of the usage of the deprecated xterm.registerLinkMatcher API
  • Fix UI bug where the link hover doesn't show up This happened when the mouse is above the hover as it gets visible, leading to xterm canceling the hover right away, because the mouse "seemingly" left the link. This has been fixed by preventing to hide it if the mouse left the link but is above the hover.
  • Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes #11521 Fixes #11507 Fixes #11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc Signed-off-by: Philip Langer planger@eclipsesource.com

Improved HostedPluginSupport Extensibility (#11755)

The commit improves the extensibility of the HostedPluginSupport class.

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Fix wrong terminal attach when switching workspaces

... with preserve window option

  • generate random unique ids in process manager

Register VSCode items directly with corresponding internal menus (#11741)

Fixes bug where inline items were not appearing in TreeViews.

vscode: Support TerminalOptions.hideFromUser (#11630)

  • Add TerminalOptions.hideFromUser in theia.d.ts
  • Add TerminalWidget.hiddenFromUser
  • Fix cwd for created terminals with undefined cwd (default: workspace)

If TerminalOptions.hideFromUser is set to true, the TerminalWidget will be hidden from any user-facing terminal lists until it is first explicitly shown to the user (see TerminalWidget.hiddenFromUser).

As we don't open TerminalWidgets by default on TerminalService.newTerminal and as we don't have a global terminal view (in contrast to VS Code), we only need to hide it in the TerminalQuickOpenService really.

Contributed on behalf of STMicroelectronics. Fixes https://github.com/eclipse-theia/theia/issues/11144

Change-Id: Ic1fdf2d5515d5b2fa8feb58b72218b93eeabda4d

make @theia/ffmpeg lazy (#11754)

@theia/ffmpeg is loaded eagerly and tries to load its native addon eagerly as well.

Make imports of @theia/ffmpeg lazy both internally and externally.

This will fix the issue when dependents pull our packages while ignoring install scripts: In such a case the native addon won't be built and won't be found at runtime when @theia/ffmpeg is loaded.

Introduce automated license check reviews

In this PR we introduce the option to use our license check tool, "dash-licenses", in "Automatic IP Team Review Requests" mode [1]. In this mode, any dependency that's found to have an unclear or suspicious license will be automatically submitted to the Eclipse Foundation for review. Each such dependency will have a ticket opened on the Foundation's Gitlab and be automatically reviewed. If the automated review is not conclusive, a manual assessment will be performed by the Foundation's IP team.

In our experience, most dependencies are approved automatically within minutes.

To perform a license check with automated reviews, use the new script: $> yarn license:check:review

To perform the license check without the automated review, do as before: $> yarn license:check

Note: for review mode to work, a Personal Access Token from the Foundation's Gitlab is required, created from a project committer's Gitlab profile. Set it in an environment variable named "DASH_LICENSES_PAT". E.g. in bash: $> export DASH_LICENSES_PAT=

[1] https://github.com/eclipse/dash-licenses#automatic-ip-team-review-requests

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

[CI] enable license check auto review mode

In our license check workflow, make use of the new yarn script "license:check:review".

I have set the required Gitlab Personal Access Token as a repo secret using the GitHub API (we do not have UI access to this setting).

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

secrets + cleanup

Avoid using shell: true as I had bad experiences with it on Windows.

Instead sanitize arguments to hide secrets when prompting.

improved support for VS Code frontend extensions (#11752)

Infer the plugin deployment type based on the entry points defined in its package.json:

  • If an extension defines a browser entry point then it may be deployed in the frontend.
  • If an extension defines a main entry point then it may be deployed in the backend.

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

[CI] Fix license check for non-committers

Be more flexible in the abscense of the EF Gitlab Private Access Token, to accomodate the case where non-committers (contributors without write access to the repo) submit PRs and do not have access to GitHub secrets (for security reasons).

Instead of immediately failing the license check, warn and proceed in "normal mode" - i.e. like we did before introducing the "review mode".

Fixes #11769

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

move breaking change to correct version (#11761)

Contributed on behalf of STMicroelectronics.

Change-Id: I56869b0506adc635265bf56066b9516fc46cf4e3

vscode: Add support for resolveTreeItem to TreeDataProvider (#11708)

  • Extend theia.d.ts with optional method resolveTreeItem in TreeDataProvider
  • Add infrastructure on ext side to resolve tree items
  • Add resolvable tree view node classes
  • Add resolvement for tooltips and commands
  • Align TreeViewItem and TreeViewNode tooltip property type to include MarkdownString

Implements #11147

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler lkoehler@eclipsesource.com

vscode: add InlayHints support

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

plugin: fixed issue causing plugins to not load (#11771)

The commit fixes the handling of PluginVsCodeDirectoryHandler to fallback to backend (as previously done) when a plugin does not have browser or main defined in their package.json. The previous implementation would make plugins fail to load properly.

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

pin vscode-textmate dependency to v7.0.1

in both @theia/monaco and @theia/plugin-ext

It turns out that more recent versions are not compatible with our current Monaco and plugin-ext

Fixes #11772

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

[security] perform yarn upgrade to update our dependencies

I noticed that a new version of axios is available, that fixes our only high level vulnerability (on the dev side). Performing yarn upgrade picks it up, along with a few others.

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

Check whether editor commands are declared in package.json (#11764)

Support vscode TypeHierarchy API (references-view)

This change introduces support for vscode Typehierarchy API and integrates the solution with the facilities provided by the references-view extension. E.g. via the implementation of the commands vscode.prepareTypeHierarchy, vscode.provideSupertypes, vscode.provideSupertypes

The Show Type Hierarchy context menu shall be enabled from an editor as long as a TypeHIerarchyProvider is registered for the specific language.

Similarly the following commands shall now be functional from the command palette. Types: Show Type Hierarchy Types: Show Subtypes Types: Show Supertypes

Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com

Stub vscode 'Tests' API

This enables the possibility to load and start plugins which depend on the 'Tests' API. The 'Tests' functionality will not be operational but the rest of the functionality offered by the plugin will be.

Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com

Created at 2 weeks ago

core: uncaught error handler made easily overridable (#12068)

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Created at 2 weeks ago
pull request opened
Uncaught error handler made easily overridable

What it does

This PR make the generic error for an uncaught exception more easily overridable.

How to test

It's possible to test this PR by creating a subclass of BackendApplication overriding the handleUncaughtError method.

Review checklist

Reminder for reviewers

Created at 2 weeks ago

Uncaught error handler made easily overridable

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Created at 2 weeks ago
create branch
federicobozzini create branch overridable-uncaught-error-handler
Created at 2 weeks ago
delete branch
federicobozzini delete branch hosted-plugin-support-extensibility
Created at 3 weeks ago

[output] Fix the channel selector.

Let the channel selector automatically switch to the selected channel name based on the current channel name.

Created at 1 month ago

Fixed QuickInput behavior on Enter

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Created at 1 month ago
pull request closed
Plugin might contain @ in its name

What it does

This PR fixes a problem coming from plugins containing the @ in their name. If a plugin (or a vs-code extension) contains @ in its name (eg: @acme/hello-world) at the moment the name is processed incorrectly. This is especially relevant for private plugins where this naming convention is frequently used.

Using lastIndexOf guarantees we stop reading the name where the version (eg: @2.4.5) begins.

How to test

Two plugins need to be installed, using the same pattern (eg: @acme/hello-world and @acme/hello-theia). One of the two will be removed because of a incorrect processing of their name.

Review checklist

Reminder for reviewers

Created at 1 month ago
issue comment
Upload command always visible on browser

@colin-grant-work @vince-fugnitto Can this PR be merged?

Created at 1 month ago
pull request opened
Fixed QuickInput behavior on Enter

What it does

It fixes https://github.com/eclipse-theia/theia/issues/11979. When clicking enter the first element of a QuickInput is picked by default.

How to test

  1. Open a git-versioned project with Theia
  2. Click on the branch name in the status bar (the QuickInput to choose the branch to checkout is presented, first element of the list is "create new branch...")
  3. Press Enter. the first element is selected by default.

Review checklist

Reminder for reviewers

Created at 1 month ago

Fixed QuickInput behavior on Enter

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Created at 1 month ago

Fixex QuickInput behavior on Enter

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

Created at 1 month ago
create branch
federicobozzini create branch quickinput-enter
Created at 1 month ago

vscode: Add support for resolveTreeItem to TreeDataProvider (#11708)

  • Extend theia.d.ts with optional method resolveTreeItem in TreeDataProvider
  • Add infrastructure on ext side to resolve tree items
  • Add resolvable tree view node classes
  • Add resolvement for tooltips and commands
  • Align TreeViewItem and TreeViewNode tooltip property type to include MarkdownString

Implements #11147

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler lkoehler@eclipsesource.com

vscode: add InlayHints support

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

plugin: fixed issue causing plugins to not load (#11771)

The commit fixes the handling of PluginVsCodeDirectoryHandler to fallback to backend (as previously done) when a plugin does not have browser or main defined in their package.json. The previous implementation would make plugins fail to load properly.

Signed-off-by: Federico Bozzini federico.bozzini@gmail.com

pin vscode-textmate dependency to v7.0.1

in both @theia/monaco and @theia/plugin-ext

It turns out that more recent versions are not compatible with our current Monaco and plugin-ext

Fixes #11772

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

[security] perform yarn upgrade to update our dependencies

I noticed that a new version of axios is available, that fixes our only high level vulnerability (on the dev side). Performing yarn upgrade picks it up, along with a few others.

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

Check whether editor commands are declared in package.json (#11764)

Support vscode TypeHierarchy API (references-view)

This change introduces support for vscode Typehierarchy API and integrates the solution with the facilities provided by the references-view extension. E.g. via the implementation of the commands vscode.prepareTypeHierarchy, vscode.provideSupertypes, vscode.provideSupertypes

The Show Type Hierarchy context menu shall be enabled from an editor as long as a TypeHIerarchyProvider is registered for the specific language.

Similarly the following commands shall now be functional from the command palette. Types: Show Type Hierarchy Types: Show Subtypes Types: Show Supertypes

Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com

Stub vscode 'Tests' API

This enables the possibility to load and start plugins which depend on the 'Tests' API. The 'Tests' functionality will not be operational but the rest of the functionality offered by the plugin will be.

Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com

git: fix unstageAll

The commit fixes unstage all to properly reset the index rather than report errors or discard changes.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Translation update for version 1.31.0

docs: update changelog for 1.31.0 (#11804)

  • docs: update changelog for v1.31.1

The commit updates the changelog for the v1.31.0 release to highlight notable new features, fixes, and any potential breaking changes. The change also includes misc typo fixes.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

v1.31.0

core: update re-exports for 1.31.0

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

git: add unit tests for GitScmProvider.unstageAll (#11806)

The commit adds unit tests for GitScmProvider.unstageAll to confirm that unstaging works correctly.

Signed-off-by: Vivien Jovet vivien.jovet@torocloud.com

docs: update 1.31.0 changelog for unstage all

The commit adds an entry for the unstage all fix in the 1.31.0 changelog.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

deps: upgrade socket.io (#11819)

The commit upgrades socket.io to fix a known critical vulnerability with socket.io-parser.

CVE: https://security.snyk.io/vuln/SNYK-JS-SOCKETIOPARSER-3091012

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

repo: upgrade mocha

The commit includes the following changes:

  • upgrades lerna
  • upgrades mocha including our config files
  • upgrades minimatch

The main reason of the upgrade was to fix known vulnerabilties and benefit from the newer mocha version.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

security: socket.io-parser resolution docs

The commit adds a note regarding the socket.io-parser resolution in our migration guide for downstream adopters.

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Add task#runOptions to API. (#11759)

  • Add task#runOptions to API.

Additionally added functionality to support reevaluateOnRerun. If this flag is set to false no variables will be resolved again. Therefore lastTask can now be re-triggered without resolving all variables. For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves #11132

[git] update to latest dugite-extra, dugite-no-gpl

This commit updates @theia/git to consume the latest dugite-extra, which in turn uses the latest, recently uplifted dugite-no-gpl.

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

Created at 1 month ago
opened issue
QuickInput is not picking the first element as a fallback on Enter

Bug Description:

When opening the QuickInput and pressing enter, vs-code by default selects the first element. This doesn't happen in Theia.

vs-code quickinput-vscode

Theia quickinput-theia

Steps to Reproduce:

As an example to reproduce

  1. Open a git-versioned project with Theia
  2. Click on the branch name in the status bar (the QuickInput to choose the branch to checkout is presented, first element of the list is "create new branch...")
  3. Press Enter. Nothing happens. In vs-code the first element is picked by default.

Additional Information

  • Operating System: Ubuntu 20.04
  • Theia Version: 1.32
Created at 1 month ago

Don't display folder icons in the file tree view

Fix pseudo terminal startup

Fix treeview icons

Implement extensions namespace

Revert "Fix treeview icons"

This reverts commit 1f478c0d8423b650df7e7ca791ffb233baa95761.

Merge pull request #64 from ARMmbed/release-1.27.0-rob

Implement VS Code API extensions namespace

Fixes copying of files in the case of broken symlink

This changes the doCopy method of DiskFileSystemProvider to handle failure when stat call fails when a symlink points to something that doesn't exist.

reverted some changes from 4b248bb7

  • remove handling of broken symlinks as that is now done in mbs-ide
  • keep the await on call to mkdirp as that has been upstreamed to theia
Created at 2 months ago
create branch
federicobozzini create branch release-1.27.0-fed
Created at 2 months ago
Created at 2 months ago
pull request opened
Fix typo

Description

Improved error message by removing a typo.

Related Issue

No existing issue.

Types of changes

  • [X] Updated docs / Refactor code / Added a tests case (non-breaking change)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] I have updated the changelog.
Created at 2 months ago