fancyweb
Repos
59
Followers
42
Following
18

The Symfony PHP framework

28148
8786

Twig, the flexible, fast, and secure template language for PHP

7734
1140

Doctrine Object Relational Mapper (ORM)

9530
2363

The missing Symfony Admin Generator

2087
1241

The Symfony documentation

2024
4830

Events

issue comment
[HttpClient] Fix not calling the on progress callback when canceling a MockResponse

After retesting, it works with CurlHttpClient and not with NativeHttpClient... So it might not be the best solution.

Created at 21 hours ago

[Form] Deprecate not honoring with_seconds => false for HTML5 datetime inputs in DateTimeType

Created at 1 day ago

[Console] fix clear of section with question

Added condition to always return the real Authenticator

[Serializer] Replace the MissingConstructorArgumentsException class with MissingConstructorArgumentException

add Sender to the list of bypassed headers

[HttpKernel] Fix setting the session on the main request when it's started by a subrequest

[Form] Check for RepeatedType child in PasswordHasherListener

Remove unused data provider

minor #49278 Remove unused data provider (OskarStark)

This PR was merged into the 5.4 branch.

Discussion

Remove unused data provider

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs https://github.com/symfony/symfony/pull/48668/files#r1098456404 | License | MIT | Doc PR | -

Commits

492fe4af0b Remove unused data provider

Fix: Split and clean up tests

[Semaphore] Fix test

[Tests] Migrate tests to static data providers

bug #49214 [Mailer] add Sender to the list of bypassed headers (xabbuh)

This PR was merged into the 5.4 branch.

Discussion

[Mailer] add Sender to the list of bypassed headers

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48936 | License | MIT | Doc PR |

Commits

f50bec1d8d add Sender to the list of bypassed headers

[HttpClient] Fix data collector

Revert "[HttpClient] Add support for "friendsofphp/well-known-implementations""

This reverts commit b814ce8f2dd54571a5458682959f3dce730e50a4.

Use xxh128 instead of md5

Fix Psalm job

[Notifier] Fix notifier profiler when transport name is null

bug #49314 [HttpClient] Revert support for "friendsofphp/well-known-implementations" (nicolas-grekas)

This PR was merged into the 6.2 branch.

Discussion

[HttpClient] Revert support for "friendsofphp/well-known-implementations"

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

This reverts PR #47950

The major features of "friendsofphp/well-known-implementations" are now available in "php-http/discovery" v1.15.0, see:

  • https://github.com/php-http/discovery/pull/209
  • https://github.com/php-http/discovery/pull/208

Given the extremely low download stats of "friendsofphp/well-known-implementations", I propose to just remove support for it as a bugfix: https://packagist.org/packages/friendsofphp/well-known-implementations

This will save us from maintaining this integration, which is unused code in practice anyway.

Commits

081aa00f96 Revert "[HttpClient] Add support for "friendsofphp/well-known-implementations""

[HttpClient] Fix over-encoding of URL parts to match browser's behavior

bug #49299 [HttpClient] Fix over-encoding of URL parts to match browser's behavior (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion

[HttpClient] Fix over-encoding of URL parts to match browser's behavior

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48315 | License | MIT | Doc PR | -

Yes, the RFC says these chars should be url-encoded:

[ ] \ ^ ` { | }

But in practice, browser's don't encode them, and some servers don't expect them to be encoded either. See https://stackoverflow.com/questions/2366260/whats-valid-and-whats-not-in-a-uri-query for some pointers.

Commits

e79e331810 [HttpClient] Fix over-encoding of URL parts to match browser's behavior

Created at 1 day ago

[HttpClient] Add ServerSentEvent::getArrayData() to get the SSE's data decoded as an array directly

Created at 1 day ago

[HttpClient] Add ServerSentEvent::getArrayData() to get the SSE's data decoded as an array directly

Created at 1 day ago
issue comment
[HttpClient] Fix not calling the on progress callback when canceling a MockResponse

Is the callback called when a real response is canceled?

Yes.

What about the "info" of the response? Don't they give the needed clue?

No, since the original mock response reference is lost, we can't access it and get the info from it.

Created at 1 day ago
pull request opened
[Scheduler] Make some properties readonly

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Created at 5 days ago
create branch
fancyweb create branch scheduler/ro
Created at 5 days ago

[HttpClient] Add ServerSentEvent::getArrayData() to get the SSE's data decoded as an array directly

Created at 5 days ago
pull request opened
[HttpClient] Add ServerSentEvent::getArrayData() to get the SSE's data decoded as an array directly

| Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

Although the data field in SSEs can be "anything", it's really common that it's a JSON payload.

Just like we have a shortcut in responses (ResponseInterface::toArray()), I think it's worth having a shortcut in ServerSentEvent to avoid writing boilerplate code again and again :sweat_smile:

Created at 5 days ago
create branch
fancyweb create branch http-client/sse-get-array-data
Created at 5 days ago
pull request opened
[HttpClient] Fix not calling the on progress callback when canceling a MockResponse

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

I want to assert that a response is canceled under certain circumstances.

My first approach was to get the info from the MockResponse I pass as the response factory to the MockHttpClient but this one is lost since a new instance is created when the request method is called.

My next approach was to wrap the MockHttpClient I pass to the class I'm testing with a TraceableHttpClient. But it doesn't work because the traced info is outdated. The problem seems to be that the on-progress callback is not called when a MockResponse is canceled.

Created at 5 days ago

[HttpClient] Fix not calling the on progress callback when canceling a MockResponse

Created at 5 days ago
create branch
fancyweb create branch http-client/fix-mock-response-cancel
Created at 5 days ago
issue comment
yaml dumper with objects and magic method __debugInfo

To expose only needed data for debug/dump.

For debug yes, for var_dump() yes, but not for dumps in general IMO.

Created at 3 weeks ago
delete branch
fancyweb delete branch fix/twig-dc-rt
Created at 3 weeks ago