@jnsh I'm not familiar with the package release procedure for Ubuntu, but is it possible to release 20221218-1
for the current Ubuntu distribution (22.10)?
I see that this release exists only for 23.04, which is not released yet.
@luismiramirez sorry, could you elaborate a bit on what you mean by out of the app scope
?
Also, does that mean that now I should wrap every AppSignal method individually and not the whole application code once?
And what about native throw
s? Will they be caught in this case (because wrapping these individually is not quite possible, as they can happen anywhere in the app)?
Sorry for a bunch of questions, just trying to understand how to use this in the most efficient way (considering it's used in the existing pretty large project in terms of code).
When I try to use .extend()
in v14 in TypeScript project:
import nlp from 'compromise';
nlp.extend(/* */);
it gives me an error:
Property 'extend' does not exist on type 'typeof nlp'.
A quick look at types shows that when importing compromise
, its types are taken from types/three.d.ts
, which doesn't contain a definition of the extend
method, and only types/one.d.ts
contains it.
Thanks for the quick reply. I think for this case it's completely good to just define the function as you did. :)
@luismiramirez how to use this in the project that doesn't use ES modules?
I see now from the code that .extend()
is just an alias for the .plugin()
method. Would be also useful to have this reference somewhere in Readme.
When I try to use .extend()
in v14 in TypeScript project:
import nlp from 'compromise';
nlp.extend(/* */);
it gives me an error:
Property 'extend' does not exist on type 'typeof nlp'.
A quick look at types shows that when importing compromise
, its types are taken from types/three.d.ts
, which doesn't contain a definition of the extend
method, and only types/one.d.ts
contains it.
This fixes missing TypeScript types for the compromise-dates
plugin.
Fix types for the dates plugin
Faced a black screen issue when starting the game on Ubuntu 22.04 with Nvidia 525.60.11, GE-Proton7-42, and DirectX 12 mode. The sound is present, but the screen goes completely black from the beginning. DirectX 11 mode runs just fine.
This workaround fixed the issue for me, though you need to disable gamemode
for this to work. With gamemode
(v1.6.1) the black screen is still present somehow.
You need to provide existing Postgres connection parameters along these lines: https://github.com/evenfrost/appsignal-knex-issue/blob/master/src/db.ts#L24.
Also, the error is gone with the disableDefaultInstrumentations: ['@opentelemetry/instrumentation-pg']
option, so I believe it's more of pg
than knex
thing, though. But if I disable pg
instrumentation, will it have side effects like not logging SQL queries in AppSignal?
Here is a minimal repro repository: https://github.com/evenfrost/appsignal-knex-issue.
A bit of backstory: we're using mikro-orm
as our Postgres ORM, which uses knex
internally for SQL management, and faced this issue with v4
of mikro-orm
. However, a quick upgrade to v5
in this demo repository showed that the error was gone, possibly due to an upgrade of underlying libraries. The problem is that upgrading our infrastructure to v5
will take plenty of work, so I'd like to know if there is a solution to this issue that doesn't require it.
I upgraded from v2.x to v3 following the migration guide, and now I'm getting the following error when trying to start the application:
> node --require ./build/server/appsignal.cjs ./build/server/index.js
/home/project/node_modules/knex/lib/dialects/postgres/index.js:115
connection.on('error', (err) => {
^
TypeError: Cannot read properties of undefined (reading 'on')
at Client.<anonymous> (/home/project/node_modules/knex/lib/dialects/postgres/index.js:115:20)
at Client.patchedClientConnectCallback [as _connectionCallback] (/home/project/node_modules/@opentelemetry/instrumentation-pg/build/src/utils.js:187:12)
at Client._handleReadyForQuery (/home/project/node_modules/pg/lib/client.js:279:14)
at Connection.emit (node:events:527:28)
at Connection.emit (node:domain:475:12)
at /home/project/node_modules/pg/lib/connection.js:114:12
at Parser.parse (/home/project/node_modules/pg-protocol/dist/parser.js:40:17)
at Socket.<anonymous> (/home/project/node_modules/pg-protocol/dist/index.js:11:42)
at Socket.emit (node:events:527:28)
at Socket.emit (node:domain:475:12)
It seems that @opentelemetry
patches some method, which is being used by Knex afterwards, and this gives an error (possible due to clash of scopes/names because of the patching, but this is just an assumption).
Signed-off-by: Aliaksei Kislou evenfrosty@gmail.com
This adds the missing PostCSS file extension to the type definitions.
Avoid TS compiler errors for PostCSS files
Signed-off-by: Aliaksei Kislou evenfrosty@gmail.com
An invertedIndexConfig.indexNullState
schema property can be updated via PUT /v1/schema/{className}
, but it should be immutable, as discussed here.
Updating a class doesn't seem to work. When I try the following curl:
curl \
-X PUT \
-H "Content-Type: application/json" \
-d '{
"class": "MyClass",
"description": "My class"
}' \
http://localhost:7070/v1/schema/MyClass
it throws an error:
properties cannot be updated through updating the class. Use the add property feature (e.g. \"POST /v1/schema/{className}/properties\") to add additional properties
though I don't provide any properties.
Heads up: you need to provide explicit class schema as seen in /v1/schema/{class}
to update the class properly.
E.g.
curl localhost:7070/v1/schema/MyClass > myclass.json
# edit file as desired
curl localhost:7070/v1/schema/MyClass -X PUT -H 'content-type: application/json' -d @myclass.json
Updating a class doesn't seem to work. When I try the following curl:
curl \
-X PUT \
-H "Content-Type: application/json" \
-d '{
"class": "MyClass",
"description": "My class"
}' \
http://localhost:7070/v1/schema/MyClass
it throws an error:
properties cannot be updated through updating the class. Use the add property feature (e.g. \"POST /v1/schema/{className}/properties\") to add additional properties
though I don't provide any properties.
FWIW, I contacted DigitalOcean, and it seems that the issue is on their side. They're currently working on a fix.
It would be great to have the possibility to update a class as currently it seems there is no way to do it.