ericclemmons
Repos
205
Followers
948
Following
22

Faster, route-centric development for Node.js apps with built-in Hot Module Replacement.

285
5

Static site generator powered by TypeScript, MDX, & React.

48
2

Simple recording & replaying of HTTP requests for predictable development & testing.

96
4

Speed up development by automatically installing & saving dependencies with Webpack.

1440
70

Async rendering & data-fetching for universal React applications.

1657
51

Events

Created at 2 days ago
ericclemmons create branch main
Created at 2 days ago
create repository
ericclemmons create repository
Created at 2 days ago
Created at 2 days ago
Created at 3 days ago
started
Created at 4 days ago
Created at 6 days ago
issue comment
Runtime Error Endpoint is a 404

I have the same issue - everything "works", but any uncaught error on the page gets sent here.

For example:

{"message":"ResizeObserver loop limit exceeded","source":"http://localhost:6006/iframe.html?viewMode=story&id=payments-experience--live","line":0,"column":0,"error":null,"origin":"preview"}
Created at 6 days ago
pull request opened
Fix StorybookTestRunnerError – length on undefined

When running yarn test-storybook on my story, a 3rd party library throws an uncaught exception, but StorybookTestRunnerError assumes logs is an array, which throws this error:

UnhandledPromiseRejectionWarning: page.evaluate: TypeError: Cannot read properties of undefined (reading 'length')
    at new StorybookTestRunnerError (<anonymous>:58:34)
    at __throwError (<anonymous>:71:15)
    at eval (eval at evaluate (:192:30), <anonymous>:4:19)
    at UtilityScript.evaluate (<anonymous>:194:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)

This PR simply defaults logs to [], so I can correctly see that the underlying error is actually coming from a 3rd party library:

 Cannot read properties of null (reading 'focus')
Created at 1 week ago

Fix StorybookTestRunnerError – length on undefined

When running yarn test-storybook on my story, a 3rd party library throws an uncaught exception, but StorybookTestRunnerError assumes logs is an array, which throws this error:

UnhandledPromiseRejectionWarning: page.evaluate: TypeError: Cannot read properties of undefined (reading 'length')
    at new StorybookTestRunnerError (<anonymous>:58:34)
    at __throwError (<anonymous>:71:15)
    at eval (eval at evaluate (:192:30), <anonymous>:4:19)
    at UtilityScript.evaluate (<anonymous>:194:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)

This PR simply defaults logs to [], so I can correctly see that the underlying error is actually coming from a 3rd party library:

 Cannot read properties of null (reading 'focus')
Created at 1 week ago
Created at 2 weeks ago
issue comment
Support multiple targets in the editor

I just ran into this issue as well, where my machine had target: [...] like OPs but the visualizer rewrote it in VS Code to a single target: '...'.

Created at 3 weeks ago
started
Created at 3 weeks ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
opened issue
Sidebar is too large & not collapsible

Expected Result

  • [ ] Collapsed by default
  • [ ] Collapsible like stately editor
  • [ ] (Or re-use stately editor 🙏)

Something like this: Screen Shot 2022-08-19 at 10 25 34 AM

Actual Result

Screen Shot 2022-08-19 at 10 22 13 AM

Reproduction

Using https://github.com/simeonc/storybook-xstate-addon

Additional context

Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
[Bug] Missing shadow dom

I just ran into this issue and, with interactions, this is how I'm working around it:

MyThing.play = async ({args, canvasElement}) => {
  const wc = canvasElement.querySelector(
    'my-thing',
  ) as HTMLElement;

  // Wait for Shadow DOM to be mounted & `open`
  const root = await waitFor(
    () => (wc.shadowRoot as ShadowRoot).firstElementChild as HTMLElement,
    {
      timeout: 5000,
    },
  );

  ...
};

Perhaps this could be documented away?

Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago