No, for now only the 5.x dev version is compatible with amphp 3. You can use this:

"amphp/http-client": "^5.0@dev",

Minagoroshi

Automatically re-download changed files

Add rei 2019.4.4 to build scripts

Update readme.md

Fix checksum specific sharedassets using assets from wrong folder

ignore lastModified.json file

Add Higurashi Rei Mac to buiild scripts

Update documentation link

Revert "Add Higurashi Rei Mac to buiild scripts"

This reverts commit 50cd94327950a714f0b8d250f56e12c436e9fa8c.

Update Readme.md

Add support for extracting a specific character's dialogue

Bump inflector version

Add proper fonts for rei

• Generated using new Rei font instructions
• Font Size: 26pt
• Used font file PTSans+MS-PGothic.ttf
• Used SDF32
• See https://github.com/07th-mod/higurashi-rei/issues/5#issuecomment-1364560588

Use class instead of string for BuildVariants

Add option for installer translation output format

Update Readme.md

Replace images

Update texts

Update texts

Revert json changes

Add translations

I'm aware but I'd still like to see an option to suppress it.

Unfortunately your idea isn't good enough for me so I won't spend time on implementing it. I'm forced to decorate the extractor to ignore the src directory no matter if your idea is implemented or not.

@nicolas-grekas I tried your way by changing PhpExtractor like this:

    public function extract($resource, MessageCatalogue $catalog)
    {
        $files = $this->extractFiles($resource);
        foreach ($files as $file) {
            $contents = file_get_contents($file);
            if (strpos($contents, 'trans') !== false) {
                $this->parseTokens(token_get_all($contents), $catalog, $file);

                gc_mem_caches();
            }
        }
    }

Current implementation: 302 seconds Your idea: 62 seconds Removal of /src: 5 seconds

While your idea does provide significant improvement it's still nowhere near fast enough.

That said I believe that in my case the main issue is the sheer number of files in /src directory. The project is large and only a few files are using translations.

The CreateTicketComment method is trying to load the response from Zendesk back into the TicketComment struct. However the response of the endpoint had a completely different structure which I'm sharing below.

This means that the returned struct is always a zero-value and doesn't contain the data of the newly created comment.

The data of the comment are in the struct under ticket.audit.events[0].

{
  "ticket": {
    "url": "https://<redacted>.zendesk.com/api/v2/tickets/2.json",
    "id": 2,
    "external_id": null,
    "via": {
      "channel": "email",
      "source": {
        "from": {
          "address": "enumag@gmail.com",
          "name": "Enumag"
        },
        "to": {
          "name": "<redacted>",
          "address": "<redacted>"
        },
        "rel": null
      }
    },
    "created_at": "2023-03-02T12:02:32Z",
    "updated_at": "2023-03-08T14:37:57Z",
    "type": null,
    "subject": "testing ticket",
    "raw_subject": "testing ticket",
    "description": "new testing ticket",
    "priority": null,
    "status": "new",
    "recipient": "<redacted>",
    "requester_id": 13408217713553,
    "submitter_id": 13408217713553,
    "assignee_id": null,
    "organization_id": null,
    "group_id": null,
    "collaborator_ids": [],
    "follower_ids": [],
    "email_cc_ids": [],
    "forum_topic_id": null,
    "problem_id": null,
    "has_incidents": false,
    "is_public": true,
    "due_at": null,
    "tags": [],
    "custom_fields": [
      {
        "id": 13571382524561,
        "value": null
      },
      {
        "id": 13571427625617,
        "value": null
      },
      {
        "id": 13571382547345,
        "value": null
      }
    ],
    "satisfaction_rating": null,
    "sharing_agreement_ids": [],
    "custom_status_id": 12333265000209,
    "fields": [
      {
        "id": 13571382524561,
        "value": null
      },
      {
        "id": 13571427625617,
        "value": null
      },
      {
        "id": 13571382547345,
        "value": null
      }
    ],
    "followup_ids": [],
    "ticket_form_id": 12333269809169,
    "brand_id": 12333264969745,
    "allow_channelback": false,
    "allow_attachments": true,
    "from_messaging_channel": false
  },
  "audit": {
    "id": 13577164093841,
    "ticket_id": 2,
    "created_at": "2023-03-08T14:37:57Z",
    "author_id": 12333884012433,
    "metadata": {
      "system": {
        "client": "Apache-HttpClient/4.5.13 (Java/17.0.5)",
        "ip_address": "<redacted>",
        "location": "<redacted>",
        "latitude": 0,
        "longitude": 0
      },
      "custom": {}
    },
    "events": [
      {
        "id": 13577135544337,
        "type": "Comment",
        "author_id": 12333884012433,
        "body": "Lorem Ipsum Dolor Sit Amet",
        "html_body": "<div class=\"zd-comment\" dir=\"auto\"><p dir=\"auto\">Lorem Ipsum Dolor Sit Amet</p></div>",
        "plain_body": "Lorem Ipsum Dolor Sit Amet",
        "public": true,
        "attachments": [],
        "audit_id": 13577164093841
      },
      {
        "id": 13577135545105,
        "type": "WebhookEvent",
        "via": {
          "channel": "rule",
          "source": {
            "from": {
              "deleted": false,
              "title": "Spaceflow Add Comment Webhook",
              "id": 13571419878673,
              "revision_id": 6
            },
            "rel": "trigger"
          }
        }
      },
      {
        "id": 13577164095633,
        "type": "Notification",
        "via": {
          "channel": "rule",
          "source": {
            "from": {
              "deleted": false,
              "title": "Notify requester and CCs of comment update",
              "id": 12333296041361,
              "revision_id": 1
            },
            "rel": "trigger"
          }
        },
        "subject": "[{{ticket.account}}] Re: {{ticket.title}}",
        "body": "{{ticket.latest_comment_html}}",
        "recipients": [
          13408217713553
        ]
      }
    ],
    "via": {
      "channel": "api",
      "source": {
        "from": {},
        "to": {
          "name": "Enumag",
          "address": "enumag@gmail.com"
        },
        "rel": null
      }
    }
  }
}

@arderyp see https://github.com/easy-coding-standard/easy-coding-standard/pull/58

Description

Recently I'm unable to play multiple videos at the same time - such as multiple youtube videos, multiple twitch streams or a combination. It worked before because often I had a muted stream on one monitor while watching youtube on the other.

Steps to Reproduce

1. Open a random twitch stream in one Brave window
2. Open a random youtube video in another brave window
3. Both videos need to be in the selected tab of their respective window.

Actual result:

The twitch stream immediately stops and neither video runs. As soon as I pause one of them or make it inactive by opening a new tab the other will work again.

Expected result:

Both videos should run at the same time.

Reproduces how often:

Happens every time for me.

Brave version (brave://version info)

Brave | 1.48.171 Chromium: 110.0.5481.177 (Official Build) (64-bit) Revision | f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239} OS | Windows 11 Version 22H2 (Build 22621.1265)

Version/Channel Information:

Happens on current stable. Didn't try other channels yet.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? Unsure

Anyone else experiencing this?

@cleptric Thanks but I already found that before creating the issue. The https://docs.sentry.io/platforms/go/serverless/#source-context only contains an example how to add in my own sources but not how to make sentry correctly locate package sources.

Summary

I successfully set up Sentry for my project and can see the errors there including stack traces. However while for my own code I can click and show a piece of the code around the line, the same isn't possible for the stack trace lines that point to a package - the first 7 lines in the screenshot are missing the toggling arrow on the right.

Is it possible to setup sentry in a way that the source code from packages would be available there?

Motivation

It would help understanding the context of the error.

@kcq As someone who started learning Go just a few weeks ago I was looking looking for some examples how to write Go lang applications and structure my code. So of course I stumbled on your repository which at first glance for a Go noob looks seems a well-documented example what a typical Go application looks like. But it was also very confusing because there are so many directories I was overwhelmed. Most of it is way more complicated than what I needed for a well organized but still simple example web application. Only after several hours of trying to understand things I noticed that this repository has a suspiciously high number of issues and ultimately found this one.

I lost several hours of my life because you're selling your highly opinionated and overcomplicated approach as some sort of Go community standard. This repository is actively harming the Go community and especially people like myself who are just starting with Go and aren't able to immediately determine that there is something wrong here. Please consider renaming the organization or moving the repository elsewhere to avoid this confusion. Thank you.

@nicolas-grekas I don't have a way to easily check the bottleneck since blackfire.io removed the free tier.

@welcoMattic Ah I see. Yeah I'm pretty sure those wouldn't be discovered in and kinda make the inclusion of /src necessary. That said anynone concerned with performance of these commands would likely want to disable it anyway and configure the paths where this function is used in their project manually. So I still think there should be an option to disable this behavior even if it stays enabled by default.