edify42
Repos
73
Followers
3
Following
3

Alpine Linux Python with PyOTP library configured

1
0

created for a friend, i use github only i swear!

0
0

Golang written app to store my file hashes of my camera photos!

0
0

Takes your OTP secret in and spits out the 6 digit OTP code

1
0

my personal blog page

0
0

StackJanitor is a serverless, event-driven stack cleanup tool.

36
2

Events

issue comment
Feature request to allow additional VPC's added to private networking of EKS API server.

Whenever EKS is setup, an AWS managed ENI is added to the selected VPC.

I can see 2 ways to solve the possibility of allowing multiple VPCs connecting to a single EKS master:

  1. Additional VPC + subnet dropdown when creating/updating the EKS cluster. This will add a new ENI per target VPC. The API server should have the routing updated on the AWS end to route requests accordingly depending on the target IP/CIDR range
  2. Allow users to modify the EKS control plane / API server route mechanism (simple add / subtract of route rules) to go through the chosen ENI of the single VPC. This would mean that when the request lands in the VPC, as long as the right route tables / peering is setup, the request should forward to the correct node.

Right now without this, we can register nodes in other VPCs and have pods scheduled to those nodes, but we cannot do kubectl API operations which must originate from the API server (i.e. kubectl logs|exec)

I'd be happy with either option -> Please prioritise AWS :pray:

Created at 3 weeks ago
exec_auth.ts getCredential function mutates entire nodejs process.env when run

Describe the bug The exec.env adds all the environment variables passed in through the KUBECONFIG to the process.env global variable.

For our usage, it introduces a race condition depending on when the call to the k8s API client occurs.

e.g. the KUBECONFIG users block below changes the entire nodejs process env:

users:
- name: arn:aws:eks:us-east-2:702880000000:cluster/our-cluster  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - --region
      - ap-southeast-2
      - eks
      - get-token
      - --cluster-name
      - our-cluster
      command: aws
      env:
        - name: teddy
          value: testing

It's not really necessary to do this, instead we can pass a copy of the process.env with the appended env array from the KUBECONFIG to the child_process.

** Client Version ** e.g. 0.18.0

** Server Version ** e.g. 1.23.0

To Reproduce Steps to reproduce the behavior:

Run the code with the env specified in the KUBECONFIG:

...
const k8sApi = kc.makeApiClient(k8s.CoreV1Api);
console.log(`how come ${process.env.teddy} is not set?`)
const nodes = await k8sApi.listNode();
console.log(`how come ${process.env.teddy} is set?`)

Expected behavior Entire process.env should not be mutated (unknowingly depending on what is stored in env of the KUBECONFIG).

Environment (please complete the following information):

  • OS: Debian Linux
  • NodeJS Version 16/18
Created at 1 month ago
exec_auth.ts getCredential function mutates entire nodejs process.env when run

Fixed pending release/publish of new version -> https://github.com/kubernetes-client/javascript/pull/955

Created at 1 month ago
Copy the nodejs process.env rather than mutate the global state

@brendandburns failed CI prettier check which I've just changed

Created at 1 month ago

lint/prettier bug!

Signed-off-by: edward kim edward.kim@lendi.com.au

Created at 1 month ago
pull request opened
Copy the nodejs process.env rather than mutate the global state

Quick change which fixes the issue I just raised around modifying the global process.env state https://github.com/kubernetes-client/javascript/issues/954

Created at 1 month ago
exec_auth.ts getCredential function mutates entire nodejs process.env when run

Describe the bug The exec.env adds all the environment variables passed in through the KUBECONFIG to the process.env global variable.

For our usage, it introduces a race condition depending on when the call to the k8s API client occurs.

e.g. the KUBECONFIG users block below changes the entire nodejs process env:

users:
- name: arn:aws:eks:us-east-2:702880000000:cluster/our-cluster  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - --region
      - ap-southeast-2
      - eks
      - get-token
      - --cluster-name
      - our-cluster
      command: aws
      env:
        - name: teddy
          value: testing

It's not really necessary to do this, instead we can pass a copy of the process.env with the appended env array from the KUBECONFIG to the child_process.

** Client Version ** e.g. 0.18.0

** Server Version ** e.g. 1.23.0

To Reproduce Steps to reproduce the behavior:

Run the code with the env specified in the KUBECONFIG:

...
const k8sApi = kc.makeApiClient(k8s.CoreV1Api);
console.log(`how come ${process.env.teddy} is not set?`)
const nodes = await k8sApi.listNode();
console.log(`how come ${process.env.teddy} is set?`)

Expected behavior Entire process.env should not be mutated (unknowingly depending on what is stored in env of the KUBECONFIG).

Environment (please complete the following information):

  • OS: Debian Linux
  • NodeJS Version 16/18
Created at 1 month ago

take a copy of the environment and don't actually mutate it

Signed-off-by: edward kim edward.kim@lendi.com.au

Created at 1 month ago
Created at 1 month ago