eKoopmans
Repos
23
Followers
161

Client-side HTML-to-PDF rendering using pure JS.

3013
1198

Visual PDF comparison tool.

Synchronises batches of git repositories

0
0

Panel of 3D flippable tiles that turn when moused over.

Easy-to-use web proxy using YQL (Yahoo! Query Language).

Screenshots with JavaScript

98
478

Events

Updating Visual Diff Goldens for Branch main

Yep, changes look good, thanks @oelhanafey!

Created at 3 days ago
create branch
eKoopmans create branch ekoopmans/selection-header-cleanup
Created at 4 days ago

feat: Rename selection headers to controls (#3224)

Created at 4 days ago
delete branch
eKoopmans delete branch ekoopmans/rename-headers
Created at 4 days ago
pull request closed
feat: Rename selection headers to controls

This PR begins the process of renaming d2l-selection-header, d2l-list-header, and d2l-table-header to d2l-*-controls. This is primarily being done because for tables, the "header" language is confusing.

There are three pieces left in that will need to be cleaned up:

  1. list-header.js, which now just duplicates list-controls.js to create <d2l-list-header>
  2. --d2l-list-header-background-color
  3. slot="header" on <d2l-list>

The next steps will be:

  1. Update imports on documentation for Daylight
  2. Switch all consumers of d2l-list-header to d2l-list-controls (fortunately, selection-header and table-header aren't used anywhere externally yet)
  3. Remove cleanup code above

Rally: https://rally1.rallydev.com/#/?detail=/userstory/673800144323&fdp=true

Created at 4 days ago

Fix Lit duplicate class usage

Rename affected visual-diff goldens

Created at 4 days ago
issue comment
Updating Visual Diff Goldens for PR 3224

Visual-diff flake: d2l-list nested all-selected

Created at 4 days ago
issue comment
feat: Rename selection headers to controls

@dlockhart Yeah I should have done that - the visual-diff PR showed mostly "moved" files, but two showed up as delete + new. I spent a while comparing them to make sure there was no change.

Do you think I should go back and just rename the files, and force-push over this? I'm happy to if you think that would be better.

Created at 4 days ago

Fix Lit duplicate class usage

Created at 4 days ago

Updating Visual Diff Goldens (#3225)

Co-authored-by: github-actions github-actions@github.com

Created at 4 days ago
delete branch
eKoopmans delete branch ghworkflow/visual-diff-pr-3224
Created at 4 days ago
pull request closed
Updating Visual Diff Goldens for PR 3224

This pull request updates the visual-diff golden images for the changes in pull request #3224.

Please review the following failed reports closely before merging to ensure the visual differences are expected.

Failed Reports:

Created at 4 days ago
pull request opened
feat: Rename selection headers to controls

This PR begins the process of renaming d2l-selection-header, d2l-list-header, and d2l-table-header to d2l-*-controls. This is primarily being done because for tables, the "header" language is confusing.

There are three pieces left in that will need to be cleaned up:

  1. list-header.js, which now just duplicates list-controls.js to create <d2l-list-header>
  2. --d2l-list-header-background-color
  3. slot="header" on <d2l-list>

The next steps will be:

  1. Update imports on documentation for Daylight
  2. Switch all consumers of d2l-list-header to d2l-list-controls (fortunately, selection-header and table-header aren't used anywhere externally yet)
  3. Remove cleanup code above

Rally: https://rally1.rallydev.com/#/?detail=/userstory/673800144323&fdp=true

Created at 4 days ago
create branch
eKoopmans create branch ekoopmans/rename-headers
Created at 4 days ago
eKoopmans delete branch ekoopmans/fix-github-script
Created at 5 days ago

fix: github-script usage after upgrade to v6 (#21)

Created at 5 days ago
pull request closed
fix: github-script usage after upgrade to v6

Following https://github.com/BrightspaceUI/core/pull/3222, I checked this repo for any usages of third-party-actions@actions/github-script that might be affected by yesterday's move to v6 and the resulting Octokit API change.

It looks like the Backport action is affected, so I've fixed it here. I don't have an easy way of testing this, but the changes should be correct. I could put a post on #web-platform for consumers to watch out next time they backport for any issues...

Created at 5 days ago
fix: github-script usage after upgrade to v6

Gotcha, thanks @omsmith!

Created at 5 days ago
fix: github-script usage after upgrade to v6

@Scy-D2L I also noticed on Line 31, it looks like the uses: Brightspace/third-party-actions@actions/github-script isn't necessary - does that sound right? Doesn't look like it's using the Octokit SDK in that code snippet.

Created at 5 days ago
pull request opened
fix: github-script usage after upgrade to v6

Following https://github.com/BrightspaceUI/core/pull/3222, I checked this repo for any usages of third-party-actions@actions/github-script that might be affected by yesterday's move to Octokit v6 and the resulting API change.

It looks like the Backport action is affected, so I've fixed it here. I don't have an easy way of testing this, but the changes should be correct. I could put a post on #web-platform for consumers to watch out next time they backport for any issues...

Created at 5 days ago
eKoopmans create branch ekoopmans/fix-github-script
Created at 5 days ago

fix: github-script usage after upgrade to v6 (#3222)

Created at 5 days ago
delete branch
eKoopmans delete branch ekoopmans/fix-github-script
Created at 5 days ago
pull request closed
fix: github-script usage after upgrade to v6

This PR should fix the PR previews! They've started failing because third-party-actions@actions/github-script was upgraded yesterday to v6 (from v3), and the Octokit API moved a lot of commands e.g. github.issues to github.rest.issues.

Created at 5 days ago
pull request opened
fix: github-script usage after upgrade to v6

This PR should fix the PR previews! They've started failing because third-party-actions@actions/github-script was upgraded yesterday to v6 (from v3), and the Octokit API moved a lot of commands e.g. github.issues to github.rest.issues.

Created at 5 days ago
create branch
eKoopmans create branch ekoopmans/fix-github-script
Created at 5 days ago