Not sure to get the reason of the remaining failures 🤔 I started to check on jenkins side but I don't exactly get the reason of the failure and the link to the current change.

Je te confirme rapidement ma dispo, je dois encore book un billet de train pour monter à Paris.

Hey @bloodyowl, any update?

⬆️ Update dependency typescript to ^4.9.5 (#529)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | typescript (source) | ^4.9.4 -> ^4.9.5 | | | | |

Release Notes

v4.9.5: TypeScript 4.9.5

Compare Source

For release notes, check out the release announcement.

Downloads are available on:

• npm
• NuGet package

Changes:

• 69e88ef Port ignore deprecations to 4.9 (#​52419)
• daf4e81 Port timestamp fix to 4.9 (#​52426)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

⬆️ Update typescript-eslint monorepo to ^5.50.0 (#3599)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @typescript-eslint/eslint-plugin | ^5.49.0 -> ^5.50.0 | | | | | | @typescript-eslint/parser | ^5.49.0 -> ^5.50.0 | | | | |

Release Notes

v5.50.0

Compare Source

Bug Fixes

• eslint-plugin: [ban-ts-comment] counts graphemes instead of String.prototype.length (#​5704) (09d57ce)
• eslint-plugin: [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors (#​6028) (85e783c)
• eslint-plugin: [prefer-optional-chain] fixer produces wrong logic (#​5919) (b0f6c8e), closes #​1438

Features

• eslint-plugin: add key-spacing rule extension for interface & type declarations (#​6211) (67706e7)

v5.50.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

⬆️ Update dependency @microsoft/api-extractor to ^7.34.2 (#3600)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @microsoft/api-extractor (source) | ^7.34.1 -> ^7.34.2 | | | | |

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

⬆️ Update dependency rollup to ^3.12.1 (#3601)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | rollup (source) | ^3.12.0 -> ^3.12.1 | | | | |

Release Notes

v3.12.1

Compare Source

2023-02-01

Bug Fixes

• Handle self-references in class static blocks and construtors when the class is renamed (#​4827)
• Improve warnings when creating circular chunks taht reexport variables (#​4829)

Pull Requests

• #​4827: fix: use the original class name in the class body (@​TrickyPi)
• #​4829: Improve and fix cross-chunk-reexport warning (@​lukastaegert)
• #​4830: Add Algolia doc search (@​lukastaegert)
• #​4831: Add warning not to add assets directly to the bundle (@​lukastaegert)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

⬆️ Update dependency @npmcli/arborist to v6.2.1 (#3603)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | @npmcli/arborist | 6.2.0 -> 6.2.1 | | | | |

Release Notes

v6.2.1

Compare Source

Bug Fixes

• 72a7a59 #​6095 only save package-lock when truly finished (@​wraithgar)

Dependencies

• 721fe3f #​6118 read-package-json-fast@3.0.2
• 6e4a649 pacote@15.0.8
• 1820afe cacache@17.0.4
• 4b8046e @npmcli/name-from-folder@2.0.0
• 1d4be7a @npmcli/map-workspaces@3.0.1
• a39556f @npmcli/template-oss@4.11.3

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Update test/parallel/test-vm-global-symbol.js

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com

Yes definitely I will

Adding missing is_contextual_store||check

Merge branch 'fix-global-access-issue' of https://github.com/dubzzz/node into fix-global-access-issue

This PR makes test/parallel/test-repl-underscore fail

I'll rework it to make sure this test passes too. I may have missed one condition in the code I added.

Update test/parallel/test-vm-global-symbol.js

Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com

Normally everything should be good now. As suggested by @aduh95, I force-pushed on my original commit to fix the commit message. Only changes made since the original commit (before force-push) are: edit commit message and fix lint on the new test file.

vm: properly support symbols on globals

A regression has been introduced in node 18.2.0, it makes the following snippet fails while it used to work in the past:

const assert = require('assert');
const vm = require('vm');
const global = vm.runInContext('this', vm.createContext());
const totoSymbol = Symbol.for('toto');
Object.defineProperty(global, totoSymbol, {
  enumerable: true,
  writable: true,
  value: 4,
  configurable: true,
});
assert(Object.getOwnPropertySymbols(global).includes(totoSymbol));

Regression introduced by: https://github.com/nodejs/node/pull/42963. So I basically attempted to start understanding what it changed to make it fix the initial issue while not breaking the symbol related one.

Fixes: https://github.com/nodejs/node/issues/45983

Perfect, I'll adapt the commit message of the first commit and force push on the PR then. Will try to run the lint on commit message locally before pushing again

fix lint

I'll rework the commit message to fit the guidelines. Do I need to change the commit in-place and force push or can I push an extra commit on top of it?

Regarding to the regression posted recently, I opened a PR to fix it. Here is the fix I suggest: https://github.com/nodejs/node/pull/46458