dsp
Repos
61
Followers
387
Following
15

Events

push

Fix a bug in schema processing

Summary: In typecheckSchema we were calling checkStored on all the predicates in the environment, but using the type environment from the current schema only. So if any types were removed or changed, we would get an error.

The fix is to not do checkStored on predicates that were already in the tcEnv, because those have been checked already.

Reviewed By: pepeiborra

Differential Revision: D37786898

fbshipit-source-id: 50af80439b07a03231fd066cab619a917f555b5a

buck find-references (#215)

Summary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/215

enable find-references for buck

Reviewed By: donsbot

Differential Revision: D37632073

fbshipit-source-id: 451d6f7cd28e2a50f955dfde489a4a8881fc7bf7

Use cached schemas when opening a DB

Summary: Starting to reap the benefits of hashing schemas: when opening a DB, if the DB contains a schema that is also in our current schema index, then we can use the cached ProcessedSchema and we don't have to parse/resolve/etc. the DB schema.

Reviewed By: pepeiborra

Differential Revision: D37713113

fbshipit-source-id: ef4dd22ff2aecb1e42a142e9b386910eccfda0e6

add tests for shards published (#216)

Summary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/216

New tests to make sure the set of published shards doesn't change accidentally

Reviewed By: simonmar

Differential Revision: D37755747

fbshipit-source-id: 20384ff3c837af712de25de2ba538adee95032bc

Add a callstack to UnknownDatabase exceptions

Summary: malanka noticed that we are getting UnknownDatabase errors in Production that arise after deleting a DB. It's almost certain that they are being raised by Catalog.getEntry, but there are >50 transitive call sites which makes guessing a bit hard.

This diff adds a very simple rendered call stack to the UnknownDatabase exception, which will be included in the server exception logs.

Reviewed By: simonmar

Differential Revision: D37754521

fbshipit-source-id: acd613f5b9a92082048237f8082910b4f1d6b6c9

Retire cxx1.3 and related schemas

Summary: Original commit changeset: 547c7e5c009f

Original Phabricator Diff: D37787118 (https://github.com/facebookincubator/Glean/commit/33c3f32d86ad264781927c4d45f006efe6148957)

Reviewed By: bochko

Differential Revision: D37817883

fbshipit-source-id: 9651c37d5b4dab025f96ec93c5e37a18e3e53f53

Add more to the roadmap

Reviewed By: pepeiborra

Differential Revision: D37814364

fbshipit-source-id: f5ecff9cbbbc9f3599cff4a18770b31ff9f525d6

Don't search the same repo multiple times (#217)

Summary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/217

Reviewed By: donsbot

Differential Revision: D37812773

Pulled By: simonmar

fbshipit-source-id: e657c9662d5e31e163ab489bdaf262b877a333a6

Relax validation check when use_schema_id is enabled

Reviewed By: nhawkes

Differential Revision: D37850827

fbshipit-source-id: b954322fbc8bbc37f1e1e85760b0aa7c479a370e

Run gen-schema once, not twice

Summary: Just saves a bit of build time

Reviewed By: malanka

Differential Revision: D37781671

fbshipit-source-id: cd12d55881232d8e0256f658736b7d63af308658

Abstract the loggers from glean/db (#219)

Summary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/219

Reviewed By: malanka

Differential Revision: D37823434

fbshipit-source-id: fed6beea456142c797b57b7a97a8807242600e21

Use a NullConfigProvider for tests

Summary: After the preceding diff, we can now abstract glean/db over the ConfigProvider, and in tests we can instantiate it with a NullConfigProvider that always fails. This has two benefits:

  • avoid accidentially depending on config values from the environment
  • reduce the dependencies

Reviewed By: nhawkes

Differential Revision: D37853058

fbshipit-source-id: d25a0463d7d75583825b5fadc4939259a2ef81f4

Remove useless namespace rust directives in Thrift files

Summary:

Why

namespace rust directives in Thrift files have no effect on the generated code and can be misleading. Therefore we should remove them.

What this diff does

This diff removes most of these from existing Thrift files in fbcode, except for the generated files.

hg grep -l "^namespace rust " | grep "thrift$" | xargs grep -L "generated" | xargs sed -i "/^namespace rust /d"

(Manually reverted a few files, e.g. some of the Thrift fixtures.)

Reviewed By: demosdemon

Differential Revision: D37889844

fbshipit-source-id: 337231401a64a53744c5c3fd9137abc6cfeaa817

extract all other options for write command as separate functions

Summary: Extract some more options as separate functions. So it is easier later to improve 'glean write --help' and 'glean create --help'

Reviewed By: simonmar

Differential Revision: D37720810

fbshipit-source-id: c2f2fc22aabc549e86ace92bd16471bf9a39c5d4

Extract even more command line options as separate functions for 'glean write'/'glean create'

Reviewed By: simonmar

Differential Revision: D37757197

fbshipit-source-id: a62b9cfd65da82b11b5cf3ca00e67b4a8d0ea50f

extract unitsReader for includeOpts and excludeOpts for glean write

Reviewed By: simonmar

Differential Revision: D37757956

fbshipit-source-id: daaae5f9daf26b586c07d7acdfdb63dccaa66ef7

add --schema-id option to deriver

Summary: This option displays the schema-id used by the deriver.

See https://fb.workplace.com/groups/csi.wtf/permalink/5285287351547888/ for motivation

Reviewed By: simonmar

Differential Revision: D37887533

fbshipit-source-id: fb166e1bf1823656247b140087fd12c940d83ca4

Improve help by adding more information for 'glean write' and 'glean create' commands

Reviewed By: simonmar

Differential Revision: D37759584

fbshipit-source-id: 4a33f49d56c1180b64e9b0064c1a3ad6cd3118f6

Log all Glean dbs used in Glass search

Summary: We were only logging the first element of the NonEmpty set of gleandbs used to search. This makes debugging things harder, as we see results from N dbs, but only the first is mentioend in logs.

Log all.

Reviewed By: simonmar

Differential Revision: D37915922

fbshipit-source-id: 7f752d0b16b4825637e3e088737586c51eb6bc33

Refactor searchEntityByString

Summary: One pass over to simplify things.

  • don't recompute symbol ids in the inner and outer passes
  • use a type to process the search results

A bit clearer what is going on now, but still not 100% clear

I'd like to figure out a way to test x-repo symbol ids too, to at least specify what we're trying to do here.

Reviewed By: simonmar

Differential Revision: D37916022

fbshipit-source-id: e94e45041a93c12ac1233a4c6501911958f1a3c7

Created at 1 month ago
opened issue
pgadmin4 failed to install on unstable

Describe the bug

Adding pgadmin4 to /etc/nixos/configuration.nix and then nixos-rebuild switch leads to

ERROR: Could not find a version that satisfies the requirement Authlib==0.15.* (from pgadmin4) (from versions: none)
ERROR: No matching distribution found for Authlib==0.15.*

error: builder for '/nix/store/s2ifwkzjz4bxqrxcy2ihdzyyrvqvkcr2-pgadmin-6.11.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/10kwashq28akvs9acca6ap5h9k0zy8mw-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2i73wgryxbp8xr1apnmmjw3a022bw9wi-nixos-system-fw-22.11pre395754.2a93ea177c3.drv' failed to build

Steps To Reproduce

Steps to reproduce the behavior:

  1. Add pgadmin4 to environment.systemPackages in /etc/nixos/configuration.nix
  2. Run nixos-rebuild switch
  3. Fails with error

Expected behavior

NixOS derivation succeeds

Notify maintainers

@gador

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

dsp:~/⁞ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.06 MiB download, 0.30 MiB unpacked):
  /nix/store/a9f4h2yjhdlk7xj3wj3p7b5r6s659qfl-bash-interactive-5.1-p16-dev
copying path '/nix/store/a9f4h2yjhdlk7xj3wj3p7b5r6s659qfl-bash-interactive-5.1-p16-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.18.13, NixOS, 22.11 (Raccoon), 22.11pre395754.2a93ea177c3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - channels(root): `"nixos"`
 - channels(dsp): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
Created at 2 months ago
Created at 2 months ago
issue comment
haskellPackages: Use proper absolute path in haskell builds

@cdepillabout wow! Thank you so much. This is a good start and one of the missing pieces. Really appreciated! I'll go and play around with this!

Created at 2 months ago
issue comment
haskellPackages: Use proper absolute path in haskell builds

@cdepillabout Sorry, I don't have a derivation. I tried setting up a flake file (current version here: https://gist.github.com/dsp/05dd9e3402bf4454f10e5ff7684c8b0b) to build Glean and HSThrift, but I wasn't able to get either callCabal2Nix or callPackage working due to the cabal version mismatch. When I use ghc8 packages and use callCabal2Nix it uses cabal 3.2 or 3.4 which fails to build. So I am not even sure how to get started building my own cabal with GHC8 in the build process.

Created at 2 months ago
issue comment
Use proper absolute path in haskell builds.

@cdepillabout: https://github.com/facebookincubator/hsthrift/ and https://github.com/facebookincubator/glean require Cabal 3.6 but GHC 8 (they specifically restrict usage of base >=4.15. I've tried building with cabal2nix but it fails since I cannot get use a cabal 3.6 and then underlying use a GHC 8 to compile with.

Created at 2 months ago
Provide make install

At the moment the Makefile does not provide a make install as it's customary for Makefiles. In particular, this would allow much easier packaging for most packaging systems (as they require install to a chroot before packaging). In addition, it helps to quickly move the right binaries to an easy accessible place.

Created at 2 months ago

autodeploy

Created at 2 months ago

blog post

drafts

Created at 2 months ago

autodeploy

Created at 2 months ago
push

Introduce subroutine activation records

Summary: This encapsulates some of the functionality needed to prepare and execute a Subroutine in the new Activation type. This is both cleaner and will allow more nice things further down the road. A slight benefit is that we can now write arguments directly into the frame rather than creating an intermediary vector.

This would be very easy to extend to allow subroutine calls from within bytecode if we have a use case for that.

Reviewed By: simonmar

Differential Revision: D37555822

fbshipit-source-id: bf54bdb12b3ae61f11316bb9dcfb325c879b7129

Change how suspending works

Summary: Previously, we were calling a function which recorded the state and then returning from the subroutine. Now, we update the Activation such that then next call to execute will resume the subroutine and return a status code from the evaluator which says whether the subroutine has been suspended. This means that we decouple serialisation/deserialisation of suspended subroutines (subsequent diffs) and can also be easily tweaked to support subrotuine calls from within the bytecode should we need that.

Note that this does not require a bytecode version bump as the implementation is both forwards and backwards compatible. This required leaving in the register which was used for passing in the saveState function for now. It is unused and will be removed later but I'd rather do all breaking changes in one go.

Reviewed By: simonmar

Differential Revision: D37602267

fbshipit-source-id: bf35f4566c80a71e1208ebd89fa89786fabe173e

Refactor serialisation of suspended queries

Summary: This just moves serialisation toSubroutineState into Activation. We should really do the same for deserialisation but I'll leave that for later.

Reviewed By: simonmar

Differential Revision: D37610654

fbshipit-source-id: cb22d751edab4db5fb0131ba07e8d20c5083e52d

extract repoTimeOpt as parser

Summary: Personally for me, the code of the function is too long and hard to follow. Also I get used to have all parameters specified somewhere at one place at the top of the file, so it is easier to edit and see. So I have started just extracting all parameters into separate functions at the top of the file

Reviewed By: simonmar

Differential Revision: D37682803

fbshipit-source-id: c634764596add6816f17a21610d20d67b8dd6dd5

move file options from common to wrtie.hs where is belongs

Summary: This 'fileArgs' is not common, it belongs only to write.hs. So I have moved it there.

And actually this was a main point why this entire stack of diff exists.

Reviewed By: simonmar

Differential Revision: D37682805

fbshipit-source-id: 1b7fcc643e4c0b327f93787b6d5dd0ecf0c56086

extract dbPropertiesOpt as parser

Reviewed By: simonmar

Differential Revision: D37682799

fbshipit-source-id: b1d064fb5965ba4a5f10cd504b258b26a8585760

glean write --inventory is deprecated, remove it

Reviewed By: pepeiborra

Differential Revision: D37715578

fbshipit-source-id: 86d61c960df3b0f9453dc12a44a5423eb95ab8bf

extract fileFormatOpt as parser

Reviewed By: pepeiborra

Differential Revision: D37682804

fbshipit-source-id: 9ee8a80975dff81eeb89fd15a7289ec89fec2bef

allow --file-format in the glean create command

Reviewed By: pepeiborra

Differential Revision: D37682802

fbshipit-source-id: 410a270d7d64bbbae99093d645cf74d580684eb0

extract finishOpt as parser

Reviewed By: pepeiborra

Differential Revision: D37682801

fbshipit-source-id: e3fff4ca97f6853dfbfddf30fa83465b2864d89e

update description of argumets for 'glean write' and 'glean create' commands

Reviewed By: pepeiborra

Differential Revision: D37682800

fbshipit-source-id: fb2c47823b023c7dfe81f1334e6a9bd23f23b3c1

Unset the expiring bit for DBs we want to keep

Summary: We want to handle the following scenario:

  1. Server starts up and finds a db A in the local storage
  2. Janitor kicks in with an incomplete shard assignment that doesn't include A, so A gets marked for expiry
  3. In the next Janitor run the shard assignment is extended with A, which gets added to the keep set

Before this Diff, 3 would be followed by: 4. After roughly 30m (the retention expire delay for glean.query.prod) the DB gets deleted. This is not what we want!

After this Diff, 4 will not happen. Moreover, we can drop the sleep when the shard assignment is empty, since there is basically no penalty for starting with an empty or incomplete shard assignment (assuming a long enough expire delay).

Reviewed By: malanka

Differential Revision: D37715592

fbshipit-source-id: 4ef9384a5e0cc12befab5424dd907bc4306bfc39

Support updating the schema in a stacked DB

Summary: We sometimes want to be able to use stacked DBs for testing derived predicates, but doing that safely is a bit tricky. The workflow will be

glean create --stacked <base> --repo <repo> --update-schema-for-stacked

To use the current schema in the stacked DB, instead of the schema from the base DB. This will fail if the current schema is incompatible; you can only add or remove predicates.

Reviewed By: pepeiborra

Differential Revision: D37648917

fbshipit-source-id: 5f1f6a7f60319de350426e1c49bb1534fd5dcbdc

Log DB open operations to Scuba

Summary: I want to monitor the performance of DB open when we switch to the new schema format.

Reviewed By: malanka

Differential Revision: D37685535

fbshipit-source-id: ced25714e373602a48acf201708afd23afec3f0a

Don't re-typecheck derived predicates

Summary: When we have multiple schema versions, we were re-typechecking all the derived predicates for each schema, rather than just the new ones.

Reviewed By: pepeiborra

Differential Revision: D37711681

fbshipit-source-id: bc5f5621b3262dab9969cd5f0a59c6999f46d934

getSchemaInfo: send the stored schema by default, instead of ""

Summary: If the client doesn't specify a SelectSchema when calling getSchemaInfo, I wrongly assumed Thrift would default to the first alternative, but actually it defaults to EMPTY, and in that case we were sending back "" as the schema source.

Reviewed By: malanka

Differential Revision: D37753349

fbshipit-source-id: 8fc1e6120b0f55e94793651a6903bcf8258eea58

Retire cxx1.3 and related schemas

Summary: See dependent diffs for removing the existing uses that I found

Reviewed By: malanka

Differential Revision: D37715765

fbshipit-source-id: daa06c9c0497c80bd50094fdeab6a324836c9e95

Shrink publish shards batching window

Summary: Having a 10s delay between glean create and the new DB being published seems excessive. Let's lower it to 1s

Reviewed By: simonmar

Differential Revision: D37779898

fbshipit-source-id: 2596dc7f0dd18e1b2af3af17bd4fcf5246b96945

extract publish shards helpers to a library

Summary: This is a pure refactoring, the next Diff includes new tests for shard publishing that use the new library

Reviewed By: simonmar

Differential Revision: D37755748

fbshipit-source-id: 1c350e0f74928d8b9e205c170a3b6c0b37a72b38

Back out "Retire cxx1.3 and related schemas"

Reviewed By: pepeiborra, malanka

Differential Revision: D37787118

fbshipit-source-id: 547c7e5c009ff3c5af97171a77404768befdc6e7

Created at 2 months ago
push

Add hsthrift as submodule

Created at 2 months ago
create branch
dsp create branch tested
Created at 2 months ago
fork
Created at 2 months ago
Add `install` to Makefile

Currently the Makefile has no install and cabal install glean glean-server glean-hyperlink fails. For packaging purposes it would be great to have a make install honoring a PREFIX env variable.

Created at 2 months ago

update

flake file

Created at 2 months ago
Add `install` to Makefile

Currently the Makefile has no install and cabal install glean glean-server glean-hyperlink fails. For packaging purposes it would be great to have a make install honoring a PREFIX env variable.

Created at 2 months ago
Undefined symbol setHighMemDynamic

When compiling hsthrift lib:thrift-server with GHC 8.8.4 (due to the requirement of base < 4.15), it fails with

Configuring library 'if-glean-hs' for glean-0.1.0.0..
Preprocessing library for thrift-server-0.1.0.0..
Building library for thrift-server-0.1.0.0..
[3 of 3] Compiling Thrift.Server.CppServer ( Thrift/Server/CppServer.hs, /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/thrift-server-0.1.0.0/build/Thrift/Server/CppServer.o )
Warning: 'hs-source-dirs: glean/if/search/gen-hs2' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/hs' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/thrift/gen-hs2' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/thrift/query/gen-hs2' directory does not exist.
Warning: 'hs-source-dirs: glean/if/search/gen-hs2' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/hs' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/thrift/gen-hs2' directory does not exist.
Warning: 'hs-source-dirs: glean/schema/thrift/query/gen-hs2' directory does not exist.
<command line>: /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/fb-util-0.1.0.0/build/libHSfb-util-0.1.0.0-inplace-ghc8.8.4.so: undefined symbol: setHighMemDynamic
Preprocessing library 'if-glean-hs' for glean-0.1.0.0..
Building library 'if-glean-hs' for glean-0.1.0.0..
Preprocessing library 'if-glean-cpp' for glean-0.1.0.0..
Building library 'if-glean-cpp' for glean-0.1.0.0..
[1 of 3] Compiling Glean.Types      ( glean/if/gen-hs2/Glean/Types.hs, /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/glean-0.1.0.0/l/if-glean-hs/build/if-glean-hs/Glean/Types.o )
[2 of 3] Compiling Glean.GleanService.Service ( glean/if/gen-hs2/Glean/GleanService/Service.hs, /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/glean-0.1.0.0/l/if-glean-hs/build/if-glean-hs/Glean/GleanService/Service.o )
[3 of 3] Compiling Glean.GleanService.Client ( glean/if/gen-hs2/Glean/GleanService/Client.hs, /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/glean-0.1.0.0/l/if-glean-hs/build/if-glean-hs/Glean/GleanService/Client.o )

Please note:

<command line>: /home/dsp/src/glean/dist-newstyle/build/x86_64-linux/ghc-8.8.4/fb-util-0.1.0.0/build/libHSfb-util-0.1.0.0-inplace-ghc8.8.4.so: undefined symbol: setHighMemDynamic

due to missing setHighMemDynamic, which seems to be defined in GHC RTS https://gitlab.haskell.org/ghc/ghc/-/commit/7a65f9e140906087273ce95f062775f18f6a708d. Looking at gitlab the function seems to first appear in GHC 9.2.X, released a year ago and not available in 8.8.4 RTS.

It seems to me that either hsthrift needs to be bumped to require 9.2.X or setHighMemDynamic needs to be removed. Maybe i am missunderstanding how i am supposed to build this, so please advice.

Created at 2 months ago
Undefined symbol setHighMemDynamic

Closed by #91

Created at 2 months ago
Fix builds on systems with RTLD_DEFAULT enabled

@pepeiborra I added the env variable to the github workflow.

Created at 2 months ago

github: Set LD_BIND_NOW to ensure strictly link at build time

Issue #88 and #90 describe that depending on system GHC can lazily link all symbols or strictly link them at link time. To ensure we consistently test that all the symbols in the binary are available, we need to set LD_BIND_NOW to a non empty string. This will force ld to resolv all symbols (see https://man7.org/linux/man-pages/man8/ld.so.8.html) at link time.

Created at 2 months ago
pull request opened
Fix builds on systems with RTLD_DEFAULT enabled

The following PR addresses various build issues that occur when GHC does load symbols strictly at build times. @exi's did an investigation in #90. GHC on NixOS is compiled with _GNU_SOURCE leading to dlsym using RTLD_DEFAULT, causing strict loading. For hsthrift his means various symbols cannot be found at compile time and error out.

With the following stack I am able to build it on NixOS, but have not tested it on any other platform just yet.

I want to highlight commit 83ed60e, since it moves Utils/Executor.cpp to cpp/Executor.cpp and I am not sure if that's okay.

The rest hopefully should be straight forward.

This is branch includes PR #89 and should cleanly rebase if needed.

Created at 2 months ago

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/fbthrift/commit/bda40b335f5adc69766a8a5211211cd7a982001b https://github.com/facebookincubator/velox/commit/40eb1efac952362d156d61e5f5eeb84b3435f093

Reviewed By: wittgenst

fbshipit-source-id: 9772ed9b112d6100a86a417beca0336448c097b3

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/fbthrift/commit/df7e1e3afa342f2b89f55fa9950ced9577441763 https://github.com/facebook/folly/commit/3c950270581e1712aa82a7dcaef789755ef9baf9

Reviewed By: wittgenst

fbshipit-source-id: 63ef6cc73cf66277a8e8eb5362831613694e5811

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/59c34546115152c1f8c97a2fc4d9dc7961cbd0e2 https://github.com/facebook/fb303/commit/fe9d060576b365351ac82b7ac0a56ae11727aa5f https://github.com/facebook/fbthrift/commit/3b9d90574a9f6758a911afcd85e48e9d4ee26d6d https://github.com/facebook/proxygen/commit/b3750ea60613dfd535b6758e8fa434831fe53d4b https://github.com/facebook/wangle/commit/49d8ca2c6463dde7f4f4a40d109315c0befd8928 https://github.com/facebook/watchman/commit/0787c4654466a7028e9f8c08ebbb67de43af49fd https://github.com/facebookexperimental/edencommon/commit/46e6c9a1087df39b91b5d7138de3d92f3485063c https://github.com/facebookexperimental/rust-shed/commit/6b5b0c341f1e67973df07b5cda93eec37eba1afa https://github.com/facebookincubator/fizz/commit/ecf3082698c5d11efd68e9232e8f615cc5fe08ec https://github.com/facebookincubator/katran/commit/ca83d053953e70b822c2812bcb719ac16dd4b38e https://github.com/facebookincubator/mvfst/commit/b95c842e4090fecd706fa71bd8ee3ea316959165 https://github.com/facebookincubator/velox/commit/e3d4754e78ccc269fdff0c207e7bc7e6221bb249 https://github.com/facebookresearch/beanmachine/commit/3e8c4b85d38c090591f3005d796d42186304ef27 https://github.com/pytorch/fbgemm/commit/56cd603d4889310db5e520a5f469306de19200b8

Reviewed By: wittgenst

fbshipit-source-id: 83b8136b88116e3f12bc67cbd36168e86d8cbe43

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/ed795e0ec64cfa607f6e3264d0b7e646193730d4 https://github.com/facebook/fb303/commit/5c779c2bf9dca3073f7ad09966e57f29bac54a3c https://github.com/facebook/fbthrift/commit/5e2d062d5aca61e61c65a9505a02180553d84b47 https://github.com/facebook/proxygen/commit/007bc28139178b2a05af9a5f589098ec3188ff02 https://github.com/facebook/wangle/commit/98cf0e472c8c7e4b17534eea7e865e129e460389 https://github.com/facebook/watchman/commit/db7e87f0285f5a7c556158eaf5c472d23e18a905 https://github.com/facebookexperimental/rust-shed/commit/eadb0af4c88a993b5b59469b23b6a66cdd73a711 https://github.com/facebookincubator/katran/commit/d0b32c86dd31270d715ac3573cc46a55504c82c8 https://github.com/facebookincubator/mvfst/commit/10691617b20a018b6fc7320c4cb5c28b1d89e915

Reviewed By: wittgenst

fbshipit-source-id: ec61f6466fc0a1a67fa50566e8851dde6a093017

improve build times on Ubuntu by using the system google logging package

Reviewed By: genevievehelsel

Differential Revision: D37230000

fbshipit-source-id: ba843b32364b77231d515a2f96bcce6b05a96586

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/143ad4a40605807b6163630285e19074c677608c https://github.com/facebook/fb303/commit/6d973417556f15e2a6466703d1032d82b35dab41 https://github.com/facebook/fbthrift/commit/49bbb9cbfb6f2ca9edc3a1580bba0ec9be463ff3 https://github.com/facebook/proxygen/commit/6087df4838dc0941435bf99b80b5893a702b87ea https://github.com/facebook/watchman/commit/36864bc24a679ff46115852b239f23c2be941d48 https://github.com/facebookexperimental/rust-shed/commit/92087e065497b6f363229086d15ee7d64fc4a97d

Reviewed By: wittgenst

fbshipit-source-id: 1bc2d0343f49c2c2bb75633a0a3ea825ee22c5bd

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/e2dee8c6b07ed97c4b7c0934824d41f3f0f7a536 https://github.com/facebook/fb303/commit/9fd7d73670f51c52f5cd01a3b8a28e3a854feea6 https://github.com/facebook/fbthrift/commit/96336a91426259fc8a0de9ca70cc888ea4c18652 https://github.com/facebook/folly/commit/e1ef30ccbf4a1fe9ffd13dd1cddd92033313c089 https://github.com/facebook/litho/commit/9d72d40cad5eda0ea0e10de6c835813180c601c1 https://github.com/facebook/proxygen/commit/aefbe56de44601caed6f92131d61579aab82e728 https://github.com/facebook/wangle/commit/aa8171e147206c095ddf2e72b424d20128063b28 https://github.com/facebook/watchman/commit/7cd4f87cd3b0aacfbd3d654c16c9ac65032d722a https://github.com/facebookexperimental/edencommon/commit/a11b9d82e17d700f0f0807497b010e3660414370 https://github.com/facebookexperimental/rust-shed/commit/56530a616eae728d6a0c73c3dd87f0d0a5250ec4 https://github.com/facebookincubator/fizz/commit/3243080a8ee16b5bd49806f6d314a617af940bad https://github.com/facebookincubator/katran/commit/332eb90896e68abdf844c00b5721be6a7501b373 https://github.com/facebookincubator/mvfst/commit/56d24855628e3cf75c77782f6d1c60af8c5f3d30 https://github.com/facebookincubator/velox/commit/db24118840d5028614b3f034c61e6d50f19b883c https://github.com/facebookresearch/multimodal/commit/56016ef51e664f21d080dc299242d74a47e18af9

Reviewed By: wittgenst

fbshipit-source-id: ea5eefba5823f559207a634d7ed1e574fe2d557a

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/6e400859641c70262c57f2e14090798c620ca934 https://github.com/facebook/fb303/commit/bf45af0f29cd1ac47fe09ef739b5f2da738cdae5 https://github.com/facebook/fbthrift/commit/76296e47b9b202099515309f682f62ae910cf6d5 https://github.com/facebook/folly/commit/1cc8eb3bf35de60acb8a5cd821baf8fee26bf435 https://github.com/facebook/proxygen/commit/274fe112603dc160d837b77fe07f2da8cdc03d50 https://github.com/facebook/wangle/commit/0b18a7453b017513e5042db7fb5d36d1c0620564 https://github.com/facebook/watchman/commit/a64abf95a9a84adf0350f49965d9d6a79aea3484 https://github.com/facebookexperimental/edencommon/commit/a5395b427b7ca611bb0c992c184bbe459d361454 https://github.com/facebookexperimental/rust-shed/commit/b6d8e1c37f7d101c2779500960dcb5b52ac01875 https://github.com/facebookincubator/fizz/commit/de140f0a7f4a1c32d0fb9d25cb634f11bd9c9e1e https://github.com/facebookincubator/katran/commit/68c5dcfc4df2207ce3569fff3c22ee9b9442abc8 https://github.com/facebookincubator/mvfst/commit/4f85543b8b419a8f17bd1eb17ca37918129eb0c0 https://github.com/facebookincubator/velox/commit/d7fd237feb9c3607b19ffcf497f9d26c4c8b1348 https://github.com/facebookresearch/beanmachine/commit/c515bea145a1b4abfcab942ab8ad17eab5e83b5c

Reviewed By: wittgenst

fbshipit-source-id: 28b47cbca17967be98e7bf3a92f0f0b092c0960b

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/c50f58db59ec446eabcc6df04aca75cebeec77fc https://github.com/facebook/fb303/commit/b518c741d0b8fd37080b7219db43668bfecce355 https://github.com/facebook/fbthrift/commit/b546e3204b0d5300b051c250c93239c9c8c914eb https://github.com/facebook/proxygen/commit/380c058fb355fcdbe899340968fb98b303e048f3 https://github.com/facebook/wangle/commit/d37515831f4c5cf5e2326e8c60a70b20866e3fac https://github.com/facebook/watchman/commit/96a81a1a4e15e7750878eae78796f09295e4cca8 https://github.com/facebookexperimental/edencommon/commit/f6f71c17b8d8fae7d7f818d3455e26ba8b86c8c6 https://github.com/facebookexperimental/rust-shed/commit/be8be278eb8539c06c2471445aba62aadb476c8d https://github.com/facebookincubator/fizz/commit/a16034045df91919a5c87be88b79ffaad656f609 https://github.com/facebookincubator/katran/commit/58a492bfed91b364b06bb907a5721d1592bf4261 https://github.com/facebookincubator/mvfst/commit/f33bb93810951cd02c34b0a9c4f87713560e397f https://github.com/facebookincubator/velox/commit/4e2c4f26fede6ca89b40b8358309a94f27995363

Reviewed By: wittgenst

fbshipit-source-id: 79fb18dd009d9819680574ab70e0e79796076510

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/e8b7679dfac447b7280d0b2a0593d752238868f2 https://github.com/facebook/fb303/commit/612d50e081dd3b7c9cff7c98dc661d574cf22f92 https://github.com/facebook/fbthrift/commit/aee681c5bf6ecebcc04571ad298c49d6ca68421d https://github.com/facebook/proxygen/commit/9e433bcd6ad7ad63a4ade12c89737c780c44d84f https://github.com/facebook/wangle/commit/dd13fd49d494927a334ea68a09c0da8fd2851dab https://github.com/facebook/watchman/commit/5ee940e01530fd3b55c6ca7a314281d1827364ee https://github.com/facebookexperimental/rust-shed/commit/621c52e7fe721f562c3fe490cdb78997923a42c0 https://github.com/facebookincubator/katran/commit/edf5eeea2f594bcfd32e100b206d1d71cf0f4664 https://github.com/facebookincubator/mvfst/commit/fefbd035fbf24d2dc0790310a14092c2330b19c0 https://github.com/facebookincubator/velox/commit/52918a1b5d00143ad26d1d69a018839c759b8b6d

Reviewed By: wittgenst

fbshipit-source-id: e95b2a1530a1addcdf81e2d11bb149a974fde250

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/9eb41fe9a3841415052af3a4f86390c266448a76 https://github.com/facebook/fb303/commit/5f3faa1183291e4b4dcc1525c1027621ec5d61cb https://github.com/facebook/fbthrift/commit/5963d6ec8dd4f6ef3249f595820985dee1d477b8 https://github.com/facebook/proxygen/commit/cf7b0056006cb3399b7a555f3a8e29cd9241ca2e https://github.com/facebook/watchman/commit/33a4aea5b07e7bdf95838cbd79b2956c332c579f https://github.com/facebookexperimental/rust-shed/commit/747d5ac226f98acdadd02c2ac5083916626ebb02 https://github.com/facebookincubator/velox/commit/2b34e25218ea8dafa3a074c767bc62df56d79e89 https://github.com/facebookresearch/multimodal/commit/61db7f4c465ca5a9e4860a24b1fd45148a857469

Reviewed By: wittgenst

fbshipit-source-id: d94e6974745544fdf9b8ff775b851ff895a192b9

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/1ecc06bb0300710f39e9ee09a410ece5ca2f9ac0 https://github.com/facebook/fb303/commit/7c5a5461affb71e266a22b41f249e297556f53d4 https://github.com/facebook/fbthrift/commit/0bcea4db62637355a972db5838bf579e3eb10a7f https://github.com/facebook/watchman/commit/4171a1a534c8aa2a816baac77465f1de3670f006 https://github.com/facebookexperimental/rust-shed/commit/f968beb76b4188ff9c69f5ce4b3a5c3b6c49c749 https://github.com/pytorch/fbgemm/commit/bff21c73487c5dc501acddb4788d985e9487bd68

Reviewed By: wittgenst

fbshipit-source-id: ac19d5f21f8410b980237b6df3a059cf84b74fe6

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/fbthrift/commit/bd5ceb8f0affbe3df250cb7bda226f8113fab512 https://github.com/facebook/folly/commit/2ce35a40f5fa50c4d5e9608addfa3df3881e184e

Reviewed By: wittgenst

fbshipit-source-id: b5a426882268d022c58873ba7b7ed4e911f8d891

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/6addd7bc4dd64925a898c64c716612a09ffadc44 https://github.com/facebook/fb303/commit/c4770ef8f7a50609610a0328512f1266ed37ab25 https://github.com/facebook/fbthrift/commit/a729758ddafdd53b231be92b6e7c832a56c18865 https://github.com/facebook/proxygen/commit/caeaab5ad43206da1b6e064cdd351d40a9c8a48b https://github.com/facebook/wangle/commit/887e904667573f584861d160e6ed3eaeef0d077b https://github.com/facebook/watchman/commit/8ae1f2e66be2cfd71d4dce7489e739f8d0474d6f https://github.com/facebookexperimental/edencommon/commit/e530c0bba43c75e592c37903ca2aa0e3ac204895 https://github.com/facebookexperimental/rust-shed/commit/a4b718c3e45f6308997b59a58bab405957f5c76e https://github.com/facebookincubator/fizz/commit/3e5eca5790ad1bd1c7b582e33d4dcee857d0ee00 https://github.com/facebookincubator/katran/commit/befdb22f6062abe0458d6d6bb3df0ef54d96e81c https://github.com/facebookincubator/mvfst/commit/e7a31c86fa9e48c8e8b10283473d06d2c42fcef3 https://github.com/facebookincubator/velox/commit/31cddbd84cee2f79a37250c142b50a85e22dda66

Reviewed By: wittgenst

fbshipit-source-id: 7570e10b51b565105541b0ad294a6ff08eb02eee

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/9af406973f3dc055dd94a2b3f1aee551f0a5503d https://github.com/facebook/fb303/commit/a372f0e240fb0f1b0d843d84fba026b6561e1764 https://github.com/facebook/fbthrift/commit/33e9b2da64f4b75bf159b5bb482cfcf7efad77b0 https://github.com/facebook/proxygen/commit/f58673b5cafcbdb0b6e301ea7519e3b6e6efc63f https://github.com/facebook/wangle/commit/43068d26a3792330faf8f35a25d27818e68f56d5 https://github.com/facebook/watchman/commit/06acf9b14696adcb0c559ece00e137a8e7bfdc84 https://github.com/facebookexperimental/rust-shed/commit/977de11cb3afd824fa857213c4cd71cc8e907316 https://github.com/facebookincubator/katran/commit/91c7bfcd82518fc91f9e104780db45633bd87400 https://github.com/facebookincubator/mvfst/commit/567654d1a6f4a0a6f62c2847effad33837583401

Reviewed By: wittgenst

fbshipit-source-id: 5ec29a3f58a9768dc0e98bccc79bc46af9657013

report process name and uptime for each connected client

Summary: It's helpful to know the set of connected clients, when they connected, and what their status is. Include pid and command line and uptime in watchman debug-status.

Reviewed By: kmancini

Differential Revision: D37436553

fbshipit-source-id: dc9488dab4a0b2e1fd6860a65d3a73bdd5a1e712

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/57bec14fdd98a0a8a48cfa4682acd1e23ff9fc49 https://github.com/facebook/fb303/commit/a26055e556fa4ab3b1610a6c6022ce4f3a266861 https://github.com/facebook/fbthrift/commit/c6027747688cfc941fa11924f3dee7802ff17026 https://github.com/facebook/folly/commit/3155a05553407fd4f035d1ce1e134b2a5e239929 https://github.com/facebook/proxygen/commit/449b55272312ae4e1685318b2c6a5a50387d30b3 https://github.com/facebook/wangle/commit/c789a119b8dc5ee5a67ab8419ced945947947c1a https://github.com/facebook/watchman/commit/208a092dc895fcbea9d52de2ebaf84947ba24c77 https://github.com/facebookexperimental/edencommon/commit/b0e90c9d399a38595626266c5dedd5f3b4fd9a44 https://github.com/facebookexperimental/rust-shed/commit/cbf7ce6dff690660a17f0c9d4d01b03754bf6b18 https://github.com/facebookincubator/fizz/commit/f68c49c967eca7dd6cf55f5e43888c477fc603bb https://github.com/facebookincubator/katran/commit/64a7e0613fbdcd25c4132cd8308c49a272b9a240 https://github.com/facebookincubator/mvfst/commit/5bc852de299a64b496ee5ed92efd275be7359643 https://github.com/facebookincubator/velox/commit/60542241dc4acbe2b9b2c44802932fa161ff1e45

Reviewed By: wittgenst

fbshipit-source-id: d4b5102c8137cfa63b48c45e0575f17b813594fe

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/093479efeb65b746a6712ffb8bba50cdada320a3 https://github.com/facebook/fb303/commit/bcf94b224aef4a3a6f13aa86d9005c6a972dee0a https://github.com/facebook/fbthrift/commit/e07558f91ccda73ca9175ac47ba6969ec5665429 https://github.com/facebook/proxygen/commit/74311c18571306cbc93040126718312d06724835 https://github.com/facebook/wangle/commit/aa7447f27a0e98266caedef2d29640b4a5ae18ee https://github.com/facebook/watchman/commit/adc322896d69d6ca044b3e8886da109f69a2b17e https://github.com/facebookexperimental/edencommon/commit/a6f04342c0159259ae2c2f0befcce2823930ce29 https://github.com/facebookexperimental/rust-shed/commit/16c2ed8ebb4da8b33893c595d04c3056fa2a6264 https://github.com/facebookincubator/fizz/commit/1af6e51b12e8c4124753dfd0c18b1e87b277c012 https://github.com/facebookincubator/katran/commit/f5ec5bd11323f7fdb7d2fc58d2179eaa7b683432 https://github.com/facebookincubator/mvfst/commit/dc9691aaf7d7ab279b845b98100d1ee37619031a https://github.com/facebookincubator/velox/commit/946e6b8422f1df6d457730da75449fb945133f8a https://github.com/facebookresearch/multimodal/commit/2352bc5b63d30e7324a8547d2ee58eac4d48b163

Reviewed By: wittgenst

fbshipit-source-id: 5d36856d68612e83926aa70a445d147524c507c7

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/7809472412c61331212c85ae6d5daddc03c124df https://github.com/facebook/fb303/commit/8872da14ba5c0c89217b4ecc7516899f373fda95 https://github.com/facebook/fbthrift/commit/bf073c6fecc52524ca8ac137c4d81a32bad8849c https://github.com/facebook/proxygen/commit/e2d25f78ffd7eb51fcf53c8325656935cfb40267 https://github.com/facebook/wangle/commit/b2f774953f1e0fc41c2f2228ecc7f7dcdca551b6 https://github.com/facebook/watchman/commit/c9529023814c3bdb1d108bb6fe04e7fdeb46b942 https://github.com/facebookexperimental/rust-shed/commit/2e11ed574e3a285fedce7e4320944481fbe5c841 https://github.com/facebookincubator/katran/commit/5a26c975fc93dbb7a76c272b2194dfc93950a98c https://github.com/facebookincubator/mvfst/commit/21ac23f9fe6c4bd18176f03ee30bfec5263176d8

Reviewed By: wittgenst

fbshipit-source-id: 43c1189c9976b7a4b7d11d8a72ecb73b44a4dcd6

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/801e29d692d0f447468c4dd63d7e653427382f75 https://github.com/facebook/fb303/commit/723b46d8e7d5ca796d3d06466708402062bc8089 https://github.com/facebook/fbthrift/commit/187c08c1d4539242554ce0481c2168422caa405f https://github.com/facebook/proxygen/commit/d87ff129d89a51948cbd031a74cb3d8c69c6b6bf https://github.com/facebook/watchman/commit/e252beabe8b69ab6c03e8048763702f23623ad92 https://github.com/facebookexperimental/rust-shed/commit/aeb3034d6d5153da689e336551bf10d4366f4673

Reviewed By: wittgenst

fbshipit-source-id: 46b828bae238705d287f82cae34b864c0aa1fa8e

Created at 2 months ago
create branch
dsp create branch build-fixups
Created at 2 months ago
Undefined symbol setHighMemDynamic

@simonmar Executor fails due to a missing symbol. I see it's actually later required by Glean, so I fixed the missing symbol. I have a PR coming.

Created at 2 months ago
Undefined symbol setHighMemDynamic

@alpmestan here is my hacked together flake file : https://gist.github.com/dsp/05dd9e3402bf4454f10e5ff7684c8b0b . Note that i must build folly and a few other things myself due to the haswell flag required for AVX2 support. Note also that i cannot yet build hsthrift and glean as a package because of the weird ghc8 + cabal3.6 requirement, that i just can't get to work.

The workflow of nix develop + cabal buildshould work (I use it out of the glean directory and hsthrift is a subdirectory).

Note #90 explains why my builds fail. @exi was so kind to help me debug this.

Created at 2 months ago

autodeploy

Created at 2 months ago

autodeploy

Created at 2 months ago

Update blog and theme

Created at 2 months ago

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/fbthrift/commit/7462ca5a15deeae14295f42038fa28ae040e92c2 https://github.com/facebook/litho/commit/e7bf83ae5d9098cbfe15420ff581e1548807d4fb

Reviewed By: wittgenst

fbshipit-source-id: 3053b11425d4789debb44c12b6f2238d4523f795

Revert D37573487: implement processWithMetadata for services that do not implement them

Differential Revision: D37573487 (https://github.com/facebookincubator/hsthrift/commit/f91c4002959bcfb9d3e0367b55fe246c1c6daa5d)

Original commit changeset: f215f4ecc8b1

Original Phabricator Diff: D37573487 (https://github.com/facebookincubator/hsthrift/commit/f91c4002959bcfb9d3e0367b55fe246c1c6daa5d)

fbshipit-source-id: 2dea32a490ee8daae58b6d5dbf74ec116cd71a31

Changing openssl general dependency to debs dependency (#165)

Summary: X-link: https://github.com/facebookincubator/katran/pull/165

Having the openssl general dependency generated problem with the default build of getdeps.py as it expected the --allow-system-packages flag, but this is disabled by default in the github-actions build as per D26743251.

Found how to add the dependency of the development library for debian based distributions, so now it only requires in this case and our build doesn't need either the --allow-system-packages flag.

Reviewed By: avasylev

Differential Revision: D37636832

fbshipit-source-id: 7a05215fa1b95e096be5343ae25d6c9b909cd7e5

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/4723dc4c69621c803f81f968977fa55dfc567584 https://github.com/facebook/fb303/commit/417e08bff3ca481bed835f0355c18a99ca7c52c3 https://github.com/facebook/fbthrift/commit/4bdbed4798d0389214a4eb7228ba741776eef234 https://github.com/facebook/watchman/commit/347763f56bb8abcafba3d6f6964e35b8a5ba86a2 https://github.com/facebookexperimental/rust-shed/commit/4d9db0d5ec41c3a797d951d2a9605d89af4e40ff https://github.com/facebookincubator/fizz/commit/ce073b743ca667494bc96b2745a20e91f8d5f425 https://github.com/facebookincubator/katran/commit/8d9d4cd2b8408f7101fa17afdb0a1014504ee4aa https://github.com/facebookincubator/mvfst/commit/05968a03d701d25c110770ba68890450cc89a81e https://github.com/facebookincubator/velox/commit/7337deeb1105a26fc158680bab56c46c27be38e5

Reviewed By: wittgenst

fbshipit-source-id: cfc9e933564b17d25f094cbcae14a44578e22024

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/39f1d8c5347cc2fc9695878e9f35285dbca4a306 https://github.com/facebook/fb303/commit/83324230ad4e3b721a4c09f94f98c03395c58dff https://github.com/facebook/fbthrift/commit/7ee9e640f0d0c56a46cb9d3507b5cdc3fbae536b https://github.com/facebook/folly/commit/fd6c047316ce74f3b5fbf8473d7e5698fc713247 https://github.com/facebook/proxygen/commit/959533ebf8e7ffdd59fcd05a4cb1f5428f2311df https://github.com/facebook/wangle/commit/913e640ae62df539c8b1d3ff6164d19e89bfe47f https://github.com/facebook/watchman/commit/091dc439da1a7232ca0c0f7e1e3f797eb63670c4 https://github.com/facebookexperimental/edencommon/commit/7af65cba27ff9ef10511c9ceb32b1376f1be9eec https://github.com/facebookexperimental/rust-shed/commit/27f38652248de7dcb0b8d1f9285e9e158cec64bf https://github.com/facebookincubator/katran/commit/9052541a1b28972e57d8881753c3f3020c546d60 https://github.com/facebookincubator/mvfst/commit/2714c5844b8e6a0ec0c9389ae856aa52f77e1cbb

Reviewed By: wittgenst

fbshipit-source-id: dd884869bb44ebe257114349ec9526ae72fee432

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/7eac7275a8cfba88f28e58c9c98d25ad42451238 https://github.com/facebook/fb303/commit/6e45686a9248058aa4f0c097d72b0907f78ef700 https://github.com/facebook/fbthrift/commit/9e1b50901aca9e7a725db3687c1ec05e74506fd3 https://github.com/facebook/litho/commit/c6057f9449647ed8533f89713ec5e18f1be599e8 https://github.com/facebook/proxygen/commit/40a0f9473c66e730338b6a82e74492d401cc239a https://github.com/facebook/rocksdb/commit/177b2fa341483dcfa1d70be447f94e0ef7c85588 https://github.com/facebook/wangle/commit/bab071fffe6b0d33a5f2bb409c05d6cbcca53994 https://github.com/facebook/watchman/commit/f09b2479016be9d2741b755a5d1c5f6eb4b31deb https://github.com/facebookexperimental/edencommon/commit/507e1f293660481ad6189e8582234e23aaecfa54 https://github.com/facebookexperimental/rust-shed/commit/f9d9f14651fc12bf0bd06f9bc669aa13d8e9a38a https://github.com/facebookincubator/fizz/commit/003f7b72ed12915b835bbbb15b4307587eabd4dc https://github.com/facebookincubator/katran/commit/5a5ee46866acf6609278e85047be6d04c6a58efa https://github.com/facebookincubator/mvfst/commit/6b639b7a0b03f31187a7ee381c36ad5e13a9e49c https://github.com/facebookincubator/velox/commit/07746ee02ea78b84ec74ad6797c5f4ea039601aa https://github.com/facebookresearch/multimodal/commit/b99183ccecdb0eb51a4da9a914afd146e96c5dcc https://github.com/pytorch/multipy/commit/80fd3b366de1a700fa56b8aa7b6bf33687aa49fd

Reviewed By: wittgenst

fbshipit-source-id: fad0d74c8bf80ad2567bdd25f1ac70384f4cc409

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/2d1d70e17a3e576040c8af9b48057d4fa7b26b66 https://github.com/facebook/fb303/commit/de19543b502e48e845ce9b1e991987a3b420c01a https://github.com/facebook/fbthrift/commit/b06e9763c090c7b3829a2aeadb65bf84406cfefa https://github.com/facebook/proxygen/commit/695e0c1a4ff55fcdfdcc36543e855efdae9366bd https://github.com/facebook/wangle/commit/f935e61188e85768983e3ac112340808815dce56 https://github.com/facebook/watchman/commit/0db800b659185383cef3edc7df3070649629c6d9 https://github.com/facebookexperimental/rust-shed/commit/1fc1ac7e790aba7381ac40bb17690fcb797d9726 https://github.com/facebookincubator/katran/commit/0efbfbe40900415cc3d6691f2d93f7bd118a4d1a https://github.com/facebookincubator/mvfst/commit/c69451065d3937865e92cbe1e526a75dfb28157a https://github.com/pytorch/kineto/commit/066696ef46f17709606d02a824658a1b4430e3ad

Reviewed By: wittgenst

fbshipit-source-id: ae426ef90b23d28c2fb0d498a4c3ea7db00eef48

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/d5a69a05bd6307c8eeb45ad2cf29d4ba21c63796 https://github.com/facebook/fb303/commit/52a4fc7f20b535bb390c27431686b9106661ad9c https://github.com/facebook/fbthrift/commit/2ab8261e2e905ef1a171d1b84d401ef73d56496a https://github.com/facebook/proxygen/commit/edd59e4489300ca6d427c1d773a4527ffbacbf6b https://github.com/facebook/watchman/commit/415fab0f4725fd243f1240a39a426627a4daadac https://github.com/facebookexperimental/rust-shed/commit/405f24bbfa9ce550241291340012d665dc639d98 https://github.com/facebookincubator/fizz/commit/bcfc2b98726ee213e709bc2b1a28c1950b53f05c https://github.com/facebookincubator/katran/commit/37316f37d286ca4fe0217ff6d4ec138bc4af29e5 https://github.com/facebookincubator/mvfst/commit/32df46c68c5f8756b4383b1228d17df6538ae671 https://github.com/facebookincubator/velox/commit/1c83bb32dd1ecdf58374a462235bfdf22e05de84 https://github.com/facebookresearch/flsim/commit/fb884b32bcabd6f1316e271143cb161f3eff4f49

Reviewed By: wittgenst

fbshipit-source-id: fb3f4534d8ac1d7034501f39857dc638c5ff9ce3

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/423340e25fcdc14a05930d4abe2d104a488d37a6 https://github.com/facebook/fb303/commit/6e5ef4fa4b8a560a2536a40cd89993ab06613c91 https://github.com/facebook/fbthrift/commit/39a2a966a0d8c258642b3bb7240038f28112f1f0 https://github.com/facebook/proxygen/commit/203a34003708ce4b8c0609fab2b48bc8d9a55b68 https://github.com/facebook/rocksdb/commit/2acbf386a38421760d73a62cfcf2a66bfaf8d711 https://github.com/facebook/wangle/commit/c9d5f5183120544ccd0dda090b8a040bf5904d6f https://github.com/facebook/watchman/commit/ef37df8719d090c67765fd8ab62c133bebb36150 https://github.com/facebookexperimental/rust-shed/commit/b2b5803c939c09f7526df71430b03a34851b36a2 https://github.com/facebookincubator/fizz/commit/a2972cc8c2c48803c193860de40e116d95c88d04 https://github.com/facebookincubator/katran/commit/59dd230e4dfa88b4d177652e0ec35cfe20e28440 https://github.com/facebookincubator/mvfst/commit/d67340dc4aba4a6fec6209cdfab944aef1097709 https://github.com/facebookincubator/velox/commit/ba742e2cf5045ca2d6c9b1a174d46f4a8e7fd5bf

Reviewed By: wittgenst

fbshipit-source-id: b545fa3e63432e2c25037b9fae30ac6bfa99b092

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/87ecfb438d5efe4167bec277e1f0740139741f33 https://github.com/facebook/fb303/commit/bf98b123be2019d24e2cb7a40cc9dda221f0a4b0 https://github.com/facebook/fbthrift/commit/cf454d97cb3dfa7c5e26ba321b4b23e79533f11c https://github.com/facebook/proxygen/commit/a884e15276a68c384b471fad7118ac94571cb1f8 https://github.com/facebook/wangle/commit/c6963f44748ea42867d105ab7a88cf2a589c26b4 https://github.com/facebook/watchman/commit/4241ab4338fea1fbe75b8389cab27d8244635fb1 https://github.com/facebookexperimental/rust-shed/commit/e9fef422cafe6871241e33004291ca9ce183d1d2 https://github.com/facebookincubator/katran/commit/7b4d1cc93412dadc933c545bf63224b27fe2d83d https://github.com/facebookincubator/mvfst/commit/4a185541570f55d6166e93e3c1d9d70e632cff67

Reviewed By: wittgenst

fbshipit-source-id: 62d55152560a34af651b050b917fc93e673c9ec0

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/c5bb3154c3daac3fff409c4e3687584cbd943e7c https://github.com/facebook/fb303/commit/53c11cefefb25d837a55f1684a293242a86c7dd3 https://github.com/facebook/fbthrift/commit/58f6281abff5a0e5c671e5c19a77f29faed4a697 https://github.com/facebook/proxygen/commit/3e975890a934173c981fb906b41d8e8b47bd83ed https://github.com/facebook/rocksdb/commit/e6c5e0ab9a7235a90a511553cb3c5fb2cec85e99 https://github.com/facebook/watchman/commit/e013f7ec891bedd3eda1abd4bfb3f3927e2504ca https://github.com/facebookexperimental/rust-shed/commit/01d3cbb7d21ad1976255e3fd1ddcf7d06c100d23 https://github.com/facebookincubator/fizz/commit/7baf5ce2d27ce22f836dcc61e9ad8463119a4cfd https://github.com/facebookincubator/velox/commit/e4ce5a6a4e9b6ba69cb20484e67b04685c6b4ebc https://github.com/facebookresearch/beanmachine/commit/26529f821fed83149db6ac849631d600e43bbadd

Reviewed By: wittgenst

fbshipit-source-id: 011fe16cbf54a79afb2c63f435fdfe29288e6484

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/d7774d2eda685aa2b9d986a7dc336b0058d5fb43 https://github.com/facebook/fb303/commit/a00aaaac6cefad9fb1ab777185d213ba6f9a5c6a https://github.com/facebook/fbthrift/commit/1e843b68a8abe04cac37e554d3d54ae8b57d1646 https://github.com/facebook/proxygen/commit/5908b3545227d27a35a7f7c3a04dba893f3b8909 https://github.com/facebook/watchman/commit/5c4af1f9bca21f9db5b618d2227fdc695a6f7642 https://github.com/facebookincubator/velox/commit/2c4cdcdd875639e290f2cb4b005fd0773bd470bf https://github.com/facebookresearch/flsim/commit/a027cecd4b6e127dd72d25ef9d28e88b7693f044

Reviewed By: wittgenst

fbshipit-source-id: 2dc3ac0d9bf29221348a77b8db1c17fb44ecc9d8

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/02d2183a9cd730e71557990f58fa5c2a1ab2c18c https://github.com/facebook/fb303/commit/21e8f326469ea9947444816d537bb2ab3a94cb3f https://github.com/facebook/fbthrift/commit/75f34b47926302b738ce45a960e6866bd2977135 https://github.com/facebook/rocksdb/commit/c277aeb42cec4af56084e3200df919631efe8430 https://github.com/facebook/watchman/commit/bdf19a755a1b21cc8010eef67c17e0519f6f59d3 https://github.com/facebookexperimental/rust-shed/commit/38a8ff3a57d806b5d36aea7bdc7b8656c8a69571

Reviewed By: wittgenst

fbshipit-source-id: 0a3e291d49ac82179678613e7f49924d51e5fe6d

define some dependency debs for ubuntu 18.04 and 20.04

Summary: This makes our open source builds faster. I tested on both Ubuntu 18.04 and Ubuntu 20.04.

Reviewed By: genevievehelsel

Differential Revision: D36552498

fbshipit-source-id: 02867fccc275ec775d0fdfaaf0f686ecdbbc4eaf

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/b75bf520597f506591e7eed06cd0fd904627cb84 https://github.com/facebook/fb303/commit/0af2348f90848ffe0527e38d1196ebaba2031ff1 https://github.com/facebook/fbthrift/commit/688f5f9d3fa1f0cf2216065ff8cb42810065edf8 https://github.com/facebook/rocksdb/commit/c987eb47125911972d038566d06f4b98b58f2e45 https://github.com/facebook/watchman/commit/7495c65aad20e67481299c96f16ed32ce6e65e6b https://github.com/facebookexperimental/rust-shed/commit/c78cdd1de0080b7601072716be916b2d4c2204b7 https://github.com/facebookincubator/fizz/commit/a5efd202b28ad4461eb2b6274c9d6d9428651994 https://github.com/facebookincubator/katran/commit/23b7fbf026e0ff9d1cdc1620478ac05dd2c1ffde https://github.com/facebookincubator/mvfst/commit/5a8a6ef1c6e8de83444bd3e0c90d785dfa8ebefc https://github.com/facebookincubator/velox/commit/ba7bfd6136cc40979fe756a480cbbe2f85757716

Reviewed By: wittgenst

fbshipit-source-id: c55e29e240c7702f19258d06a52381d2d32d185f

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/be1e6c5a749d7b177b6fad486539a885e41c1eaf https://github.com/facebook/fb303/commit/dfabecf5abf6d46b584458daece7bd808f48334f https://github.com/facebook/fbthrift/commit/9b1303f6e4e41a1e411e3137cd138855fe821feb https://github.com/facebook/folly/commit/81e2ecc1eb126bc12b4e1e50e6954ce69bb65daa https://github.com/facebook/proxygen/commit/ecfe3585a7c802d7e5ec197b1c05154251f9918a https://github.com/facebook/wangle/commit/14e94d0b0fd175bc13ad363cad58d7764eef4e02 https://github.com/facebook/watchman/commit/d8c6daee9d7c82fa37d88d4feadf6f896f2d70c7 https://github.com/facebookexperimental/edencommon/commit/db860507494e22b3812f03e4e1c5ed4f6556685f https://github.com/facebookexperimental/rust-shed/commit/fb8f750d2088c35b8a8c71a5fc688248de172649 https://github.com/facebookincubator/katran/commit/bb6ca6690a503ff7beb12f037a8dfe30fa81e5c9 https://github.com/facebookincubator/mvfst/commit/a4c62b589166d5388d760736823c52740067a903

Reviewed By: wittgenst

fbshipit-source-id: 9bfa8c5f19b288c708c09bdc21e9f6dfc5ffcf14

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/364983804a13ecc381eaf8120110a0f5ac351282 https://github.com/facebook/fb303/commit/0fbda77199f98c4e984b09f600663a7cc7550e31 https://github.com/facebook/fbthrift/commit/b236377c141d97f31e4af616f8b90d07073065e9 https://github.com/facebook/proxygen/commit/6c16137c67c68651df318860965f684b3c2431e8 https://github.com/facebook/wangle/commit/de80c0909c649496b869df1ac095130bb6103639 https://github.com/facebook/watchman/commit/bb7e8dde755e87ed45993ccdff01df3ca79f436a https://github.com/facebookexperimental/edencommon/commit/71f9035849ea47ffdc1a42542d686e45fd8ead42 https://github.com/facebookexperimental/rust-shed/commit/d98809334e9f3aecebc0800294950d0c9afd3605 https://github.com/facebookincubator/fizz/commit/92b8dbf3455e2b530b9d6be2fbf4c739d422a8b0 https://github.com/facebookincubator/katran/commit/6bf8a0e22d744d9244a9406278f176e81778a013 https://github.com/facebookincubator/mvfst/commit/814ff3f78825acde353e41ea3b643b631ea6fd86 https://github.com/facebookincubator/velox/commit/2faf039e82278f1170689514fef73c48a4c81d62

Reviewed By: wittgenst

fbshipit-source-id: 80245f197e3828e4cf23e92250cae5f5793692d3

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/81e18c4f469c76bc94d09ab6e77bec54173f619d https://github.com/facebook/fb303/commit/5eb45eb70a99a1df865c049c74f3315d81824540 https://github.com/facebook/fbthrift/commit/73bf4b277762453a93e18325f9fcf84e7b018aeb https://github.com/facebook/proxygen/commit/fda9a2f2d7a3ebe4db575ae5592033bc9b24ec83 https://github.com/facebook/wangle/commit/001afd714caf4672ab8b2a93b55eb3d8df85f9ec https://github.com/facebook/watchman/commit/32bf3f0b1d4361bdba667dc4d036fc460576869e https://github.com/facebookexperimental/rust-shed/commit/8b0d97b24324c1b996b2c4311059f6928f14e91e https://github.com/facebookincubator/katran/commit/021e989b9da8bdadc523da3f8cbcad3a4369dd1f https://github.com/facebookincubator/mvfst/commit/51d75ffda29bf504fed07896c979374b608728b3 https://github.com/facebookincubator/velox/commit/e036d7bacf41e956ec0e19ccbb406f5d3008494e

Reviewed By: wittgenst

fbshipit-source-id: e4b12e3bfc83ff48c08ca3838e94dc556a80a24b

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/dd2280a6a35e74da6257bd28ddb01bb789ecd2c2 https://github.com/facebook/fb303/commit/b8d033b5f41bc8d9c33f05a4f4b1b2c8b8f68de7 https://github.com/facebook/fbthrift/commit/44a71eb5e9f582bb03d67d69e6f2d7989bfc9c69 https://github.com/facebook/proxygen/commit/8e2ac0134882171e7ce4893d693a58c941f0c8a1 https://github.com/facebook/watchman/commit/ff8a04e7134d1668617a29389fb4e0bae0317d16 https://github.com/facebookexperimental/rust-shed/commit/860ab2c23cf4a6dc1d32f19c56f7c0e35b95ac3c

Reviewed By: wittgenst

fbshipit-source-id: f0dabb881a493958aada714c42ff5f19e61cf5dc

Updating submodules

Summary: GitHub commits:

https://github.com/facebook/cachelib/commit/dc3a7f25757ea852fceacdb91b4909e494af078b https://github.com/facebook/fb303/commit/665bccf9edb13c67450141b5efd156a4fdb55fd9 https://github.com/facebook/fbthrift/commit/1ac01ff5816b5e04174305c571cc8c7a3eee4a14 https://github.com/facebook/watchman/commit/a6152e6d251b15c30707891d88ebd151ef093802 https://github.com/facebookexperimental/rust-shed/commit/e5c20fe2480a1f4e290bb54ef866d07bdb3f53db

Reviewed By: wittgenst

fbshipit-source-id: fbf9c7bdaab665f45d95c7ed953f6adbfd3a04eb

Created at 2 months ago