driesvints
Repos
10
Followers
3887
Following
26

A package to easily make use of SVG icons in your Laravel Blade views.

1644
115

A set of renderless components to utilise in your Laravel Blade views.

1162
68

Get started with your own dotfiles.

1696
546

The Laravel.io Community Portal.

2216
572

The Laravel.io Pastebin.

154
31

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.

1060
82

Events

issue comment
Call to a member function status() on bool in EnsureRequestsDontExceedMaxExecutionTime

It was not clear to me that this was a bug at that time. Your report here was more insightful.

Created at 13 minutes ago
closed issue
Error : Class "Illuminate\Support\Testing\Fakes\UpdatedBatchJobCounts" not found

Hello everyone! Seems like import of UpdatedBatchJobCounts is missing here:

https://github.com/laravel/framework/blob/23e8dd8fac5910edd20327a23529b52af8a77268/src/Illuminate/Support/Testing/Fakes/BatchFake.php#L128

I opened a PR with a fix https://github.com/laravel/framework/pull/44435

Created at 1 hour ago
issue comment
Error : Class "Illuminate\Support\Testing\Fakes\UpdatedBatchJobCounts" not found

Thanks! I saw your PR so let's follow up there.

Created at 1 hour ago
issue comment
[4.x] Do not record when unserializing command

Perhaps it should check the original state before re-enabling recording?

Thanks, I sent in a PR for that: https://github.com/laravel/telescope/pull/1258

Could we just do an instance check in the JobWatcher class with fallback to unserializing?

Sorry, I'm not sure if it's the right approach.

Created at 1 hour ago
pull request opened
[4.x] Fix re-enabling recording

Small adjustment for my PR at https://github.com/laravel/telescope/pull/1257. We should check if Telescope was recording to begin with. If it wasn't, we should also not re-enable recording.

Created at 1 hour ago
create branch
driesvints create branch fix-re-enabling-recording
Created at 1 hour ago
delete branch
driesvints delete branch driesvints-patch-1
Created at 1 hour ago
issue comment
Eloquent `upsert()` method doesn't work with UUID primary key

@plakhin we'd welcome a PR for that 👍

Created at 2 hours ago
closed issue
Eloquent `upsert()` method doesn't work with UUID primary key
  • Laravel Version: 9.33.0
  • PHP Version: 8.1.10
  • Database Driver & Version: mysql Ver 8.0.30 for macos12.4 on arm64 (Homebrew)

Description:

Users table migration creates the UUID id column: $table->uuid('id')->primary();. Users model uses Illuminate\Database\Eloquent\Concerns\HasUuids trait. When trying to upsert a number of records, getting the error: PDOException: SQLSTATE[HY000]: General error: 1364 Field 'id' doesn't have a default value in...

When using auto-incrementing id column all works fine.

Created at 2 hours ago
issue comment
Eloquent `upsert()` method doesn't work with UUID primary key

Not sure this is compatible with upsert.

Created at 2 hours ago
closed issue
Factory autocomplete
  • Laravel Version: 9.33
  • PHP Version: 8.1

Description:

Factory autocompletion works when using the factory itself, but not using the factory() method

Steps To Reproduce:

First option; Autocomplete working:

    $cat = CatFactory::new()->makeOne();
    // This works, cat is an instance of Cat instead of Model
    $cat->property = '';

Second option; Autocomplete NOT working:

    $cat = Cat::factory()->makeOne();
    // This one says: Potentially polymorphic call. The code may be inoperable depending on the actual class instance passed as the argument. (because cat is an instance of Model, not Cat)
    $cat->property = '';

Am i doing something wrong here? My Cat model uses the HasFactory trait, and the factory has the right @extends Factory<Cat> docblock before the class definition

I also see that https://github.com/laravel/framework/blob/9.x/types/Database/Eloquent/Factories/Factory.php contains only assertions using the first option. If the second option is not the standard; why the docs point me to using it? (https://laravel.com/docs/9.x/eloquent-factories#instantiating-models)

Thanks

Created at 2 hours ago
issue comment
Factory autocomplete

Hi there,

Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!

Thanks.

Created at 2 hours ago
closed issue
Crash when using Blade's echo to render enum
  • Laravel Version: 9.3.8
  • PHP Version: 8.1.0

Description:

Not sure if this is a bug per se, but when using Blade's echo function to render an enum it throws an exception. I guess this is expected, but it'd be nice to add a check for this in the echo function and either render the name if it's a non-backed enum, or the value for a backed enum.

https://github.com/laravel/framework/blob/da859e7c1d67278d79ad95410c7656e6b4f8e7be/src/Illuminate/Support/helpers.php#L109-L121

Steps To Reproduce:

return view('my-view', [
    'enum' => MyEnum::myValue,
]);
// view
{{ $enum }}
htmlspecialchars(): Argument #1 ($string) must be of type string, MyEnum given
Created at 2 hours ago
issue comment
Crash when using Blade's echo to render enum

Heya, thanks for submitting this.

This seems like a feature request or an improvement so I'm converting this to a discussion instead. It's best to post these in the discussions section in the future to get support for your idea. After that you may send a PR to the framework. Please only use the laravel/framework issue tracker to report bugs and issues with the framework.

Thanks!

Created at 2 hours ago
issue comment
[9.x] Fix Precognition headers for Symfony responses

@bert-w a symfony response can still be sent out instead of a Illuminate http response.

Created at 6 hours ago
closed issue
Migrations may fail to run in mysql if sql_require_primary_key is enabled
  • Laravel Version: v9.33.0
  • PHP Version: 8.1.18
  • Database Driver & Version: mysql 8.0.28

Description:

When trying to run a DB migration structured like this:

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

class CreateNovaNotificationsTable extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('somename', function (Blueprint $table) {
            $table->uuid('id')->primary();
            // ...
        });
    }

    // ...
}

If the DB is a mysql server with sql_require_primary_key enabled, the migration fails with the following message:

SQLSTATE[HY000]: General error: 3750 Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting. at /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Connection.php:544)

From what I can tell, this appears to run CREATE TABLE (`id` char(36) not null, ...) default character set utf8mb4 collate 'utf8mb4_unicode_ci') and then ALTER TABLE ... ADD PRIMARY KEY (`id`)

Ideally, the two would be combined into a single statement, as $table->id() does. I'm not sure if there are other options (such as temporarily disabling that mode)

Steps To Reproduce:

The easiest repro step is to do a clean install of Laravel Nova and try to run artisan migrate when configured to a MySQL server with that setting enabled (this is, apparently, the default on DigitalOcean managed DBs) - I ran into this when one of the built-in Nova migrations was running. However I believe this is not a Nova issue, but one where any UUID PK is configured with the above structure.

Otherwise, a migration as above should be sufficient.

Created at 6 hours ago
issue comment
Migrations may fail to run in mysql if sql_require_primary_key is enabled

Thanks @rodrigopedra

Created at 6 hours ago
issue comment
[10.x] Fix custom scout keys not being utilized when deleting from queue

Thanks @stevebauman. I'll use this PR as a reference once 9.x is updated and I merge it into master.

Created at 6 hours ago
issue comment
feature: added config option to disable handling of bearer tokens

What's the use of Sanctum if you use a third party auth service?

Created at 6 hours ago
pull request closed
wip
Created at 6 hours ago
issue comment
wip

I think I closed a similar PR just now? Please don't send in PR's that contain breaking changes.

Created at 6 hours ago
issue comment
Working on NULL inspect response message issue

This PR contains multiple breaking changes unfortunately.

Created at 7 hours ago
pull request closed
Working on NULL inspect response message issue
Created at 7 hours ago
issue comment
[9.x] Consider newlines in foreach/forelse Blade statements

I'm not sure we should support this tbh. Why can't you add it to one line as in the test example?

Created at 7 hours ago
closed issue
List Site Directory

There is no way i can list files inside my site. I needed to my site directory and delete a file or copy file. It will be nice to be able to list the files directory for each site

Created at 8 hours ago
issue comment
List Site Directory

Hi @iamprincesly. Please send a feature request to forge support.

Created at 8 hours ago