dregad
Repos
62
Followers
49
Following
12

ADOdb is a PHP database class library that provides powerful abstractions for performing queries and managing databases. ADOdb also hides the differences between DB engines so you can easily switch them without changing your code.

388
241

Mantis Bug Tracker (MantisBT)

1442
658

Source control integration plugin framework for MantisBT, including support for Github, Gitlab, Bitbucket, Gitweb, Cgit, Subversion, Mercurial and more

175
128

Events

Fix deprecated resolve_pageid()

@fiwswe

people may have different preferences as to what should be ignored

I hear that, but in this specific case I don't believe anyone would want to commit editor-specific and temporary files. Moreover, the exclusions I added to .gitignore are identical to DokuWiki's so it's consistent within the ecosystem.

the .DS_Store line for example. Someone not using macOS would not need this line (though it doesn't really hurt either).

Exactly. It does not make any difference to anyone

Also adding a .gitignore in a PR that addresses something completely unrelated to this file seems wrong

As far as I'm concerned, that is actually the only receivable argument. I included it in the PR as a pure act of laziness 😉

@Klap-in

developing these plugins out of the development tree is less common

Possibly, but regardless of that fact, a Git repository is a standalone unit. JetBrains IDE's inheriting .gitignore settings from a parent directory outside of the git root is not a standard thing, and not having the .gitignore file inside the plugin's repo is causing the not-excluded files to be flagged by Git for anyone not using the IDE for commit operations, making their life more difficult for no reason, and introducing the risk of accidentally committing temp files.

For example, I personally use the Git command-line and SmartGit a lot, so can I never have a clean working tree because of this (untracked files are always present):

Created at 13 hours ago
Fix display of mail icon in plugin information
  • Icon appeared lower than rest of line
  • Missing space between icon and author's name

| Before | After | |---|---| |||

Created at 21 hours ago

Fix display of mail icon in plugin information

  • Icon appeared lower than rest of line
  • Missing space between icon and author's name
Created at 21 hours ago
Issue #4 Wildcard redirect

@splitbrain any plans to merge this PR ?

Created at 22 hours ago
Wrong description on plugin page?

I updated the wiki page. This issue can be closed.

Created at 22 hours ago
issue comment
Object of class mysqli_result could not be converted to int

Duplicate of https://github.com/ADOdb/ADOdb/issues/867

Created at 1 day ago
closed issue
Object of class mysqli_result could not be converted to int

I've just updated a project, that's be running without any noticeable errors, from 5.22.2 to 5.22.3 and now get

Object of class mysqli_result could not be converted to int in adodb.inc.php on line 3946

I reverted back to .2 and the error doesn't appear.

Created at 1 day ago
issue comment
Mail subject displayed as empty when encoded

WIP - merging some of the submitted PR's and then getting to this fix. Still aiming for the next few days

The "next few days" are now long gone, still hoping for a release with this fix 🙏

Created at 2 days ago
dregad delete branch php8-warnings
Created at 2 days ago
Fix deprecated resolve_pageid()

Thanks for merging and taking care of the class_exists() fix for me.

I take note of your suggested approach for handling plugins directly within DokuWiki tree, and will try it out to see how that works for me.

For the record, I must say that I really don't understand the strong resistance against having a .gitignore file in the plugin. Even if it's somewhat redundant in the specific use case of cloning the repo under lib/plugins when using PHPStorm,

  • it is also a perfectly normal and valid situation to clone the repo elsewhere.
  • consider also that not everyone is using a smart JetBrains IDE that is able to deal with repositores within repositories.
Created at 2 days ago
dregad delete branch i134-deprecated-resolve_pageid
Created at 2 days ago
Fix deprecated resolve_pageid()

@Klap-in With regards to the .gitignore file

So far I know this ignore file is already set at top level in DokuWiki’s development version code, and not needed at plugin level.

Consider that the plugin's code is managed in its own Git repository, separate from the main DokuWiki repo. This means that any IDE/temp files created during development (e.g. PHPStorm's .idea/ directory) will be marked as Untracked files.

Maybe my development practice is not the same as yours and possibly not the best or recommended DokuWiki way of doing things. This is what I have.

~/dev
  /pagelist      <- clone of dokufreaks/pagelist
  /dokuwiki      <- clone of splitbrain/dokuwiki
    /lib/plugins
      /pagelist  <- symlink to ~/dev/pagelist

I work on the plugin's code from ~/dev/pagelist, so from this perspective the .gitignore file is needed at plugin level. Please advise if I should do things differently.

Maybe you could put the ignore file to the ignore file as well?

This is confusing. What do you mean ?

Created at 3 days ago
Fix deprecated resolve_pageid()

Thanks for your feedback and testing @fiwswe.

Normally these version number checks are not used, for this kind of backward compatibility code. Not sure why, maybe because it not consistent enough with the development version?

Sorry, I'm not a DokuWiki development expert, using version number seemed like a sensible thing to do.

The typical solution used is checking if the actual function already exists, if not then fall back.

OK, I'll try with class_exists() to see if it works, and update the PR if so.

Created at 3 days ago
Fix deprecated resolve_pageid()

wouldn't it be easier to use the global $updateVersion defined in doku.php?

I don't think that would work actually, as users are told to update this value to squelch the upgrade warning check:

If you don't want to upgrade to an announced release you can simply increase the number in doku.php. (note: in older versions, this number was at the top of the file ./conf/msg).

Created at 4 days ago
resolve_pageid() is deprecated. ("Igor")

Pull request is welcome, if so please to this branch #130

Done => #135

Created at 4 days ago
pull request opened
Fix deprecated resolve_pageid()

Add conditional execution based on DokuWiki version date to maintain backwards compatibility.

Fixes #134

Created at 4 days ago
dregad create branch i134-deprecated-resolve_pageid
Created at 4 days ago

Forward-compatible approach to initialize flags

Ensures the code works properly in case new flags are added in the future.

Created at 4 days ago
issue comment
Revise and possibly automate offline documentation build process

Many thanks for looking into it and confirming that it works.

I had to add --no-check-certificate to the wget to get it to download straight to my windows box using cygwin bash tools.

I remember facing this issue on my work laptop. Most likely the certificates authority on your Cygwin is not up-to-date. Did you try installing the ca-certificates package ? It's been a while since I've fixed that issue, and I don't remember how I did it.

If you can't fix it, then I guess that for our purposes it may be acceptable to skip the SSL certificate check.

The image "download-big.png" is kept outside of the accessible pages, so we should just keep this as a separate resource and copy it into the final directory tree before zipping it up.

Weird that this image is not being downloaded, while the Twitter and GitHub icons are.

This is so simple we should just automate the whole process.

Indeed, that was the idea when I tested downloading the site with wget

I'll work on a script to automate the documentation build.

Maybe once a week could be good?

That sounds overkill to me - looking at the history of changes over the past months, it's quite static. I would go for a build each time we release, and whenever needed (i.e. after significant changes are made)

We could also remove the plugins we don't need

That would be just the sync plugin then ? siteexport we still need. We can probably disable the XMLRPC (and related adodb-xml user)

Created at 5 days ago
resolve_pageid() is deprecated. ("Igor")

What about conditional code, checking if DokuWiki version is Igor or later then use PageResolver, and execute the legacy code otherwise ? This way backwards-compatibility can be maintained, until you decide to drop it.

Created at 5 days ago
pull request opened
Fix undefined array key warnings on PHP 8
Created at 5 days ago
dregad create branch php8-warnings
Created at 5 days ago

Add .gitignore

Remove code leftover from the switch to array_pad()

Created at 5 days ago