donquixote
Repos
114
Followers
21
Following
1

Events

[do not merge] OEL-1500: Vertical margins proof-of-concept.

Proof-of-concept solution for vertical margins.

Goals

  • Standardize vertical margins between elements.
  • Use margins for vertical space between elements, avoid padding where margin would be the more natural fit.
  • Stick with Bootstrap strategies as much as possible.
  • Stick with utility classes.
  • Avoid classes that must be applied conditionally depending on outside criteria (e.g. whether specific other element exists).
    • -> Make vertical spacing still work correctly if some elements on the page are missing or empty.
  • Avoid element classes in rich text. (E.g. <p> tags typically come from rich text, and the editor won't be allowed to add classes.)
  • Avoid unnecessary wrappers.
  • Avoid custom contextual CSS that expects a specific DOM structure.
  • Semantic html where it makes sense - e.g. wrapping sections into <section> seems like a good idea.

Strategy

  • Step 1:
    • Use margin-bottom over margin-top, see https://getbootstrap.com/docs/5.0/content/reboot/#approach and https://csswizardry.com/2012/06/single-direction-margin-declarations/.
    • Clean up one-off paddings and margins and replace them with standardized margins.
    • Wrap main content sections into <section class="mb-5">, with <h2> title.
      • I chose .mb-5, but we could choose a smaller margin.
  • Step 2:
    • Introduce .eat-margin* utility classes that can absorb margins of first and last element more reliably than :first-child or :last-child rules.
    • Add .children-eat-margin class to .row elements, to neutralize margins in column elements.
    • Add gy-5 class for vertical margin between columns in mobile viewport.
    • Add .bcl-text class as a wrapper for rich text, and set margin-top for h* headings within these rich text blocks. Use .eat-margin or eat-margin-top to neutralize the margin-top of the first element, or allow margin collapse with the margin-top of the parent element.
    • Add margin-top to other elements as needed, now that we can absorb it with eat-margin.

Scope

  • Only applied to some content type pages for proof-of-concept.
  • Some pages show alternative solutions. E.g. for publication I add mt-5 to h2 headings instead of wrapping the sections.
Created at 1 month ago

OEL-1500: Change: Remove classes in rich text.

OEL-1500: Change: Add '.bcl-text' class with top margins for h1..h6 headings.

OEL-1500: Change: Make a second full page for news.

Created at 1 month ago
donquixote create branch OEL-1500-Andreas
Created at 1 month ago
issue comment
[4.4] [Yaml] dumper fix and refactor

So we need to change this into a "fix only" branch.

Created at 1 month ago

cs fix

[Yaml] Restore two failing test methods in DumperTest.

Unlike in 4.4, in 6.0 these failing calls throw exceptions.

Dumper: Refactor: Use early return to drop else.

Dumper: Refactor: Break long sprintf() calls to multiple lines.

Dumper: Refactor: Use string concat instead of sprintf.

Dumper: Refactor: Move shared concat parts to shared place in code.

Dumper: Refactor: Drop some local variables when handling multi-line literal block.

Dumper: Refactor: Simplify condition in multi-line literal block.

Dumper: Refactor: Introduce $this->indentStr to reduce number of str_repeat() calls.

Dumper + DumperTest: Fix and simplify TaggedValue dumping.

Dumper: Refactor: Move inline check to a separate method.

Dumper: Refactor inline check, part I.

Dumper: Refactor inline check, part II.

Dumper: Refactor inline check, part III.

Dumper + DumperTest: Fix TaggedValue in top level.

Created at 1 month ago
issue comment
[6.0] [Yaml] Restore two failing test methods in DumperTest.

We'd better merge the PR fixing these issues rather than merging "expected failures". That would better align with our processes.

I like a strategy where we document known issues as tests with @todo or some other marker. So we would have a "known issue" in 6.0, but a fix in 6.2. But I am aware this is not the common way of doing things. So ok.

Created at 1 month ago

[Serializer] Respect default context in DateTimeNormalizer::denormalize

fixes #29030

[HttpKernel] [HttpCache] Don't throw on 304 Not Modified

[Serializer] Fix inconsistent behaviour of nullable objects in key/value arrays

Fixes symfony/45883

Added toHexString method to AbstractUid class

[Validator] Add the match option to the Choice constraint

[HttpFoundation] Test invalid cookie regeneration

Asserts that validateId logic in AbstractSesssionHandler correctly protects against session fixation attempts by regenerating the session id.

[DependencyInjection] Optimize autowiring logic by telling it about excluded symbols

made max_per_second option configurable by dsn

[HttpKernel][ErrorHandler] Add favicon to welcome and error pages

updated version to 6.2

Update branch alias for contracts

Update backers of Symfony 6.2: thank you Les-Tilleuls.coop and Sulu!

Merge branch '6.1' into 6.2

  • 6.1: do not accept array input when a form is not multiple Update PR template [FrameworkBundle] fix tests Fix merge [Mime] Throw exception when body in Email attach method is not ok [VarDumper][VarExporter] Deal with DatePeriod->include_end_date on PHP 8.2 [Cache] Throw when "redis_sentinel" is used with a non-Predis "class" option New bundle path convention when AbstractBundle is used fix merge Bootstrap 4 fieldset for row errors [Form] Fix same choice loader with different choice values [Filesystem] Safeguard (sym)link calls Fix dumping extension config without bundle [HttpClient] Honor "max_duration" when replacing requests with async decorators [FrameworkBundle] Simplify registration of #[AsRoutingConditionService] [HttpClient] Add missing HttpOptions::setMaxDuration() [HttpKernel] Fix missing null type in ErrorListener::__construct() [HttpFoundation] [Session] Overwrite invalid session id

Merge branch '6.1' into 6.2

  • 6.1: Fix merge Fix merge [FrameworkBundle] fix tests [FrameworkBundle] fix wiring of annotations.cached_reader [SecurityBundle] Remove dead class_exists checks Fix BC break [DependencyInjection] Ignore unused bindings defined by attribute [ErrorHandler] update tentative types

[DependencyInjection] Optimize dumped container

[Routing] Add Requirement::POSITIVE_INT for common ids and pagination

Merge branch '6.1' into 6.2

  • 6.1: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"

Merge branch '6.1' into 6.2

  • 6.1: [ExpressionLanguage] Fix null-safe chaining [Console] Complete negatable options (Fish) [PropertyInfo] Fix resolution of partially docblock covered constructors [DependencyInjection] Fix "proxy" tag: resolve its parameters and pass it to child definitions Complete negatable options

[VarExporter] Add Hydrator::hydrate() and preserve PHP references when using it

feature #46452 [DependencyInjection] Add Hydrator::hydrate() and preserve PHP references when using it (nicolas-grekas)

This PR was merged into the 6.2 branch.

Discussion

[DependencyInjection] Add Hydrator::hydrate() and preserve PHP references when using it

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | -

To make it easy to hydrate already created objects (usually created without calling the constructor.)

  • Add Hydrator::hydrate()
  • Preserve PHP references also when using Hydrator::hydrate() or Instantiator::instantiate()
  • Add support for hydrating from native (array) casts

Commits

e1a8502376 [VarExporter] Add Hydrator::hydrate() and preserve PHP references when using it

Created at 1 month ago

cs fix

[Yaml] Restore two failing test methods in DumperTest.

Unlike in 4.4, in 6.0 these failing calls throw exceptions.

Created at 1 month ago

cs fix

Dumper: Refactor: Use early return to drop else.

Dumper: Refactor: Break long sprintf() calls to multiple lines.

Dumper: Refactor: Use string concat instead of sprintf.

Dumper: Refactor: Move shared concat parts to shared place in code.

Dumper: Refactor: Drop some local variables when handling multi-line literal block.

Dumper: Refactor: Simplify condition in multi-line literal block.

Dumper: Refactor: Introduce $this->indentStr to reduce number of str_repeat() calls.

Dumper + DumperTest: Fix and simplify TaggedValue dumping.

Dumper: Refactor: Move inline check to a separate method.

Dumper: Refactor inline check, part I.

Dumper: Refactor inline check, part II.

Dumper: Refactor inline check, part III.

Dumper + DumperTest: Fix TaggedValue in top level.

Created at 1 month ago

Dumper: Refactor: Use string concat instead of sprintf.

Dumper: Refactor: Move shared concat parts to shared place in code.

Dumper: Refactor: Drop some local variables when handling multi-line literal block.

Dumper: Refactor: Simplify condition in multi-line literal block.

Dumper: Refactor: Introduce $this->indentStr to reduce number of str_repeat() calls.

Dumper + DumperTest: Fix and simplify TaggedValue dumping.

Dumper: Refactor: Move inline check to a separate method.

Dumper: Refactor inline check, part I.

Dumper: Refactor inline check, part II.

Dumper: Refactor inline check, part III.

Dumper + DumperTest: Fix TaggedValue in top level.

Created at 1 month ago
pull request opened
[Yaml] Restore two failing test methods in DumperTest.

The methods were lost in merge commit 8752c8bf3d4243e710e533b9880243d123e90c0e - too bad we can't show a direct diff between two commits for a single file in github.

The test methods document the misbehavior as known issues. They will be changed when the failing behavior is fixed in #46731.

Unlike in 4.4, in 6.0 these failing calls throw exceptions.

| Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follow-up to PR #46739 | License | MIT | Doc PR |

Created at 1 month ago
create branch
donquixote create branch yaml-tests-6-0
Created at 1 month ago
issue comment
[Yaml] Improve test coverage in DumperTest and ParserTest

Oh no! Two methods in DumperTest were lost when merging to 6.0 :(

testDumpingTaggedValueTopLevelAssoc() testDumpingTaggedValueTopLevelMultiLine()

Created at 1 month ago
pull request opened
[4.4] Yaml dumper fix and refactor

Backport of #46731 to 4.4.

| Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no, but increased completeness of existing feature | Deprecations? | no | Tickets | Fixes #46725, relates to #46718 and #46728. | License | MIT | Doc PR | -

Check individual commits when reviewing! The idea is that every commit should have a passing test.

Created at 1 month ago
create branch
donquixote create branch yaml-Dumper-fix-and-refactor-4x
Created at 1 month ago
issue comment
[Yaml] Dumper fix and refactor

If I rebase on 4.4, do we want to support PHP 7.1? The composer.json says so. With 7.1 we cannot even use composer2 :) But maybe this is exactly the point, to support legacy projects.

I am not sure if we actually do want to go for 4.4, so I make that a separate PR and we can choose.

Created at 1 month ago
issue comment
[Yaml] Dumper fix and refactor

@nicolas-grekas Thanks! What is a good base to rebase on? We want to merge this into all branches later, right?

Created at 1 month ago