derrabus
Repos
118
Followers
256
Following
109

The Symfony PHP framework

27475
8589

Doctrine Object Relational Mapper (ORM)

9365
2334

Doctrine Database Abstraction Layer

8817
1185

A web interface for MySQL and MariaDB

6199
3077

Replacement for the ereg legacy php extension

11
1

🍻 Default formulae for the missing package manager for macOS (or Linux)

11692
10459

Events

Update index.rst

Thank you for your PR. Please try to find a PR title that describes and summarizes what the PR is doing.

Created at 20 hours ago
pull request closed
catch \Throwable instead of \Exception

| Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR |

HttpKernel do not catch \TypeErrors to handle it later using kernel.exception event which is already implemented in symfony:6.2. According to minimum version of PHP this do not cause BC Breaks.

Created at 1 day ago
issue comment
catch \Throwable instead of \Exception

Your PR would introduce a breaking change into an LTS branch. The change you're suggesting has been implemented in a backwards-compatible manner in 6.2 via #45997. If you need this change, upgrade to Symfony 6.2.

Created at 1 day ago
issue comment
Deprecate driver name aliases

Being able to do one thing in four different ways (pgsql, postgres, postgresql, pdo-pgsql) has rarely been a good idea.

Even worse: pgsql:// might suggest that we're connecting through ext-pgsql while we're actually using PDO. And if we ever were to develop a driver for ext-pgsql (btw: do we want one?), we'd either need to use a non-intuitive URL schema for that or reassign pgsql:// which would be a breaking change.

So 👍🏻 from my side!

Created at 2 days ago
issue comment
2.13.2 Enum column - Object of class x could not be converted to x

@NotionCommotion Please provide a small application or a functional test case that reproduces your issue.

Created at 2 days ago
issue comment
[Validator] Add PHP 8.1 backed enums as Assert\Choice

@kconde2 Please use Discussions for support questions: https://github.com/symfony/symfony/discussions

Created at 3 days ago
issue comment
egulias/email-validator not being installed when installing symfony/symfony by "composer require symfony/synfony:^5.4"

Yes, you have to install this package yourself. Also, please don't use the monorepo as a dependency anymore. Use e.g. symfony/mime as a dependency if you want to use the MIME component.

Created at 3 days ago
pull request closed
Update Index.php

fix named arguments order like in UniqueConstraint and like in docs to avoid phpstorm codestyle warnings

Created at 3 days ago
issue comment
Update Index.php

Sorry, but that PhpStorm inspection is pointless. There's nothing to fix here.

Created at 3 days ago
issue comment
3.5.x

Thank you for your PR. Please pick a more meaningful PR title.

Probably should be ported to 4.x and 2.x

We don't maintain 2.x anymore.

Created at 3 days ago
delete branch
derrabus delete branch bump-phpstan-1.8.6
Created at 3 days ago
issue comment
Fix setting readonly properties in different scopes

It will only be executed if the isReadOnly-method is present, this will also check if PHP is 8.1 or higher, I am not sure if there is any performance impact on this.

There is: if (PHP_VERSION_ID >= 80100) can be optimized by the compiler. Apart from that, this check is easier to spot when we drop support for older PHP versions eventually. This is why I would prefer PHP version checks over feature detection in this case.

Created at 5 days ago
create branch
derrabus create branch bump-phpstan-1.8.6
Created at 5 days ago
pull request opened
phpstan 1.8.6

Created with brew bump-formula-pr.

Created at 5 days ago
issue comment
Fix commit order

What is the status of this PR?

Well, it has been open for a while. If it's still relevant, it needs a rebase and a functional test that reproduces the issues that it tries to fix.

Created at 6 days ago