dashpole
Repos
73
Followers
90
Following
9

Events

MetricProducer support

Problem Statement

https://github.com/open-telemetry/opentelemetry-specification/pull/2951 defined an experimental MetricProducer interface, which can be used to support metric bridges. Note that the specifications are experimental, so it isn't critical that it is implemented at this time.

Changes:

  • [ ] Define a MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
  • [ ] Define a RegisterProducer(metricProducer) function on MetricReader, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer
Created at 15 hours ago
MetricProducer support

Problem Statement

https://github.com/open-telemetry/opentelemetry-specification/pull/2951 defined an experimental MetricProducer interface, which can be used to support metric bridges. Note that the specifications are experimental, so it isn't critical that it is implemented at this time.

Changes:

  • [ ] Define a MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
  • [ ] Define a RegisterProducer(metricProducer) function on MetricReader, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer
Created at 15 hours ago
MetricProducers

The previous spec PR was closed in favor of https://github.com/open-telemetry/opentelemetry-specification/pull/2951, which is now merged. See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer for the MetricProducer spec, and https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer for the RegisterProducer(metricProducer) function on MetricReaders.

Created at 15 hours ago
OpenCensus metrics bridge

Problem Statement

After https://github.com/open-telemetry/opentelemetry-specification/pull/2951, and https://github.com/open-telemetry/opentelemetry-specification/pull/2979, we could implement a metric bridge for OpenCensus.

Note that the specifications are experimental, so it isn't critical that it is implemented at this time.

Changes:

  • [ ] Define a MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
  • [ ] Define a RegisterProducer(metricProducer) function on MetricReader, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer
  • [ ] Create an OpenCensus metric bridge which implements the MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md

cc @aabmass

Created at 15 hours ago
OpenCensus metric bridge

Problem Statement

After https://github.com/open-telemetry/opentelemetry-specification/pull/2951, and https://github.com/open-telemetry/opentelemetry-specification/pull/2979, we could implement a metric bridge for OpenCensus.

Note that the specifications are experimental, so it isn't critical that it is implemented at this time.

Changes:

  • [ ] Define a MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
  • [ ] Define a RegisterProducer(metricProducer) function on MetricReader, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer
  • [ ] Create an OpenCensus metric bridge which implements the MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md

cc @aabmass

Created at 15 hours ago
issue comment
Connected traces in the kubelet

The second attempt to plumb context succeeded. All that is needed is to add a span to connect traces together. Ideally, we only create a span when we need to do some work, and don't start a span if we know it will not have any children

Created at 17 hours ago
Spec-Compliant OpenCensus bridge

Problem Statement

After https://github.com/open-telemetry/opentelemetry-specification/pull/2951, and https://github.com/open-telemetry/opentelemetry-specification/pull/2979, we should update our OpenCensus bridge implementation to comply with the new specification.

Note that the specifications are experimental.

Requirements:

  • [ ] Define a MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
  • [ ] Define a RegisterProducer(metricProducer) function on MetricReader, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#registerproducermetricproducer
  • [ ] Update the OpenCensus metric bridge to implement the MetricProducer interface, following https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md
Created at 19 hours ago
issue comment
drop nvml from cadvisor and k/k

Some users may be using it with stand-alone cAdvisor

Created at 21 hours ago
issue comment
drop nvml from cadvisor and k/k

Is it possible to keep it, but not include it in the go module imported by k/k?

Created at 21 hours ago
issue comment
add github.com/mindprince/gonvml to unwanted dependencies

if so, can we drop nvml from cadvisor and k/k entirely now?

Yes, we should be able to drop NVML entirely now.

Created at 1 day ago
Normalization of exponential histograms correctly handles scale changes

marking it blocked SGTM.

Created at 1 day ago