danepowell
Repos
146
Followers
28

Events

push

CLI-856: Clarify .acquia-cli.yml filepath (#1176)

Created at 4 days ago
pull request closed
CLI-856: Clarify .acquia-cli.yml filepath

I had a bit of a brain fart and kept looking for this file in my home directory somewhere, I forgot it's project-local. Printing the full filepath would prevent confusion, and doing it directly from the datastore makes this future-proof.

Created at 4 days ago
issue comment
CLI-846: acli push:artifact is not copying over composer.json

@klaw772 I cannot reproduce this. Steps I took (must have access to the DevX Canary app):

  1. Clone https://github.com/acquia/drupal-canary-project
  2. acli push:artifact -vvv --destination-git-branch="CLI-846"

Please provide steps to reproduce the bug using an actual repo. You can put sensitive details in Jira.

Created at 4 days ago
push

DX-5170: Warn if xdebug active rather than loaded (#4601)

Created at 4 days ago
pull request closed
DX-5170: Warn if xdebug active rather than loaded
Created at 4 days ago
pull request opened
CLI-856: Clarify .acquia-cli.yml filepath

I had a bit of a brain fart and kept looking for this file in my home directory somewhere, I forgot it's project-local. Printing the full filepath would prevent confusion, and doing it directly from the datastore makes this future-proof.

Created at 4 days ago
create branch
danepowell create branch CLI-856
Created at 4 days ago
pull request opened
DX-5170: Warn if xdebug active rather than loaded
Created at 4 days ago
create branch
danepowell create branch DX-5170
Created at 4 days ago
push

CLI-848: Code style cleanup (#1175)

  • AcsfApi cleanup

  • CloudApi cleanup

  • CLI-848: Code style cleanup

Created at 5 days ago
pull request closed
CLI-848: Code style cleanup
Created at 5 days ago
pull request opened
Cli 848
Created at 5 days ago
create branch
danepowell create branch CLI-848
Created at 5 days ago
pull request closed
CLI-847: Attach acli.phar as GH artifact

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
Created at 6 days ago
push

CLI-847: Attach acli.phar as GH artifact (#1173)

  • CLI-847: Attach acli.phar as GH artifact

  • cleanup

Created at 6 days ago

cleanup

Created at 6 days ago
pull request opened
CLI-847: Attach acli.phar as GH artifact

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
Created at 6 days ago
create branch
danepowell create branch CLI-847
Created at 6 days ago
create tag
danepowell create tag 2.4.1
Created at 1 week ago
push

IDE-2272: Fix refresh token files (#1170)

Created at 1 week ago
pull request closed
IDE-2272: Fix refresh token files
Created at 1 week ago
pull request opened
IDE-2272: Fix refresh token files
Created at 1 week ago
create branch
danepowell create branch IDE-2272-2
Created at 1 week ago
create tag
danepowell create tag 2.4.0
Created at 1 week ago
push

CLI-838: SSH key upload timeouts (#1168)

  • CLI-838: SSH key upload timeouts

  • verbiage

Created at 1 week ago
pull request closed
CLI-838: SSH key upload timeouts

Motivation

Fixes CLI-838

Proposed changes

  • Modify ssh key upload warning message to mention specific times (>1 hour)
  • Tell customers to contact support if it takes too long (workarounds would be to re-use an existing key or delete the key and try again, and support should channel this into a PF)
  • Add this prompt to SSH key uploads in IDEs for consistency

Testing steps

  1. Follow the contribution guide to set up your development environment.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
Created at 1 week ago

CLI-837: Broken SSL certs cause pull:db to fail (#1165)

  • CLI-837: Broken SSL certs cause pull:db to fail

  • add client to service container

  • squash mutants

Merge branch 'main' into CLI-838

Created at 1 week ago

verbiage

Created at 1 week ago
push

CLI-837: Broken SSL certs cause pull:db to fail (#1165)

  • CLI-837: Broken SSL certs cause pull:db to fail

  • add client to service container

  • squash mutants

Created at 1 week ago
pull request closed
CLI-837: Broken SSL certs cause pull:db to fail

Motivation

Fixes CLI-837

Proposed changes

Use a plain Guzzle Client request since we're not actually calling the Cloud API the second time but the customer domain directly. This might break some minor features that were dependent on the Cloud client, such as progress reporting, but this seems like a small price to pay to support SSL fallback. Ultimately this is all a problem with Cloud API redirecting download requests instead of streaming them directly (which is what caused the SSL issue in the first place).

Shockingly, it seems we don't make raw Guzzle requests anywhere else in a way that requires mocking, so this requires adding a new service via DI.

Alternatives considered

Keep abusing the Acquia Cloud Client for the subsequent request like before. Doesn't seem smart.

Testing steps

  1. Follow the contribution guide to set up your development environment.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. acli pull:db c[SNIP]b.prod --no-import
  4. Try to gunzip the downloaded file. This would be invalid before, but should pass now.
Created at 1 week ago