152
29
Events
danepowell push acquia/cli
don't wait to build release
danepowell push acquia/cli
rotate bugsnag key
Replace abandoned composer package 'webmozart/path-util'
Unfortunately, I don't think we can do this until Drupal 9 is EOL, since Drupal 9 requires Symfony 4 and the path utilities were only added to Symfony 5.
CLI-1004: BugSnag reports from downstream projects
Fix #1445
Wish we had https://github.com/box-project/box/issues/890
CLI-1004: BugSnag reports from downstream projects
Projects that consume Acquia CLI as a library (which is super unsupported, by the way) are throwing errors that get caught by our BugSnag instance.
I think we should set the BugSnag token in bin/acli so that it only gets picked up during CLI execution. Or better still, inject it at build time so it's only present in the Phar.
danepowell push acquia/cli
CLI-1004: BugSnag reports from downstream projects (#1446)
-
CLI-1004: BugSnag reports from downstream projects
-
fixup
danepowell push danepowell/cli
fixup
Allow defining the env-like vars for inside the PHAR
I'd like to use this to pass semi-sensitive credentials as environment variables at runtime.
CLI-1004: BugSnag reports from downstream projects
Fix #1445
BugSnag reports from downstream projects
Projects that consume Acquia CLI as a library (which is super unsupported, by the way) are throwing errors that get caught by our BugSnag instance.
I think we should set the BugSnag token in bin/acli so that it only gets picked up during CLI execution.
Drush 8 warnings on PHP 8.1
This should be resolved in 8.4.12. Let's open new issues if there are unresolved issues with Drush 8 and PHP 8.
Drush 8 warnings on PHP 8.1
Describe the bug Running Drush 8 in a PHP 8.1 environment leads to deprecation warnings:
Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/ide/project/drush.phar/.box/src/RequirementCollection.php on line 14
Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/ide/project/drush.phar/.box/src/RequirementCollection.php on line 19
To Reproduce
Run drush using Drush 8 and PHP 8.1
Expected behavior No deprecation warnings
Actual behavior Deprecation warnings
Workaround It's just a warning so it doesn't block anything, but it is annoying
System Configuration
| Q | A | --------------- | --- | Drush version? | 8.4.11 | Drupal version? | none | PHP version | 8.1 | OS? | Linux
Additional information Looks like maybe this was intended to fix it, but it didn't: https://github.com/drush-ops/drush/pull/4978
danepowell push danepowell/cli
fix tests
CLI-996: [env:certificate-create] new command
Motivation
The existing api:environments:certificate-create command is difficult to use because you have to pass certificates as arguments, which can be thousands of characters, and the help text is incorrect and certificate --- lines are interpreted as Bash argument separators.
Proposed changes
Add a new command env:certificate-create that accepts filenames of certicates.
Alternatives considered
Change help text on api:environments:certificate-create to show people how to simply read a file as an argument. But the existing help text would still be broken.
Testing steps
- Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
- Clear the kernel cache to pick up new and changed commands:
./bin/acli ckc -
wacli env:certificate-create ~/Downloads/cert.pem ~/Downloads/key.pem foo.dev --ca_certificates=~/Downloads/ca.pem
danepowell push acquia/cli
Suppress missing php version file warnings (#1443)
danepowell push acquia/cli
Fix empty key and secret when running auth:login -q (#1442)
