danawoodman
Repos
183
Followers
145
Following
138

A React Font Awesome component.

670
74

An example SvelteKit app implementing a simple authentication system.

71
9

📇 Create a QR code with your contact details that anyone can scan to add your info to their contacts list.

7
1

Events

Created at 1 day ago
started
Created at 1 day ago
Created at 1 day ago
Created at 4 days ago
issue comment
Commit comment "Validation Failed"

Getting this as well, is there a solution to it? Using v20 as stated in docs

cc @amondnet

Created at 4 days ago
Feature request: Support for preview comment.

Hate to be "that guy", but can we get a bumpbump on this bad boy? Kinda makes this action worthless for PR deploys at this point.

Also, seems related to #90 #81

Created at 5 days ago
Created at 5 days ago

Move readme

Created at 1 week ago
create branch
danawoodman create branch main
Created at 1 week ago
create repository
danawoodman create repository
Created at 1 week ago
Created at 1 week ago
issue comment
Documentation needs to have examples

Chiming in here with the same sentiment. A lack of examples and at least a description of what the types do makes this (probably great) library much less useful than it could be.

Here are some of the things that would help the docs site:

  • Add examples and a description of why you'd want to use it for every helper
  • Better search: Search seems broken, I just see Preparing search index. A cmd+k menu with quick search would be great.
  • Group helpers by category Any, Boolean, Class, etc with headings that are collapsible. There is a lot of extra "noise" with the prefixes in front of every sidebar link
  • Make the code samples legible, the highlighting theme is impossible to read (reported in issues a few times)
  • Don't navigate to a new URL on every change as this breaks the scroll position (SPA would work)

For reference, ere are just a few of the other tickets describing docs/examples related topics:

  • https://github.com/millsp/ts-toolbelt/issues/223
  • https://github.com/millsp/ts-toolbelt/pull/304
  • https://github.com/millsp/ts-toolbelt/issues/112
  • https://github.com/millsp/ts-toolbelt/pull/329
Created at 1 week ago
Display is toggling on hover of UI elements

When hovering over diff parts of an issue I'm seeing a weird toggling of the display:

Screen Recording 2023-03-15 at 12 51 58 PM

Created at 1 week ago
Created at 2 weeks ago
issue comment
--ignore flag is not working for build commands in package scripts

Same here, literally copy-pasted from the docs turbo run build --ignore="apps/**/*" but build is running in the apps/ folder

{
  "scripts": {
    "build:packages": "turbo run build --ignore=\"apps/**/*\"",
  }
}

Seems ignore is broken?

Created at 2 weeks ago
issue comment
safeParse discriminated union doesn't have 'error' attribute

I've noticed that this issue as well:

const foo = z.string().safeParse('hi')
if (!foo.success) throw foo.error // Property 'error' does not exist on type 'SafeParseSuccess<string>'.
console.log(foo.data)

image

The resp.success === false workaround works but feels awkward/buggy behavior as I've been able to use !resp.success previously (not sure if this is a newly introduced issue?)

Using Zod 3.21.4 and TypeScript 4.9.5 (both latest as of writing)

Created at 2 weeks ago
issue comment
@sveltejs/adapter-cloudflare v2.2.0 always triggers hooks on build

@Conduitry yeah, I had a feeling it was from #9294 as well based on it being the main change from 2.1.0 to 2.2.0.

I could probably do that, but as @stefandevo says, it is a weird workaround/hack. I would assume that Kit would not run my hooks if I have no pre-rendering configured anywhere. For now I'll stay on 2.1.0 but if we decide to update I'll do the suggestion you offer, thanks 👍

Created at 2 weeks ago
opened issue
@sveltejs/adapter-cloudflare v2.2.0 always triggers hooks on build

Describe the bug

Took a while to track down the cause of this, but I recently updated to adapter-cloudflare 2.2.0 and my builds started to break.

It appears a change from 2.1.0 to 2.2.0 now always triggers hooks.server.js to run, even if there are no configured prerenderable routes, which then triggers my auth middleware which redirects the user to another domain if they have no authentication cookie set (see hooks.server.js in the repro repo).

v2.1.0 works fine and I can build without the hook getting triggered by the adapter, but now in 2.2.0 it always triggers and thus breaks the build. AFAIK this means that there is no way to build for CloudFlare anymore if you have such an auth hook in place.

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-g2rzrj?file=src/hooks.server.js

Logs

> Using @sveltejs/adapter-cloudflare
file:///Users/my-app/node_modules/@sveltejs/kit/src/core/postbuild/fallback.js:53
        throw new Error(`Could not create a fallback page — failed with status ${response.status}`);
              ^

Error: Could not create a fallback page — failed with status 302
    at generate_fallback (file:///Users/my-app/node_modules/@sveltejs/kit/src/core/postbuild/fallback.js:53:8)
    at async process.<anonymous> (file:///Users/my-app/node_modules/@sveltejs/kit/src/utils/fork.js:25:17)
error during build:
Error: Failed with code 1
    at ChildProcess.<anonymous> (file:///Users/my-app/node_modules/@sveltejs/kit/src/utils/fork.js:68:13)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess.emit (node:domain:489:12)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)


### System Info

```Shell
System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M2
    Memory: 740.67 MB / 24.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.19.0 - ~/Library/Caches/fnm_multishells/80853_1678404247439/bin/node
    npm: 8.19.3 - ~/Library/Caches/fnm_multishells/80853_1678404247439/bin/npm
  Browsers:
    Brave Browser: 106.1.44.112
    Chrome: 111.0.5563.64
    Firefox: 103.0
    Safari: 16.3
  npmPackages:
    @sveltejs/adapter-auto: 2.0.0 => 2.0.0 
    @sveltejs/adapter-cloudflare: 2.1.0 => 2.1.0 
    @sveltejs/kit: 1.11.0 => 1.11.0 
    svelte: 3.55.1 => 3.55.1 
    vite: 4.1.4 => 4.1.4

Severity

annoyance

Additional Information

No response

Created at 2 weeks ago
Created at 2 weeks ago
Created at 3 weeks ago
create repository
danawoodman create repository
Created at 3 weeks ago
create branch
danawoodman create branch main
Created at 1 month ago
create repository
danawoodman create repository
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
Created at 1 month ago
issue comment
[BUG] "npm outdated" always returns all outdated dependencies when passing "--workspace" argument (v8 and v9)

That feeling when you hit the same issue, google it and then realize you've already filed a bug for it 🤦

Created at 1 month ago