daixiang0
Repos
65
Followers
109

GCI, a tool that control golang package import order and make it always deterministic.

202
35

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.

11230
1688

Fast linters Runner for Go

11569
1089

Cloud-native high-performance edge/middle/service proxy

21008
3781

Events

opened issue
compatibility with tokio

I want to print metrics of Tokio example with master HEAD, then I get below error:


error[E0308]: mismatched types
    --> examples/tinyhttp.rs:40:51
     |
40   |         let runtime_monitor = RuntimeMonitor::new(&handle);
     |                               ------------------- ^^^^^^^ expected struct `tokio::runtime::handle::Handle`, found struct `Handle`
     |                               |
     |                               arguments to this function are incorrect
     |
     = note: expected reference `&tokio::runtime::handle::Handle`
                found reference `&Handle`
     = note: perhaps two different versions of crate `tokio` are being used?
note: associated function defined here
    --> /root/github/tokio-metrics/src/runtime.rs:1015:12
     |
1015 |     pub fn new(runtime: &runtime::Handle) -> RuntimeMonitor {
     |            ^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `examples` due to previous error

Full change in Tokio:

diff --git a/.cargo/config b/.cargo/config
index df885898..71097e3c 100644
--- a/.cargo/config
+++ b/.cargo/config
@@ -1,2 +1,5 @@
+[build]
+rustflags = ["--cfg", "tokio_unstable"]
+rustdocflags = ["--cfg", "tokio_unstable"]
 # [build]
-# rustflags = ["--cfg", "tokio_unstable"]
\ No newline at end of file
+# rustflags = ["--cfg", "tokio_unstable"]
diff --git a/examples/Cargo.toml b/examples/Cargo.toml
index b35c587b..e628ceb2 100644
--- a/examples/Cargo.toml
+++ b/examples/Cargo.toml
@@ -10,7 +10,7 @@ edition = "2018"
 tokio = { version = "1.0.0", path = "../tokio", features = ["full", "tracing"] }
 tokio-util = { version = "0.7.0", path = "../tokio-util", features = ["full"] }
 tokio-stream = { version = "0.1", path = "../tokio-stream" }
-
+tokio-metrics = { version = "0.1.0", path = "../../tokio-metrics" }
 tracing = "0.1"
 tracing-subscriber = { version = "0.3.1", default-features = false, features = ["fmt", "ansi", "env-filter", "tracing-log"] }
 bytes = "1.0.0"
@@ -24,6 +24,9 @@ httpdate = "1.0"
 once_cell = "1.5.2"
 rand = "0.8.3"

+
+
+
 [target.'cfg(windows)'.dev-dependencies.windows-sys]
 version = "0.42.0"

diff --git a/examples/tinyhttp.rs b/examples/tinyhttp.rs
index fa0bc669..0457406a 100644
--- a/examples/tinyhttp.rs
+++ b/examples/tinyhttp.rs
@@ -18,8 +18,10 @@ use futures::SinkExt;
 use http::{header::HeaderValue, Request, Response, StatusCode};
 #[macro_use]
 extern crate serde_derive;
+use std::time::Duration;
 use std::{env, error::Error, fmt, io};
 use tokio::net::{TcpListener, TcpStream};
+use tokio_metrics::RuntimeMonitor;
 use tokio_stream::StreamExt;
 use tokio_util::codec::{Decoder, Encoder, Framed};

@@ -33,6 +35,18 @@ async fn main() -> Result<(), Box<dyn Error>> {
     let server = TcpListener::bind(&addr).await?;
     println!("Listening on: {}", addr);

+    let handle = tokio::runtime::Handle::current();
+    {
+        let runtime_monitor = RuntimeMonitor::new(&handle);
+        tokio::spawn(async move {
+            for interval in runtime_monitor.intervals() {
+                // pretty-print the metric interval
+                println!("{:?}", interval);
+                // wait 500ms
+                tokio::time::sleep(Duration::from_secs(1)).await;
+            }
+        });
+    }
     loop {
         let (stream, _) = server.accept().await?;
         tokio::spawn(async move {

Command:

RUSTFLAGS="--cfg tokio_unstable" cargo run --example tinyhttp
Created at 5 hours ago

Fix multiple race conditions when resiliency is enabled (#5538)

  • Fixed race conditions in pkg/actors

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes in pkg/http

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race conditions in pkg/grpc

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race conditions in pkg/runtime

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes in pkg/messaging too and other fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 🤷

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • WIP

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Completed refactoring

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Updated deps

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Replace module in test app too

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Remove mod replace

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Upgrading dapr/kit

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed error unwrapping on service invocation

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fix log message

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Added unit test for bulk get timeout

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More unit tests (+ fixes) for bulk get

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: Alessandro (Ale) Segala 43508+ItalyPaleAle@users.noreply.github.com

  • Use generics rather than runtime assertions

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race condition in unit tests

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Address review feedback part 1

Co-authored-by: Mukundan Sundararajan 65565396+mukundansundar@users.noreply.github.com Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Do not modify a fasthttp context inside a policyRunner

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • so much improve

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com Signed-off-by: Alessandro (Ale) Segala 43508+ItalyPaleAle@users.noreply.github.com Co-authored-by: Yaron Schneider schneider.yaron@live.com Co-authored-by: Mukundan Sundararajan 65565396+mukundansundar@users.noreply.github.com

Update AKS version due to EOL for 1.22.x (#5580)

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Merge branch 'master' into graceperiod_5481

Created at 8 hours ago

fix: make image failed in darwin (#764)

Signed-off-by: bitliu bitliu@tencent.com

Signed-off-by: bitliu bitliu@tencent.com

Created at 21 hours ago

[file_system_http_cache] Add proto helpers (#23939)

The simplest of these helpers exist more to get around the envoy CI constraint that doesn't want us to use proto.SerializeToString; allowing this one file to perform specifically the required serialization operations makes more sense than allowing it more broadly in several files.

The only helper function here performing any cache-specific logic is updateProtoFromHeadersAndMetadata.

This is part 2 of #23175

Signed-off-by: Raven Black ravenblack@dropbox.com

Commit Message: [file_system_http_cache] Add proto helpers Additional Description: This is a small support class as part of of file_system_http_cache implementation. Risk Level: None, code is not yet used. Testing: Unit tested. Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

Signed-off-by: Raven Black ravenblack@dropbox.com

Change OpenTelemetry grpc access logger to use unary RPCs rather than streaming (#24268)

  • Make the OpenTelemetry access logger use a non streaming GRPC client

Signed-off-by: itamarkam itamark@google.com

build(deps): bump charset-normalizer from 2.0.12 to 3.0.1 in /mobile/docs (#24229)

build(deps): bump charset-normalizer in /mobile/docs

Bumps charset-normalizer from 2.0.12 to 3.0.1.


updated-dependencies:

  • dependency-name: charset-normalizer dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 21 hours ago

Update AKS version due to EOL for 1.22.x (#5580)

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Created at 21 hours ago

[core] Parse --threads option

Created at 22 hours ago

reduce unnecessary workload handler calls (#42216)

Created at 22 hours ago

Update (#1140)

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Created at 22 hours ago
Created at 1 day ago
issue comment
deps: updates wazero to 1.0.0-pre.4

It is pre-release, not very stable, could we wait for the next release?

Created at 1 day ago
issue comment
deps: updates wazero to 1.0.0-pre.4

breaks GoModuleFunc API

How did it affect Dapr?

Created at 1 day ago

docs: Updated documentation for OCI Object Storage, added link to (#5928)

blog post

Signed-off-by: Ali Mukadam ali.mukadam@oracle.com

Signed-off-by: Ali Mukadam ali.mukadam@oracle.com

Created at 1 day ago

Fix ServiceEntries using DNS_ROUND_ROBIN (#42185)

  • add release note

  • Fix release notes

  • add check for >1 endpoints

  • Add test case for 0 endpoints

  • Update 42184.yaml

  • Update 42184.yaml

Automator: update proxy@master in istio/istio@master (#42225)

1

Signed-off-by: Loong loong.dai@intel.com

Created at 1 day ago

infra: wait for job succeeded (#750)

  • infra: wait for job succeeded

Signed-off-by: hejianpeng hejianpeng2@huawei.com

  • update

Signed-off-by: hejianpeng hejianpeng2@huawei.com

Signed-off-by: hejianpeng hejianpeng2@huawei.com

Created at 1 day ago

stats: disable virtual cluster histograms (#2712)

Description: Disable histograms used to track the duration of time requests routed to a given virtual cluster take. That's to reduce the potential impact of adding a lot of virtual cluster stats to Envoy Mobile. Risk Level: Low Testing: Docs Changes: Release Notes:

Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard jp@jpsim.com

android proxy: fix initial proxy settings state (#2709)

Description: Upon investigation of multiple sessions with active proxy settings it seems to be highly likely that our EM proxy logic did not engage in all of the aforementioned sessions. That appears to be a direct result of the way our logic for registering to PROXY_CHANGE intent works. The implementation assumes that upon subscription to the intent we always receive an initial intent with the state of proxy settings. That does not seem to be guaranteed by Android as PROXY_CHANGE intent is not documented to be sticky (a term used by Android) and whether it's sticky or not may depend on manufacturer / type of the proxy update. Risk Level: Low, hidden behind a feature flag and disabled by default. Testing: Integration tests Docs Changes: N/A Release Notes: N/A

Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard jp@jpsim.com

gcp_authn: Modify the token time constraint check (#23366)

  • gcp_authn: Modify the token time constraint check

Signed-off-by: Tianyu Xia tyxia@google.com

uhv: path normalization (#22707)

Signed-off-by: Adam Meily adam.meily@trailofbits.com

listener: refactors to use a listener manager impl factory (#24245)

Risk Level: medium (should be pure refactor) Testing: n/a Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy-mobile#2711

Signed-off-by: Alyssa Wilk alyssar@chromium.org

formatter: fix parameter type (#24263)

Signed-off-by: Michael Kaufmann michael.kaufmann@ergon.ch

Risk Level: Low

feat(hds): allow to configure upstream bind address for HDS (#24053)

Sometimes when an application doesn't bind to localhost and the machine uses iptables for traffic redirection, HDS might need to override the source address for iptables to redirect traffic to the application instead of getting into the loop. Risk Level: Low Testing: small unit test configuration, upstream cluster tests binding functionality, manual testing Docs Changes: API docs Release Notes: Platform Specific Features: no

Signed-off-by: Łukasz Dziedziak lukidzi@gmail.com

upstream: not parse bootstrap upstream config when cluster upstream config specified (#24257)

Signed-off-by: He Jie Xu hejie.xu@intel.com

tls: SNI-based cert selection during TLS handshake (#22036)

Envoy supports selecting certs by selecting filter chain based on SNI. But it is possible that we access different services via one filter chain, which requires SNI-based cert selection in one single filter chain during handshake.

Signed-off-by: Luyao Zhong luyao.zhong@intel.com

Refactor: Filter Manager (#24267)

Commit Message: Rename overloaded term (dual filter), Remove unnecessary duplicated bit in base class. Additional Description: N/A Risk Level: low Testing: ran filter tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

Created at 1 day ago

Fix multiple race conditions when resiliency is enabled (#5538)

  • Fixed race conditions in pkg/actors

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes in pkg/http

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race conditions in pkg/grpc

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race conditions in pkg/runtime

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes in pkg/messaging too and other fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 🤷

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • WIP

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Completed refactoring

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More fixes

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Updated deps

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Replace module in test app too

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Remove mod replace

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Upgrading dapr/kit

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed error unwrapping on service invocation

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fix log message

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Added unit test for bulk get timeout

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • More unit tests (+ fixes) for bulk get

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: Alessandro (Ale) Segala 43508+ItalyPaleAle@users.noreply.github.com

  • Use generics rather than runtime assertions

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Fixed race condition in unit tests

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • 💄

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Address review feedback part 1

Co-authored-by: Mukundan Sundararajan 65565396+mukundansundar@users.noreply.github.com Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • Do not modify a fasthttp context inside a policyRunner

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

  • so much improve

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com

Signed-off-by: ItalyPaleAle 43508+ItalyPaleAle@users.noreply.github.com Signed-off-by: Alessandro (Ale) Segala 43508+ItalyPaleAle@users.noreply.github.com Co-authored-by: Yaron Schneider schneider.yaron@live.com Co-authored-by: Mukundan Sundararajan 65565396+mukundansundar@users.noreply.github.com

Created at 1 day ago

Additional tests for Hashicorp Vaul Secret Store certification.

  • This PR adds additional tests to complete vault certification. A detailed test plann is added to its README.
  • Fixes a vault behaviour regarding its multiple key-values per secret behaviour when its valueType flag is set to text.

This is a follow up to dapr/components-contrib#2140.

Closes #1926.

Signed-off-by: Tiago Alves Macambira tmacam@burocrata.org

Fixes in response to code review.

  • Removes emojis from output
  • Auto-generate certificates on the fly
  • Move helper methods out of vault_test.go and into helper files.

Signed-off-by: Tiago Alves Macambira tmacam@burocrata.org

Small fixes (documentation, comments)

Signed-off-by: Tiago Alves Macambira tmacam@burocrata.org

Merge branch 'master' into VaultMoreTestsRebased

Allow HTTP binding to not error on non-200 responses

Signed-off-by: John Ewart john@johnewart.net

Update tests to be a little more isolated

Signed-off-by: John Ewart john@johnewart.net

gofumpt'd

Signed-off-by: John Ewart john@johnewart.net

Fix naming to make ci-linter happy

Signed-off-by: John Ewart john@johnewart.net

Enforce error checking for Vault component initialization on tests.

Tests in vault_test.go had the following :

    // This call will throw an error on Windows systems because of the of
    // the call x509.SystemCertPool() because system root pool is not
    // available on Windows so ignore the error for when the tests are run
    // on the Windows platform during CI
    _ = target.Init(m)

As of Go 1.18 this is not the case for Windows anymore and we can instead enforce error checking. References:

  • https://github.com/golang/go/issues/16736
  • https://github.com/golang/go/issues/18609
  • https://github.com/rancher/system-agent/pull/84
  • https://github.com/jaegertracing/jaeger/pull/2756

Given Dapr depends on Go 1.19, we can enforce tests on Init result and remove this comment.

While enforcing error checking we notice that the code above was actually hiding errors in the test setup. Component initialization was ending prematurely due to those errors and the test code was wrongfully testing for the behavior of a component that has not been successfully initialized. This is also addressed in this PR.

Closes #2330.

Signed-off-by: Tiago Alves Macambira tmacam@burocrata.org

Merge pull request #2331 from tmacam/SystemCertPoolWorksInWindows

Merge branch 'master' into allow_http_binding_non_200_response

Add missing filter subject in Jetstream pubsub (#2312)

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Signed-off-by: Tomasz Pietrek tomasz@nats.io Co-authored-by: Bernd Verst 4535280+berndverst@users.noreply.github.com Co-authored-by: Dapr Bot 56698301+dapr-bot@users.noreply.github.com

Merge branch 'master' into allow_http_binding_non_200_response

Merge branch 'master' into VaultMoreTestsRebased

Merge pull request #2316 from tmacam/VaultMoreTestsRebased

Additional tests for Hashicorp Vaul Secret Store certification.

Merge branch 'master' into allow_http_binding_non_200_response

Merge pull request #2321 from johnewart/allow_http_binding_non_200_response

Allow non-200 responses to be treated as non-errors

Created at 1 day ago
issue comment
Fix multiple race conditions when resiliency is enabled

Agree that generics may be better to put in a single PR.

Created at 1 day ago

fuzz: fix build (#42201)

Now it is not a testing.T passed but another T. So use an interface.

Remove our skip() hacks which were upstreamed

1

Signed-off-by: Loong loong.dai@intel.com

Created at 1 day ago

[chore] npm audit fix

[test] Parse and decode HTTP/1 responses for verification in testcases

[sample] Add inbound/outbound TLS to samples/sidecar

Created at 1 day ago

upgrade kiali to latest version 1.60.0 (#42193)

  • upgrade kiali to latest version 1.60.0

  • update annotation checksum

  • related with https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/42193/gencheck_istio/1597779053383782400

1

Signed-off-by: Loong loong.dai@intel.com

Created at 1 day ago

ci: Remove unused submodules config (#24211)

this also allows the the checkout action to be updated

Signed-off-by: Ryan Northey ryan@synca.io

Created at 1 day ago

tests: fix a typo (#5236)

Signed-off-by: Loong loong.dai@intel.com

net: update try_io docs with interest limitations (#5222)

Box Futures in #[tokio::test]

This reduces the amount of copies of the Runtime::block_on and related functions the compiler has to generate and LLVM process. We've seen it reduce the compilation time of our tests (some 1900 of them) from 40s down to 12s, with no impact on the runtime of tests.

Below is an output of llvm-lines for our tests.

Before:

Lines Copies Function name


8954414 156577 (TOTAL) 984626 (11.0%, 11.0%) 9289 (5.9%, 5.9%) std::thread::local::LocalKey::try_with 648093 (7.2%, 18.2%) 1857 (1.2%, 7.1%) tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}} 557100 (6.2%, 24.5%) 3714 (2.4%, 9.5%) tokio::park::thread::CachedParkThread::block_on 551679 (6.2%, 30.6%) 7430 (4.7%, 14.2%) tokio::coop::with_budget::{{closure}} 514389 (5.7%, 36.4%) 3714 (2.4%, 16.6%) tokio::runtime::scheduler::current_thread::Context::enter 326832 (3.6%, 40.0%) 1857 (1.2%, 17.8%) tokio::runtime::scheduler::current_thread::CurrentThread::block_on 291549 (3.3%, 43.3%) 1857 (1.2%, 19.0%) tokio::runtime::scheduler::current_thread::CoreGuard::enter 261907 (2.9%, 46.2%) 7430 (4.7%, 23.7%) tokio::coop::budget 189468 (2.1%, 48.3%) 7430 (4.7%, 28.5%) tokio::coop::with_budget 137418 (1.5%, 49.8%) 3714 (2.4%, 30.8%) tokio::runtime::enter::Enter::block_on 126276 (1.4%, 51.3%) 1857 (1.2%, 32.0%) tokio::runtime::Runtime::block_on 124419 (1.4%, 52.6%) 1857 (1.2%, 33.2%) tokio::macros::scoped_tls::ScopedKey::set 118897 (1.3%, 54.0%) 3715 (2.4%, 35.6%) core::option::Option::or_else 111420 (1.2%, 55.2%) 1857 (1.2%, 36.8%) tokio::runtime::scheduler::current_thread::CurrentThread::block_on::{{closure}} 109408 (1.2%, 56.4%) 2105 (1.3%, 38.1%) <core::future::from_generator::GenFuture as core::future::future::Future>::poll 105893 (1.2%, 57.6%) 9289 (5.9%, 44.0%) std::thread::local::LocalKey::with 96564 (1.1%, 58.7%) 1857 (1.2%, 45.2%) tokio::runtime::scheduler::current_thread::Context::run_task 90993 (1.0%, 59.7%) 7428 (4.7%, 50.0%) tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}} 90515 (1.0%, 60.7%) 2105 (1.3%, 51.3%) core::pin::Pin<&mut T>::map_unchecked_mut 89136 (1.0%, 61.7%) 1857 (1.2%, 52.5%) tokio::runtime::scheduler::multi_thread::MultiThread::block_on

After:

Lines Copies Function name


3188618 41634 (TOTAL) 109408 (3.4%, 3.4%) 2105 (5.1%, 5.1%) <core::future::from_generator::GenFuture as core::future::future::Future>::poll 90515 (2.8%, 6.3%) 2105 (5.1%, 10.1%) core::pin::Pin<&mut T>::map_unchecked_mut 56220 (1.8%, 8.0%) 1874 (4.5%, 14.6%) alloc::boxed::Box::pin 48333 (1.5%, 9.5%) 2179 (5.2%, 19.8%) core::ops::function::FnOnce::call_once 28587 (0.9%, 10.4%) 1 (0.0%, 19.8%) XXXXXXXXXXXXXXXXXXX 18730 (0.6%, 11.0%) 1873 (4.5%, 24.3%) alloc::boxed::Box<T,A>::into_pin 16190 (0.5%, 11.5%) 2 (0.0%, 24.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 15870 (0.5%, 12.0%) 2 (0.0%, 24.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 15250 (0.5%, 12.5%) 1 (0.0%, 24.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXX 12801 (0.4%, 12.9%) 2 (0.0%, 24.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 12801 (0.4%, 13.3%) 2 (0.0%, 24.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 12630 (0.4%, 13.7%) 2105 (5.1%, 29.4%) <core::future::from_generator::GenFuture as core::future::future::Future>::poll::{{closure}} 12613 (0.4%, 14.1%) 2 (0.0%, 29.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 12613 (0.4%, 14.5%) 2 (0.0%, 29.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 12613 (0.4%, 14.9%) 2 (0.0%, 29.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 12613 (0.4%, 15.3%) 2 (0.0%, 29.4%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX 11395 (0.4%, 15.7%) 96 (0.2%, 29.7%) alloc::alloc::box_free 11364 (0.4%, 16.0%) 1891 (4.5%, 34.2%) <T as core::convert::Into>::into 11238 (0.4%, 16.4%) 1873 (4.5%, 38.7%) alloc::boxed::<impl core::convert::From<alloc::boxed::Box<T,A>> for core::pin::Pin<alloc::boxed::Box<T,A>>>::from 10735 (0.3%, 16.7%) 2 (0.0%, 38.7%) XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

Note that I have replaced our test functions with XXX. As you can clearly see they're not in the top 20 in the before output, while they're in the after oput.

Further note that the amount of copies have been reduced from 156577 to 41634.

Pin Future to stack in #[tokio::test]

Instead of boxing it.

Use #crate_ident in test macro

Instead of ::tokio.

Prepare tokio-macros 1.8.1

macros: fix span of body variable (#5244)

Merge branch 'master' into tinyhttp

Created at 2 days ago

macros: fix span of body variable (#5244)

Created at 2 days ago

push headless endpoint change when headless enabled or dns is enabled (#42165)

  • push headless endpoint change when headless enabled or dns is enabled

Signed-off-by: Rama Chavali rama.rao@salesforce.com

  • address comments

Signed-off-by: Rama Chavali rama.rao@salesforce.com

  • comments

Signed-off-by: Rama Chavali rama.rao@salesforce.com

Signed-off-by: Rama Chavali rama.rao@salesforce.com

Merge or Append ISTIO_KUBE_APP_PROBERS (#41652)

  • Merge or Append ISTIO_KUBE_APP_PROBERS

  • minor comment fix

  • fix format + lint

  • add test for re-injection testcase

  • lint fix

  • Fix comment

  • fix gen file

  • Fix format

  • fix lint

  • Parse injection status

  • fix comment

  • address lint / fumpt

  • Add cast check

  • fix merge-probers.yaml.38.template.gen.yaml

  • log line (temp)

  • Add test for empty container

  • remove log line

  • remove redundant return

Handle QAT PrivateKeyProvider configuration (#42203)

  • Handle QAT PrivateKeyProvider configuration

When the PrivateKeyProvider configuration information is provided through Istio operator yaml file, parse and pass it to gateway or sidecars. Envoy will act based on the information provided by the configuration.

To set the mesh wide defaults, configure the defaultConfig section of meshConfig. For example:

meshConfig: defaultConfig: privateKeyProvider: qat: pollDelay: 0.01s

This can also be configured on a per-workload basis by configuring the proxy.istio.io/config annotation on the pod. For example:

annotations: proxy.istio.io/config: | privateKeyProvider: qat: pollDelay: 0.01s

Note: Users should request QAT resources through k8s:resources.

  • add release notes

Automator: update proxy@master in istio/istio@master (#42211)

Update BASE_VERSION to master-2022-11-29T19-01-22 (#42204)

default vwh config differs - helm vs istioctl (#42209)

Signed-off-by: Faseela K faseela.k@est.tech

Signed-off-by: Faseela K faseela.k@est.tech

1

Signed-off-by: Loong loong.dai@intel.com

Created at 2 days ago

fix:about lint-deps (#751)

Signed-off-by: thredreams 1220474743@qq.com

Signed-off-by: thredreams 1220474743@qq.com

Support suffix matches for headers (#739)

  • Support suffix matches for headers

  • The gateway API allows wildcard hostnames such as *.example.com to be used in HTTPRoutes https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.Listener

  • Added a suffix match in the Xds IR as well as the xds matcher translation to support this case

Fixes: https://github.com/envoyproxy/gateway/issues/738

Signed-off-by: Arko Dasgupta arko@tetrate.io

  • run make generate

Signed-off-by: Arko Dasgupta arko@tetrate.io

  • rm whitespace in test file

Signed-off-by: Arko Dasgupta arko@tetrate.io

Signed-off-by: Arko Dasgupta arko@tetrate.io

chore: sync targets logs (#748)

Signed-off-by: bitliu bitliu@tencent.com

Created at 2 days ago

jni: fix cleanup on terminal callbacks (#1224)

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

python: update headers from impl experience (#1217)

Description: This PR contains only the header changes from #1209 which were made while developing. Risk Level: Low Testing: N/A, no behavior changes Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

python: implement enum-related code (#1220)

Description: This PR implements all of the enum-related code, like translating between string- and enum-representations. It also implements RetryPolicy, since it's related to RetryRule (and defined in the same file).

Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/orC++ Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

python: implement stream-related classes (#1218)

Description: This PR implements all of the stream-related classes: Stream, StreamCallbacks EnvoyHttpCallbacksAdapter, and StreamPrototype`.

Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/orC++ Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

python: implement bridge utilities (#1222)

Description: This implements all of the util functions used to convert between envoy-mobile types and cc-lib types. Note that right now it copies all data at the border between envoy-mobile and the cc-lib, which is inefficient. As noted in the TODO, this is going to be a good place for optimization.

Risk Level: Low Testing: N/A, will follow up with testing in only C++, since this won't be exposed into the Python layer. Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

python: engine implementation (#1223)

Description: This PR implements all of the engine-related classes, like Engine and EngineBuilder. Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/or C++ Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

Update envoy to e073b32 (#1230)

Description: this PR updates envoy and makes the following changes:

  • linux CI jobs now use the envoy-build-ubuntu container published by envoy-build-tools
  • updates upload/download-artifact to v2.
  • specified using remote jdk toolchain for the coverage build.
  • temporarily moves java and kt unit tests to macOS. Subsequent PR will move as many CI jobs as possible to run on linux runners, as this saves time via container execution; and concurrency as the linux limit is higher than the macOS limit.
  • updates protobuf dep to 3.14.0
  • updates metrics transport to V3 Api
  • updates bazel build targets used in several places in the codebase
  • Fixes warnings in C++ tests.

Risk Level: low for all jobs ran in CI. High for release and artifact jobs as they won't execute until a release is done, and they are most likely broken. Will fix after running. Testing: CI

Signed-off-by: Jose Nino jnino@lyft.com

Co-authored-by: Jose Nino jnino@lyft.com Signed-off-by: JP Simard jp@jpsim.com

python: http header impl (#1219)

Description: This PR implements all of the header-related classes--all of the request/response headers/trailers, their builders, and their base classes. Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/orC++ Docs Changes: N/A Release Notes: N/A

Signed-off-by: Cerek Hillen chillen@lyft.com Signed-off-by: JP Simard jp@jpsim.com

ci: set ndk version to 21 (#1238)

Description: Set ndk version to 21 for the Mac image. Github's Mac image installs latest version of ndk, which had been updated to 22 recently. Risk Level: low Testing: ci

Signed-off-by: Jingwei Hao jingwei.hao@gmail.com Signed-off-by: JP Simard jp@jpsim.com

error path: include LocalError filter in config (#1239)

Description: This crucial piece of config was missed in the original PR, thank you @junr03 for the catch. Risk Level: Moderate Testing: Local

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

ci: fix and consolidate release artifacts jobs (#1243)

Description: this PR fixes the android release job and caches the release artifacts to prevent double unnecessary compute time. Risk Level: med - confirm working with release tag. Testing: testing done in #1236. However, we will need to cut a release to verify final correctness

Signed-off-by: Jose Nino jnino@lyft.com Signed-off-by: JP Simard jp@jpsim.com

filters: refactor PlatformBridgeFilter and fix iteration state (#1245)

Description: Better encapsulates directional state in the filter chain, and allows for iteration state to be maintained independently in each direction, fixing a previous bug. Risk Level: Low Testing: Local & CI

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

filters: add support for data and trailers injection (#1246)

Description: Adds support for injecting data and/or trailers specifically during onResume() callbacks when resuming filter iteration asynchronously. This is accomplished by passing back data and/or trailers where none were originally present at the point of resumption. Risk Level: Moderate Testing: Local & CI

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

docs: update commands to reference bazelisk (#1247)

Description: bazelisk is the default and preferred way to build to ensure consistency as much as possible. This change updates the project's docs to refer to bazelisk when providing example build commands.

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

pull envoy 8e2286b (#1248)

Description: pull envoy 8e2286b for envoyproxy/envoy#14887 to fix ci Risk Level: low Testing: ci

Signed-off-by: Jingwei Hao jingweih@lyft.com Signed-off-by: JP Simard jp@jpsim.com

stats: adds metrics sink with ack (#1183)

Description: Replace the metrics sink from the envoy one to a custom one. The custom metrics sink comes with ack function on the grpc stream. This change is based on upstream envoy change: envoyproxy/envoy#13919 Risk Level: High Testing: Local and ci unit tests and integration tests

Signed-off-by: Jingwei Hao jingweih@lyft.com Signed-off-by: JP Simard jp@jpsim.com

stats: avoid string join during stats reporting (#1250)

Description: construct the stats name in constructor, avoid string join during stats reporting (inc, set, etc.) Risk Level: low Testing: unit, ci

Signed-off-by: Jingwei Hao jingweih@lyft.com Signed-off-by: JP Simard jp@jpsim.com

config: experiment with tighter keepalive configuration (#1252)

Description: This change will result in faster dead connection cycling at the expense of much busier connections once keepalive triggers. It's probably not an appropriate setting in all cases, but supports an experiment we're running with connection behavior on preferred interface switchovers. Applications can still override this to meet their specific requirements until we land a reasonable default. Augmenting this with h2 pings will give us quite a bit more flexibility. Risk Level: Low Testing: CI

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

errors: map locally-generated gRPC errors (#1251)

Description: Because Envoy may generate local grpc replies for grpc requests, this is required (for now) to maintain existing error mapping behavior. Risk Level: Low Testing: Pending grpc integration coverage

Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard jp@jpsim.com

pulse: expose histogram envoy stats methods to interface & engines (#1214)

Description: Expose the histogram stat in envoy/include/envoy/stats/ to envoy-mobile engine. This will be leveraged in subsequent PRs to support a new set of stats collection in the iOS and Android layers. Risk Level: Medium (due to changes in the core engine impl, but should be Low given no one depends on these APIs yet) Testing: Unit tests, CI, Build Envoy Mobile Library and compile into mobile apps to ensure that changes do not break the build. Docs Changes: Done in https://github.com/envoyproxy/envoy-mobile/blob/main/docs/root/api/stats.rst Release Notes: Expose histogram as a stat exposed via Pulse

Signed-off-by: Don Yu donyu@lyft.com Signed-off-by: JP Simard jp@jpsim.com

Created at 2 days ago