dahu33
Repos
23
Followers
8
Following
5

Events

started
Created at 2 days ago
pull request opened
Align config gpo.ignoreprice with txpool.pricelimit

Description

Just a config change, part of maticnetwork/launch#62.

Changes

  • [x] Bugfix (non-breaking change that solves an issue)
  • [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [ ] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • [x] I have added at least 2 reviewer or the whole pos-v1 team
  • [x] I have added sufficient documentation in code
  • [x] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • [ ] This PR requires changes to heimdall
    • In case link the PR here:
  • [ ] This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • [ ] I have added unit tests
  • [ ] I have added tests to CI
  • [ ] I have tested this code manually on local environment
  • [ ] I have tested this code manually on remote devnet using express-cli
  • [ ] I have tested this code manually on mumbai
  • [ ] I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Created at 1 week ago
dahu33 create branch gpo-ignoreprice
Created at 1 week ago
Created at 1 week ago
pull request opened
Align bor mainnet `gpo.ignoreprice` with `txpool.pricelimit`

Fixes #62.

Created at 1 week ago
opened issue
Bor `gpo.ignoreprice` should be aligned with `txpool.pricelimit`

When running Polygon Mainnet nodes using the provided config in this repository, the txpool.pricelimit (minimum gas price limit to enforce acceptance into the pool) is set to 30000000000 but the gpo.ignoreprice (gas price below which the gas price oracle will ignore transactions) is left to its default value of 2.

Because some validators on the network include transactions with gas price under 30 Gwei, the nodes gas price oracle may return a value under 30 Gwei when called with the JSON RPC eth_maxPriorityFeePerGas.

This is a recurring issue we've seen across many node providers leading to many transactions being rejected with the error {"code":-32000,"message":"transaction underpriced"} (when using the node gas price oracle).

The nodes gpo.ignoreprice and txpool.pricelimit settings should be aligned to remove the discrepancy between the minimum gas tip/priority price that nodes are willing to accept a transaction at and the suggested gas tip/priority price that nodes return.

Created at 1 week ago
dahu33 create branch gpo-ignoreprice
Created at 1 week ago
Created at 2 weeks ago
issue comment
Video attachment playback issues

Same problem here.

Created at 2 months ago
Created at 2 months ago
opened issue
Server variable input support

User Story Description

As an API user,

I want to input my server URL,

so I can try the API against the URL of my choice.


Currently an API user cannot input a value for a (non enum) server variable. Basically only the default or enum values are used.

Acceptance Criteria

  • [ ] User can input the server URL and use it with the Try It functionality.

Sprint Ready Checklist

  • [ ] Acceptance criteria defined
  • [ ] Team understands acceptance criteria
  • [ ] Team has defined solution / steps to satisfy acceptance criteria
  • [ ] Acceptance criteria is verifiable / testable
  • [ ] External / 3rd Party dependencies identified
Created at 2 months ago