ctalkington
Repos
24
Followers
105
Following
99

Events

Created at 4 days ago
issue comment
Skip over files without mime type in Jellyfin

thanks @j-stienstra for tackling things. I hopefully will be able to jump back in on things soon.

Created at 2 weeks ago

Add translation key for IPP printer integration (#84441)

  • Add translation key for IPP printer integration

  • Add tests

Created at 4 weeks ago
pull request closed
Add translation key for IPP printer integration

Proposed change

Add translation key for the printer sensor entity.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Created at 4 weeks ago
Interested in Partnering?

Roku recently axed PlayOnRoku for third parties in OS 11.5.

Are you interested in working with me and taking this solution you created to Roku Store as a public channel? Assuming we can get it past requirement.

I would then make it the preferred channel in rokuecp and HA integration.

Created at 1 month ago
issue comment
Roku Media player does not stream to "Play On Roku"

thanks for the information. I will have to see if we can pivot to using an already established channel for such.

Created at 1 month ago
issue comment
Jellyfin media browser show share password and failed on stub files

thanks for the report, I will try to review over the next weekend or Thanksgiving break.

Created at 2 months ago

Add integration_type for flick_electric (#81065)

  • Add integration_type for flick_electric

  • Updates from hassfest

Created at 2 months ago
pull request closed
Add integration_type for flick_electric

Proposed change

Super simple, adding integration_type to manifest. Wasn't sure if this was going to be done in bulk by core team, but if not then here you go 😊

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Created at 2 months ago
issue comment
Jellyfin movie library is broken

media source seems to work fine for me. what does your directory structure look like as that error mentions 'Data' but I dont see such in the request unless that's the parent folder? are you logged in as a restricted user or admin?

that method reporting the error comes in various issues on jellyfin so not sure that helps much.

Created at 2 months ago
issue comment
Jellyfin movie library is broken

yes there should be a media player for any recently active sessions (upon the integration startup). we still have some work to be done to support dynamically adding such for sessions that werent recently active until after integration starts.

as far as the media source, that predates my involvement but I do intend to get some tests going for it as I know there's atleast one other bug related to it. I don't have anything using media sources currently but will try to recreate over the weekend.

Created at 2 months ago