craue
Repos
44
Followers
78

Events

pull request opened
fixed issues with unintentional value changes when using the built-in form

This fixes issues with unintentional value changes when using the built-in form to manage settings.

When a new setting is added between rendering and submitting the form, values might be wrongly assigned to other settings. This happens because the settings used to be added as a collection whose fields are usually ordered by the settings' names. Now, if a setting is added in the database, the order of fields could change (depending on the new setting's name) but the submitted values are assigned to fields corresponding to the original order.

Additionally, values of settings not submitted by the form (i.e. not present in the request) used to be effectively set to null.

To illustrate both issues:

  1. given settings (and values): name1 (value1), name2 (value2)
  2. render the form
  3. add new setting name11 (value11) into the database
  4. submit the previously rendered form unchanged
  5. persisted settings: name1 (value1), name11 (value2), name2 (null)

Now with these fixes, the last step would correctly be:

  1. persisted settings: name1 (value1), name11 (value11), name2 (value2)

In order to fix these issues, form field names are now name-based (instead of previously index-based). Thus, form or template customizations need to be revised to reflect these changes.

Created at 1 week ago

fixed issues with unintentional value changes when using the built-in form

Created at 1 week ago
create branch
craue create branch fix-form
Created at 1 week ago

updated copyright year range

dropped support for Symfony 5.3, 6.0, 6.1

removed outdated information from the README file

migrated from Travis CI to GitHub Actions

Created at 1 week ago

dropped support for Symfony 5.3, 6.0, 6.1

removed outdated information from the README file

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

fixes issues with unintentional value changes when using the built-in form to manage settings

Created at 1 week ago

fixes issues with unintentional value changes when using the built-in form to manage settings

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

removed outdated information from the README file

migrated from Travis CI to GitHub Actions

Created at 1 week ago

dropped support for Symfony 5.3, 6.0, 6.1

migrated from Travis CI to GitHub Actions

Created at 1 week ago

dropped support for Symfony 5.3, 6.0, 6.1

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago

migrated from Travis CI to GitHub Actions

Created at 1 week ago