craiglabenz
Repos
43
Followers
106
Following
7

Events

issue comment
Feedback on "install SDK popup" experiment

fwiw, I completely agree with @lrhn on the desire to revert this.

Created at 3 weeks ago
issue comment
use_build_context_synchronously lint triggers for BuildContext argument, but not context property

This is a nice catch. And now that you mention it, I think back in the early summer I saw some folks describing this as "the workaround" for the new lint - oof!

Created at 3 weeks ago
Cloud Logging fix

improves GCP logging conformance of generated code

New formatting:

fixes #351

Created at 3 weeks ago
craiglabenz create branch dartfn-logging-fix
Created at 3 weeks ago
Add code for Cloud SQL performance video
Created at 1 month ago
craiglabenz create branch add-cloud-sql-performance
Created at 1 month ago
Generated project (from dartfn) logs CloudEvent awkwardly

I could play with this, but I'll pretty much just be trying random things and re-deploying until something changes with no real theory of which layer is overly splitting the message.

If you have any ideas of where to start, I can tinker.

Created at 1 month ago
Generated project (from dartfn) logs CloudEvent awkwardly

The generated file from dartfn contains this code in lib/functions.dart

stderr.writeln(_encoder.convert(event));

Which renders awkwardly in the Cloud Run console with extraneous newlines and separate log statements.

Created at 1 month ago
issue comment
`flutter create --empty`

I think either is fine, honestly. The value in this option is that developers aren't going to use anything we put in here.

Created at 1 month ago

small cleanup

Created at 1 month ago

Re-add Craig Labenz's code sharing sample (#1466)

  • Revert "Revert "Add code sharing sample (#1444)" (#1464)"

This reverts commit dc50c46ef13c08feb4e4b588101ca70acf840305.

  • Opting out failing tests on Windows for CI

Co-authored-by: Craig Labenz craig.labenz@gmail.com

Created at 1 month ago
pull request closed
Re-add Craig Labenz's code sharing sample

This reverts commit dc50c46ef13c08feb4e4b588101ca70acf840305.

Created at 1 month ago
issue comment
Re-add Craig Labenz's code sharing sample

Opting out only on Windows. Seems like we might finally have it right, @domesticmouse?

Created at 1 month ago

Opting out failing tests on Windows for CI

Created at 1 month ago
issue comment
Re-add Craig Labenz's code sharing sample

These tests continue to pass on my development machine - there must be permissions or other environmental differences between my machine and CI. The failing tests are integration tests - they actually launch a process to run the server and connect to it. Maybe we need to be more delicate around this with CI? (Or I need to rethink the testing strategy for this sample?)

Created at 1 month ago
issue comment
testWidgets hangs if resources created in setUp

What are you thinking, @slightfoot? Are you aware of a different scenario this doesn't solve?

Created at 1 month ago
closed issue
testWidgets hangs if resources created in setUp

The following test hangs until the global 30s timeout. The scenario is a chain of StreamControllers, with a Completer that is resolved when the final StreamController receives its event. However, IFF the controllers are initialized in setUp, and IFF the test method is testWidgets (this behavior is not seen with the test/test package's test() method), then the last output below will be "pre-wait".

import 'dart:async';
import 'package:flutter_test/flutter_test.dart';

late StreamController<int> controller;
late StreamController<int> controller2;

void main() {
  setUp(() {
    controller = StreamController<int>();
    controller2 = StreamController<int>();

    controller.stream.listen(controller2.add);
  });

  testWidgets(
    'Await StreamControllers initialized in setUp',
    (tester) async {
      final completer = Completer<void>();
      controller2.stream.listen((_) {
        print('pre-complete');
        completer.complete();
        print('post-complete');
      });

      controller.add(0);

      print('pre-wait');
      await completer.future;
      print('post-wait');

      expect(true, true);
    },
  );
}

Output:

pre-wait
pre-complete
post-complete
TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
dart:isolate  _RawReceivePortImpl._handleMessage

✖ 
Exited (1)

cc @felangel @slightfoot

Created at 1 month ago