codesome
Repos
47
Followers
281
Following
26

The Prometheus monitoring system and time series database.

45634
7377

The open and composable observability and data visualization platform. Visualize metrics, logs, and traces from multiple sources like Prometheus, Loki, Elasticsearch, InfluxDB, Postgres and many more.

52548
9828

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

4917
682

List of talk that I have given or will be giving in future

3
0

A Plug-and-Play Load Balancer in Golang

5
4

Events

codesome create tag v0.40.3
Created at 3 days ago
codesome create tag v2.40.3
Created at 3 days ago

Add TestCompactHeadWithDeletion to test compaction failure after deletion

Signed-off-by: Ganesh Vernekar ganeshvern@gmail.com

Do not error on empty chunk during iteration in populateWithDelChunkSeriesIterator

Signed-off-by: Ganesh Vernekar ganeshvern@gmail.com

Cut v2.40.3

Signed-off-by: Ganesh Vernekar ganeshvern@gmail.com

Merge pull request #11623 from codesome/2403

Cut v2.40.3

Created at 3 days ago
pull request closed
Cut v2.40.3

Fixes https://github.com/prometheus/prometheus/issues/11585 and cuts a new version at the same time. Do not squash.

Reasoning for the fix: https://github.com/prometheus/prometheus/issues/11585#issuecomment-1324942953

Created at 3 days ago
issue comment
Cut v2.40.3

Re-run did magic

Created at 3 days ago

Remove unused ooo.go and ooo_test.go (#366)

The code lives in ooo_head.go now.

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

Created at 4 days ago
pull request closed
Remove unused ooo.go and ooo_test.go

The code lives in ooo_head.go now.

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

Created at 4 days ago
issue comment
Cut v2.40.3

Failed again. Will check on Monday (off for the rest of the week). I saw this error happening on the histogram PR as well, and it magically disappeared later.

Created at 4 days ago
issue comment
Cut v2.40.3

It is mostly a flake. I have seen that before. Restarted the tests.

Created at 4 days ago

Cut v2.40.3

Signed-off-by: Ganesh Vernekar ganeshvern@gmail.com

Created at 4 days ago

Comment fixes (#364)

  • matcher.go: restore comment from upstream

There's no reason to remove this comment.

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

  • head_append.go: Cortex to Mimir

This repo is used in Mimir.

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

Created at 4 days ago
pull request opened
Cut v2.40.3

Fixes https://github.com/prometheus/prometheus/issues/11585 and cuts a new version at the same time. Do not squash.

Created at 4 days ago
create branch
codesome create branch 2403
Created at 4 days ago
issue comment
Prometheus TSDB compactions failed

Good to know that this existed before as well, and we don't need to error here. Earlier it didn't give a problem because of a bug, which 2.40.x fixed.

See https://github.com/prometheus/prometheus/blob/release-2.39/tsdb/querier.go#L694

It uses errors.Wrap on a nil error, which resulted in a nil error at the end. Tt actually had to create a new error, which 2.40.x fixes. Will cut a 2.40.3 with the fix.

Created at 4 days ago
issue comment
Prometheus TSDB compactions failed

Looks like this should have happened pre 2.40.x as well (the error existed before). Testing out what changed in between. We should not be erroring out here ideally.

Created at 4 days ago
issue comment
Sync with upstream for native histograms

To be noted that this should not go into Mimir until we have closed https://github.com/prometheus/prometheus/issues/11585 and https://github.com/prometheus/prometheus/issues/11602 (but we can merge it in the meantime)

Created at 4 days ago
issue comment
Out-of-order post merge cleanup

What happens when Prometheus itself writes OOO?

TSDB is agnostic to this. If a sample is OOO and within the out_of_order_time_window, it will be added to the TSDB. Regarding the stale sample, if it is added to the TSDB, and then there is another sample later for the series, does that still work fine or the stale sample causes any problems?

Created at 4 days ago
issue comment
`Appender.Append` should return the appended labelset

Does doing the label cleanup step before calling GetRef work? Or does the extention of interface have other benefits as well? (I am not considering any modifications in labels.Labels right now)

Created at 5 days ago
pull request opened
Merge back release-2.40 branch
Created at 1 week ago
codesome create tag v0.40.2
Created at 1 week ago
codesome create tag v2.40.2
Created at 1 week ago

Fix black-on-black metric name color in dark mode (#11572)

The color should not be set explicitly at all. That way it simply inherits the theme's default color, as before https://github.com/prometheus/prometheus/pull/11068.

Fixes https://github.com/prometheus/prometheus/issues/11568

Signed-off-by: Julius Volz julius.volz@gmail.com

Signed-off-by: Julius Volz julius.volz@gmail.com

Cut v2.40.2

Signed-off-by: Ganesh Vernekar ganeshvern@gmail.com

Merge pull request #11590 from codesome/cut2402

Cut v2.40.2

Created at 1 week ago
pull request closed
Cut v2.40.2

DO NOT SQUASH

Created at 1 week ago

GetRefByhash will query a label's ref with hash value rather than lset.Hash().

Signed-off-by: tanghengjian 1040104807@qq.com

Merge pull request #11485 from t00350320/prometheus-office

GetRefByhash() will query a label's ref with hash value rather than lset.Hash().

Created at 1 week ago
pull request closed
GetRefByhash() will query a label's ref with hash value rather than lset.Hash().

GetRef() computes label's Hash in a.head.series.getByHash(lset.Hash(), lset). But we find a case that (1) label's Hash will be used twice in a function and (2) there will be a hash cache to speed up some operations in future. So Hash may be computed in advance. For case (1) GetRefByhash will query a label's ref with hash value rather than lset.Hash(). Full details will be found in Cortex's PR https://github.com/cortexproject/cortex/issues/4915 Please @alanprot @yeya24 help to review.

Created at 1 week ago

GetRefByhash will query a label's ref with hash value rather than lset.Hash().

Signed-off-by: tanghengjian 1040104807@qq.com

Created at 1 week ago
pull request opened
Cut v2.40.2

DO NOT SQUASH

Created at 1 week ago