I don't know - I'm going around in circles. There's no reason commit 58cb9e6 should have broken the types imports. There seems to just be something finicky going on with the linter and I can't reproduce it locally.
try again - passing locally
I think it needs something like
import { CanvasFontSpec } from '../src/helpers/helpers.options';
local linter didn't like that - I've reverted to the known lint-passing from this run: https://github.com/chartjs/Chart.js/pull/10837/checks?check_run_id=9254407423 using this code: https://github.com/chartjs/Chart.js/pull/10837/commits/84999207ac796f2bebcfdff1e57fe910af547d62
revert to known-passing imports
I think it needs something like
import { CanvasFontSpec } from '../src/helpers/helpers.options';
I'll try it - weird that this passed a week or so ago without a problem:
import { RenderTextOpts } from './helpers/helpers.canvas'; import { CanvasFontSpec } from './helpers';
rename renderTextOptions to options
@etimberg can you take a look at this? It evolved out of #10759 - now that that bug is fixed, there's a lot more that we could do with the axis labels if we had API access to the label dimensions.
Reproducible: https://codepen.io/cmcnulty/pen/LYrNoPQ that said, whether it's centered on the top, middle or bottom of the text seems somewhat subjective to me.
textOffset not a render option
The failure during build appears to be unrelated, and I have no idea how to resolve it - I'd love some help!
fix #10836 - add publc getLabelItems()
fix #10836 - add publc getLabelItems()
remove failing tests