Revise Dic

• Extract Dic::contentFolder()
• Extract Dic::makeView()
• Prefer double-quoted strings
• Prefer string concatenation over complex interpolation
• Drop doc-block comments
• Test Dic

Wrap CSRFProtection and fake it for testing

Revise Response

• Split responsibilities into Response (value object) and Responder
• Drop Response::__construct()
• Introduce Response::withExit()
• Make Response immutable
• Introduce Response::create()
• Introduce Response::redirect()

Revise Request/Url

• Replace Request::get() with Url::param()
• Introduce Request::deletePost() and ::commentPost()
• Start testing against FakeRequest instead of stub
• Replace Dic::makeRequest() with Request::current()
• Url is not a dependency of Request
• Url is a value object
• Construct Url from CMSIMPLE_URL and query string (not $sn and $su)
• Refactor Url::relative() and ::absolute()
• Replace Url::replace() with ::with()

Implement autoloader for tests

Revise view and templates

• Silently ignore ob_get_clean() errors
• Rename View::$templateDir to ::$templateFolder
• Use ternary operator
• Rename View::$lang to ::$text
• Use short_open_tags in view templates during development
• Auto-escaping of view values
• Don't pass objects nor callables as view values

Tweak build system

• Minification during build is sufficient
• Compact exec tasks
• Don't sniff tests
• Add "check" target for convenience
• Install PHPUnit via composer

Fix typo

Fix FakeRepository

Solved by 00e560efdb2768f4eb5a6c187af3ad136a7b912e.

That's simply bad style, see https://github.com/cmb69/tetris_xh/blob/1/tetris.js#L193.

There may be cases where it is necessary to manually modify the highscores; with the current serialization format that is almost impossible. A simple colon separated values format would be an improvement.

Tweak HighscoreService

• Extract ::filename()
• Prefer type declarations over hints
• Cater to configurable content folder

Close #13 (Switch to a human readable data format for highscores)

Revise Highscore(s)

• Repository::addHighscore() is fallible
• Repository::write() is fallible
• Replace magic number with constant
• Rename Repository::readHighscores() to ::highscores()
• Rename Repository::enterHighscore() to ::addHighscore()
• Rename HighscoreService to Repository
• Introduce Util::validateHighscore()
• Request::highscorePost() returns Highscore
• ::enterHighscore() accepts Highscore
• Introduce Highscore value objects

There may be cases where it is necessary to manually modify the highscores; with the current serialization format that is almost impossible. A simple colon separated values format would be an improvement.

Update approval test wrt. f059074

This should be fixed!

Reported by Simmyne – should be credited.

Include JS as module

Fix #11 (The arrow keys don't work in all browsers)

The most relevant part of this fix was already done by 00e560e.

Close #12 (Drop jQuery requirement)

Revise JS

• Use newsbox() instead of HTML markup in language texts
• Show highscores right away
• Fix tabs (broken since the jQueryUI removal)
• Fix indentation
• Fix removal of JS warning (yeah, everything is !important)

Fix build

Unify help files and README

Introduce Request

• Introduce Request::action()
• Introduce Request::highscorePost()
• Introduce Request::url()

Auto-escape view values

Revise MainController

• Make controller language text agnostic
• Write script to body instead of head
• Write JS configuration into data attribute instead of script
• Prefer shaped array over stdClass
• Avoid compact()

Revise InfoController

• Controllers should be agnostic of language texts
• Prefer type declarations over hints
• Favor shaped arrays over stdClass
• Remove noisy license info from info screen
• Avoid compact()

Tests

• Mark "untestable" classes
• Inline Plugin
• Move dispatch into MainController
• Inject plugin folder into MainController
• Test against FakeHighscoreService instead of stub
• Test HighscoreService
• Test MainController
• Test InfoController
• Test Dic

A-frame architecture

• Extract Dic
• Introduce Response/Responder
• Extract Jquery
• Inject data folder into HighscoreService
• Inject HighscoreService into controllers
• Make HighscoreService non static
• Inject MainController dependencies
• Inject InfoController dependencies
• Inline SystemCheckService
• Extract SystemChecker
• Collapse Controller hierarchy
• View is infra
• SystemCheckService is infra
• HighscoreService is infra
• Drop own autoloader in favor of CMSimple_XH's

That simplifies the implementation and adds a few potential enhancements.