cmb69
Repos
179
Followers
163
Following
5

The PHP Interpreter

C
34369
7008

GD Graphics Library

C
771
231

A modular, easy-to-install, flat file CMS without database

28
17

A plugin framework for CMSimple_XH

2
1

A portable CMSimple_XH distribution for Windows

Events

pull request opened
Remove support for libmysql-client from mysqli test suite

Since mysqli can no longer be built against libmysql-client, there is no longer the need to distinguish.


By the way, do we really still support MySQL < 5.0?

Created at 17 hours ago
create branch
cmb69 create branch cmb/is_mysqlnd
Created at 17 hours ago

gh9590.phpt requires ext/posix

Created at 17 hours ago

gh9590.phpt requires ext/posix

Merge branch 'PHP-8.1' into PHP-8.2

  • PHP-8.1: gh9590.phpt requires ext/posix

Merge branch 'PHP-8.2'

  • PHP-8.2: gh9590.phpt requires ext/posix
Created at 17 hours ago

gh9590.phpt requires ext/posix

Merge branch 'PHP-8.1' into PHP-8.2

  • PHP-8.1: gh9590.phpt requires ext/posix
Created at 17 hours ago

Use --EXTENSIONS-- section for newly added tests

As of PHP 8.1.0, the `--EXTENSIONS-- section is properly supported, and CIs may make use of that (our AppVeyor CI does). Thus it is important to list required extensions there, since otherwise they may not be loaded, causing the test to be skipped, or worse, to be borked.

Created at 18 hours ago

Use --EXTENSIONS-- section for newly added tests

As of PHP 8.1.0, the `--EXTENSIONS-- section is properly supported, and CIs may make use of that (our AppVeyor CI does). Thus it is important to list required extensions there, since otherwise they may not be loaded, causing the test to be skipped, or worse, to be borked.

Merge branch 'PHP-8.1' into PHP-8.2

  • PHP-8.1: Use --EXTENSIONS-- section for newly added tests
Created at 18 hours ago

Use --EXTENSIONS-- section for newly added tests

As of PHP 8.1.0, the `--EXTENSIONS-- section is properly supported, and CIs may make use of that (our AppVeyor CI does). Thus it is important to list required extensions there, since otherwise they may not be loaded, causing the test to be skipped, or worse, to be borked.

Merge branch 'PHP-8.1' into PHP-8.2

  • PHP-8.1: Use --EXTENSIONS-- section for newly added tests

Merge branch 'PHP-8.2'

  • PHP-8.2: Use --EXTENSIONS-- section for newly added tests
Created at 18 hours ago
issue comment
Intro doc page mentions PECL without saying what it is

I've linked to https://www.php.net/manual/en/install.pecl.intro.php instead of directly to pecl.php.net.

Created at 19 hours ago
closed issue
Intro doc page mentions PECL without saying what it is

This is where is the first mention of PECL: https://www.php.net/manual/en/intro-whatcando.php

The mention could just link to: https://pecl.php.net/

Created at 19 hours ago
push

Fix GH-1858: Intro doc page mentions PECL without saying what it is

Created at 19 hours ago
issue comment
Revert "Stop copying zend_module_entry (#8551)"

An alternative might be to catch double-loading of modules:

 ext/standard/dl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ext/standard/dl.c b/ext/standard/dl.c
index aae0996384..b8d1cbc78c 100644
--- a/ext/standard/dl.c
+++ b/ext/standard/dl.c
@@ -205,6 +205,10 @@ PHPAPI int php_load_extension(const char *filename, int type, int start_now)
 		return FAILURE;
 	}
 	module_entry = get_module();
+	if (zend_hash_str_exists(&module_registry, module_entry->name, strlen(module_entry->name))) {
+		zend_error(E_CORE_WARNING, "Module \"%s\" is already loaded", module_entry->name);
+		return FAILURE;
+	}
 	if (module_entry->zend_api != ZEND_MODULE_API_NO) {
 			php_error_docref(NULL, error_type,
 					"%s: Unable to initialize module\n"
Created at 1 day ago
issue comment
PHP 8.1 support

I think before going ahead with this, we should setup a working Linux CI (the existing Travis CI should be replaced).

Also, could you please rebase onto HEAD of the "develop" branch?

Created at 1 day ago
issue comment
Windows MSVC build issue on gd_webp.c

but --with-external-gd seems not to be implemented for Windows:

Oh, right – I totally forgot that. The proper solution would then to implement support for building PHP's gd extension against external libgd. I suggest to file a respective feature request at https://github.com/php/php-src/issues/new/choose.

Created at 1 day ago
issue comment
embed sapi unable to load tokenizer, undefined symbol zend_ce_stringable

I think we generally should have some documentation of the embed SAPI; probably in https://www.phpinternalsbook.com/.

Created at 1 day ago
issue comment
Windows MSVC build issue on gd_webp.c

replace gd bundled src for php 8.1.11

That's not supposed to work. Instead, you should compile libgd with all features desired, install it, and then build PHP with configure --enable-gd --with-external-gd …. Doesn't that work for you?

Created at 1 day ago
issue comment
add docs for `ini_parse_quantity` function

wondering if it makes sense to add examples with prefixes in the docs?

I think it would make more sense, to add some ini_get() examples.

Created at 1 day ago
issue comment
Fix test when session extesion is shared

But I see no way to get access to list of dependencies for test

Since these should already be loaded, you could use get_loaded_extensions(), but applying that might be a fiddly.

Created at 1 day ago
issue comment
Fix test when session extesion is shared

Hmm, this looks somewhat hackish to me. Can't we just detect the extension_dir and all loaded extensions in Adoy\FastCGI\Client\Tester and set it there when starting the server? At the very least, we should use ini_get('extension_dir') instead of hard-coding the path.

Created at 1 day ago
issue comment
PDO execute not correctly binding booleans

From the docs:

All values are treated as PDO::PARAM_STR.

So not a bug, but rather a feature request. Still, only treating values of type bool as PDO::PARAM_BOOL and all others as PDO::PARAM_STR would be more confusing than as it's now. However, how to map other types is not necessarily clear.

Created at 1 day ago
issue comment
Make socket path shorter for socket_cmsg_{rights|credentials}.phpt

Then let's go with sys_get_temp_dir(). However, I think the --CLEAN-- section should come after the --FILE-- section, not the other way round.

Created at 2 days ago
issue comment
fix php_init_crypt_r/php_shutdown_crypt_r signatures warning.

Isn't it more relevant to fix this in the header (php_crypt_r.h)?

Created at 2 days ago
issue comment
Actually fix GH-9583

Oh, and please delete the comment /* This is not used yet */ just above the definition of PHP_FUNCTION(session_create_id) – obviously it is used now.

Created at 2 days ago