chokoswitch
Repos
18
Followers
6

Events

issue comment
Support matching against package-qualified name as well

@capnspacehook Thanks for the feature request, being able to match against package sounds useful. Would you be able to give this PR a brief check to make sure it accomplishes what you need? Thanks!

Created at 1 day ago
pull request opened
Support matching against package-qualified name as well

Fixes #11

Created at 1 day ago
create branch
chokoswitch create branch pattern-package
Created at 1 day ago

Bump golang.org/x/tools from 0.2.0 to 0.3.0 (#10)

Created at 3 weeks ago
pull request closed
Bump golang.org/x/tools from 0.2.0 to 0.3.0

Bumps golang.org/x/tools from 0.2.0 to 0.3.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 3 weeks ago

Remove limitation that isn't there anymore and add Development sectio… (#7)

…n to README

Created at 1 month ago
pull request closed
Remove limitation that isn't there anymore and add Development sectio…

…n to README

Created at 1 month ago

Bump golang.org/x/tools from 0.1.12 to 0.2.0 (#9)

Bumps golang.org/x/tools from 0.1.12 to 0.2.0.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 1 month ago
pull request closed
Bump golang.org/x/tools from 0.1.12 to 0.2.0

Bumps golang.org/x/tools from 0.1.12 to 0.2.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 1 month ago
pull request opened
chore: update reassign to v0.2.0

Thanks to @MichaelUrman for fixing an issue with shadowing imports by switching to use TypesInfo for import tracking.

Created at 2 months ago
chokoswitch create branch reassign-v0.2.0
Created at 2 months ago
chokoswitch create tag v0.2.0
Created at 2 months ago
pull request closed
Bump github.com/magefile/mage from 1.13.0 to 1.14.0

Bumps github.com/magefile/mage from 1.13.0 to 1.14.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Created at 2 months ago

Bump github.com/magefile/mage from 1.13.0 to 1.14.0 (#8)

Bumps github.com/magefile/mage from 1.13.0 to 1.14.0.

Dependabot compatibility
score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Created at 2 months ago
pull request opened
Remove limitation that isn't there anymore and add Development sectio…

…n to README

Created at 2 months ago
create branch
chokoswitch create branch readme-mage
Created at 2 months ago
issue comment
Use typesinfo to compare packages

Thanks again @MichaelUrman - will try to get this released and a PR to update golangci within the next few days

Created at 2 months ago

Use typesinfo to compare packages (#6)

This avoids a false positive in shadow.go, and enables detecting dot-imported.

Fixes #5

Co-authored-by: Choko choko@curioswitch.org

Created at 2 months ago
reassign false positives on shadowed names

Reassign issues false positives for shadowed package names. For example,

$ go run github.com/curioswitch/go-reassign/cmd@v0.1.2 ./...
/home/murman/src/reassign-broke/foo.go:9:5: reassigning variable EOF in other package fmt
exit status 3

This is an otherwise empty directory with a new module (go mod init foo) and a foo.go with the following:

package main

import "fmt"

func main() {
    fmt.Println("hi")

    fmt := struct{ EOF int }{}
    fmt.EOF = 5
}

I did encounter this in real code while using golangci-lint, albeit shadowing my own packages instead of standard ones, and with a pattern of .* instead of the default.

See golangci/golangci-lint#3145 for additional details about the environment in which I ran it, but I don't expect they are necessary.

Created at 2 months ago
pull request closed
Use typesinfo to compare packages

This avoids a false positive in shadow.go, and enables detecting dot-imported.

Fixes #5

Created at 2 months ago
issue comment
Use typesinfo to compare packages

Thanks @MichaelUrman for the context and discussion. Agree that it sounds like it's good to keep the change to fixing the issue with shadowing for now and explore address-taking in the future. I have gone ahead and pushed the change to this PR

Created at 2 months ago

Remove support checking that addresses aren't taken for now

Created at 2 months ago
issue comment
Use typesinfo to compare packages

Thanks @MichaelUrman! I think this means the linter will move from the syntax phase to types phase of golanglint which is fine. I'm not sure if &global is always, or even almost always an error - I suppose the idea is that if a global was meant to be used as a pointer, it already would be. But it seems to have high risk of false positive, can we make that opt-in?

Created at 2 months ago
issue comment
reassign false positives on shadowed names

@MichaelUrman Thanks for the help, a PR would be wonderful!

Created at 2 months ago