76
25
7
Events
Generic 404 operation
Right now, for requests, the operation name is set/updated multiples during the instrumentation:
- first, it is set to whatever the request uri is, eg.
http.get /posts/123. - when the symfony route is resolved, we set the operation name to the
route_nameorroute_path, eg.http.get /posts/{id}, depending on which resolver you configure - if the response code is
404, we set the operation name tohttp.error 404to avoid the high cardinality of op names that would occur if no route name was ever resolved. - The problem is particularly obvious when you're getting scraped by robots because each 404 for a file they test (eg. wp-admin.php, config.php, .env, etc...) would be a different operation from Otel's perspective...
One way to fix this, would be to set the operation name to http.error 404 only if no route name was ever resolved.
only set generic 404 operation when no route was resolved (#39)
only set generic 404 operation when no route was resolved
Fixes #40
Generic 404 operation
Right now, for requests, the operation name is set/updated multiples during the instrumentation:
- first, it is set to whatever the request uri is, eg.
http.get /posts/123. - when the symfony route is resolved, we set the actual operation name, eg.
http.get /posts/{id}. - if the response code is
404, we set the operation name tohttp.error 404to avoid the high cardinality of op names that would occur if no route name was ever resolved. - The problem is particularly obvious when you're getting scraped by robots because each 404 for a file they test (eg. wp-admin.php, config.php, .env, etc...) would be a different operation from Otel's perspective...
One way to fix this, would be to set the operation name to http.error 404 only if no route name was ever resolved.
fix phpstan lint
add operation name as label to response_codes_total metric
only set generic 404 operation when no route was resolved
cdaguerre create branch only-set-generic-404-op-name-when-no-route-was-resolved
add operation name as label to response_codes_total metric
add operation name as label to `response_codes_total` metric
cdaguerre create branch add-operation-name-to-response-code-metric
keep http response content even when throwing (#37)
keep http response content even when throwing
keep http response content even when throwing
cdaguerre create branch keep-http-response-content-even-when-throwing
catch exceptions during http message bodies span attributes creation
add opt-in feature to add http message bodies as span attributes
Merge branch 'master' into http-bodies-as-attrs
catch exceptions during http message bodies span attributes creation
add opt-in feature to add http message bodies as span attributes
