@nehagup How do I sign the DCO? Can I do it directly here on Github?
Update searchmodel.ts
@krassowski Take a look at the updated searchview.tss
Update searchview.tsx
Bump verdaccio (#13807)
Dependabot alert on json5 (#13808)
Bump lerna
Bump json5 in dependencies
Adopt ruff and clean up pre-commit (#13562)
adopt ruff and clean up pre-commit
ignore changelog.md
reinstate prints
reinstate print
reinstate print
reinstate imports
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
reinstate prints
print fixups
fixups in labapp
lint and fix output
Fix latest linter errors
sync pre-commit and pyproject versions
use local versions of black, ruff
formatting
Update snapshots
Correct gutter lines
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@gmail.com Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Remove debug print in test (#13814)
Bump tj-actions/changed-files from 35.4.1 to 35.4.3 (#13816)
Bumps tj-actions/changed-files from 35.4.1 to 35.4.3.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Clean examples (#13812)
Backport PR #13593: Bug fixes/revisions for the Lab extension tutorial (#13813)
Co-authored-by: Eric Gentry ericsnekbytes@gmail.com
Bump pandas from 1.3.5 to 1.5.3 (#13817)
Bumps pandas from 1.3.5 to 1.5.3.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Bump matplotlib from 3.5.1 to 3.6.3 (#13821)
Bumps matplotlib from 3.5.1 to 3.6.3.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump scipy from 1.7.3 to 1.10.0 (#13818)
Bumps scipy from 1.7.3 to 1.10.0.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump ruff from 0.0.177 to 0.0.226 (#13819)
Bumps ruff from 0.0.177 to 0.0.226.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Align ruff version
Set correct new ruff version
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Fix linter errors
Skip last linter error
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@gmail.com
Drop the moment
dependency (#13469)
Drop the moment
dependency
Drop timeFormat
from Time.format()
Fix a call to format
Default to en
Remove Time.format()
tests
Update test
Update Playwright Snapshots
Update Playwright Snapshots
Remove console.log
Fix default document.documentElement.lang
Update Playwright Snapshots
Update extension migration docs
Undo 1 snapshot update
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Faster rendering of the debugger tree (#13707)
Faster rendering of the debugger tree
Use 3px padding to match previous height better
Update Playwright Snapshots
Fix typo in comment and an outdated comment
Fix typos in comments, remove log.
Use useCallback
for hover handler definition
Add documentation for service prop
Add documentation for collapserIcon
Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Fix starting search with selected text (if any) (#13802)
Fix starting search with selected text (if any)
Fix a typo
Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com
Upgrades Python to 3.10, Node to 18 (#13722)
Upgrades Python to 3.10, Node to 18
Require "node": ">=16.0.0"
Undo: require "node": ">=16.0.0"
Undo change in jupyterlab/staging/package.json
Drop node-fetch
Undo staging changes
Fix @types/node resolution in yarn.lock
Keep node-fetch in jest shim for now
Fix integrity
Co-authored-by: Jeremy Tuloup jeremy.tuloup@gmail.com
default
locale will use OS default locale (#13721)
default
locale will use OS default locale
Update packages/translation-extension/schema/plugin.json
Co-authored-by: Michał Krassowski 5832902+krassowski@users.noreply.github.com
Update packages/translation/src/manager.ts
Fix linter
Update jupyterlab_server to support default
Co-authored-by: Michał Krassowski 5832902+krassowski@users.noreply.github.com
Rework sidebar styles to allow adoption of css contain:strict
(#13831)
Rework sidebar styles to allow adoption use css contain:strict
Add z-index to arrow to avoid cropping
Update Playwright Snapshots
Update Playwright Snapshots
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bump tj-actions/changed-files from 35.4.3 to 35.4.4 (#13840)
Bumps tj-actions/changed-files from 35.4.3 to 35.4.4.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump jupyterlab-language-pack-zh-cn from 3.2.post7 to 3.5.post4 (#13843)
Bumps jupyterlab-language-pack-zh-cn from 3.2.post7 to 3.5.post4.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump ruff from 0.0.226 to 0.0.230 (#13842)
Bumps ruff from 0.0.226 to 0.0.230.
updated-dependencies:
Signed-off-by: dependabot[bot] support@github.com
Align ruff version
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Fix black error
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval fcollonval@users.noreply.github.com Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. Updated the run your first app tutorial md. Instead of having same steps a link could be added to redirect the users towards the Installation Method Documentation Fixes # (issue) #112
Please delete options that are not relevant.
Tested it in my environment. Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
...
docs: documentation did not mention starting the mongodb server. So when users where running the app they were getting a 500 Server Error. Added the instructions to start the mongo server to fix that (#115)
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Merge pull request #1 from keploy/main
docs: documentation did not mention starting the mongodb server. So w…
…hen users where running the app they were getting a 500 Server Error. Added the instructions to start the mongo server to fix that (#115)
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Please delete options that are not relevant.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
...
…hen users where running the app they were getting a 500 Server Error. Added the instructions to start the mongo server to fix that (#115)
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Signed-off-by: Pranshu Srivastava iampranshu24@gmail.com
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Please delete options that are not relevant.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
...
@krassowski Do I have to change every relevant Input element I find in searchview.tsx
, like line 56 inputRef: React.RefObject<HTMLInputElement>;
, to inputRef: React.RefObject<HTMLTextAreaElement>;
.
Line 60:
onKeydown: (e: React.KeyboardEvent<HTMLInputElement>) => void;
onChange: (e: React.ChangeEvent<HTMLInputElement>) => void;
to
onKeydown: (e: React.KeyboardEvent<HTMLTextAreaElement>) => void;
onChange: (e: React.ChangeEvent<HTMLTextAreaElement>) => void;
and more. If so, I can proceed to do the changes
Oh thanks for the info! which files do I need to do the update?
@jovyntls Thats good to know! Thanks for the help!
Ignore PR#13809. I forgot that I had to draft it first
#13801
#13
At packages/documentsearch/src/searchmodel.ts
, I added the m
flag to const flag = caseSensitive ? 'g' : 'gi';
forming: const flag = caseSensitive ? 'gm' : 'gim';
. This will enable multi-line search, allowing the regular expression to match across multiple lines
At packages/fileeditor/src/searchprovider.ts
and packages/notebook/src/searchprovider.ts
, I removed the line return selection?.search(/\r?\n|\r/g) === -1 ? selection : ;''
By removing this line, the function will always return the selection regardless of whether it is a single-line or multi-line selection
At packages/documentsearch/src/searchview.tsx
, I replaced <input
with <textarea
#13801
At packages/documentsearch/src/searchmodel.ts
, I added the m
flag to const flag = caseSensitive ? 'g' : 'gi';
forming: const flag = caseSensitive ? 'gm' : 'gim';
. This will enable multi-line search, allowing the regular expression to match across multiple lines
At packages/fileeditor/src/searchprovider.ts
and packages/notebook/src/searchprovider.ts
, I removed the line return selection?.search(/\r?\n|\r/g) === -1 ? selection : ;''
By removing this line, the function will always return the selection regardless of whether it is a single-line or multi-line selection
At packages/documentsearch/src/searchview.tsx
, I replaced <input
with <textarea
#13801
At packages/documentsearch/src/searchmodel.ts
, I added the m
flag to const flag = caseSensitive ? 'g' : 'gi';
forming: const flag = caseSensitive ? 'gm' : 'gim';
. This will enable multi-line search, allowing the regular expression to match across multiple lines
At packages/fileeditor/src/searchprovider.ts
and packages/notebook/src/searchprovider.ts
, I removed the line return selection?.search(/\r?\n|\r/g) === -1 ? selection : ;''
By removing this line, the function will always return the selection regardless of whether it is a single-line or multi-line selection
At packages/documentsearch/src/searchview.tsx
, I replaced <input
with <textarea
Additionally we would want to handle enter vs shift/ctrl enter. Enter should search, shift enter add new line.
For this part, I am thinking we can do this.
onKeyDown={e => {
if (e.key === 'Enter' && e.shiftKey) {
// handle shift+enter (add new line)
e.target.value += '\n'
} else if (e.key === 'Enter') {
// handle enter (search)
}
}}
What do you think of the shift+enter function and what we can add to handle enter(search)? Let me know thanks!
Update searchview.tsx
Update searchview.tsx
Update searchprovider.ts
Update searchprovider.ts
By removing return selection.search(/\r?\n|\r/g) === -1 ? selection : '';
, the function will always return the selection regardless of whether it is a single-line or multi-line selection
I have created the PR but there seem to be some errors going on with the checks. Can you help me check what is wrong?