bwplotka
Repos
120
Followers
743
Following
36

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.

11231
1688

The Prometheus monitoring system and time series database.

45722
7395

mimic: Define your Deployments, Infrastructure and Configuration as a Go Code 🚀

208
5

Golang JSON Web Token builder with easy to use API for JWS and nested JWT (JWS+JWE)

2
1

Apache Mesos

4986
1589

Robust, smart logger for Golang http handlers

4
0

Events

Remote Read does not work for Thanos

This feature indeed require Store API being exposed on Thanos Querier managed by Prometheus Operator. I think it's fair feature request to expose it if it's not exposed yet (gRPC port).

Created at 22 minutes ago
pull request closed
Port `Contains` method

This ports the Contains method from Thanos testutil package.

Created at 1 day ago

Port Contains method (#4)

  • Port Contains method

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Change to ContainsStringSlice

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

Created at 1 day ago
issue comment
Add thread-safe multi error implementation

I would vote for having just concurrency safe code for merrors. The reason is that soon (Go 1.20) we will likely have errors.Join in standard library, so simple cases will be solved. I don't see a huge overhead of doing concurrency control in seq code when it comes to error handling, but I might underestimate it (:

I would do it (: cc @saswatamcode @matej-g

Created at 2 days ago
create branch
bwplotka create branch pre-sort-auto
Created at 2 days ago

support uploading generated blocks to object storage (#42)

  • support uploading generated blocks to object storage

Signed-off-by: Ben Ye benye@amazon.com

  • fix lint

Signed-off-by: Ben Ye benye@amazon.com

  • lint

Signed-off-by: Ben Ye benye@amazon.com

  • update test

Signed-off-by: Ben Ye benye@amazon.com

  • update go mod

Signed-off-by: Ben Ye benye@amazon.com

Signed-off-by: Ben Ye benye@amazon.com

Created at 2 days ago
pull request closed
support uploading generated blocks to object storage

Signed-off-by: Ben Ye benye@amazon.com

Add new flags --objstore.config-file and --objstore.config to support uploading blocks in block gen command.

This PR also updates Thanos, Prometheus to the latest version.

Created at 2 days ago
create branch
bwplotka create branch pre-sort
Created at 3 days ago
issue comment
Should label ordering be enforced on sample ingestion?

Is label ordering a 'hard requirement', i.e. should such samples be considered invalid and we should refuse to append them and treat them similarly to empty / duplicate labels?

So sounds like YES, it is a hard requirement.

If yes, should this check be added to head append logic

IMO If you can create test that proves Prometheus can consumes unordered metric, then yes. If it's only the case for users of TSDB (as a library), then probably this check could live in the user side unless it's inefficient to do so.

Created at 3 days ago
create tag
bwplotka create tag v0.14.0
Created at 3 days ago
closed issue
monitoring: Add option to disable cadvisor

Cadvisor is important to get container metrics. However, it requires various directories, which might be different on different OS-es causing it to fail. For example when using WSL (https://github.com/google/cadvisor/issues/2648#issuecomment-1049215354).

Without cadvisor we still can have a lot of metrics from runtimes running in containers (e.g Go app), so we can add option to disable cadvisor so users can be unblocked if they can't make cadvisor running.

Created at 3 days ago
issue comment
monitoring: Add option to disable cadvisor

Done: https://github.com/efficientgo/e2e/pull/56

Created at 3 days ago
issue comment
Add constrained labels and Constrained variant for all MetricVecs

Hm, I like the idea of reusing some concepts around instantiation, although arguably AFAIK those concepts might go away if we implement _created timestamp in OM. 🙈

On top of that, automation feels like the second step. The first should be to define the API for constraints. I am a bit afraid of putting Values items. Do we really need to force everyone to expose 100 status code metrics, because constraints allows max 100, when during execution only 200 and 500 codes were seen for weeks?

Created at 3 days ago

Added info about maintainers.

Signed-off-by: bwplotka bwplotka@gmail.com

Created at 3 days ago

Docs: Add mentee selection process (#5920)

  • Docs: Add mentee selection process

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Update docs/contributing/mentorship.md

Co-authored-by: Lucas Servén Marín lserven@gmail.com Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Address feedback

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Apply suggestions from code review

Co-authored-by: Bartlomiej Plotka bwplotka@gmail.com Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Address full-time mentee + feedback

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

  • Apply suggestions from doc review

Co-authored-by: Lucas Servén Marín lserven@gmail.com Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com

Signed-off-by: Saswata Mukherjee saswataminsta@yahoo.com Co-authored-by: Lucas Servén Marín lserven@gmail.com Co-authored-by: Bartlomiej Plotka bwplotka@gmail.com

Created at 3 days ago
pull request closed
Docs: Add mentee selection process

This PR adds content for the Mentee Selection section i.e, process and recommendations, based on recent mentor learnings meeting we had with @bwplotka, @fpetkovski & @metonymic-smokey.

Would love to get some feedback on these processes and any additional recommendations that you might want! 🙂

  • [ ] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

Verification

Created at 3 days ago
issue comment
Check metric uniqueness against timestamp

Discussion moved forwared in the issue, I think we could change it as in PR. Can we at least add unit test that proves multiple samples of same metric are possible?

Created at 4 days ago